Inspection of "[feature] Settings page to change plugin config" - pryley/pollux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 3b1736...62d6da )

by Paul

created 2017-05-09 17:01 UTC

Status

Spacing +41 added lines, -41 removed lines patch added patch discarded remove patch

@@ -24,22 +24,22 @@  discard block
 block discarded – undo
 	/**
 	 * @var array
 	 */
-	public $metaboxes = [];
+	public $metaboxes = [ ];
 
 	/**
 	 * {@inheritdoc}
 	 */
 	public function init()
 	{
-		if( empty( $this->app->config->{static::ID} ))return;
+		if( empty( $this->app->config->{static::ID} ) )return;
 
 		$this->normalize( $this->app->config->{static::ID}, [
-			'post_types' => [],
-		]);
+			'post_types' => [ ],
+		] );
 
-		add_filter( 'rwmb_show',       [$this, 'show'], 10, 2 );
-		add_filter( 'rwmb_meta_boxes', [$this, 'register'] );
-		add_filter( 'rwmb_outer_html', [$this, 'renderField'], 10, 2 );
+		add_filter( 'rwmb_show', [ $this, 'show' ], 10, 2 );
+		add_filter( 'rwmb_meta_boxes', [ $this, 'register' ] );
+		add_filter( 'rwmb_outer_html', [ $this, 'renderField' ], 10, 2 );
 	}
 
 	/**
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 	{
 		return PostMeta::get( $key, [
 			'id' => $this->getPostId(),
-		]);
+		] );
 	}
 
 	/**
@@ -81,15 +81,15 @@  discard block
 block discarded – undo
 	 */
 	public function register()
 	{
-		if( current_user_can( 'switch_themes' )) {
+		if( current_user_can( 'switch_themes' ) ) {
 			$instructions = $this->initInstructions();
-			if( is_array( $instructions )) {
+			if( is_array( $instructions ) ) {
 				$this->normalize( $instructions );
 			}
 		}
 		$metaboxes = func_num_args()
-			? ( new Helper )->toArray( func_get_arg(0) )
-			: [];
+			? ( new Helper )->toArray( func_get_arg( 0 ) )
+			: [ ];
 		return array_merge( $metaboxes, $this->metaboxes );
 	}
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
 	 */
 	public function renderField( $html, $field )
 	{
-		return $this->validate( $field['condition'] )
+		return $this->validate( $field[ 'condition' ] )
 			? $html
 			: '';
 	}
@@ -111,11 +111,11 @@  discard block
 block discarded – undo
 	public function show( $bool, array $metabox )
 	{
 		if( defined( 'DOING_AJAX' )
-			|| !isset( $metabox['condition'] )
-			|| !$this->hasPostType( $metabox )) {
+			|| !isset( $metabox[ 'condition' ] )
+			|| !$this->hasPostType( $metabox ) ) {
 			return $bool;
 		}
-		return $this->validate( $metabox['condition'] );
+		return $this->validate( $metabox[ 'condition' ] );
 	}
 
 	/**
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
 	 */
 	protected function getPostId()
 	{
-		if( !( $postId = filter_input( INPUT_GET, 'post' ))) {
+		if( !( $postId = filter_input( INPUT_GET, 'post' ) ) ) {
 			$postId = filter_input( INPUT_POST, 'post_ID' );
 		}
 		return intval( $postId );
@@ -136,10 +136,10 @@  discard block
 block discarded – undo
 	{
 		return array_unique( iterator_to_array(
 			new RecursiveIteratorIterator(
-				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ))
+				new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ) )
 			),
 			false
-		));
+		) );
 	}
 
 	/**
@@ -147,26 +147,26 @@  discard block
 block discarded – undo
 	 */
 	protected function hasPostType( array $metabox )
 	{
-		if( !isset( $metabox['post_types'] )) {
+		if( !isset( $metabox[ 'post_types' ] ) ) {
 			return true;
 		}
-		return in_array( get_post_type( $this->getPostId() ), $metabox['post_types'] );
+		return in_array( get_post_type( $this->getPostId() ), $metabox[ 'post_types' ] );
 	}
 
 	/**
 	 * @return void
 	 */
-	protected function normalize( array $metaboxes, array $defaults = [] )
+	protected function normalize( array $metaboxes, array $defaults = [ ] )
 	{
 		foreach( $metaboxes as $id => $metabox ) {
 			$data = wp_parse_args( $defaults, [
-				'condition' => [],
-				'fields' => [],
+				'condition' => [ ],
+				'fields' => [ ],
 				'id' => $id,
 				'slug' => $id,
-				'validation' => [],
-			]);
-			$this->metaboxes[] = $this->setDependencies(
+				'validation' => [ ],
+			] );
+			$this->metaboxes[ ] = $this->setDependencies(
 				$this->normalizeThis( $metabox, $data, $id )
 			);
 		}
@@ -200,10 +200,10 @@  discard block
 block discarded – undo
 	protected function normalizeFields( array $fields, array $data, $parentId )
 	{
 		return array_map( function( $id, $field ) use( $parentId ) {
-			$defaults =  [
-				'attributes' => [],
+			$defaults = [
+				'attributes' => [ ],
 				'class' => '',
-				'condition' => [],
+				'condition' => [ ],
 				'depends' => '',
 				'field_name' => $id,
 				'id' => $id,
@@ -237,11 +237,11 @@  discard block
 block discarded – undo
 	 */
 	protected function normalizeValidation( array $validation, array $data, $parentId )
 	{
-		foreach( ['messages', 'rules'] as $key ) {
-			if( empty( $validation[$key] ))continue;
-			foreach( $validation[$key] as $id => $value ) {
-				$validation[$key][$this->normalizeFieldName( $id, ['slug' => $id], $parentId )] = $value;
-				unset( $validation[$key][$id] );
+		foreach( [ 'messages', 'rules' ] as $key ) {
+			if( empty( $validation[ $key ] ) )continue;
+			foreach( $validation[ $key ] as $id => $value ) {
+				$validation[ $key ][ $this->normalizeFieldName( $id, [ 'slug' => $id ], $parentId ) ] = $value;
+				unset( $validation[ $key ][ $id ] );
 			}
 		}
 		return $validation;
@@ -252,14 +252,14 @@  discard block
 block discarded – undo
 	 */
 	protected function setDependencies( array $metabox )
 	{
-		$fields = &$metabox['fields'];
+		$fields = &$metabox[ 'fields' ];
 		$depends = array_column( $fields, 'depends' );
 		array_walk( $depends, function( $value, $index ) use( &$fields, $metabox ) {
-			if( empty( $value ))return;
-			$dependency = array_search( $value, array_column( $fields, 'id' ));
-			$fields[$index]['attributes']['data-depends'] = $value;
-			if( !$this->getMetaValue( $fields[$dependency]['slug'], '', $metabox['slug'] )) {
-				$fields[$index]['class'] = trim( 'hidden ' . $fields[$index]['class'] );
+			if( empty( $value ) )return;
+			$dependency = array_search( $value, array_column( $fields, 'id' ) );
+			$fields[ $index ][ 'attributes' ][ 'data-depends' ] = $value;
+			if( !$this->getMetaValue( $fields[ $dependency ][ 'slug' ], '', $metabox[ 'slug' ] ) ) {
+				$fields[ $index ][ 'class' ] = trim( 'hidden ' . $fields[ $index ][ 'class' ] );
 			}
 		});
 		return $metabox;

Please login to merge, or discard this patch.

Braces +13 added lines, -5 removed lines patch added patch discarded remove patch

@@ -31,7 +31,9 @@  discard block
 block discarded – undo
 	 */
 	public function init()
 	{
-		if( empty( $this->app->config->{static::ID} ))return;
+		if( empty( $this->app->config->{static::ID} )) {
+			return;
+		}
 
 		$this->normalize( $this->app->config->{static::ID}, [
 			'post_types' => [],
@@ -199,7 +201,8 @@  discard block
 block discarded – undo
 	 */
 	protected function normalizeFields( array $fields, array $data, $parentId )
 	{
-		return array_map( function( $id, $field ) use( $parentId ) {
+		return array_map( function( $id, $field ) use( $parentId )
+		{
 			$defaults =  [
 				'attributes' => [],
 				'class' => '',
@@ -238,7 +241,9 @@  discard block
 block discarded – undo
 	protected function normalizeValidation( array $validation, array $data, $parentId )
 	{
 		foreach( ['messages', 'rules'] as $key ) {
-			if( empty( $validation[$key] ))continue;
+			if( empty( $validation[$key] )) {
+				continue;
+			}
 			foreach( $validation[$key] as $id => $value ) {
 				$validation[$key][$this->normalizeFieldName( $id, ['slug' => $id], $parentId )] = $value;
 				unset( $validation[$key][$id] );
@@ -254,8 +259,11 @@  discard block
 block discarded – undo
 	{
 		$fields = &$metabox['fields'];
 		$depends = array_column( $fields, 'depends' );
-		array_walk( $depends, function( $value, $index ) use( &$fields, $metabox ) {
-			if( empty( $value ))return;
+		array_walk( $depends, function( $value, $index ) use( &$fields, $metabox )
+		{
+			if( empty( $value )) {
+				return;
+			}
 			$dependency = array_search( $value, array_column( $fields, 'id' ));
 			$fields[$index]['attributes']['data-depends'] = $value;
 			if( !$this->getMetaValue( $fields[$dependency]['slug'], '', $metabox['slug'] )) {

Please login to merge, or discard this patch.

		@@ -24,22 +24,22 @@ discard block
		block discarded – undo
24	24	/**
25	25	* @var array
26	26	*/
27		- public $metaboxes = [];
	27	+ public $metaboxes = [ ];
28	28
29	29	/**
30	30	* {@inheritdoc}
31	31	*/
32	32	public function init()
33	33	{
34		- if( empty( $this->app->config->{static::ID} ))return;
	34	+ if( empty( $this->app->config->{static::ID} ) )return;
35	35
36	36	$this->normalize( $this->app->config->{static::ID}, [
37		- 'post_types' => [],
38		- ]);
	37	+ 'post_types' => [ ],
	38	+ ] );
39	39
40		- add_filter( 'rwmb_show', [$this, 'show'], 10, 2 );
41		- add_filter( 'rwmb_meta_boxes', [$this, 'register'] );
42		- add_filter( 'rwmb_outer_html', [$this, 'renderField'], 10, 2 );
	40	+ add_filter( 'rwmb_show', [ $this, 'show' ], 10, 2 );
	41	+ add_filter( 'rwmb_meta_boxes', [ $this, 'register' ] );
	42	+ add_filter( 'rwmb_outer_html', [ $this, 'renderField' ], 10, 2 );
43	43	}
44	44
45	45	/**
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	{
73	73	return PostMeta::get( $key, [
74	74	'id' => $this->getPostId(),
75		- ]);
	75	+ ] );
76	76	}
77	77
78	78	/**
		@@ -81,15 +81,15 @@ discard block
		block discarded – undo
81	81	*/
82	82	public function register()
83	83	{
84		- if( current_user_can( 'switch_themes' )) {
	84	+ if( current_user_can( 'switch_themes' ) ) {
85	85	$instructions = $this->initInstructions();
86		- if( is_array( $instructions )) {
	86	+ if( is_array( $instructions ) ) {
87	87	$this->normalize( $instructions );
88	88	}
89	89	}
90	90	$metaboxes = func_num_args()
91		- ? ( new Helper )->toArray( func_get_arg(0) )
92		- : [];
	91	+ ? ( new Helper )->toArray( func_get_arg( 0 ) )
	92	+ : [ ];
93	93	return array_merge( $metaboxes, $this->metaboxes );
94	94	}
95	95
		@@ -99,7 +99,7 @@ discard block
		block discarded – undo
99	99	*/
100	100	public function renderField( $html, $field )
101	101	{
102		- return $this->validate( $field['condition'] )
	102	+ return $this->validate( $field[ 'condition' ] )
103	103	? $html
104	104	: '';
105	105	}
		@@ -111,11 +111,11 @@ discard block
		block discarded – undo
111	111	public function show( $bool, array $metabox )
112	112	{
113	113	if( defined( 'DOING_AJAX' )
114		- \|\| !isset( $metabox['condition'] )
115		- \|\| !$this->hasPostType( $metabox )) {
	114	+ \|\| !isset( $metabox[ 'condition' ] )
	115	+ \|\| !$this->hasPostType( $metabox ) ) {
116	116	return $bool;
117	117	}
118		- return $this->validate( $metabox['condition'] );
	118	+ return $this->validate( $metabox[ 'condition' ] );
119	119	}
120	120
121	121	/**
		@@ -123,7 +123,7 @@ discard block
		block discarded – undo
123	123	*/
124	124	protected function getPostId()
125	125	{
126		- if( !( $postId = filter_input( INPUT_GET, 'post' ))) {
	126	+ if( !( $postId = filter_input( INPUT_GET, 'post' ) ) ) {
127	127	$postId = filter_input( INPUT_POST, 'post_ID' );
128	128	}
129	129	return intval( $postId );
		@@ -136,10 +136,10 @@ discard block
		block discarded – undo
136	136	{
137	137	return array_unique( iterator_to_array(
138	138	new RecursiveIteratorIterator(
139		- new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ))
	139	+ new RecursiveArrayIterator( array_column( $this->metaboxes, 'post_types' ) )
140	140	),
141	141	false
142		- ));
	142	+ ) );
143	143	}
144	144
145	145	/**
		@@ -147,26 +147,26 @@ discard block
		block discarded – undo
147	147	*/
148	148	protected function hasPostType( array $metabox )
149	149	{
150		- if( !isset( $metabox['post_types'] )) {
	150	+ if( !isset( $metabox[ 'post_types' ] ) ) {
151	151	return true;
152	152	}
153		- return in_array( get_post_type( $this->getPostId() ), $metabox['post_types'] );
	153	+ return in_array( get_post_type( $this->getPostId() ), $metabox[ 'post_types' ] );
154	154	}
155	155
156	156	/**
157	157	* @return void
158	158	*/
159		- protected function normalize( array $metaboxes, array $defaults = [] )
	159	+ protected function normalize( array $metaboxes, array $defaults = [ ] )
160	160	{
161	161	foreach( $metaboxes as $id => $metabox ) {
162	162	$data = wp_parse_args( $defaults, [
163		- 'condition' => [],
164		- 'fields' => [],
	163	+ 'condition' => [ ],
	164	+ 'fields' => [ ],
165	165	'id' => $id,
166	166	'slug' => $id,
167		- 'validation' => [],
168		- ]);
169		- $this->metaboxes[] = $this->setDependencies(
	167	+ 'validation' => [ ],
	168	+ ] );
	169	+ $this->metaboxes[ ] = $this->setDependencies(
170	170	$this->normalizeThis( $metabox, $data, $id )
171	171	);
172	172	}
		@@ -200,10 +200,10 @@ discard block
		block discarded – undo
200	200	protected function normalizeFields( array $fields, array $data, $parentId )
201	201	{
202	202	return array_map( function( $id, $field ) use( $parentId ) {
203		- $defaults = [
204		- 'attributes' => [],
	203	+ $defaults = [
	204	+ 'attributes' => [ ],
205	205	'class' => '',
206		- 'condition' => [],
	206	+ 'condition' => [ ],
207	207	'depends' => '',
208	208	'field_name' => $id,
209	209	'id' => $id,
		@@ -237,11 +237,11 @@ discard block
		block discarded – undo
237	237	*/
238	238	protected function normalizeValidation( array $validation, array $data, $parentId )
239	239	{
240		- foreach( ['messages', 'rules'] as $key ) {
241		- if( empty( $validation[$key] ))continue;
242		- foreach( $validation[$key] as $id => $value ) {
243		- $validation[$key][$this->normalizeFieldName( $id, ['slug' => $id], $parentId )] = $value;
244		- unset( $validation[$key][$id] );
	240	+ foreach( [ 'messages', 'rules' ] as $key ) {
	241	+ if( empty( $validation[ $key ] ) )continue;
	242	+ foreach( $validation[ $key ] as $id => $value ) {
	243	+ $validation[ $key ][ $this->normalizeFieldName( $id, [ 'slug' => $id ], $parentId ) ] = $value;
	244	+ unset( $validation[ $key ][ $id ] );
245	245	}
246	246	}
247	247	return $validation;
		@@ -252,14 +252,14 @@ discard block
		block discarded – undo
252	252	*/
253	253	protected function setDependencies( array $metabox )
254	254	{
255		- $fields = &$metabox['fields'];
	255	+ $fields = &$metabox[ 'fields' ];
256	256	$depends = array_column( $fields, 'depends' );
257	257	array_walk( $depends, function( $value, $index ) use( &$fields, $metabox ) {
258		- if( empty( $value ))return;
259		- $dependency = array_search( $value, array_column( $fields, 'id' ));
260		- $fields[$index]['attributes']['data-depends'] = $value;
261		- if( !$this->getMetaValue( $fields[$dependency]['slug'], '', $metabox['slug'] )) {
262		- $fields[$index]['class'] = trim( 'hidden ' . $fields[$index]['class'] );
	258	+ if( empty( $value ) )return;
	259	+ $dependency = array_search( $value, array_column( $fields, 'id' ) );
	260	+ $fields[ $index ][ 'attributes' ][ 'data-depends' ] = $value;
	261	+ if( !$this->getMetaValue( $fields[ $dependency ][ 'slug' ], '', $metabox[ 'slug' ] ) ) {
	262	+ $fields[ $index ][ 'class' ] = trim( 'hidden ' . $fields[ $index ][ 'class' ] );
263	263	}
264	264	});
265	265	return $metabox;

		@@ -31,7 +31,9 @@ discard block
		block discarded – undo
31	31	*/
32	32	public function init()
33	33	{
34		- if( empty( $this->app->config->{static::ID} ))return;
	34	+ if( empty( $this->app->config->{static::ID} )) {
	35	+ return;
	36	+ }
35	37
36	38	$this->normalize( $this->app->config->{static::ID}, [
37	39	'post_types' => [],
		@@ -199,7 +201,8 @@ discard block
		block discarded – undo
199	201	*/
200	202	protected function normalizeFields( array $fields, array $data, $parentId )
201	203	{
202		- return array_map( function( $id, $field ) use( $parentId ) {
	204	+ return array_map( function( $id, $field ) use( $parentId )
	205	+ {
203	206	$defaults = [
204	207	'attributes' => [],
205	208	'class' => '',
		@@ -238,7 +241,9 @@ discard block
		block discarded – undo
238	241	protected function normalizeValidation( array $validation, array $data, $parentId )
239	242	{
240	243	foreach( ['messages', 'rules'] as $key ) {
241		- if( empty( $validation[$key] ))continue;
	244	+ if( empty( $validation[$key] )) {
	245	+ continue;
	246	+ }
242	247	foreach( $validation[$key] as $id => $value ) {
243	248	$validation[$key][$this->normalizeFieldName( $id, ['slug' => $id], $parentId )] = $value;
244	249	unset( $validation[$key][$id] );
		@@ -254,8 +259,11 @@ discard block
		block discarded – undo
254	259	{
255	260	$fields = &$metabox['fields'];
256	261	$depends = array_column( $fields, 'depends' );
257		- array_walk( $depends, function( $value, $index ) use( &$fields, $metabox ) {
258		- if( empty( $value ))return;
	262	+ array_walk( $depends, function( $value, $index ) use( &$fields, $metabox )
	263	+ {
	264	+ if( empty( $value )) {
	265	+ return;
	266	+ }
259	267	$dependency = array_search( $value, array_column( $fields, 'id' ));
260	268	$fields[$index]['attributes']['data-depends'] = $value;
261	269	if( !$this->getMetaValue( $fields[$dependency]['slug'], '', $metabox['slug'] )) {

pryley / pollux

Push — develop ( 3b1736...62d6da )

Status

Category

Spacing +41 added lines, -41 removed lines patch added patch discarded remove patch

Braces +13 added lines, -5 removed lines patch added patch discarded remove patch