SiteMeta::get() - Code Metrics - Inspection of "remove Application injection in Helper classes" - pryley/pollux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 510e0e...2d2242 )

by Paul

created 2017-04-28 04:33 UTC

SiteMeta::get() A

↳ Parent: SiteMeta

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	10
nc	4
nop	3
dl	0
loc	14
rs	9.2
c	0
b	0
f	0

<?php

namespace GeminiLabs\Pollux;

use GeminiLabs\Pollux\Settings;

class SiteMeta
{
	/**
	 * @param null|string $group
	 * @param null|string $key
	 * @param mixed $fallback
	 * @return mixed
	 */
	public function get( $group = null, $key = null, $fallback = null )
	{
		$options = get_option( Settings::ID );
		if( !$options ) {
			return $fallback;
		}
		if( !$group ) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			return $options;
		}
		$group = $this->normalize( $options, $group, $fallback );
		return is_string( $key )
			? $this->normalize( (array) $group, $key, $fallback )
			: $group;
	}

	/**
	 * @param string $key
	 * @param mixed $fallback
	 * @return mixed
	 */
	protected function normalize( array $options, $key, $fallback )
	{
		if( !array_key_exists( $key, $options )) {
			return $fallback;
		}
		$option = $options[$key];
		$option = is_array( $option )
			? array_filter( $option )
			: trim( $option );
		return empty( $option )
			? $fallback
			: $option;
	}
}


1			<?php
2
3			namespace GeminiLabs\Pollux;
4
5			use GeminiLabs\Pollux\Settings;
6
7			class SiteMeta
8			{
9			/**
10			* @param null\|string $group
11			* @param null\|string $key
12			* @param mixed $fallback
13			* @return mixed
14			*/
15			public function get( $group = null, $key = null, $fallback = null )
16			{
17			$options = get_option( Settings::ID );
18			if( !$options ) {
19			return $fallback;
20			}
21			if( !$group ) {
			0 ignored issues – show Bug Best Practice introduced 2017-04-28 04:27 UTC by Report Bug Copy Issue Report The expression `$group` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
22			return $options;
23			}
24			$group = $this->normalize( $options, $group, $fallback );
25			return is_string( $key )
26			? $this->normalize( (array) $group, $key, $fallback )
27			: $group;
28			}
29
30			/**
31			* @param string $key
32			* @param mixed $fallback
33			* @return mixed
34			*/
35			protected function normalize( array $options, $key, $fallback )
36			{
37			if( !array_key_exists( $key, $options )) {
38			return $fallback;
39			}
40			$option = $options[$key];
41			$option = is_array( $option )
42			? array_filter( $option )
43			: trim( $option );
44			return empty( $option )
45			? $fallback
46			: $option;
47			}
48			}
49

pryley / pollux

Push — master ( 510e0e...2d2242 )

SiteMeta::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like