pollux.metabox.init - Code Metrics - Inspection of "fix archive featured image" - pryley/pollux - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 39ebd6...fc1005 )

by Paul

created 2017-05-05 22:54 UTC

pollux.metabox.init A

↳ Parent: +/main.js

Complexity

Conditions	1
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
c	0
b	0
f	0
nc	2
nop	0
dl	0
loc	11
rs	9.4285

1 Function

Rating	Name	Duplication	Size	Complexity
A		0	7	2

var pollux = {
	media: {
		featured: {},
	},
	metabox: {},
};

/**
 * @return void
 */
pollux.media.featured.init = function()
{
	jQuery( '#postimagediv' )
	.on( 'click', '#pollux-set-featured', function( ev ) {
		ev.preventDefault();
		wp.media.view.settings.post.featuredImageId = Math.round( jQuery( '#featured' ).val() );

		pollux.media.featured.frame = wp.media.featuredImage.frame;
		pollux.media.featured.frame().open();
	})
	.on( 'click', '#pollux-remove-featured', function( ev ) {
		ev.preventDefault();
		pollux.media.featured.frame = wp.media.featuredImage.frame;

		pollux.media.featured.set(-1);
	});
};

/**
 * @return void
 */
pollux.media.featured.select = function()
{
	if( !wp.media.view.settings.post.featuredImageId )return;
if (a > 0)
    b = 42;
	var selection = this.get( 'selection' ).single();
	pollux.media.featured.set( selection ? selection.id : -1 );
};

/**
 * @return void
 */
pollux.media.featured.set = function( id )
{
	wp.media.view.settings.post.featuredImageId = Math.round( id );

	wp.media.post( 'pollux/archives/featured/html', {
		_wpnonce: jQuery( '#_wpnonce' ).val(),
		post_type: jQuery( '#archive-type' ).val(),
		thumbnail_id: id,
	}).done( function( html ) {
		jQuery( '.inside', '#postimagediv' ).html( html );
	});
};

/**
 * @return bool
 */
pollux.metabox.hasValue = function( el )
{
	if( el.type === 'checkbox' ) {
		return el.checked === true;
	}
	return el.value !== '';
};

/**
 * @return void
 */
pollux.metabox.init = function()
{
	var depends = document.querySelectorAll( '.rwmb-input [data-depends]' );
	[].forEach.call( depends, function( el ) {
		var dependency = pollux.metabox.setVisibility( el );
		var event = dependency.type === 'checkbox' ? 'change' : 'keyup';
		dependency.addEventListener( event, function() {
			pollux.metabox.onChangeValue( el );
		}, false );
	});
};

/**
 * @return void
 */
pollux.metabox.onChangeValue = function( el )
{
	pollux.metabox.setVisibility( el );
};

/**
 * @return element
 */
pollux.metabox.setVisibility = function( el )
{
	var dependency = document.getElementById( el.getAttribute( 'data-depends' ));
	var field = el.closest( '.rwmb-field' );
	if( pollux.metabox.hasValue( dependency )) {
		field.classList.remove( 'hidden' );
	}
	else {
		field.classList.add( 'hidden' );
	}
	return dependency;
};

jQuery(function() {
	pollux.media.featured.init();
	pollux.metabox.init();
});


1			var pollux = {
2			media: {
3			featured: {},
4			},
5			metabox: {},
6			};
7
8			/**
9			* @return void
10			*/
11			pollux.media.featured.init = function()
12			{
13			jQuery( '#postimagediv' )
14			.on( 'click', '#pollux-set-featured', function( ev ) {
15			ev.preventDefault();
16			wp.media.view.settings.post.featuredImageId = Math.round( jQuery( '#featured' ).val() );
			0 ignored issues – show Bug introduced 2017-05-05 22:57 UTC by Report Bug Copy Issue Report The variable `wp` seems to be never declared. If this is a global, consider adding a `/** global: wp */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
17			pollux.media.featured.frame = wp.media.featuredImage.frame;
18			pollux.media.featured.frame().open();
19			})
20			.on( 'click', '#pollux-remove-featured', function( ev ) {
21			ev.preventDefault();
22			pollux.media.featured.frame = wp.media.featuredImage.frame;
			0 ignored issues – show Bug introduced 2017-05-05 22:57 UTC by Report Bug Copy Issue Report The variable `wp` seems to be never declared. If this is a global, consider adding a `/** global: wp */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
23			pollux.media.featured.set(-1);
24			});
25			};
26
27			/**
28			* @return void
29			*/
30			pollux.media.featured.select = function()
31			{
32			if( !wp.media.view.settings.post.featuredImageId )return;
			1 ignored issue – show Coding Style Best Practice introduced 2017-05-05 22:57 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... Bug introduced 2017-05-05 22:57 UTC by Report Bug Copy Issue Report The variable `wp` seems to be never declared. If this is a global, consider adding a `/** global: wp */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
33			var selection = this.get( 'selection' ).single();
34			pollux.media.featured.set( selection ? selection.id : -1 );
35			};
36
37			/**
38			* @return void
39			*/
40			pollux.media.featured.set = function( id )
41			{
42			wp.media.view.settings.post.featuredImageId = Math.round( id );
			0 ignored issues – show Bug introduced 2017-05-05 22:57 UTC by Report Bug Copy Issue Report The variable `wp` seems to be never declared. If this is a global, consider adding a `/** global: wp */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
43			wp.media.post( 'pollux/archives/featured/html', {
44			_wpnonce: jQuery( '#_wpnonce' ).val(),
45			post_type: jQuery( '#archive-type' ).val(),
46			thumbnail_id: id,
47			}).done( function( html ) {
48			jQuery( '.inside', '#postimagediv' ).html( html );
49			});
50			};
51
52			/**
53			* @return bool
54			*/
55			pollux.metabox.hasValue = function( el )
56			{
57			if( el.type === 'checkbox' ) {
58			return el.checked === true;
59			}
60			return el.value !== '';
61			};
62
63			/**
64			* @return void
65			*/
66			pollux.metabox.init = function()
67			{
68			var depends = document.querySelectorAll( '.rwmb-input [data-depends]' );
69			[].forEach.call( depends, function( el ) {
70			var dependency = pollux.metabox.setVisibility( el );
71			var event = dependency.type === 'checkbox' ? 'change' : 'keyup';
72			dependency.addEventListener( event, function() {
73			pollux.metabox.onChangeValue( el );
74			}, false );
75			});
76			};
77
78			/**
79			* @return void
80			*/
81			pollux.metabox.onChangeValue = function( el )
82			{
83			pollux.metabox.setVisibility( el );
84			};
85
86			/**
87			* @return element
88			*/
89			pollux.metabox.setVisibility = function( el )
90			{
91			var dependency = document.getElementById( el.getAttribute( 'data-depends' ));
92			var field = el.closest( '.rwmb-field' );
93			if( pollux.metabox.hasValue( dependency )) {
94			field.classList.remove( 'hidden' );
95			}
96			else {
97			field.classList.add( 'hidden' );
98			}
99			return dependency;
100			};
101
102			jQuery(function() {
103			pollux.media.featured.init();
104			pollux.metabox.init();
105			});
106

pryley / pollux

Push — develop ( 39ebd6...fc1005 )

pollux.metabox.init A

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like