pryley / castor-framework

src/Image.php

<?php

namespace GeminiLabs\Castor;

use GeminiLabs\Castor\Helpers\PostMeta;
use GeminiLabs\Castor\Helpers\Utility;

class Image
{
    public $image;

    protected $postmeta;
    protected $utility;

    public function __construct(PostMeta $postmeta, Utility $utility)
    {
        $this->postmeta = $postmeta;
        $this->utility = $utility;
    }

    /**
     * @param int|string $attachment
     *
     * @return self
     */
    public function get($attachment)
    {
        $attachment = $this->normalize($attachment);
        if ($attachment && $thumbnail = wp_get_attachment_image_src($attachment, 'thumbnail')) {

The expression $attachment of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $medium = $this->normalizeSrc(wp_get_attachment_image_src($attachment, 'medium'), $thumbnail);

It seems like wp_get_attachment_image_src($attachment, 'medium') can also be of type false; however, parameter $image of GeminiLabs\Castor\Image::normalizeSrc() does only seem to accept array, maybe add an additional type check?

            $large = $this->normalizeSrc(wp_get_attachment_image_src($attachment, 'large'), $medium);

            $this->image = (object) [
                'alt' => wp_strip_all_tags(get_post_meta($attachment, '_wp_attachment_image_alt', true), true),

It seems like get_post_meta($attachment, '_wp_attachment_image_alt', true) can also be of type false; however, parameter $string of wp_strip_all_tags() does only seem to accept string, maybe add an additional type check?

                'caption' => wp_get_attachment_caption($attachment),
                'copyright' => wp_strip_all_tags(get_post_meta($attachment, '_copyright', true), true),
                'ID' => $attachment,
                'large' => $large,
                'medium' => $medium,
                'permalink' => get_attachment_link($attachment),
                'thumbnail' => $this->normalizeSrc($thumbnail),
            ];
        }
        return $this;
    }

    public function render($size = 'large')
    {
        if ($this->image) {
            return wp_get_attachment_image($this->image->ID, $size);
        }
    }

    protected function normalize($attachmentId)
    {
        if (!filter_var($attachmentId, FILTER_VALIDATE_INT)) {
            $attachmentId = $this->postmeta->get($attachmentId);
        }

        $attachment = get_post($attachmentId);

        if (is_null($attachment) || 'attachment' != $attachment->post_type) {
            return;
        }

        return $attachment->ID;
    }

    /**
     * @param mixed $fallback
     *
     * @return array
     */
    protected function normalizeSrc(array $image, $fallback = false)
    {
        if (is_array($fallback) && count(array_diff($image, $fallback)) < 2) {
            $image = $fallback;
        }
        $image = array_pad($image, 3, '');
        return [
            'url' => array_shift($image),
            'width' => array_shift($image),
            'height' => array_shift($image),
        ];
    }
}