View GitHub Repository castor-framework

Schedule Inspection
Subscribe
Passed
Push — develop ( c6dd2a...1f8334 )
by Paul
03:38
created

assets/js/castor-dom.js   A

↳ Parent: Project

Complexity

Total Complexity 9
Complexity/F 1.8

Size

Lines of Code 34
Function Count 5

Duplication

Duplicated Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 0
nc 4
dl 0
loc 34
rs 10
c 0
b 0
f 0
wmc 9
mnd 2
bc 7
fnc 5
bpm 1.4
cpm 1.8
noi 6

4 Functions

Rating   Name   Duplication   Size   Complexity  
A castor._insertAfter 0 5 1
A castor._removeEl 0 6 2
A castor._insertBefore 0 5 1
A castor._createEl 0 9 4
1 
castor._appendTo = function( el, tag, attributes ) {
0 ignored issues
– show
Bug introduced by
The variable castor seems to be never declared. If this is a global, consider adding a /** global: castor */ comment.

This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed.

To learn more about declaring variables in Javascript, see the MDN.

Loading history...
2 
	var newEl = castor._createEl( tag, attributes );
0 ignored issues
– show
Bug introduced by
The variable castor seems to be never declared. If this is a global, consider adding a /** global: castor */ comment.

This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed.

To learn more about declaring variables in Javascript, see the MDN.

Loading history...
3 
	el.appendChild( newEl );
4 
	return newEl;
5 
};
6 

            


            
                                                        
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
castor._createEl = function( tag, attributes ) {

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
	var el = ( typeof tag === 'string' ) ? document.createElement( tag ) : tag;

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
	attributes = attributes || {};

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
	for( var key in attributes ) {

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
		if( !attributes.hasOwnProperty( key ))continue;

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Best Practice
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
Curly braces around statements make for more readable code and help prevent bugs when you add further statements.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Consider adding curly braces around all statements when they are executed conditionally.
This is optional if there is only one statement, but leaving them out can lead to unexpected
behaviour if another statement is added later.


Consider:


if (a > 0)
    b = 42;





If you or someone else later decides to put another statement in, only the first
statement will be executed.


if (a > 0)
    console.log("a > 0");
    b = 42;





In this case the statement b = 42 will always be executed, while
the logging statement will be executed conditionally.


if (a > 0) {
    console.log("a > 0");
    b = 42;
}





ensures that the proper code will be executed conditionally no matter how
many statements are added or removed.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
		el.setAttribute( key, attributes[ key ] );

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
	}

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
	return el;

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
};

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
castor._insertAfter = function( el, tag, attributes ) {

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The variable castor seems to be never declared. If this is a global, consider adding a /** global: castor */ comment.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This checks looks for references to variables that have not been declared. This is most
likey a typographical error or a variable has been renamed.


To learn more about declaring variables in Javascript, see the
MDN.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
	var newEl = castor._createEl( tag, attributes );

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The variable castor seems to be never declared. If this is a global, consider adding a /** global: castor */ comment.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This checks looks for references to variables that have not been declared. This is most
likey a typographical error or a variable has been renamed.


To learn more about declaring variables in Javascript, see the
MDN.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
	el.parentNode.insertBefore( newEl, el.nextSibling );

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
	return newEl;

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
};

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
castor._insertBefore = function( el, tag, attributes ) {

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
	var newEl = castor._createEl( tag, attributes );

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The variable castor seems to be never declared. If this is a global, consider adding a /** global: castor */ comment.
                                                                                                

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This checks looks for references to variables that have not been declared. This is most
likey a typographical error or a variable has been renamed.


To learn more about declaring variables in Javascript, see the
MDN.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
	el.parentNode.insertBefore( newEl, el );

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
	return newEl;

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
};

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
castor._removeEl = function( selector, parent ) {

            


            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
	var el = parent.querySelector( selector );

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
	if( el !== null ) {

            


            
                                                        
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
		el.parentNode.removeChild( el );

            


            
                                                        
            
                                    
            
            

                
                    33
                

                                    
                                                    
                
                
                
	}

            


            
                                                        
            
                                    
            
            

                
                    34
                

                                    
                                                    
                
                
                
};

            


            
                                                        
            
                                    
            
            

                
                    35