Profiler::__construct() - Code Metrics - Inspection of "refactor for PHP 7.2" - pryley/blackbar - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1bb139...d77149 )

by Paul

created 2023-02-01 17:55 UTC

Profiler::__construct() A

↳ Parent: Profiler

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

namespace GeminiLabs\BlackBar;

class Profiler
{
    /**
     * This is the time that WordPress takes to execute the profiler hook.
     * @var float
     */
    protected $noise;
    /**
     * @var float
     */
    protected $start;
    /**
     * @var float
     */
    protected $stop;
    /**
     * @var array
     */
    protected $timers;

    public function __construct()
    {
        $this->noise = (float) 0;
        $this->start = (float) 0;
        $this->stop = (float) 0;
        $this->timers = [];
    }

    public function getMeasure(): array
    {
        return $this->timers;
    }

    public function getMemoryString(array $timer): string
    {
        return sprintf('%s kB', round($this->normalize($timer)['memory'] / 1000));
    }

    public function getNameString(array $timer): string
    {
        return $this->normalize($timer)['name'];
    }

    public function getTimeString(array $timer): string
    {
        $timer = $this->normalize($timer);
        $index = array_search($timer['name'], array_column($this->timers, 'name'));
        $start = $this->start + ($index * $this->noise);
        $time = number_format(round(($timer['time'] - $start) * 1000, 4), 4);
        return sprintf('%s ms', $time);
    }

    public function getTotalTime(): float
    {
        $totalNoise = (count($this->timers) - 1) * $this->noise;
        return $this->stop - $this->start - $totalNoise;
    }

    public function trace(string $name): void
    {
        $microtime = microtime(true); // float
        if (!$this->start) {
            $this->start = $microtime;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }
        if ('blackbar/profiler/noise' === $name) {
            $this->noise = $microtime - $this->start;
            return;
        }
        $this->timers[] = [
            'memory' => memory_get_peak_usage(),
            'name' => $name,
            'time' => $microtime,
        ];
        $this->stop = $microtime;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    protected function normalize(array $timer): array
    {
        return wp_parse_args($timer, [
            'memory' => 0,
            'name' => '',
            'time' => (float) 0,
        ]);
    }
}


1			<?php
2
3			namespace GeminiLabs\BlackBar;
4
5			class Profiler
6			{
7			/**
8			* This is the time that WordPress takes to execute the profiler hook.
9			* @var float
10			*/
11			protected $noise;
12			/**
13			* @var float
14			*/
15			protected $start;
16			/**
17			* @var float
18			*/
19			protected $stop;
20			/**
21			* @var array
22			*/
23			protected $timers;
24
25			public function __construct()
26			{
27			$this->noise = (float) 0;
28			$this->start = (float) 0;
29			$this->stop = (float) 0;
30			$this->timers = [];
31			}
32
33			public function getMeasure(): array
34			{
35			return $this->timers;
36			}
37
38			public function getMemoryString(array $timer): string
39			{
40			return sprintf('%s kB', round($this->normalize($timer)['memory'] / 1000));
41			}
42
43			public function getNameString(array $timer): string
44			{
45			return $this->normalize($timer)['name'];
46			}
47
48			public function getTimeString(array $timer): string
49			{
50			$timer = $this->normalize($timer);
51			$index = array_search($timer['name'], array_column($this->timers, 'name'));
52			$start = $this->start + ($index * $this->noise);
53			$time = number_format(round(($timer['time'] - $start) * 1000, 4), 4);
54			return sprintf('%s ms', $time);
55			}
56
57			public function getTotalTime(): float
58			{
59			$totalNoise = (count($this->timers) - 1) * $this->noise;
60			return $this->stop - $this->start - $totalNoise;
61			}
62
63			public function trace(string $name): void
64			{
65			$microtime = microtime(true); // float
66			if (!$this->start) {
67			$this->start = $microtime;
			1 ignored issue – show Documentation Bug introduced 2023-02-01 17:58 UTC by Report Bug Copy Issue Report It seems like `$microtime` can also be of type `string`. However, the property `$start` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
68			}
69			if ('blackbar/profiler/noise' === $name) {
70			$this->noise = $microtime - $this->start;
71			return;
72			}
73			$this->timers[] = [
74			'memory' => memory_get_peak_usage(),
75			'name' => $name,
76			'time' => $microtime,
77			];
78			$this->stop = $microtime;
			1 ignored issue – show Documentation Bug introduced 2023-02-01 17:58 UTC by Report Bug Copy Issue Report It seems like `$microtime` can also be of type `string`. However, the property `$stop` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
79			}
80
81			protected function normalize(array $timer): array
82			{
83			return wp_parse_args($timer, [
84			'memory' => 0,
85			'name' => '',
86			'time' => (float) 0,
87			]);
88			}
89			}
90

pryley / blackbar

Push — master ( 1bb139...d77149 )

Profiler::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like