proyectotau /
TAUonDDD
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 13 |
| Code Lines | 5 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 6 |
| CRAP Score | 2 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
| 1 | <?php |
||
| 22 | 68 | public function add(string $id, $concrete = null): DefinitionInterface |
|
| 23 | { |
||
| 24 | // \ProyectoTAU\TAU\Common\Logger::debug("$id ".var_export($concrete, true)); |
||
| 25 | |||
| 26 | 68 | if( $this->has($id, $concrete) ) // Replace concrete if id exists |
|
|
|
|||
| 27 | { |
||
| 28 | 68 | $definition = $this->extend($id); |
|
| 29 | 68 | $definition->setConcrete($concrete); |
|
| 30 | 68 | return $definition; |
|
| 31 | |||
| 32 | } |
||
| 33 | |||
| 34 | 32 | return parent::add($id, $concrete); |
|
| 35 | } |
||
| 37 |
This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.