promopult / tiktok-marketing-api

src/AbstractService.php

<?php

declare(strict_types=1);

namespace Promopult\TikTokMarketingApi;

use GuzzleHttp\Psr7\Request;
use Promopult\TikTokMarketingApi\Exception\ErrorResponse;
use Promopult\TikTokMarketingApi\Exception\MalformedResponse;
use Psr\Http\Client\ClientInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

abstract class AbstractService implements ServiceInterface
{
    use RequestSenderTrait;

    protected CredentialsInterface $credentials;
    protected ClientInterface $httpClient;

    public function __construct(
        CredentialsInterface $credentials,
        ClientInterface $httpClient
    ) {
        $this->credentials = $credentials;
        $this->httpClient = $httpClient;
    }

    public function requestApi(
        string $httpMethod,
        string $endpoint,
        array $args = []
    ): array {
        $httpMethod = strtolower($httpMethod);

        $args = array_filter($args);

        $url = $this->credentials->getApiBaseUrl() . $endpoint;

        if ($args && $httpMethod === 'get') {

The expression $args of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $url .= '?' . $this->prepareGetParams($args);
        }

        $headers = [
            'Content-Type' => 'application/json',
            'Accept' => 'application/json',
        ];

        if (!empty($this->credentials->getAccessToken())) {
            $headers['Access-Token'] = $this->credentials->getAccessToken();
        }

        $body = $httpMethod === 'get' || empty($args)
            ? null
            : \json_encode($args, JSON_THROW_ON_ERROR);

        $request = new Request(
            $httpMethod,
            $url,
            $headers,
            $body
        );

        $response = $this->sendRequest($request);

        return $this->handleResponse($response, $request);
    }

    /**
     * @throws \JsonException
     */
    protected function handleResponse(
        ResponseInterface $response,
        RequestInterface $request
    ): array {
        /** @var array $decodedJson */
        $decodedJson = \json_decode(
            (string) $response->getBody(),
            true,
            512,
            JSON_THROW_ON_ERROR
        );

        if (!isset($decodedJson['code'])) {
            throw new MalformedResponse(
                $request,
                $response
            );
        }

        if ($decodedJson['code'] != 0) {
            throw new ErrorResponse(
                (int) $decodedJson['code'],
                (string) ($decodedJson['message'] ?? 'Unknown error.'),
                $request,
                $response
            );
        }

        return $decodedJson;
    }

    protected function prepareGetParams(array $args): string
    {
        $formedArgs = [];

        /**
         * @psalm-suppress MixedAssignment
         */
        foreach ($args as $arg => $value) {
            if (is_scalar($value)) {
                $formedArgs[$arg] = $value;
            }

            if (is_array($value)) {
                $formedArgs[$arg] = \json_encode(array_filter($value));
            }
        }

        return http_build_query($formedArgs);
    }
}