ProjetNormandie\ForumBundle\Service\ForumService::migrateBbcode()

Complexity

Conditions	5
Paths	5

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	ForumService::setRead()	0	6	1

<?php

namespace ProjetNormandie\ForumBundle\Service;

use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\ORMException;
use ProjetNormandie\ForumBundle\Entity\Forum;

class ForumService
{
    private $em;
    private $topicService;

    /**
     * ForumService constructor.
     * @param EntityManagerInterface $em
     * @param TopicService           $topicService
     */
    public function __construct(EntityManagerInterface $em, TopicService $topicService)
    {
        $this->em = $em;
        $this->topicService = $topicService;
    }

    /**
     * @param $forum
     * @return Forum
     */
    private function getForum($forum): Forum
    {
        if (!$forum instanceof Forum) {
            $forum = $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\Forum')
                ->findOneBy(['id' => $forum]);
        }
        return $forum;

The expression return $forum could return the type null which is incompatible with the type-hinted return ProjetNormandie\ForumBundle\Entity\Forum. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param $user
     */
    public function readAll($user)
    {
        $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\TopicUser')->readAll($user);
        $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\ForumUser')->readAll($user);
    }

    /**
     * @param $user
     * @param $forum
     */
    public function read($user, $forum)
    {
        $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\TopicUser')->readForum($user, $forum);
        $this->setRead($forum, $user);
    }

    /**
     * @param $forum
     * @throws ORMException
     */
    public function majParent($forum)
    {
        $forum = $this->getForum($forum);
        $data = $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\Forum')->getParentData($forum);
        $forum->setLastMessage($this->em->getReference('ProjetNormandie\ForumBundle\Entity\Message', $data['lastMessage']));
        $forum->setNbTopic($data['nbTopic']);
        $forum->setNbMessage($data['nbMessage']);
        $this->em->flush();
    }


    /**
     * @param Forum $forum
     * @throws ORMException
     */
    public function maj(Forum $forum)
    {
        $data = $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\Topic')->getForumData($forum);
        $forum->setLastMessage($this->em->getReference('ProjetNormandie\ForumBundle\Entity\Message', $data['lastMessage']));
        $forum->setNbTopic($data['nbTopic']);
        $forum->setNbMessage($data['nbMessage']);
        $this->em->flush();
    }

    /**
     * @param $forum
     */
    public function majPosition($forum)
    {
        $forum = $this->getForum($forum);
        if ($forum->getIsParent() == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            foreach ($forum->getChildrens() as $child) {
                foreach ($child->getTopics() as $topic) {
                    $this->topicService->majPositions($topic);
                }
            }
        } else {
            foreach ($forum->getTopics() as $topic) {
                $this->topicService->majPositions($topic);
            }
        }
    }


    /**
     * @param Forum $forum
     * @param       $user
     */
    public function setRead(Forum $forum, $user)
    {
        $forumUser = $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\ForumUser')
                ->findOneBy(['forum' => $forum, 'user' => $user]);
        $forumUser->setBoolRead(true);
        $this->em->flush();
    }


    /**
     * @param Forum $forum
     * @param       $user
     */
    public function setNotRead(Forum $forum, $user)
    {
        $forumUser = $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\ForumUser')
                ->findOneBy(['forum' => $forum, 'user' => $user]);
        $forumUser->setBoolRead(false);
        $this->em->flush();
    }


    /**
     * @param Forum $forum
     * @param       $user
     * @return int
     */
    public function countTopicNotRead(Forum $forum, $user): int
    {
        return $this->em->getRepository('ProjetNormandie\ForumBundle\Entity\TopicUser')
                ->countNotRead($forum,$user);
    }


    /**
     * @param Forum $parent
     * @param       $user
     * @return int
     */
    public function countSubForumNotRead(Forum $parent, $user): int
    {
        return $this->em->getRepository('ProjetNormandieForumBundle:ForumUser')
                ->countSubForumNotRead($parent, $user);
    }
}