projet-normandie / email-bundle

src/Mapper/MailerMapper.php

<?php

namespace ProjetNormandie\EmailBundle\Mapper;

use ProjetNormandie\EmailBundle\Entity\Email as EmailEntity;
use Symfony\Component\Mime\Email;

/**
 * Mapper class upon the Swift_Mailer to send Swift_Messages.
 */
class MailerMapper
{
    /**
     * Transforms an Email message to an Email entity
     */
    public function fromEmail(Email $email): EmailEntity
    {
        $emailEntity =  (new EmailEntity())
            ->setSubject($email->getSubject())

It seems like $email->getSubject() can also be of type null; however, parameter $subject of ProjetNormandie\EmailBundle\Entity\Email::setSubject() does only seem to accept string, maybe add an additional type check?

            ->setTargetMail($email->getTo()[0]->toString())
            ->setBodyText($email->getTextBody())

It seems like $email->getTextBody() can also be of type null and resource; however, parameter $bodyText of ProjetNormandie\EmailBundle\Entity\Email::setBodyText() does only seem to accept string, maybe add an additional type check?

            ->setBodyHtml($email->getHtmlBody());

It seems like $email->getHtmlBody() can also be of type null and resource; however, parameter $bodyHtml of ProjetNormandie\EmailBundle\Entity\Email::setBodyHtml() does only seem to accept string, maybe add an additional type check?

        if (count($email->getFrom()) > 0) {
            $emailEntity->setFrom($email->getFrom()[0]->toString());
        }

        if (count($email->getReplyTo()) > 0) {
            $emailEntity->setFrom($email->getReplyTo()[0]->toString());
        }

        return $emailEntity;
    }
}