procyonweb / laravel-translation-generator

src/GenerateCommand.php

<?php declare(strict_types=1);

namespace ProcyonWeb\TranslationGenerator;

use Illuminate\Console\Command;

class GenerateCommand extends Command
{
    protected $signature = 'translation:generate {lang=en} {--upload}';

    protected $description = 'Generate missing translation strings in php and Vue files';

    /** @var PhraseClient */
    private $client;

    public function __construct(PhraseClient $client)
    {
        parent::__construct();
        $this->client = $client;
    }

    public function handle(): void
    {
        $translatables = (new SearchService())->getTranslatableStrings(config('translation.generator.patterns'));

The function config was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->client->downloadFiles();

        $lang = $this->argument('lang');
        $fileName = 'resources/lang/' . $lang . '.json';

Are you sure $lang of type null|string|string[] can be used in concatenation?

        $jsonFile = file_get_contents($fileName);
        $translations = json_decode($jsonFile, true);

        foreach ($translatables as $translatable) {
            $translatable = str_replace('\\', '', $translatable);
            if (!array_key_exists($translatable, $translations)) {
                $translations[$translatable] = $translatable;
            }
        }

        $content = json_encode($translations, JSON_PRETTY_PRINT + JSON_UNESCAPED_UNICODE + JSON_UNESCAPED_SLASHES);
        file_put_contents($fileName, $content);

        $isUpload = $this->option('upload');
        if ($isUpload && $this->client->isReady()) {
            $this->client->uploadFile($content, $fileName, $lang);

It seems like $lang can also be of type null and string[]; however, parameter $langIso of ProcyonWeb\TranslationGenerator\PhraseClient::uploadFile() does only seem to accept string, maybe add an additional type check?

        }
    }
}