Issues in Resource.php (master) - Issues in master - prgTW/basecrm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (108)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Resource/Resource.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace prgTW\BaseCRM\Resource;

use Doctrine\Common\Inflector\Inflector;
use prgTW\BaseCRM\Transport\Transport;

abstract class Resource extends BaseResource
{
	/** @var \Resource[] */
	protected $subResources = [];

	/** @var Transport */
	protected $transport;

	/** @var string */
	protected $uri;

	/**
	 * @param Transport $transport
	 * @param string    $uri
	 * @param array     $data
	 */
	public function __construct(Transport $transport, $uri, array $data = [])
	{
		$this->transport = $transport;
		$this->uri       = $uri;
		if ([] !== $data)
		{
			$this->hydrate($data);
		}

		$this->init();
	}

	/**
	 * @return string
	 */
	abstract protected function getEndpoint();

	protected function init()
	{

	}

	/**
	 * @param string $suffix
	 *
	 * @return string
	 */
	protected function getFullUri($suffix = '')
	{
		return sprintf('%s/%s/%s%s', static::getEndpoint(), static::PREFIX, $this->uri, $suffix);
	}

	/**
	 * @param string $name

	 *
	 * @return Resource|\Resource[]

	 */
	public function getSubResources($name = null)
	{
		if (isset($name))
		{
			return isset($this->subResources[$name]) ? $this->subResources[$name] : null;
		}

		return $this->subResources;
	}

	/**
	 * @param string[] $resourceClassNames
	 *
	 * @throws \InvalidArgumentException when class name is not a Resource
	 */
	protected function setSubResources(array $resourceClassNames)
	{
		foreach ($resourceClassNames as $key => $value)
		{
			$resourceClassName = is_int($key) ? $value : $key;
			if (false === is_subclass_of($resourceClassName, Resource::class))
			{
				//@codeCoverageIgnoreStart
				throw new \InvalidArgumentException(sprintf('Class %s is not an instance of %s', $resourceClassName, Resource::class));

				//@codeCoverageIgnoreEnd
			}
			$resourceName = $this->getResourceName($resourceClassName);
			$uri          = ltrim(sprintf('%s/%s', $this->uri, $resourceName), '/');
			if (false === is_int($key))
			{
				$uri = $value;
			}

			$class = new $resourceClassName($this->transport, $uri);

			$this->subResources[lcfirst(Inflector::camelize($resourceName))] = $class;
		}
	}

	/**
	 * @param array  $params
	 * @param string $instanceClassName

	 * @param string $idParam
	 *
	 * @return Resource

	 */
	protected function getObjectFromArray(array $params, $instanceClassName = null, $idParam = 'id')
	{
		if (null === $instanceClassName)
		{
			$instanceClassName = Inflector::singularize(static::class);
		}

		if (array_key_exists($idParam, $params))
		{
			$uri = sprintf('%s/%s', $this->uri, $params[$idParam]);
		}
		else
		{
			$uri = $this->uri;
		}

		return new $instanceClassName($this->transport, $uri, $params);
	}

	/**
	 * @param $method
	 * @param $arguments
	 *
	 * @return Resource|ResourceCollection

	 * @throws \BadMethodCallException
	 */
	public function __call($method, $arguments)
	{
		if ('get' !== substr($method, 0, 3))
		{
			//@codeCoverageIgnoreStart
			throw new \BadMethodCallException('Unknown resource');
			//@codeCoverageIgnoreEnd
		}

		$key         = lcfirst(substr($method, 3));
		$subResource = $this->getSubResources($key);
		if (null === $subResource)
		{
			//@codeCoverageIgnoreStart
			throw new \BadMethodCallException(sprintf('Resource "%s" not found', $key));
			//@codeCoverageIgnoreEnd
		}

		return $subResource;
	}

	/**
	 * @return Transport
	 */
	public function getTransport()
	{
		return $this->transport;
	}
}


1			<?php
2
3			namespace prgTW\BaseCRM\Resource;
4
5			use Doctrine\Common\Inflector\Inflector;
6			use prgTW\BaseCRM\Transport\Transport;
7
8			abstract class Resource extends BaseResource
9			{
10			/** @var \Resource[] */
11			protected $subResources = [];
12
13			/** @var Transport */
14			protected $transport;
15
16			/** @var string */
17			protected $uri;
18
19			/**
20			* @param Transport $transport
21			* @param string $uri
22			* @param array $data
23			*/
24			public function __construct(Transport $transport, $uri, array $data = [])
25			{
26			$this->transport = $transport;
27			$this->uri = $uri;
28			if ([] !== $data)
29			{
30			$this->hydrate($data);
31			}
32
33			$this->init();
34			}
35
36			/**
37			* @return string
38			*/
39			abstract protected function getEndpoint();
40
41			protected function init()
42			{
43
44			}
45
46			/**
47			* @param string $suffix
48			*
49			* @return string
50			*/
51			protected function getFullUri($suffix = '')
52			{
53			return sprintf('%s/%s/%s%s', static::getEndpoint(), static::PREFIX, $this->uri, $suffix);
54			}
55
56			/**
57			* @param string $name
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$name` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
58			*
59			* @return Resource\|\Resource[]
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\Resource\|null\|\Resource[]`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
60			*/
61			public function getSubResources($name = null)
62			{
63			if (isset($name))
64			{
65			return isset($this->subResources[$name]) ? $this->subResources[$name] : null;
66			}
67
68			return $this->subResources;
69			}
70
71			/**
72			* @param string[] $resourceClassNames
73			*
74			* @throws \InvalidArgumentException when class name is not a Resource
75			*/
76			protected function setSubResources(array $resourceClassNames)
77			{
78			foreach ($resourceClassNames as $key => $value)
79			{
80			$resourceClassName = is_int($key) ? $value : $key;
81			if (false === is_subclass_of($resourceClassName, Resource::class))
82			{
83			//@codeCoverageIgnoreStart
84			throw new \InvalidArgumentException(sprintf('Class %s is not an instance of %s', $resourceClassName, Resource::class));
			0 ignored issues – show Coding Style introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This line exceeds maximum limit of 120 characters; contains 123 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
85			//@codeCoverageIgnoreEnd
86			}
87			$resourceName = $this->getResourceName($resourceClassName);
88			$uri = ltrim(sprintf('%s/%s', $this->uri, $resourceName), '/');
89			if (false === is_int($key))
90			{
91			$uri = $value;
92			}
93
94			$class = new $resourceClassName($this->transport, $uri);
95
96			$this->subResources[lcfirst(Inflector::camelize($resourceName))] = $class;
97			}
98			}
99
100			/**
101			* @param array $params
102			* @param string $instanceClassName
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$instanceClassName` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
103			* @param string $idParam
104			*
105			* @return Resource
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `object`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
106			*/
107			protected function getObjectFromArray(array $params, $instanceClassName = null, $idParam = 'id')
108			{
109			if (null === $instanceClassName)
110			{
111			$instanceClassName = Inflector::singularize(static::class);
112			}
113
114			if (array_key_exists($idParam, $params))
115			{
116			$uri = sprintf('%s/%s', $this->uri, $params[$idParam]);
117			}
118			else
119			{
120			$uri = $this->uri;
121			}
122
123			return new $instanceClassName($this->transport, $uri, $params);
124			}
125
126			/**
127			* @param $method
128			* @param $arguments
129			*
130			* @return Resource\|ResourceCollection
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\Resource\|\Resource[]`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
131			* @throws \BadMethodCallException
132			*/
133			public function __call($method, $arguments)
134			{
135			if ('get' !== substr($method, 0, 3))
136			{
137			//@codeCoverageIgnoreStart
138			throw new \BadMethodCallException('Unknown resource');
139			//@codeCoverageIgnoreEnd
140			}
141
142			$key = lcfirst(substr($method, 3));
143			$subResource = $this->getSubResources($key);
144			if (null === $subResource)
145			{
146			//@codeCoverageIgnoreStart
147			throw new \BadMethodCallException(sprintf('Resource "%s" not found', $key));
148			//@codeCoverageIgnoreEnd
149			}
150
151			return $subResource;
152			}
153
154			/**
155			* @return Transport
156			*/
157			public function getTransport()
158			{
159			return $this->transport;
160			}
161			}
162

GitHub Access Token became invalid

Issues (108)

Security Analysis no request data

Resource/Resource.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

prgTW / basecrm-php-api

GitHub Access Token became invalid

Issues (108)

Security Analysis no request data

Resource/Resource.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like