prgTW / basecrm-php-api

Resource/ListResource.php

<?php

namespace prgTW\BaseCRM\Resource;

use Doctrine\Common\Inflector\Inflector;
use prgTW\BaseCRM\Resource\Partial\CreateResource;
use prgTW\BaseCRM\Transport\Transport;

abstract class ListResource extends Resource implements \ArrayAccess, \IteratorAggregate, \Countable
{
	use CreateResource;

	/** @var ResourceCollection */
	protected $collection;

	/** @var array */
	private $query;

	/** {@inheritdoc} */
	public function __construct(Transport $transport, $uri)
	{
		parent::__construct($transport, $uri);
		$this->reset();
	}

	protected function reset()
	{
		$this->collection = null;
		$this->query      = [];
	}

	/**
	 * @param string $id
	 *
	 * @return InstanceResource
	 */
	public function get($id)
	{
		$instanceClassName = Inflector::singularize(static::class);
		$uri               = sprintf('%s/%s', $this->uri, $id);
		/** @var InstanceResource $resource */
		$resource = new $instanceClassName($this->transport, $uri);

		return $resource;
	}

	/**
	 * @param string $id
	 *
	 * @return bool
	 */
	public function delete($id)
	{
		$uri    = $this->getFullUri(sprintf('/%d', $id));
		$result = $this->transport->delete($uri);

		return in_array($result, [null, true], true);
	}

	/**
	 * @param array $query
	 *
	 * @return ResourceCollection
	 */
	public function all($query = [])
	{
		if (null !== $this->collection && $this->query === $query)
		{
			return $this->collection;
		}

		$uri     = $this->getFullUri();
		$options = [] === $query ? [] : ['query' => $query];
		$data    = $this->transport->get($uri, null, $options);

		$this->query      = $options;
		$this->collection = $this->postAll($data);

It seems like $data defined by $this->transport->get($uri, null, $options) on line 74 can also be of type boolean; however, prgTW\BaseCRM\Resource\ListResource::postAll() does only seem to accept array, maybe add an additional type check?

		return $this->collection;
	}

	/** {@inheritdoc} */
	public function count()
	{
		$collection = $this->all();

		return count($collection);
	}

	/**
	 * @return ResourceCollection
	 */
	public function getIterator()
	{
		$collection = $this->all();

		return $collection;
	}

	/**
	 * @param array $data
	 *
	 * @return ResourceCollection
	 */
	protected function postAll(array $data)
	{
		$childResourceName = $this->getChildResourceName();

		foreach ($data as $key => $resourceData)
		{
			$data[$key] = $this->getObjectFromArray($resourceData[$childResourceName]);
		}

		return new ResourceCollection($data, $childResourceName);

The call to ResourceCollection::__construct() has too many arguments starting with $childResourceName.

	}

	/** {@inheritdoc} */
	public function offsetExists($offset)
	{
		$this->all($this->query);

		return $this->collection->offsetExists($offset);
	}

	/** {@inheritdoc} */
	public function offsetGet($offset)
	{
		$this->all($this->query);

		return $this->collection->offsetGet($offset);
	}

	/** {@inheritdoc} */
	public function offsetSet($offset, $value)
	{
		$this->all($this->query);

		$this->collection->offsetSet($offset, $value);
	}

	/** {@inheritdoc} */
	public function offsetUnset($offset)
	{
		$this->all($this->query);

		return $this->collection->offsetUnset($offset);
	}
}