Contacts::create() - Code Metrics - prgTW/basecrm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

Contacts::create() B
last analyzed 2016-08-09 08:15 UTC

↳ Parent: Contacts

Complexity

Conditions	1
Paths	1

Size

Total Lines	29
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	29
rs	8.8571
cc	1
eloc	25
nc	1
nop	3

<?php

namespace prgTW\BaseCRM\Service;

use prgTW\BaseCRM\Resource\DetachedResource;
use prgTW\BaseCRM\Resource\Page;
use prgTW\BaseCRM\Resource\PaginatedListResource;

class Contacts extends PaginatedListResource
{
	/** {@inheritdoc} */
	protected function getEndpoint()
	{
		return self::ENDPOINT_SALES;
	}

	/**
	 * @param int $page
	 *
	 * @return Page

	 */
	public function all($page = 1)
	{
		return parent::getPage($page);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
	}

	/** {@inheritdoc} */
	public function create(DetachedResource $resource, array $fieldNames = [], $useKey = true)
	{
		$fieldNames = array_intersect($fieldNames, [
			'name',
			'last_name',
			'first_name',
			'is_organisation',
			'contact_id',
			'email',
			'phone',
			'mobile',
			'twitter',
			'skype',
			'facebook',
			'linkedin',
			'address',
			'city',
			'country',
			'title',
			'description',
			'industry',
			'website',
			'fax',
			'tag_list',
			'private',
		]);

		return parent::create($resource, $fieldNames, $useKey);
	}
}


1			<?php
2
3			namespace prgTW\BaseCRM\Service;
4
5			use prgTW\BaseCRM\Resource\DetachedResource;
6			use prgTW\BaseCRM\Resource\Page;
7			use prgTW\BaseCRM\Resource\PaginatedListResource;
8
9			class Contacts extends PaginatedListResource
10			{
11			/** {@inheritdoc} */
12			protected function getEndpoint()
13			{
14			return self::ENDPOINT_SALES;
15			}
16
17			/**
18			* @param int $page
19			*
20			* @return Page
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report Should the return type not be `\prgTW\BaseCRM\Resource\ResourceCollection`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
21			*/
22			public function all($page = 1)
23			{
24			return parent::getPage($page);
			0 ignored issues – show Comprehensibility Bug introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getPage()` instead of `all()`). Are you sure this is correct? If so, you might want to change this to `$this->getPage()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
25			}
26
27			/** {@inheritdoc} */
28			public function create(DetachedResource $resource, array $fieldNames = [], $useKey = true)
29			{
30			$fieldNames = array_intersect($fieldNames, [
31			'name',
32			'last_name',
33			'first_name',
34			'is_organisation',
35			'contact_id',
36			'email',
37			'phone',
38			'mobile',
39			'twitter',
40			'skype',
41			'facebook',
42			'linkedin',
43			'address',
44			'city',
45			'country',
46			'title',
47			'description',
48			'industry',
49			'website',
50			'fax',
51			'tag_list',
52			'private',
53			]);
54
55			return parent::create($resource, $fieldNames, $useKey);
56			}
57			}
58

prgTW / basecrm-php-api

GitHub Access Token became invalid

Contacts::create() B last analyzed 2016-08-09 08:15 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Contacts::create() B
last analyzed 2016-08-09 08:15 UTC