Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class Sources extends ListResource |
||
10 | { |
||
11 | /** {@inheritdoc} */ |
||
12 | protected function getEndpoint() |
||
16 | |||
17 | /** |
||
18 | * @param bool $other Retrieves sources which were added by other users in the account |
||
19 | * |
||
20 | * @return ResourceCollection |
||
21 | */ |
||
22 | public function all($other = false) |
||
32 | |||
33 | /** {@inheritdoc} */ |
||
34 | View Code Duplication | public function create(DetachedResource $resource, array $fieldNames = [], $useKey = true) |
|
42 | } |
||
43 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.