TaggableTrait - Code Metrics - prgTW/basecrm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

TaggableTrait A
last analyzed 2016-08-09 08:15 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	1
c	2
b	0
f	0
lcom	1
cbo	4
dl	0
loc	34
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	saveTags()	0	26	1

<?php

namespace prgTW\BaseCRM\Service\Behavior;

use prgTW\BaseCRM\Resource\ResourceCollection;
use prgTW\BaseCRM\Service\Detached\Tag;
use prgTW\BaseCRM\Service\Enum\TagAppId;
use prgTW\BaseCRM\Service\Tags;

/**
 * @method string getClassNameOnly()
 * @method Tags   getTags()
 */
trait TaggableTrait
{
	/**
	 * @param string[] $tags
	 *
	 * @return ResourceCollection
	 */
	public function saveTags(array $tags)
	{
		$classNameOnly = $this->getClassNameOnly();

		$tag          = TagAppId::fromName($classNameOnly);
		$appId        = $tag->getValue();
		$taggableType = $tag->getName();
		$taggableId   = $this->id;
class MyClass { }

$x = new MyClass();
$x->foo = true;

		$tag               = new Tag;
		$tag->appId        = $appId;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$tag->taggableType = $taggableType;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$tag->taggableId   = $taggableId;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$tag->tagList      = implode(',', $tags);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

		/** @var Tags $tags */
		$tags   = $this->getTags();
		$result = $tags->create($tag, [
			'app_id',
			'taggable_type',
			'taggable_id',
			'tag_list',
		], false);

		return $result;
	}
}


1			<?php
2
3			namespace prgTW\BaseCRM\Service\Behavior;
4
5			use prgTW\BaseCRM\Resource\ResourceCollection;
6			use prgTW\BaseCRM\Service\Detached\Tag;
7			use prgTW\BaseCRM\Service\Enum\TagAppId;
8			use prgTW\BaseCRM\Service\Tags;
9
10			/**
11			* @method string getClassNameOnly()
12			* @method Tags getTags()
13			*/
14			trait TaggableTrait
15			{
16			/**
17			* @param string[] $tags
18			*
19			* @return ResourceCollection
20			*/
21			public function saveTags(array $tags)
22			{
23			$classNameOnly = $this->getClassNameOnly();
24
25			$tag = TagAppId::fromName($classNameOnly);
26			$appId = $tag->getValue();
27			$taggableType = $tag->getName();
28			$taggableId = $this->id;
			0 ignored issues – show Bug introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29
30			$tag = new Tag;
31			$tag->appId = $appId;
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report The property `appId` does not exist on `object<prgTW\BaseCRM\Service\Detached\Tag>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
32			$tag->taggableType = $taggableType;
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report The property `taggableType` does not exist on `object<prgTW\BaseCRM\Service\Detached\Tag>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
33			$tag->taggableId = $taggableId;
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report The property `taggableId` does not exist on `object<prgTW\BaseCRM\Service\Detached\Tag>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			$tag->tagList = implode(',', $tags);
			0 ignored issues – show Documentation introduced 2016-08-09 08:15 UTC by Report Bug Copy Issue Report The property `tagList` does not exist on `object<prgTW\BaseCRM\Service\Detached\Tag>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35
36			/** @var Tags $tags */
37			$tags = $this->getTags();
38			$result = $tags->create($tag, [
39			'app_id',
40			'taggable_type',
41			'taggable_id',
42			'tag_list',
43			], false);
44
45			return $result;
46			}
47			}
48

prgTW / basecrm-php-api

GitHub Access Token became invalid

TaggableTrait A last analyzed 2016-08-09 08:15 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

TaggableTrait A
last analyzed 2016-08-09 08:15 UTC