RouteServiceProvider - Code Metrics - Inspection of "update composer.json" - preetender/routing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 527bb5...aca9c3 )

by César

created 2017-07-31 17:26 UTC

RouteServiceProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	20
c	0
b	0
f	0
wmc	1
lcom	0
cbo	3
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	register()	0	5	1

<?php

namespace Preetender\Routing;

use League\Container\ServiceProvider\AbstractServiceProvider;
use Illuminate\Http\Response;
use Illuminate\Http\Request;

/**
 * Class RouteServiceProvider
 * @package Preetender\Routing
 */
class RouteServiceProvider extends AbstractServiceProvider
{
    protected $provides = [
        Request::class,
        Response::class
    ];

    /**
     * Use the register method to register items with the container via the
     * protected $this->container property or the `getContainer` method
     * from the ContainerAwareTrait.
     *
     * @return void
     */
    public function register()
    {
        $this->getContainer()->add(Request::class, Request::createFromGlobals());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->getContainer()->add(Response::class, new Response());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}

Push — master ( 527bb5...aca9c3 )

RouteServiceProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Available Fixes

1			<?php
2
3			namespace Preetender\Routing;
4
5			use League\Container\ServiceProvider\AbstractServiceProvider;
6			use Illuminate\Http\Response;
7			use Illuminate\Http\Request;
8
9			/**
10			* Class RouteServiceProvider
11			* @package Preetender\Routing
12			*/
13			class RouteServiceProvider extends AbstractServiceProvider
14			{
15			protected $provides = [
16			Request::class,
17			Response::class
18			];
19
20			/**
21			* Use the register method to register items with the container via the
22			* protected $this->container property or the `getContainer` method
23			* from the ContainerAwareTrait.
24			*
25			* @return void
26			*/
27			public function register()
28			{
29			$this->getContainer()->add(Request::class, Request::createFromGlobals());
			0 ignored issues – show Bug introduced 2017-07-31 17:31 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `add()` does only exist in the following implementations of said interface: `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
30			$this->getContainer()->add(Response::class, new Response());
			0 ignored issues – show Bug introduced 2017-07-31 17:31 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `add()` does only exist in the following implementations of said interface: `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
31			}
32			}

preetender / routing

Push — master ( 527bb5...aca9c3 )

RouteServiceProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like