Preetender\Routing\Response\BaseResponse

Complexity

Total Complexity

1

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1

<?php

namespace Preetender\Routing\Response;

use Preetender\Routing\Contracts\Renderable;
use Illuminate\Http\Request;
use Illuminate\Http\Response;

/**
 * Class BaseResponse
 * @package Preetender\Routing\Response
 */
abstract class BaseResponse implements Renderable
{
    /** @var Renderable */
    protected $wrapped;

    /** @var array  */
    protected $headers = [];

    /** @var Response  */
    protected $response;

    /** @var Request */
    protected $request;

    /**
     * Formatter constructor.
     *
     * @param Renderable $renderer
     * @param Request $request
     * @param Response $response
     */
    public function __construct(Renderable $renderer, Request $request, Response $response)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->wrapped = $renderer;
        $this->request = $request;
        $this->response = $response;
    }
}