pratiksh404 / nepalidate

tests/Unit/NepaliDateTest.php

<?php

use Carbon\Carbon;
use Pratiksh\Nepalidate\Services\NepaliDate;

test('it can convert AD to BS date string', function () {
    $ad = Carbon::create(2024, 4, 13); // Known BS new year date
    $date = NepaliDate::create($ad);

It seems like $ad can also be of type false; however, parameter $date of Pratiksh\Nepalidate\Services\NepaliDate::create() does only seem to accept Carbon\Carbon, maybe add an additional type check?

    expect($date)->toBeInstanceOf(NepaliDate::class);
    expect($date->toBS())->toBe('2081-01-01');
});

test('it can return BS as an array', function () {
    $ad = Carbon::create(2024, 4, 13);
    $date = NepaliDate::fromAD($ad);

It seems like $ad can also be of type false; however, parameter $date of Pratiksh\Nepalidate\Services\NepaliDate::fromAD() does only seem to accept Carbon\Carbon, maybe add an additional type check?

    $bsArray = $date->toBSArray();

    expect($bsArray)->toHaveKeys(['year', 'month', 'day', 'dayOfWeek']);
    expect($bsArray['year'])->toBe(2081);
    expect((int) $bsArray['month'])->toBe(1);
    expect((int) $bsArray['day'])->toBe(1);
});

test('it can return formatted English BS date', function () {
    $date = NepaliDate::create(Carbon::create(2024, 4, 13));

It seems like Carbon\Carbon::create(2024, 4, 13) can also be of type false; however, parameter $date of Pratiksh\Nepalidate\Services\NepaliDate::create() does only seem to accept Carbon\Carbon, maybe add an additional type check?

    expect($date->toFormattedEnglishBSDate())->toBe('1 Baisakh 2081, Saturday');
});