pratiksh404 / adminetic

src/Http/Controllers/Admin/ProfileController.php

<?php

namespace Pratiksh\Adminetic\Http\Controllers\Admin;

use App\Http\Controllers\Controller;

The type App\Http\Controllers\Controller was not found. Maybe you did not declare it correctly or list all dependencies?

use Pratiksh\Adminetic\Contracts\ProfileRepositoryInterface;
use Pratiksh\Adminetic\Http\Requests\ProfileRequest;
use Pratiksh\Adminetic\Models\Admin\Profile;

class ProfileController extends Controller
{
    protected $profileRepositoryInterface;

    public function __construct(ProfileRepositoryInterface $profileRepositoryInterface)
    {
        $this->profileRepositoryInterface = $profileRepositoryInterface;
    }

    /**
     * Display the specified resource.
     *
     * @param  \Pratiksh\Adminetic\Models\Admin\Profile  $profile
     * @return \Illuminate\Http\Response
     */
    public function show(Profile $profile)
    {
        return $this->checkAuthorization($profile) ? view('adminetic::admin.profile.show', $this->profileRepositoryInterface->showProfile($profile)) : abort(403);

The expression return $this->checkAuthorization($profile) ? view('adminetic::admin.profile.show', $this->profileRepositoryInterface->showProfile($profile)) : abort(403) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

Are you sure the usage of abort(403) is correct as it seems to always return null.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \Pratiksh\Adminetic\Models\Admin\Profile  $profile
     * @return \Illuminate\Http\Response
     */
    public function edit(Profile $profile)
    {
        return $this->checkAuthorization($profile) ? view('adminetic::admin.profile.edit', $this->profileRepositoryInterface->editProfile($profile)) : abort(403);

Are you sure the usage of abort(403) is correct as it seems to always return null.

The expression return $this->checkAuthorization($profile) ? view('adminetic::admin.profile.edit', $this->profileRepositoryInterface->editProfile($profile)) : abort(403) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Pratiksh\Adminetic\Http\Requests\ProfileRequest  $request
     * @param  \Pratiksh\Adminetic\Models\Admin\Profile  $profile
     * @return \Illuminate\Http\Response
     */
    public function update(ProfileRequest $request, Profile $profile)
    {
        if ($this->checkAuthorization($profile)) {
            $this->profileRepositoryInterface->updateProfile($request, $profile);

            return redirect(adminEditRoute('profile', $profile->id))->withInfo('Profile Updated Sucessfully');

The expression return redirect(adminEditRoute('profile', $profile->id))->withInfo('Profile Updated Sucessfully') also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

        } else {
            return abort(403);

The expression return abort(403) returns the type void which is incompatible with the documented return type Illuminate\Http\Response.

Are you sure the usage of abort(403) is correct as it seems to always return null.

        }
    }

    /**
     * Check Authorization.
     */
    protected function checkAuthorization(Profile $profile)
    {
        return auth()->user()->hasRole('superadmin') || auth()->user()->hasRole('admin') || auth()->user()->id == $profile->user_id;
    }
}