| Conditions | 13 |
| Paths | 8 |
| Total Lines | 34 |
| Code Lines | 24 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 110 | private function store_setting_value(Setting $setting, $key, $value) |
||
| 111 | { |
||
| 112 | if ($setting->getRawOriginal('setting_type') == 1 || $setting->getRawOriginal('setting_type') == 10) { |
||
| 113 | $setting->update([ |
||
| 114 | 'string_value' => $value, |
||
| 115 | ]); |
||
| 116 | if ($setting->getRawOriginal('setting_type') == 10) { |
||
| 117 | if (request()->has($key)) { |
||
| 118 | $setting->update([ |
||
| 119 | 'string_value' => $value->store('admin/setting', 'public'), |
||
| 120 | ]); |
||
| 121 | $image = Image::make($value->getRealPath()); |
||
| 122 | $image->save(public_path('storage/'.$setting->string_value)); |
||
| 123 | } |
||
| 124 | } |
||
| 125 | } elseif ($setting->getRawOriginal('setting_type') == 2 || $setting->getRawOriginal('setting_type') == 6 || $setting->getRawOriginal('setting_type') == 7) { |
||
| 126 | $setting->update([ |
||
| 127 | 'integer_value' => $value, |
||
| 128 | ]); |
||
| 129 | } elseif ($setting->getRawOriginal('setting_type') == 3 || $setting->getRawOriginal('setting_type') == 4) { |
||
| 130 | $setting->update([ |
||
| 131 | 'text_value' => $value, |
||
| 132 | ]); |
||
| 133 | } elseif ($setting->getRawOriginal('setting_type') == 5) { |
||
| 134 | $setting->update([ |
||
| 135 | 'boolean_value' => $value, |
||
| 136 | ]); |
||
| 137 | } elseif ($setting->getRawOriginal('setting_type') == 8 || $setting->getRawOriginal('setting_type') == 9) { |
||
| 138 | $setting->update([ |
||
| 139 | 'setting_json' => $value, |
||
| 140 | ]); |
||
| 141 | } else { |
||
| 142 | $setting->update([ |
||
| 143 | 'string_value' => $value, |
||
| 144 | ]); |
||
| 148 |