pratiksh404 / adminetic-announcement

src/Notifications/AnnouncementNotification.php

<?php

namespace Adminetic\Announcement\Notifications;

use Adminetic\Announcement\Mail\AnnouncementMail;
use Adminetic\Announcement\Models\Admin\Announcement;
use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Notification;

class AnnouncementNotification extends Notification
{
    use Queueable;

    protected $announcement;

    /**
     * Create a new notification instance.
     *
     * @return void
     */
    public function __construct(Announcement $announcement)
    {
        $this->announcement = $announcement;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return $this->announcement->mediums();

Are you sure the usage of $this->announcement->mediums() targeting Adminetic\Announcement\Models\Admin\Announcement::mediums() seems to always return null.

    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)
    {
        return (new AnnouncementMail($this->announcement))

The expression return new Adminetic\Announcement\Mail\AnnouncementMail($this->announcement)->to($notifiable->email) returns the type Adminetic\Announcement\Mail\AnnouncementMail which is incompatible with the documented return type Illuminate\Notifications\Messages\MailMessage.

            ->to($notifiable->email);
    }

    /**
     * Get the array representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function toArray($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return [
            'model' => 'announcement',
            'id' => $this->announcement->id,
            'date_time' => $this->announcement->created_at->diffForHumans(),

The method diffForHumans() does not exist on DateTime. It seems like you code against a sub-type of DateTime such as Carbon\Carbon.

            'announcement_by' => $this->announcement->user->name ?? 'N/A',
            'announcement' => $this->announcement->body,
        ];
    }
}