pradosoft / prado

framework/Data/SqlMap/Statements/TCachingStatement.php

Doc Comments +4 added lines

@@ -97,6 +97,10 @@
 		return $cacheKey->getHash();
 	}
 
+	/**
+	 * @param integer $skip
+	 * @param integer $max
+	 */
 	protected function createCommand($connection, $parameter, $skip=null, $max=null)
 	{
 		return $this->_mappedStatement->getCommand()->create($this->getManager(),

Spacing +14 added lines, -14 removed lines

@@ -26,7 +26,7 @@ 
 
 	public function __construct(TMappedStatement $statement)
 	{
-		$this->_mappedStatement = $statement;
+		$this->_mappedStatement=$statement;
 	}
 
 	public function getID()
@@ -46,12 +46,12 @@ 
 
 	public function executeQueryForMap($connection, $parameter, $keyProperty, $valueProperty=null, $skip=-1, $max=-1, $delegate=null)
 	{
-		$sql = $this->createCommand($connection, $parameter, $skip, $max);
-		$key = $this->getCacheKey([clone($sql), $keyProperty, $valueProperty,$skip, $max]);
-		$map = $this->getStatement()->getCache()->get($key);
+		$sql=$this->createCommand($connection, $parameter, $skip, $max);
+		$key=$this->getCacheKey([clone($sql), $keyProperty, $valueProperty, $skip, $max]);
+		$map=$this->getStatement()->getCache()->get($key);
 		if($map===null)
 		{
-			$map = $this->_mappedStatement->runQueryForMap(
+			$map=$this->_mappedStatement->runQueryForMap(
 				$connection, $parameter, $sql, $keyProperty, $valueProperty, $delegate);
 			$this->getStatement()->getCache()->set($key, $map);
 		}
@@ -70,12 +70,12 @@ 
 
 	public function executeQueryForList($connection, $parameter, $result=null, $skip=-1, $max=-1, $delegate=null)
 	{
-		$sql = $this->createCommand($connection, $parameter, $skip, $max);
-		$key = $this->getCacheKey([clone($sql), $parameter, $skip, $max]);
-		$list = $this->getStatement()->getCache()->get($key);
+		$sql=$this->createCommand($connection, $parameter, $skip, $max);
+		$key=$this->getCacheKey([clone($sql), $parameter, $skip, $max]);
+		$list=$this->getStatement()->getCache()->get($key);
 		if($list===null)
 		{
-			$list = $this->_mappedStatement->runQueryForList(
+			$list=$this->_mappedStatement->runQueryForList(
 				$connection, $parameter, $sql, $result, $delegate);
 			$this->getStatement()->getCache()->set($key, $list);
 		}
@@ -84,12 +84,12 @@ 
 
 	public function executeQueryForObject($connection, $parameter, $result=null)
 	{
-		$sql = $this->createCommand($connection, $parameter);
-		$key = $this->getCacheKey([clone($sql), $parameter]);
-		$object = $this->getStatement()->getCache()->get($key);
+		$sql=$this->createCommand($connection, $parameter);
+		$key=$this->getCacheKey([clone($sql), $parameter]);
+		$object=$this->getStatement()->getCache()->get($key);
 		if($object===null)
 		{
-			$object = $this->_mappedStatement->runQueryForObject($connection, $sql, $result);
+			$object=$this->_mappedStatement->runQueryForObject($connection, $sql, $result);
 			$this->getStatement()->getCache()->set($key, $object);
 		}
 		return $object;
@@ -97,7 +97,7 @@ 
 
 	protected function getCacheKey($object)
 	{
-		$cacheKey = new TSqlMapCacheKey($object);
+		$cacheKey=new TSqlMapCacheKey($object);
 		return $cacheKey->getHash();
 	}
 

framework/Data/SqlMap/TSqlMapConfig.php

Doc Comments +1 added lines

@@ -77,6 +77,7 @@
 
 	/**
 	 * Saves the current SqlMap manager to cache.
+	 * @param TSqlMapManager $manager
 	 * @return boolean true if SqlMap manager was cached, false otherwise.
 	 */
 	protected function cacheSqlMapManager($manager)

Braces +1 added lines, -2 removed lines

@@ -68,8 +68,7 @@
 				$manager->configureXml($file);
 				$this->cacheSqlMapManager($manager);
 			}
-		}
-		elseif($this->getConnectionID() !== '') {
+		} elseif($this->getConnectionID() !== '') {
 			$manager->setDbConnection($this->getDbConnection());
 		}
 		return $manager;

Spacing +18 added lines, -18 removed lines

@@ -43,7 +43,7 @@ 
 	 */
 	private function getCacheKey()
 	{
-		return $this->getID() . $this->getConfigFile();
+		return $this->getID().$this->getConfigFile();
 	}
 
 	/**
@@ -51,8 +51,8 @@ 
 	 */
 	public function clearCache()
 	{
-		$cache = $this->getApplication()->getCache();
-		if($cache !== null) {
+		$cache=$this->getApplication()->getCache();
+		if($cache!==null) {
 			$cache->delete($this->getCacheKey());
 		}
 	}
@@ -66,16 +66,16 @@ 
 	 * @since 3.1.7
 	 */
 	public function getSqlMapManager() {
-		if(($manager = $this->loadCachedSqlMapManager())===null)
+		if(($manager=$this->loadCachedSqlMapManager())===null)
 		{
-			$manager = new TSqlMapManager($this->getDbConnection());
+			$manager=new TSqlMapManager($this->getDbConnection());
 			if(strlen($file=$this->getConfigFile()) > 0)
 			{
 				$manager->configureXml($file);
 				$this->cacheSqlMapManager($manager);
 			}
 		}
-		elseif($this->getConnectionID() !== '') {
+		elseif($this->getConnectionID()!=='') {
 			$manager->setDbConnection($this->getDbConnection());
 		}
 		return $manager;
@@ -89,11 +89,11 @@ 
 	{
 		if($this->getEnableCache())
 		{
-			$cache = $this->getApplication()->getCache();
-			if($cache !== null) {
-				$dependencies = null;
-				if($this->getApplication()->getMode() !== TApplicationMode::Performance)
-					$dependencies = $manager->getCacheDependencies();
+			$cache=$this->getApplication()->getCache();
+			if($cache!==null) {
+				$dependencies=null;
+				if($this->getApplication()->getMode()!==TApplicationMode::Performance)
+					$dependencies=$manager->getCacheDependencies();
 				return $cache->set($this->getCacheKey(), $manager, 0, $dependencies);
 			}
 		}
@@ -108,10 +108,10 @@ 
 	{
 		if($this->getEnableCache())
 		{
-			$cache = $this->getApplication()->getCache();
-			if($cache !== null)
+			$cache=$this->getApplication()->getCache();
+			if($cache!==null)
 			{
-				$manager = $cache->get($this->getCacheKey());
+				$manager=$cache->get($this->getCacheKey());
 				if($manager instanceof TSqlMapManager)
 					return $manager;
 			}
@@ -138,11 +138,11 @@ 
 			$this->_configFile=$value;
 		else
 		{
-			$file = Prado::getPathOfNamespace($value, self::CONFIG_FILE_EXT);
-			if($file === null || !is_file($file))
+			$file=Prado::getPathOfNamespace($value, self::CONFIG_FILE_EXT);
+			if($file===null || !is_file($file))
 				throw new TConfigurationException('sqlmap_configfile_invalid', $value);
 			else
-				$this->_configFile = $file;
+				$this->_configFile=$file;
 		}
 	}
 
@@ -152,7 +152,7 @@ 
 	 */
 	public function setEnableCache($value)
 	{
-		$this->_enableCache = TPropertyValue::ensureBoolean($value);
+		$this->_enableCache=TPropertyValue::ensureBoolean($value);
 	}
 
 	/**

framework/Data/TDataSourceConfig.php

Doc Comments +1 added lines

@@ -149,6 +149,7 @@
 	/**
 	 * Finds the database connection instance from the Application modules.
 	 * @param string Database connection module ID.
+	 * @param string $id
 	 * @return TDbConnection database connection.
 	 * @throws TConfigurationException when module is not of TDbConnection or TDataSourceConfig.
 	 */

Spacing +3 added lines, -3 removed lines

@@ -110,9 +110,9 @@ 
 		if($this->_conn===null)
 		{
 			if($this->_connID!=='')
-				$this->_conn = $this->findConnectionByID($this->getConnectionID());
+				$this->_conn=$this->findConnectionByID($this->getConnectionID());
 			else
-				$this->_conn = Prado::createComponent($this->getConnectionClass());
+				$this->_conn=Prado::createComponent($this->getConnectionClass());
 		}
 		return $this->_conn;
 	}
@@ -158,7 +158,7 @@ 
 	 */
 	protected function findConnectionByID($id)
 	{
-		$conn = $this->getApplication()->getModule($id);
+		$conn=$this->getApplication()->getModule($id);
 		if($conn instanceof TDbConnection)
 			return $conn;
 		elseif($conn instanceof TDataSourceConfig)

Braces +1 added lines, -2 removed lines

@@ -68,8 +68,7 @@
 				foreach($xml['database'] as $name=>$value)
 					$db->setSubProperty($name, $value);
 			}
-		}
-		else
+		} else
 		{
 			if($prop=$xml->getElementByTagName('database'))
 			{

framework/Data/TDbConnection.php

Doc Comments +4 added lines

@@ -157,6 +157,7 @@ 
 	/**
 	 * Open or close the DB connection.
 	 * @param boolean whether to open or close DB connection
+	 * @param boolean $value
 	 * @throws TDbException if connection fails
 	 */
 	public function setActive($value)
@@ -241,6 +242,7 @@ 
 
 	/**
 	 * @param string The Data Source Name, or DSN, contains the information required to connect to the database.
+	 * @param string $value
 	 * @see http://www.php.net/manual/en/function.PDO-construct.php
 	 */
 	public function setConnectionString($value)
@@ -258,6 +260,7 @@ 
 
 	/**
 	 * @param string the username for establishing DB connection
+	 * @param string $value
 	 */
 	public function setUsername($value)
 	{
@@ -274,6 +277,7 @@ 
 
 	/**
 	 * @param string the password for establishing DB connection
+	 * @param string $value
 	 */
 	public function setPassword($value)
 	{

Spacing +11 added lines, -11 removed lines

@@ -92,7 +92,7 @@ 
 	 *
 	 * @since 3.1.7
 	 */
-	const DEFAULT_TRANSACTION_CLASS = 'System.Data.TDbTransaction';
+	const DEFAULT_TRANSACTION_CLASS='System.Data.TDbTransaction';
 
 	private $_dsn='';
 	private $_username='';
@@ -141,7 +141,7 @@ 
 	public function __sleep()
 	{
 //		$this->close(); - DO NOT CLOSE the current connection as serializing doesn't neccessarily mean we don't this connection anymore in the current session
-		return array_diff(parent::__sleep(), ["\0Prado\Data\TDbConnection\0_pdo","\0Prado\Data\TDbConnection\0_active"]);
+		return array_diff(parent::__sleep(), ["\0Prado\Data\TDbConnection\0_pdo", "\0Prado\Data\TDbConnection\0_active"]);
 	}
 
 	/**
@@ -188,7 +188,7 @@ 
 		{
 			try
 			{
-				$this->_pdo=new PDO($this->getConnectionString(),$this->getUsername(),
+				$this->_pdo=new PDO($this->getConnectionString(), $this->getUsername(),
 									$this->getPassword(), $this->_attributes);
 				// This attribute is only useful for PDO::MySql driver.
 				// Ignore the warning if a driver doesn't understand this.
@@ -221,16 +221,16 @@ 
 	 */
 	protected function setConnectionCharset()
 	{
-		if ($this->_charset === '' || $this->_active === false)
+		if($this->_charset==='' || $this->_active===false)
 			return;
-		switch ($this->_pdo->getAttribute(PDO::ATTR_DRIVER_NAME))
+		switch($this->_pdo->getAttribute(PDO::ATTR_DRIVER_NAME))
 		{
 			case 'mysql':
 			case 'sqlite':
-				$stmt = $this->_pdo->prepare('SET NAMES ?');
+				$stmt=$this->_pdo->prepare('SET NAMES ?');
 			break;
 			case 'pgsql':
-				$stmt = $this->_pdo->prepare('SET client_encoding TO ?');
+				$stmt=$this->_pdo->prepare('SET client_encoding TO ?');
 			break;
 			default:
 				throw new TDbException('dbconnection_unsupported_driver_charset', $driver);
@@ -290,7 +290,7 @@ 
 	/**
 	 * @return string the charset used for database connection. Defaults to emtpy string.
 	 */
-	public function getCharset ()
+	public function getCharset()
 	{
 		return $this->_charset;
 	}
@@ -298,7 +298,7 @@ 
 	/**
 	 * @param string the charset used for database connection
 	 */
-	public function setCharset ($value)
+	public function setCharset($value)
 	{
 		$this->_charset=$value;
 		$this->setConnectionCharset();
@@ -371,7 +371,7 @@ 
 	 */
 	public function setTransactionClass($value)
 	{
-		$this->_transactionClass = (string)$value;
+		$this->_transactionClass=(string) $value;
 	}
 
 	/**
@@ -439,7 +439,7 @@ 
 	{
 		if($this->_dbMeta===null)
 		{
-			$this->_dbMeta = TDbMetaData::getInstance($this);
+			$this->_dbMeta=TDbMetaData::getInstance($this);
 		}
 		return $this->_dbMeta;
 	}

Braces +2 added lines, -4 removed lines

@@ -196,8 +196,7 @@ 
 				$this->_pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
 				$this->_active=true;
 				$this->setConnectionCharset();
-			}
-			catch(PDOException $e)
+			} catch(PDOException $e)
 			{
 				throw new TDbException('dbconnection_open_failed', $e->getMessage());
 			}
@@ -350,8 +349,7 @@ 
 		{
 			$this->_pdo->beginTransaction();
 			return $this->_transaction=Prado::createComponent($this->getTransactionClass(), $this);
-		}
-		else
+		} else
 			throw new TDbException('dbconnection_connection_inactive');
 	}
 

framework/Data/TDbTransaction.php

Doc Comments +1 added lines

@@ -101,6 +101,7 @@
 
 	/**
 	 * @param boolean whether this transaction is active
+	 * @param boolean $value
 	 */
 	protected function setActive($value)
 	{

Braces +2 added lines, -4 removed lines

@@ -63,8 +63,7 @@ 
 		{
 			$this->_connection->getPdoInstance()->commit();
 			$this->_active=false;
-		}
-		else
+		} else
 			throw new TDbException('dbtransaction_transaction_inactive');
 	}
 
@@ -78,8 +77,7 @@ 
 		{
 			$this->_connection->getPdoInstance()->rollBack();
 			$this->_active=false;
-		}
-		else
+		} else
 			throw new TDbException('dbtransaction_transaction_inactive');
 	}
 

framework/I18N/core/MessageCache.php

Doc Comments +1 added lines, -3 removed lines

@@ -99,9 +99,7 @@
 	 * Get the data from the cache.
 	 * @param string $catalogue The translation section.
 	 * @param string $culture The translation locale, e.g. "en_AU".
-	 * @param string $filename If the source is a file, this file's modified
-	 * time is newer than the cache's modified time, no cache hit.
-	 * @return mixed Boolean FALSE if no cache hit. Otherwise, translation
+	 * @return false|string Boolean FALSE if no cache hit. Otherwise, translation
 	 * table data for the specified section and locale.
 	 */
 	public function get($catalogue, $culture, $lastmodified=0)

Spacing +18 added lines, -18 removed lines

@@ -12,7 +12,7 @@ 
  */
 use Exception;
 
-require_once(dirname(__FILE__) . '/TCache_Lite.php');
+require_once(dirname(__FILE__).'/TCache_Lite.php');
 
 /**
  * Cache the translation table into the file system.
@@ -32,7 +32,7 @@ 
 	/**
 	 * Caceh life time, default is 1 year.
 	 */
-	protected $lifetime = 3153600;
+	protected $lifetime=3153600;
 
 
 	/**
@@ -41,24 +41,24 @@ 
 	 */
 	public function __construct($cacheDir)
 	{
-		$cacheDir = $cacheDir . '/';
+		$cacheDir=$cacheDir.'/';
 
 		if(!is_dir($cacheDir))
 			throw new Exception(
-				'The cache directory ' . $cacheDir . ' does not exists.' .
+				'The cache directory '.$cacheDir.' does not exists.'.
 				'The cache directory must be writable by the server.');
 		if(!is_writable($cacheDir))
 			throw new Exception(
-				'The cache directory ' . $cacheDir . ' must be writable ' .
+				'The cache directory '.$cacheDir.' must be writable '.
 				'by the server.');
 
-		$options = [
+		$options=[
 			'cacheDir' => $cacheDir,
 			'lifeTime' => $this->getLifeTime(),
 			'automaticSerialization' => true
 		];
 
-		$this->cache = new TCache_Lite($options);
+		$this->cache=new TCache_Lite($options);
 	}
 
 	/**
@@ -76,7 +76,7 @@ 
 	 */
 	public function setLifeTime($time)
 	{
-		$this->lifetime = (int)$time;
+		$this->lifetime=(int) $time;
 	}
 
 	/**
@@ -86,7 +86,7 @@ 
 	 */
 	protected function getID($catalogue, $culture)
 	{
-		return $catalogue . ':' . $culture;
+		return $catalogue.':'.$culture;
 	}
 
 	/**
@@ -96,7 +96,7 @@ 
 	 */
 	protected function getGroup($catalogue, $culture)
 	{
-		return $catalogue . ':' . get_class($this);
+		return $catalogue.':'.get_class($this);
 	}
 
 	/**
@@ -110,18 +110,18 @@ 
 	 */
 	public function get($catalogue, $culture, $lastmodified=0)
 	{
-		$ID = $this->getID($catalogue, $culture);
-		$group = $this->getGroup($catalogue, $culture);
+		$ID=$this->getID($catalogue, $culture);
+		$group=$this->getGroup($catalogue, $culture);
 
 		$this->cache->_setFileName($ID, $group);
 
-		$cache = $this->cache->getCacheFile();
+		$cache=$this->cache->getCacheFile();
 
-		if(is_file($cache) == false)
+		if(is_file($cache)==false)
 			return false;
 
 
-		$lastmodified = (int)$lastmodified;
+		$lastmodified=(int) $lastmodified;
 
 		if($lastmodified <= 0 || $lastmodified > filemtime($cache))
 			return false;
@@ -140,8 +140,8 @@ 
 	 */
 	public function save($data, $catalogue, $culture)
 	{
-		$ID = $this->getID($catalogue, $culture);
-		$group = $this->getGroup($catalogue, $culture);
+		$ID=$this->getID($catalogue, $culture);
+		$group=$this->getGroup($catalogue, $culture);
 
 		//echo '## Cache save: "'.$ID.'" : "'.$group.'"';
 		//echo "<br>\n";
@@ -156,7 +156,7 @@ 
 	 */
 	public function clean($catalogue, $culture)
 	{
-		$group = $this->getGroup($catalogue, $culture);
+		$group=$this->getGroup($catalogue, $culture);
 		$this->cache->clean($group);
 	}
 

framework/I18N/core/MessageSource_gettext.php

Doc Comments +6 added lines

@@ -200,6 +200,9 @@ 
 		return false;
 	}
 
+	/**
+	 * @param string $MOFile
+	 */
 	private function getPOFile($MOFile)
 	{
 		$filebase = substr($MOFile, 0, strlen($MOFile)-strlen($this->dataExt));
@@ -422,6 +425,9 @@ 
 		return $catalogue;
 	}
 
+	/**
+	 * @param string $catalogue
+	 */
 	protected function createMessageTemplate($catalogue)
 	{
 		if($catalogue === null) {

Braces +3 added lines, -6 removed lines

@@ -260,8 +260,7 @@ 
 				if(!empty($this->cache))
 					$this->cache->clean($variant, $this->culture);
 				return true;
-			}
-			else
+			} else
 				return false;
 		}
 		return false;
@@ -304,8 +303,7 @@ 
 					if(!empty($this->cache))
 						$this->cache->clean($variant, $this->culture);
 					return true;
-				}
-				else
+				} else
 					return false;
 			}
 		}
@@ -354,8 +352,7 @@ 
 					if(!empty($this->cache))
 						$this->cache->clean($variant, $this->culture);
 					return true;
-				}
-				else
+				} else
 					return false;
 			}
 		}

Spacing +97 added lines, -97 removed lines

@@ -25,7 +25,7 @@ 
 /**
  * Get the Gettext class.
  */
-require_once(dirname(__FILE__) . '/Gettext/TGettext.php');
+require_once(dirname(__FILE__).'/Gettext/TGettext.php');
 
 /**
  * MessageSource_gettext class.
@@ -44,23 +44,23 @@ 
 	 * Message data filename extension.
 	 * @var string
 	 */
-	protected $dataExt = '.mo';
+	protected $dataExt='.mo';
 
 	/**
 	 * PO data filename extension
 	 * @var string
 	 */
-	protected $poExt = '.po';
+	protected $poExt='.po';
 
 	/**
 	 * Separator between culture name and source.
 	 * @var string
 	 */
-	protected $dataSeparator = '.';
+	protected $dataSeparator='.';
 
 	public function __construct($source)
 	{
-		$this->source = (string)$source;
+		$this->source=(string) $source;
 	}
 
 
@@ -71,17 +71,17 @@ 
 	 */
 	protected function &loadData($filename)
 	{
-		$mo = TGettext::factory('MO', $filename);
+		$mo=TGettext::factory('MO', $filename);
 		$mo->load();
-		$result = $mo->toArray();
+		$result=$mo->toArray();
 
-		$results = [];
+		$results=[];
 		$count=0;
 		foreach($result['strings'] as $source => $target)
 		{
-			$results[$source][] = $target; //target
-			$results[$source][] = $count++; //id
-			$results[$source][] = ''; //comments
+			$results[$source][]=$target; //target
+			$results[$source][]=$count++; //id
+			$results[$source][]=''; //comments
 		}
 		return $results;
 	}
@@ -104,7 +104,7 @@ 
 	 */
 	protected function getSource($variant)
 	{
-		return $this->source . '/' . $variant;
+		return $this->source.'/'.$variant;
 	}
 
 	/**
@@ -128,24 +128,24 @@ 
 	 */
 	protected function getCatalogueList($catalogue)
 	{
-		$variants = explode('_', $this->culture);
-		$source = $catalogue . $this->dataExt;
+		$variants=explode('_', $this->culture);
+		$source=$catalogue.$this->dataExt;
 
-		$catalogues = [$source];
+		$catalogues=[$source];
 
-		$variant = null;
+		$variant=null;
 
-		for($i = 0, $k = count($variants); $i < $k; ++$i)
+		for($i=0, $k=count($variants); $i < $k; ++$i)
 		{
 			if(isset($variants[$i]{0}))
 			{
-				$variant .= ($variant)?'_' . $variants[$i]:$variants[$i];
-				$catalogues[] = $catalogue . $this->dataSeparator .
-								$variant . $this->dataExt;
+				$variant.=($variant) ? '_'.$variants[$i] : $variants[$i];
+				$catalogues[]=$catalogue.$this->dataSeparator.
+								$variant.$this->dataExt;
 			}
 		}
-		$byDir = $this->getCatalogueByDir($catalogue);
-		$catalogues = array_merge($byDir, array_reverse($catalogues));
+		$byDir=$this->getCatalogueByDir($catalogue);
+		$catalogues=array_merge($byDir, array_reverse($catalogues));
 		return $catalogues;
 	}
 
@@ -159,17 +159,17 @@ 
 	 */
 	private function getCatalogueByDir($catalogue)
 	{
-		$variants = explode('_', $this->culture);
-		$catalogues = [];
+		$variants=explode('_', $this->culture);
+		$catalogues=[];
 
-		$variant = null;
+		$variant=null;
 
-		for($i = 0, $k = count($variants); $i < $k; ++$i)
+		for($i=0, $k=count($variants); $i < $k; ++$i)
 		{
 			if(isset($variants[$i]{0}))
 			{
-				$variant .= ($variant)?'_' . $variants[$i]:$variants[$i];
-				$catalogues[] = $variant . '/' . $catalogue . $this->dataExt;
+				$variant.=($variant) ? '_'.$variants[$i] : $variants[$i];
+				$catalogues[]=$variant.'/'.$catalogue.$this->dataExt;
 			}
 		}
 		return array_reverse($catalogues);
@@ -185,14 +185,14 @@ 
 	 */
 	private function getVariants($catalogue='messages')
 	{
-		if($catalogue === null) {
-			$catalogue = 'messages';
+		if($catalogue===null) {
+			$catalogue='messages';
 		}
 
 		foreach($this->getCatalogueList($catalogue) as $variant)
 		{
-			$file = $this->getSource($variant);
-			$po = $this->getPOFile($file);
+			$file=$this->getSource($variant);
+			$po=$this->getPOFile($file);
 			if(is_file($file) || is_file($po))
 				return [$variant, $file, $po];
 		}
@@ -201,8 +201,8 @@ 
 
 	private function getPOFile($MOFile)
 	{
-		$filebase = substr($MOFile, 0, strlen($MOFile)-strlen($this->dataExt));
-		return $filebase . $this->poExt;
+		$filebase=substr($MOFile, 0, strlen($MOFile) - strlen($this->dataExt));
+		return $filebase.$this->poExt;
 	}
 
 	/**
@@ -214,46 +214,46 @@ 
 	 */
 	public function save($catalogue='messages')
 	{
-		$messages = $this->untranslated;
+		$messages=$this->untranslated;
 
 		if(count($messages) <= 0) return false;
 
-		$variants = $this->getVariants($catalogue);
+		$variants=$this->getVariants($catalogue);
 
 		if($variants)
-			list($variant, $MOFile, $POFile) = $variants;
+			list($variant, $MOFile, $POFile)=$variants;
 		else
-			list($variant, $MOFile, $POFile) = $this->createMessageTemplate($catalogue);
+			list($variant, $MOFile, $POFile)=$this->createMessageTemplate($catalogue);
 
-		if(is_writable($MOFile) == false)
+		if(is_writable($MOFile)==false)
 			throw new TIOException("Unable to save to file {$MOFile}, file must be writable.");
-		if(is_writable($POFile) == false)
+		if(is_writable($POFile)==false)
 			throw new TIOException("Unable to save to file {$POFile}, file must be writable.");
 
 		//set the strings as untranslated.
-		$strings = [];
+		$strings=[];
 		foreach($messages as $message)
-			$strings[$message] = '';
+			$strings[$message]='';
 
 		//load the PO
-		$po = TGettext::factory('PO', $POFile);
+		$po=TGettext::factory('PO', $POFile);
 		$po->load();
-		$result = $po->toArray();
+		$result=$po->toArray();
 
-		$existing = count($result['strings']);
+		$existing=count($result['strings']);
 
 		//add to strings to the existing message list
-		$result['strings'] = array_merge($result['strings'], $strings);
+		$result['strings']=array_merge($result['strings'], $strings);
 
-		$new = count($result['strings']);
+		$new=count($result['strings']);
 
 		if($new > $existing)
 		{
 			//change the date 2004-12-25 12:26
-			$result['meta']['PO-Revision-Date'] = @date('Y-m-d H:i:s');
+			$result['meta']['PO-Revision-Date']=@date('Y-m-d H:i:s');
 
 			$po->fromArray($result);
-			$mo = $po->toMO();
+			$mo=$po->toMO();
 			if($po->save() && $mo->save($MOFile))
 			{
 				if(!empty($this->cache))
@@ -274,30 +274,30 @@ 
 	 */
 	public function delete($message, $catalogue='messages')
 	{
-		$variants = $this->getVariants($catalogue);
+		$variants=$this->getVariants($catalogue);
 		if($variants)
-			list($variant, $MOFile, $POFile) = $variants;
+			list($variant, $MOFile, $POFile)=$variants;
 		else
 			return false;
 
-		if(is_writable($MOFile) == false)
+		if(is_writable($MOFile)==false)
 			throw new TIOException("Unable to modify file {$MOFile}, file must be writable.");
-		if(is_writable($POFile) == false)
+		if(is_writable($POFile)==false)
 			throw new TIOException("Unable to modify file {$POFile}, file must be writable.");
 
-		$po = TGettext::factory('PO', $POFile);
+		$po=TGettext::factory('PO', $POFile);
 		$po->load();
-		$result = $po->toArray();
+		$result=$po->toArray();
 
 		foreach($result['strings'] as $string => $value)
 		{
-			if($string == $message)
+			if($string==$message)
 			{
-				$result['meta']['PO-Revision-Date'] = @date('Y-m-d H:i:s');
+				$result['meta']['PO-Revision-Date']=@date('Y-m-d H:i:s');
 				unset($result['strings'][$string]);
 
 				$po->fromArray($result);
-				$mo = $po->toMO();
+				$mo=$po->toMO();
 				if($po->save() && $mo->save($MOFile))
 				{
 					if(!empty($this->cache))
@@ -322,31 +322,31 @@ 
 	 */
 	public function update($text, $target, $comments, $catalogue='messages')
 	{
-		$variants = $this->getVariants($catalogue);
+		$variants=$this->getVariants($catalogue);
 		if($variants)
-			list($variant, $MOFile, $POFile) = $variants;
+			list($variant, $MOFile, $POFile)=$variants;
 		else
 			return false;
 
-		if(is_writable($MOFile) == false)
+		if(is_writable($MOFile)==false)
 			throw new TIOException("Unable to update file {$MOFile}, file must be writable.");
-		if(is_writable($POFile) == false)
+		if(is_writable($POFile)==false)
 			throw new TIOException("Unable to update file {$POFile}, file must be writable.");
 
 
-		$po = TGettext::factory('PO', $POFile);
+		$po=TGettext::factory('PO', $POFile);
 		$po->load();
-		$result = $po->toArray();
+		$result=$po->toArray();
 
 		foreach($result['strings'] as $string => $value)
 		{
-			if($string == $text)
+			if($string==$text)
 			{
-				$result['strings'][$string] = $target;
-				$result['meta']['PO-Revision-Date'] = @date('Y-m-d H:i:s');
+				$result['strings'][$string]=$target;
+				$result['meta']['PO-Revision-Date']=@date('Y-m-d H:i:s');
 
 				$po->fromArray($result);
-				$mo = $po->toMO();
+				$mo=$po->toMO();
 
 				if($po->save() && $mo->save($MOFile))
 				{
@@ -380,40 +380,40 @@ 
 	 */
 	protected function getCatalogues($dir=null, $variant=null)
 	{
-		$dir = $dir?$dir:$this->source;
-		$files = scandir($dir);
+		$dir=$dir ? $dir : $this->source;
+		$files=scandir($dir);
 
-		$catalogue = [];
+		$catalogue=[];
 
 		foreach($files as $file)
 		{
-			if(is_dir($dir . '/' . $file)
+			if(is_dir($dir.'/'.$file)
 				&& preg_match('/^[a-z]{2}(_[A-Z]{2,3})?$/', $file))
 			{
 
-				$catalogue = array_merge($catalogue,
-								$this->getCatalogues($dir . '/' . $file, $file));
+				$catalogue=array_merge($catalogue,
+								$this->getCatalogues($dir.'/'.$file, $file));
 			}
 
-			$pos = strpos($file, $this->dataExt);
+			$pos=strpos($file, $this->dataExt);
 
-			if($pos >0
-				&& substr($file, -1*strlen($this->dataExt)) == $this->dataExt)
+			if($pos > 0
+				&& substr($file, -1 * strlen($this->dataExt))==$this->dataExt)
 			{
-				$name = substr($file, 0, $pos);
-				$dot = strrpos($name, $this->dataSeparator);
-				$culture = $variant;
-				$cat = $name;
+				$name=substr($file, 0, $pos);
+				$dot=strrpos($name, $this->dataSeparator);
+				$culture=$variant;
+				$cat=$name;
 				if(is_int($dot))
 				{
-					$culture = substr($name, $dot+1, strlen($name));
-					$cat = substr($name, 0, $dot);
+					$culture=substr($name, $dot + 1, strlen($name));
+					$cat=substr($name, 0, $dot);
 				}
-				$details[0] = $cat;
-				$details[1] = $culture;
+				$details[0]=$cat;
+				$details[1]=$culture;
 
 
-				$catalogue[] = $details;
+				$catalogue[]=$details;
 			}
 		}
 		sort($catalogue);
@@ -423,15 +423,15 @@ 
 
 	protected function createMessageTemplate($catalogue)
 	{
-		if($catalogue === null) {
-			$catalogue = 'messages';
+		if($catalogue===null) {
+			$catalogue='messages';
 		}
-		$variants = $this->getCatalogueList($catalogue);
-		$variant = array_shift($variants);
-		$mo_file = $this->getSource($variant);
-		$po_file = $this->getPOFile($mo_file);
+		$variants=$this->getCatalogueList($catalogue);
+		$variant=array_shift($variants);
+		$mo_file=$this->getSource($variant);
+		$po_file=$this->getPOFile($mo_file);
 
-		$dir = dirname($mo_file);
+		$dir=dirname($mo_file);
 		if(!is_dir($dir))
 		{
 			@mkdir($dir);
@@ -440,12 +440,12 @@ 
 		if(!is_dir($dir))
 			throw new TException("Unable to create directory $dir");
 
-		$po = TGettext::factory('PO', $po_file);
-		$result['meta']['PO-Revision-Date'] = @date('Y-m-d H:i:s');
-		$result['strings'] = [];
+		$po=TGettext::factory('PO', $po_file);
+		$result['meta']['PO-Revision-Date']=@date('Y-m-d H:i:s');
+		$result['strings']=[];
 
 		$po->fromArray($result);
-		$mo = $po->toMO();
+		$mo=$po->toMO();
 		if($po->save() && $mo->save($mo_file))
 			return [$variant, $mo_file, $po_file];
 		else

framework/I18N/core/MessageSource_XLIFF.php

Doc Comments +3 added lines

@@ -486,6 +486,9 @@
 		return false;
 	}
 
+	/**
+	 * @param string $catalogue
+	 */
 	protected function createMessageTemplate($catalogue)
 	{
 		if($catalogue === null) {

Unused Use Statements -1 removed lines

@@ -19,7 +19,6 @@
 namespace Prado\I18N\core;
 
 use DOMDocument;
-use DOMXPath;
 use Prado\Exceptions\TException;
 use Prado\Exceptions\TIOException;
 

Spacing +100 added lines, -100 removed lines

@@ -43,13 +43,13 @@ 
 	 * Message data filename extension.
 	 * @var string
 	 */
-	protected $dataExt = '.xml';
+	protected $dataExt='.xml';
 
 	/**
 	 * Separator between culture name and source.
 	 * @var string
 	 */
-	protected $dataSeparator = '.';
+	protected $dataSeparator='.';
 
 	/**
 	 * Constructor.
@@ -58,7 +58,7 @@ 
 	 */
 	public function __construct($source)
 	{
-		$this->source = (string)$source;
+		$this->source=(string) $source;
 	}
 
 	/**
@@ -69,20 +69,20 @@ 
 	protected function &loadData($filename)
 	{
 		//load it.
-		if(false === ($XML = simplexml_load_file($filename))) {
+		if(false===($XML=simplexml_load_file($filename))) {
 			return false;
 		}
 
-		$translationUnit = $XML->xpath('//trans-unit');
+		$translationUnit=$XML->xpath('//trans-unit');
 
-		$translations = [];
+		$translations=[];
 
 		foreach($translationUnit as $unit)
 		{
-			$source = (string)$unit->source;
-			$translations[$source][] = (string)$unit->target;
-			$translations[$source][] = (string)$unit['id'];
-			$translations[$source][] = (string)$unit->note;
+			$source=(string) $unit->source;
+			$translations[$source][]=(string) $unit->target;
+			$translations[$source][]=(string) $unit['id'];
+			$translations[$source][]=(string) $unit->note;
 		}
 
 		return $translations;
@@ -107,7 +107,7 @@ 
 	 */
 	protected function getSource($variant)
 	{
-		return $this->source . '/' . $variant;
+		return $this->source.'/'.$variant;
 	}
 
 	/**
@@ -127,28 +127,28 @@ 
 	 */
 	protected function getCatalogueList($catalogue)
 	{
-		$variants = explode('_', $this->culture);
-		$source = $catalogue . $this->dataExt;
-		$catalogues = [$source];
-		$variant = null;
+		$variants=explode('_', $this->culture);
+		$source=$catalogue.$this->dataExt;
+		$catalogues=[$source];
+		$variant=null;
 
-		for($i = 0, $k = count($variants); $i < $k; ++$i)
+		for($i=0, $k=count($variants); $i < $k; ++$i)
 		{
 			if(isset($variants[$i]{0}))
 			{
-				$variant .= ($variant)?'_' . $variants[$i]:$variants[$i];
-				$catalogues[] = $catalogue . $this->dataSeparator . $variant . $this->dataExt;
+				$variant.=($variant) ? '_'.$variants[$i] : $variants[$i];
+				$catalogues[]=$catalogue.$this->dataSeparator.$variant.$this->dataExt;
 			}
 		}
 
-		$byDir = $this->getCatalogueByDir($catalogue);
-		$catalogues = array_merge($byDir, array_reverse($catalogues));
-		$files = [];
+		$byDir=$this->getCatalogueByDir($catalogue);
+		$catalogues=array_merge($byDir, array_reverse($catalogues));
+		$files=[];
 
 		foreach($catalogues as $file)
 		{
-			$files[] = $file;
-			$files[] = preg_replace('/\.xml$/', '.xlf', $file);
+			$files[]=$file;
+			$files[]=preg_replace('/\.xml$/', '.xlf', $file);
 		}
 
 		return $files;
@@ -163,16 +163,16 @@ 
 	 */
 	private function getCatalogueByDir($catalogue)
 	{
-		$variants = explode('_', $this->culture);
-		$catalogues = [];
-		$variant = null;
+		$variants=explode('_', $this->culture);
+		$catalogues=[];
+		$variant=null;
 
-		for($i = 0, $k = count($variants); $i < $k; ++$i)
+		for($i=0, $k=count($variants); $i < $k; ++$i)
 		{
 			if(isset($variants[$i]{0}))
 			{
-				$variant .= ($variant)?'_' . $variants[$i]:$variants[$i];
-				$catalogues[] = $variant . '/' . $catalogue . $this->dataExt;
+				$variant.=($variant) ? '_'.$variants[$i] : $variants[$i];
+				$catalogues[]=$variant.'/'.$catalogue.$this->dataExt;
 			}
 		}
 
@@ -198,36 +198,36 @@ 
 	 */
 	protected function getCatalogues($dir=null, $variant=null)
 	{
-		$dir = $dir?$dir:$this->source;
-		$files = scandir($dir);
-		$catalogue = [];
+		$dir=$dir ? $dir : $this->source;
+		$files=scandir($dir);
+		$catalogue=[];
 
 		foreach($files as $file)
 		{
-			if(is_dir($dir . '/' . $file) && preg_match('/^[a-z]{2}(_[A-Z]{2,3})?$/', $file)) {
-				$catalogue = array_merge(
+			if(is_dir($dir.'/'.$file) && preg_match('/^[a-z]{2}(_[A-Z]{2,3})?$/', $file)) {
+				$catalogue=array_merge(
 					$catalogue,
-					$this->getCatalogues($dir . '/' . $file, $file)
+					$this->getCatalogues($dir.'/'.$file, $file)
 				);
 			}
 
-			$pos = strpos($file, $this->dataExt);
-			if($pos >0 && substr($file, -1*strlen($this->dataExt)) == $this->dataExt)
+			$pos=strpos($file, $this->dataExt);
+			if($pos > 0 && substr($file, -1 * strlen($this->dataExt))==$this->dataExt)
 			{
-				$name = substr($file, 0, $pos);
-				$dot = strrpos($name, $this->dataSeparator);
-				$culture = $variant;
-				$cat = $name;
+				$name=substr($file, 0, $pos);
+				$dot=strrpos($name, $this->dataSeparator);
+				$culture=$variant;
+				$cat=$name;
 
 				if(is_int($dot))
 				{
-					$culture = substr($name, $dot+1, strlen($name));
-					$cat = substr($name, 0, $dot);
+					$culture=substr($name, $dot + 1, strlen($name));
+					$cat=substr($name, 0, $dot);
 				}
 
-				$details[0] = $cat;
-				$details[1] = $culture;
-				$catalogue[] = $details;
+				$details[0]=$cat;
+				$details[1]=$culture;
+				$catalogue[]=$details;
 			}
 		}
 		sort($catalogue);
@@ -244,13 +244,13 @@ 
 	 */
 	private function getVariants($catalogue='messages')
 	{
-		if($catalogue === null) {
-			$catalogue = 'messages';
+		if($catalogue===null) {
+			$catalogue='messages';
 		}
 
 		foreach($this->getCatalogueList($catalogue) as $variant)
 		{
-			$file = $this->getSource($variant);
+			$file=$this->getSource($variant);
 			if(is_file($file)) {
 				return [$variant, $file];
 			}
@@ -267,48 +267,48 @@ 
 	 */
 	public function save($catalogue='messages')
 	{
-		$messages = $this->untranslated;
+		$messages=$this->untranslated;
 		if(count($messages) <= 0) {
 			return false;
 		}
 
-		$variants = $this->getVariants($catalogue);
+		$variants=$this->getVariants($catalogue);
 
 		if($variants) {
-			list($variant, $filename) = $variants;
+			list($variant, $filename)=$variants;
 		} else {
-			list($variant, $filename) = $this->createMessageTemplate($catalogue);
+			list($variant, $filename)=$this->createMessageTemplate($catalogue);
 		}
 
-		if(is_writable($filename) == false) {
+		if(is_writable($filename)==false) {
 			throw new TIOException("Unable to save to file {$filename}, file must be writable.");
 		}
 
 		//create a new dom, import the existing xml
-		$dom = new DOMDocument();
+		$dom=new DOMDocument();
 		$dom->load($filename);
 
 		//find the body element
-		$xpath = new DomXPath($dom);
-		$body = $xpath->query('//body')->item(0);
+		$xpath=new DomXPath($dom);
+		$body=$xpath->query('//body')->item(0);
 
-		$lastNodes = $xpath->query('//trans-unit[last()]');
+		$lastNodes=$xpath->query('//trans-unit[last()]');
 		if(($last=$lastNodes->item(0))!==null) {
-			$count = (int)$last->getAttribute('id');
+			$count=(int) $last->getAttribute('id');
 		} else {
-			$count = 0;
+			$count=0;
 		}
 
 		//for each message add it to the XML file using DOM
 		foreach($messages as $message)
 		{
-			$unit = $dom->createElement('trans-unit');
+			$unit=$dom->createElement('trans-unit');
 			$unit->setAttribute('id', ++$count);
 
-			$source = $dom->createElement('source');
+			$source=$dom->createElement('source');
 			$source->appendChild($dom->createCDATASection($message));
 
-			$target = $dom->createElement('target');
+			$target=$dom->createElement('target');
 			$target->appendChild($dom->createCDATASection(''));
 
 			$unit->appendChild($dom->createTextNode("\n"));
@@ -323,7 +323,7 @@ 
 		}
 
 
-		$fileNode = $xpath->query('//file')->item(0);
+		$fileNode=$xpath->query('//file')->item(0);
 		$fileNode->setAttribute('date', @date('Y-m-d\TH:i:s\Z'));
 
 		//save it and clear the cache for this variant
@@ -345,56 +345,56 @@ 
 	 */
 	public function update($text, $target, $comments, $catalogue='messages')
 	{
-		$variants = $this->getVariants($catalogue);
+		$variants=$this->getVariants($catalogue);
 
 		if($variants) {
-			list($variant, $filename) = $variants;
+			list($variant, $filename)=$variants;
 		} else {
 			return false;
 		}
 
-		if(is_writable($filename) == false) {
+		if(is_writable($filename)==false) {
 			throw new TIOException("Unable to update file {$filename}, file must be writable.");
 		}
 
 		//create a new dom, import the existing xml
-		$dom = DOMDocument::load($filename);
+		$dom=DOMDocument::load($filename);
 
 		//find the body element
-		$xpath = new DomXPath($dom);
-		$units = $xpath->query('//trans-unit');
+		$xpath=new DomXPath($dom);
+		$units=$xpath->query('//trans-unit');
 
 		//for each of the existin units
 		foreach($units as $unit)
 		{
-			$found = false;
-			$targetted = false;
-			$commented = false;
+			$found=false;
+			$targetted=false;
+			$commented=false;
 
 			//in each unit, need to find the source, target and comment nodes
 			//it will assume that the source is before the target.
 			foreach($unit->childNodes as $node)
 			{
 				//source node
-				if($node->nodeName == 'source' && $node->firstChild->wholeText == $text) {
-					$found = true;
+				if($node->nodeName=='source' && $node->firstChild->wholeText==$text) {
+					$found=true;
 				}
 
 				//found source, get the target and notes
 				if($found)
 				{
 					//set the new translated string
-					if($node->nodeName == 'target')
+					if($node->nodeName=='target')
 					{
-						$node->nodeValue = $target;
-						$targetted = true;
+						$node->nodeValue=$target;
+						$targetted=true;
 					}
 
 					//set the notes
-					if(!empty($comments) && $node->nodeName == 'note')
+					if(!empty($comments) && $node->nodeName=='note')
 					{
-						$node->nodeValue = $comments;
-						$commented = true;
+						$node->nodeValue=$comments;
+						$commented=true;
 					}
 				}
 			}
@@ -415,10 +415,10 @@ 
 			}
 		}
 
-		$fileNode = $xpath->query('//file')->item(0);
+		$fileNode=$xpath->query('//file')->item(0);
 		$fileNode->setAttribute('date', @date('Y-m-d\TH:i:s\Z'));
 
-		if($dom->save($filename) >0)
+		if($dom->save($filename) > 0)
 		{
 			if(!empty($this->cache)) {
 				$this->cache->clean($variant, $this->culture);
@@ -438,23 +438,23 @@ 
 	 */
 	public function delete($message, $catalogue='messages')
 	{
-		$variants = $this->getVariants($catalogue);
+		$variants=$this->getVariants($catalogue);
 		if($variants) {
-			list($variant, $filename) = $variants;
+			list($variant, $filename)=$variants;
 		} else {
 			return false;
 		}
 
-		if(is_writable($filename) == false) {
+		if(is_writable($filename)==false) {
 			throw new TIOException("Unable to modify file {$filename}, file must be writable.");
 		}
 
 		//create a new dom, import the existing xml
-		$dom = DOMDocument::load($filename);
+		$dom=DOMDocument::load($filename);
 
 		//find the body element
-		$xpath = new DomXPath($dom);
-		$units = $xpath->query('//trans-unit');
+		$xpath=new DomXPath($dom);
+		$units=$xpath->query('//trans-unit');
 
 		//for each of the existin units
 		foreach($units as $unit)
@@ -464,14 +464,14 @@ 
 			foreach($unit->childNodes as $node)
 			{
 				//source node
-				if($node->nodeName == 'source' && $node->firstChild->wholeText == $message)
+				if($node->nodeName=='source' && $node->firstChild->wholeText==$message)
 				{
 					//we found it, remove and save the xml file.
 					$unit->parentNode->removeChild($unit);
-					$fileNode = $xpath->query('//file')->item(0);
+					$fileNode=$xpath->query('//file')->item(0);
 					$fileNode->setAttribute('date', @date('Y-m-d\TH:i:s\Z'));
 
-					if(false !== $dom->save($filename)) {
+					if(false!==$dom->save($filename)) {
 						if(!empty($this->cache)) {
 							$this->cache->clean($variant, $this->culture);
 						}
@@ -488,14 +488,14 @@ 
 
 	protected function createMessageTemplate($catalogue)
 	{
-		if($catalogue === null) {
-			$catalogue = 'messages';
+		if($catalogue===null) {
+			$catalogue='messages';
 		}
 		
-		$variants = $this->getCatalogueList($catalogue);
-		$variant = array_shift($variants);
-		$file = $this->getSource($variant);
-		$dir = dirname($file);
+		$variants=$this->getCatalogueList($catalogue);
+		$variant=array_shift($variants);
+		$file=$this->getSource($variant);
+		$dir=dirname($file);
 
 		if(!is_dir($dir)) {
 			@mkdir($dir);
@@ -514,8 +514,8 @@ 
 
 	protected function getTemplate($catalogue)
 	{
-		$date = @date('c');
-		$xml = <<<EOD
+		$date=@date('c');
+		$xml=<<<EOD
 <?xml version="1.0" encoding="UTF-8"?>
 <xliff version="1.0">
  <file source-language="EN" target-language="{$this->culture}" datatype="plaintext" original="$catalogue" date="$date" product-name="$catalogue">

framework/IO/TTextWriter.php

Doc Comments +1 added lines

@@ -38,6 +38,7 @@
 	/**
 	 * Writes a string.
 	 * @param string string to be written
+	 * @param string $str
 	 */
 	public function write($str)
 	{

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 	 */
 	public function writeLine($str='')
 	{
-		$this->write($str . "\n");
+		$this->write($str."\n");
 	}
 }