pradosoft / prado

framework/Web/UI/WebControls/TAccordion.php

Spacing +1 added lines, -1 removed lines

@@ -410,7 +410,7 @@
 	public function onPreRender($param)
 	{
 		parent::onPreRender($param);
-		$this->getActiveView();  // determine the active view
+		$this->getActiveView(); // determine the active view
 		$this->registerStyleSheet();
 	}
 

framework/Web/UI/WebControls/TCheckBoxList.php

Spacing +1 added lines, -1 removed lines

@@ -367,7 +367,7 @@
 		$this->_repeatedControl->setValidationGroup($this->getValidationGroup());
 		$page = $this->getPage();
 		$n = $this->getItemCount();
-		for ($i = 0;$i < $n;++$i) {
+		for ($i = 0; $i < $n; ++$i) {
 			$this->_repeatedControl->setID("c$i");
 			$page->registerRequiresPostData($this->_repeatedControl);
 		}

Doc Comments +5 added lines, -5 removed lines

@@ -60,7 +60,7 @@ 
 
 	/**
 	 * Creates a control used for repetition (used as a template).
-	 * @return TControl the control to be repeated
+	 * @return TCheckBoxItem the control to be repeated
 	 */
 	protected function createRepeatedControl()
 	{
@@ -73,7 +73,7 @@ 
 	 * the checkbox list itself (because the checkbox list does not have child controls.)
 	 * @param string $id control ID
 	 * @param mixed $real
-	 * @return TControl control being found
+	 * @return null|\Prado\Web\UI\TControl control being found
 	 */
 	public function findControl($id, $real = false)
 	{
@@ -147,7 +147,7 @@ 
 	}
 
 	/**
-	 * @return string the direction of traversing the list, defaults to 'Vertical'
+	 * @return TRepeatDirection the direction of traversing the list, defaults to 'Vertical'
 	 */
 	public function getRepeatDirection()
 	{
@@ -163,7 +163,7 @@ 
 	}
 
 	/**
-	 * @return string how the list should be displayed, using table or using line breaks. Defaults to 'Table'.
+	 * @return TRepeatLayout how the list should be displayed, using table or using line breaks. Defaults to 'Table'.
 	 */
 	public function getRepeatLayout()
 	{
@@ -436,7 +436,7 @@ 
 	/**
 	 * Returns the value to be validated.
 	 * This methid is required by \Prado\Web\UI\IValidatable interface.
-	 * @return mixed the value of the property to be validated.
+	 * @return string the value of the property to be validated.
 	 */
 	public function getValidationPropertyValue()
 	{

framework/Web/UI/TTemplate.php

Spacing +7 added lines, -7 removed lines

@@ -476,7 +476,7 @@ 
 		$c = 0;
 		$this->_directive = null;
 		try {
-			for ($i = 0;$i < $n;++$i) {
+			for ($i = 0; $i < $n; ++$i) {
 				$match = &$matches[$i];
 				$str = $match[0][0];
 				$matchStart = $match[0][1];
@@ -704,7 +704,7 @@ 
 		$pattern = '/([\w\.\-]+)\s*=\s*(\'.*?\'|".*?"|<%.*?%>)/msS';
 		$attributes = [];
 		$n = preg_match_all($pattern, $str, $matches, PREG_SET_ORDER | PREG_OFFSET_CAPTURE);
-		for ($i = 0;$i < $n;++$i) {
+		for ($i = 0; $i < $n; ++$i) {
 			$match = &$matches[$i];
 			$name = strtolower($match[1][0]);
 			if (isset($attributes[$name])) {
@@ -745,7 +745,7 @@ 
 			$isDataBind = false;
 			$textStart = 0;
 			$expr = '';
-			for ($i = 0;$i < $n;++$i) {
+			for ($i = 0; $i < $n; ++$i) {
 				$match = $matches[0][$i];
 				$token = $match[0];
 				$offset = $match[1];
@@ -811,7 +811,7 @@ 
 					}
 				} else {
 					// a simple property
-					if (! ($class->hasMethod('set' . $name) || $class->hasMethod('setjs' . $name) || $this->isClassBehaviorMethod($class, 'set' . $name))) {
+					if (!($class->hasMethod('set' . $name) || $class->hasMethod('setjs' . $name) || $this->isClassBehaviorMethod($class, 'set' . $name))) {
 						if ($class->hasMethod('get' . $name) || $class->hasMethod('getjs' . $name)) {
 							throw new TConfigurationException('template_property_readonly', $type, $name);
 						} else {
@@ -877,7 +877,7 @@ 
 		$srcFile = $this->_tplFile;
 
 		if (($n = count($this->_includedFiles)) > 0) { // need to adjust error row number and file name
-			for ($i = $n - 1;$i >= 0;--$i) {
+			for ($i = $n - 1; $i >= 0; --$i) {
 				if ($this->_includeAtLine[$i] <= $line) {
 					if ($line < $this->_includeAtLine[$i] + $this->_includeLines[$i]) {
 						$line = $line - $this->_includeAtLine[$i] + 1;
@@ -907,7 +907,7 @@ 
 	protected function preprocess($input)
 	{
 		if ($n = preg_match_all('/<%include(.*?)%>/', $input, $matches, PREG_SET_ORDER | PREG_OFFSET_CAPTURE)) {
-			for ($i = 0;$i < $n;++$i) {
+			for ($i = 0; $i < $n; ++$i) {
 				$filePath = Prado::getPathOfNamespace(trim($matches[$i][1][0]), TTemplateManager::TEMPLATE_FILE_EXT);
 				if ($filePath !== null && is_file($filePath)) {
 					$this->_includedFiles[] = $filePath;
@@ -917,7 +917,7 @@ 
 				}
 			}
 			$base = 0;
-			for ($i = 0;$i < $n;++$i) {
+			for ($i = 0; $i < $n; ++$i) {
 				$ext = file_get_contents($this->_includedFiles[$i]);
 				$length = strlen($matches[$i][0][0]);
 				$offset = $base + $matches[$i][0][1];

Doc Comments +2 added lines, -2 removed lines

@@ -869,7 +869,7 @@ 
 	 * Handles template parsing exception.
 	 * This method rethrows the exception caught during template parsing.
 	 * It adjusts the error location by giving out correct error line number and source file.
-	 * @param Exception $e template exception
+	 * @param \Exception $e template exception
 	 * @param int $line line number
 	 * @param null|string $input template string if no source file is used
 	 */
@@ -934,7 +934,7 @@ 
 
 	/**
 	 * Checks if the given method belongs to a previously attached class behavior.
-	 * @param ReflectionClass $class
+	 * @param \ReflectionClass $class
 	 * @param string $method
 	 * @return bool
 	 */

framework/Web/UI/TPage.php

Spacing +1 added lines, -1 removed lines

@@ -894,7 +894,7 @@
 					}
 				} elseif ($control instanceof IPostBackEventHandler &&
 					empty($this->_postData[self::FIELD_POSTBACK_TARGET])) {
-					$this->_postData->add(self::FIELD_POSTBACK_TARGET, $key);  // not calling setPostBackEventTarget() because the control may be removed later
+					$this->_postData->add(self::FIELD_POSTBACK_TARGET, $key); // not calling setPostBackEventTarget() because the control may be removed later
 				}
 				unset($this->_controlsRequiringPostData[$key]);
 			} elseif ($beforeLoad) {

Doc Comments +6 added lines, -3 removed lines

@@ -290,6 +290,9 @@ 
 		$this->unloadRecursive();
 	}
 
+	/**
+	 * @param string $enc
+	 */
 	protected static function decodeUTF8($data, $enc)
 	{
 		if (is_array($data)) {
@@ -970,7 +973,7 @@ 
 
 	/**
 	 * @internal This method is invoked by TForm at the beginning of its rendering
-	 * @param mixed $writer
+	 * @param THtmlWriter $writer
 	 */
 	public function beginFormRender($writer)
 	{
@@ -984,7 +987,7 @@ 
 
 	/**
 	 * @internal This method is invoked by TForm  at the end of its rendering
-	 * @param mixed $writer
+	 * @param THtmlWriter $writer
 	 */
 	public function endFormRender($writer)
 	{
@@ -1003,7 +1006,7 @@ 
 
 	/**
 	 * Sets input focus on a control after the page is rendered to users.
-	 * @param string|TControl $value control to receive focus, or the ID of the element on the page to receive focus
+	 * @param TControl $value control to receive focus, or the ID of the element on the page to receive focus
 	 */
 	public function setFocus($value)
 	{

framework/Web/UI/TClientScriptManager.php

Spacing +1 added lines, -1 removed lines

@@ -542,7 +542,7 @@
 	public function getStyleSheetUrls()
 	{
 		$stylesheets = array_values(
-			array_map(function ($e) {
+			array_map(function($e) {
 				return is_array($e) ? $e[0] : $e;
 			}, $this->_styleSheetFiles)
 		);

Doc Comments +20 added lines, -5 removed lines

@@ -221,7 +221,7 @@ 
 	}
 
 	/**
-	 * @param mixed $script
+	 * @param string $script
 	 * @return string Prado javascript library base asset url.
 	 */
 	public function getPradoScriptAssetUrl($script = 'prado')
@@ -236,7 +236,7 @@ 
 	}
 
 	/**
-	 * @param mixed $script
+	 * @param string $script
 	 * @return string Prado javascript library base asset path in local filesystem.
 	 */
 	public function getPradoScriptAssetPath($script = 'prado')
@@ -265,7 +265,7 @@ 
 
 	/**
 	 * @param string $base javascript or css package path.
-	 * @return array tuple($path,$url).
+	 * @return string[] tuple($path,$url).
 	 */
 	protected function getPackagePathUrl($base)
 	{
@@ -446,7 +446,7 @@ 
 
 	/**
 	 * Registers a Prado style library to be loaded.
-	 * @param mixed $name
+	 * @param string $name
 	 */
 	protected function registerPradoStyleInternal($name)
 	{
@@ -784,11 +784,17 @@ 
 		$writer->write(TJavaScript::renderScriptBlocks($this->_headScripts));
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	public function renderScriptFilesBegin($writer)
 	{
 		$this->renderAllPendingScriptFiles($writer);
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	public function renderScriptFilesEnd($writer)
 	{
 		$this->renderAllPendingScriptFiles($writer);
@@ -801,6 +807,9 @@ 
 		$this->_page->registerCachingAction('Page.ClientScript', 'markScriptFileAsRendered', $params);
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	protected function renderScriptFiles($writer, array $scripts)
 	{
 		foreach ($scripts as $script) {
@@ -857,11 +866,17 @@ 
 		$writer->write(TJavaScript::renderScriptBlocksCallback($this->_endScripts));
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	public function renderHiddenFieldsBegin($writer)
 	{
 		$this->renderHiddenFieldsInt($writer, true);
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	public function renderHiddenFieldsEnd($writer)
 	{
 		$this->renderHiddenFieldsInt($writer, false);
@@ -886,7 +901,7 @@ 
 	 * Unfortunately this attribute is invalid for hidden fields, so text fields are
 	 * rendered instead (#642).
 	 * @param THtmlWriter $writer writer for the rendering purpose
-	 * @param mixed $initial
+	 * @param boolean $initial
 	 */
 
 	protected function renderHiddenFieldsInt($writer, $initial)

framework/Caching/TCache.php

Doc Comments +3 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
 
 	/**
 	 * @param string $key a key identifying a value to be cached
-	 * @return sring a key generated from the provided key which ensures the uniqueness across applications
+	 * @return string a key generated from the provided key which ensures the uniqueness across applications
 	 */
 	protected function generateUniqueKey($key)
 	{
@@ -146,7 +146,7 @@ 
 	 * @param mixed $value the value to be cached
 	 * @param int $expire the number of seconds in which the cached value will expire. 0 means never expire.
 	 * @param ICacheDependency $dependency dependency of the cached item. If the dependency changes, the item is labeled invalid.
-	 * @return bool true if the value is successfully stored into cache, false otherwise
+	 * @return null|boolean true if the value is successfully stored into cache, false otherwise
 	 */
 	public function set($id, $value, $expire = 0, $dependency = null)
 	{
@@ -283,7 +283,7 @@ 
 	 * Deletes the value with the specified key from cache
 	 * This method is required by the interface \ArrayAccess.
 	 * @param string $id the key of the value to be deleted
-	 * @return bool if no error happens during deletion
+	 * @return boolean|null if no error happens during deletion
 	 */
 	public function offsetUnset($id)
 	{

framework/Collections/TAttributeCollection.php

Doc Comments +3 added lines, -3 removed lines

@@ -103,7 +103,7 @@ 
 	/**
 	 * Returns the item with the specified key.
 	 * This overrides the parent implementation by converting the key to lower case first if CaseSensitive is false.
-	 * @param mixed $key the key
+	 * @param string $key the key
 	 * @return mixed the element at the offset, null if no element is found at the offset
 	 */
 	public function itemAt($key)
@@ -115,7 +115,7 @@ 
 	/**
 	 * Adds an item into the map.
 	 * This overrides the parent implementation by converting the key to lower case first if CaseSensitive is false.
-	 * @param mixed $key
+	 * @param string $key
 	 * @param mixed $value
 	 */
 	public function add($key, $value)
@@ -126,7 +126,7 @@ 
 	/**
 	 * Removes an item from the map by its key.
 	 * This overrides the parent implementation by converting the key to lower case first if CaseSensitive is false.
-	 * @param mixed $key the key of the item to be removed
+	 * @param string $key the key of the item to be removed
 	 * @return mixed the removed value, null if no such key exists.
 	 */
 	public function remove($key)

framework/Collections/TPagedDataSource.php

Doc Comments +1 added lines, -1 removed lines

@@ -68,7 +68,7 @@
 	}
 
 	/**
-	 * @param mixed $value original data source
+	 * @param \Traversable $value original data source
 	 */
 	public function setDataSource($value)
 	{

framework/Data/ActiveRecord/Scaffold/TScaffoldEditView.php

Doc Comments +3 added lines, -3 removed lines

@@ -104,7 +104,7 @@ 
 	}
 
 	/**
-	 * @return TActiveRecord current Active Record instance
+	 * @return \Prado\Data\ActiveRecord\TActiveRecord current Active Record instance
 	 */
 	protected function getCurrentRecord()
 	{
@@ -133,7 +133,7 @@ 
 
 	/**
 	 * Instantiate the external edit renderer.
-	 * @param TActiveRecord $record record to be edited
+	 * @param \Prado\Data\ActiveRecord\TActiveRecord $record record to be edited
 	 * @param string $classPath external edit renderer class name.
 	 * @throws TConfigurationException raised when renderer is not an
 	 * instance of IScaffoldEditRenderer.
@@ -261,7 +261,7 @@ 
 
 	/**
 	 * Create the default scaffold editor control factory.
-	 * @param TActiveRecord $record record instance.
+	 * @param \Prado\Data\ActiveRecord\TActiveRecord $record record instance.
 	 * @return TScaffoldInputBase scaffold editor control factory.
 	 */
 	protected function getScaffoldInputBuilder($record)