pradosoft / prado

framework/Data/Common/Mssql/TMssqlMetaData.php

Doc Comments +1 added lines

@@ -123,6 +123,7 @@
 	/**
 	 * @param TMssqlTableInfo table information.
 	 * @param array column information.
+	 * @param TMssqlTableInfo $tableInfo
 	 */
 	protected function processColumn($tableInfo, $col)
 	{

Indentation +7 added lines, -7 removed lines

@@ -259,15 +259,15 @@
 		return false;
 	}
 
-        /**
-	 * Returns all table names in the database.
-	 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
-	 * If not empty, the returned table names will be prefixed with the schema name.
-	 * @return array all table names in the database.
-	 */
+		/**
+		 * Returns all table names in the database.
+		 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
+		 * If not empty, the returned table names will be prefixed with the schema name.
+		 * @return array all table names in the database.
+		 */
 	public function findTableNames($schema='dbo')
 	{
-                $condition="TABLE_TYPE='BASE TABLE'";
+				$condition="TABLE_TYPE='BASE TABLE'";
 		$sql=<<<EOD
 SELECT TABLE_NAME, TABLE_SCHEMA FROM [INFORMATION_SCHEMA].[TABLES]
 WHERE TABLE_SCHEMA=:schema AND $condition

Spacing +47 added lines, -47 removed lines

@@ -69,9 +69,9 @@ 
 	 */
 	protected function createTableInfo($table)
 	{
-		list($catalogName,$schemaName,$tableName) = $this->getCatalogSchemaTableName($table);
+		list($catalogName, $schemaName, $tableName)=$this->getCatalogSchemaTableName($table);
 		$this->getDbConnection()->setActive(true);
-		$sql = <<<EOD
+		$sql=<<<EOD
 				SELECT t.*,
 												c.*,
 					columnproperty(object_id(c.table_schema + '.' + c.table_name), c.column_name,'IsIdentity') as IsIdentity
@@ -81,11 +81,11 @@ 
 										AND t.table_name = :table
 EOD;
 		if($schemaName!==null)
-			$sql .= ' AND t.table_schema = :schema';
+			$sql.=' AND t.table_schema = :schema';
 		if($catalogName!==null)
-			$sql .= ' AND t.table_catalog = :catalog';
+			$sql.=' AND t.table_catalog = :catalog';
 
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $tableName);
 		if($schemaName!==null)
 			$command->bindValue(':schema', $schemaName);
@@ -96,8 +96,8 @@ 
 		foreach($command->query() as $col)
 		{
 			if($tableInfo===null)
-				$tableInfo = $this->createNewTableInfo($col);
-			$this->processColumn($tableInfo,$col);
+				$tableInfo=$this->createNewTableInfo($col);
+			$this->processColumn($tableInfo, $col);
 		}
 		if($tableInfo===null)
 			throw new TDbException('dbmetadata_invalid_table_view', $table);
@@ -111,13 +111,13 @@ 
 	protected function getCatalogSchemaTableName($table)
 	{
 		//remove possible delimiters
-		$result = explode('.', preg_replace('/\[|\]|"/', '', $table));
+		$result=explode('.', preg_replace('/\[|\]|"/', '', $table));
 		if(count($result)===1)
-			return array(null,null,$result[0]);
+			return array(null, null, $result[0]);
 		if(count($result)===2)
-			return array(null,$result[0],$result[1]);
-		if(count($result)>2)
-			return array($result[0],$result[1],$result[2]);
+			return array(null, $result[0], $result[1]);
+		if(count($result) > 2)
+			return array($result[0], $result[1], $result[2]);
 	}
 
 	/**
@@ -126,31 +126,31 @@ 
 	 */
 	protected function processColumn($tableInfo, $col)
 	{
-		$columnId = $col['COLUMN_NAME'];
+		$columnId=$col['COLUMN_NAME'];
 
-		$info['ColumnName'] = "[$columnId]"; //quote the column names!
-		$info['ColumnId'] = $columnId;
-		$info['ColumnIndex'] = intval($col['ORDINAL_POSITION'])-1; //zero-based index
+		$info['ColumnName']="[$columnId]"; //quote the column names!
+		$info['ColumnId']=$columnId;
+		$info['ColumnIndex']=intval($col['ORDINAL_POSITION']) - 1; //zero-based index
 		if($col['IS_NULLABLE']!=='NO')
-			$info['AllowNull'] = true;
+			$info['AllowNull']=true;
 		if($col['COLUMN_DEFAULT']!==null)
-			$info['DefaultValue'] = $col['COLUMN_DEFAULT'];
+			$info['DefaultValue']=$col['COLUMN_DEFAULT'];
 
 		if(in_array($columnId, $tableInfo->getPrimaryKeys()))
-			$info['IsPrimaryKey'] = true;
+			$info['IsPrimaryKey']=true;
 		if($this->isForeignKeyColumn($columnId, $tableInfo))
-			$info['IsForeignKey'] = true;
+			$info['IsForeignKey']=true;
 
 		if($col['IsIdentity']==='1')
-			$info['AutoIncrement'] = true;
-		$info['DbType'] = $col['DATA_TYPE'];
+			$info['AutoIncrement']=true;
+		$info['DbType']=$col['DATA_TYPE'];
 		if($col['CHARACTER_MAXIMUM_LENGTH']!==null)
-			$info['ColumnSize'] = intval($col['CHARACTER_MAXIMUM_LENGTH']);
-		if($col['NUMERIC_PRECISION'] !== null)
-			$info['NumericPrecision'] = intval($col['NUMERIC_PRECISION']);
+			$info['ColumnSize']=intval($col['CHARACTER_MAXIMUM_LENGTH']);
+		if($col['NUMERIC_PRECISION']!==null)
+			$info['NumericPrecision']=intval($col['NUMERIC_PRECISION']);
 		if($col['NUMERIC_SCALE']!==null)
-			$info['NumericScale'] = intval($col['NUMERIC_SCALE']);
-		$tableInfo->Columns[$columnId] = new TMssqlTableColumn($info);
+			$info['NumericScale']=intval($col['NUMERIC_SCALE']);
+		$tableInfo->Columns[$columnId]=new TMssqlTableColumn($info);
 	}
 
 	/**
@@ -160,14 +160,14 @@ 
 	 */
 	protected function createNewTableInfo($col)
 	{
-		$info['CatalogName'] = $col['TABLE_CATALOG'];
-		$info['SchemaName'] = $col['TABLE_SCHEMA'];
-		$info['TableName'] = $col['TABLE_NAME'];
+		$info['CatalogName']=$col['TABLE_CATALOG'];
+		$info['SchemaName']=$col['TABLE_SCHEMA'];
+		$info['TableName']=$col['TABLE_NAME'];
 		if($col['TABLE_TYPE']==='VIEW')
-			$info['IsView'] = true;
-		list($primary, $foreign) = $this->getConstraintKeys($col);
-		$class = $this->getTableInfoClass();
-		return new $class($info,$primary,$foreign);
+			$info['IsView']=true;
+		list($primary, $foreign)=$this->getConstraintKeys($col);
+		$class=$this->getTableInfoClass();
+		return new $class($info, $primary, $foreign);
 	}
 
 	/**
@@ -178,7 +178,7 @@ 
 	 */
 	protected function getConstraintKeys($col)
 	{
-		$sql = <<<EOD
+		$sql=<<<EOD
 		SELECT k.column_name field_name
 				FROM INFORMATION_SCHEMA.KEY_COLUMN_USAGE k
 				LEFT JOIN INFORMATION_SCHEMA.TABLE_CONSTRAINTS c
@@ -189,13 +189,13 @@ 
 			c.constraint_type ='PRIMARY KEY'
 				AND k.table_name = :table
 EOD;
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $col['TABLE_NAME']);
-		$primary = array();
+		$primary=array();
 		foreach($command->query()->readAll() as $field)
-			$primary[] = $field['field_name'];
-		$foreign = $this->getForeignConstraints($col);
-		return array($primary,$foreign);
+			$primary[]=$field['field_name'];
+		$foreign=$this->getForeignConstraints($col);
+		return array($primary, $foreign);
 	}
 
 	/**
@@ -207,7 +207,7 @@ 
 	protected function getForeignConstraints($col)
 	{
 		//From http://msdn2.microsoft.com/en-us/library/aa175805(SQL.80).aspx
-		$sql = <<<EOD
+		$sql=<<<EOD
 		SELECT
 				KCU1.CONSTRAINT_NAME AS 'FK_CONSTRAINT_NAME'
 			, KCU1.TABLE_NAME AS 'FK_TABLE_NAME'
@@ -232,14 +232,14 @@ 
 			AND KCU2.ORDINAL_POSITION = KCU1.ORDINAL_POSITION
 		WHERE KCU1.TABLE_NAME = :table
 EOD;
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $col['TABLE_NAME']);
 		$fkeys=array();
-		$catalogSchema = "[{$col['TABLE_CATALOG']}].[{$col['TABLE_SCHEMA']}]";
+		$catalogSchema="[{$col['TABLE_CATALOG']}].[{$col['TABLE_SCHEMA']}]";
 		foreach($command->query() as $info)
 		{
-			$fkeys[$info['FK_CONSTRAINT_NAME']]['keys'][$info['FK_COLUMN_NAME']] = $info['UQ_COLUMN_NAME'];
-			$fkeys[$info['FK_CONSTRAINT_NAME']]['table'] = $info['UQ_TABLE_NAME'];
+			$fkeys[$info['FK_CONSTRAINT_NAME']]['keys'][$info['FK_COLUMN_NAME']]=$info['UQ_COLUMN_NAME'];
+			$fkeys[$info['FK_CONSTRAINT_NAME']]['table']=$info['UQ_TABLE_NAME'];
 		}
 		return count($fkeys) > 0 ? array_values($fkeys) : $fkeys;
 	}
@@ -276,9 +276,9 @@ 
 		$command->bindParam(":schema", $schema);
 		$rows=$command->queryAll();
 		$names=array();
-		foreach ($rows as $row)
+		foreach($rows as $row)
 		{
-			if ($schema == self::DEFAULT_SCHEMA)
+			if($schema==self::DEFAULT_SCHEMA)
 				$names[]=$row['TABLE_NAME'];
 			else
 				$names[]=$schema.'.'.$row['TABLE_SCHEMA'].'.'.$row['TABLE_NAME'];

framework/Data/Common/Mssql/TMssqlTableColumn.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 
 	/**
 	 * Overrides parent implementation, returns PHP type from the db type.
-	 * @return boolean derived PHP primitive type from the column db type.
+	 * @return string derived PHP primitive type from the column db type.
 	 */
 	public function getPHPType()
 	{

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
  */
 class TMssqlTableColumn extends TDbTableColumn
 {
-	private static $types = array();
+	private static $types=array();
 
 	/**
 	 * Overrides parent implementation, returns PHP type from the db type.
@@ -40,7 +40,7 @@ 
 	 */
 	public function getAutoIncrement()
 	{
-		return $this->getInfo('AutoIncrement',false);
+		return $this->getInfo('AutoIncrement', false);
 	}
 
 	/**

framework/Data/Common/Mysql/TMysqlMetaData.php

Doc Comments +1 added lines

@@ -114,6 +114,7 @@
 	/**
 	 * @param TMysqlTableInfo table information.
 	 * @param array column information.
+	 * @param TMysqlTableInfo $tableInfo
 	 */
 	protected function processColumn($tableInfo, $col)
 	{

Indentation +6 added lines, -6 removed lines

@@ -417,12 +417,12 @@
 		return false;
 	}
 
-        /**
-	 * Returns all table names in the database.
-	 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
-	 * If not empty, the returned table names will be prefixed with the schema name.
-	 * @return array all table names in the database.
-	 */
+		/**
+		 * Returns all table names in the database.
+		 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
+		 * If not empty, the returned table names will be prefixed with the schema name.
+		 * @return array all table names in the database.
+		 */
 	public function findTableNames($schema='public')
 	{
 		if($schema==='')

Spacing +74 added lines, -74 removed lines

@@ -74,24 +74,24 @@ 
 	 */
 	protected function createTableInfo($table)
 	{
-		list($schemaName,$tableName) = $this->getSchemaTableName($table);
-		$find = $schemaName===null ? "`{$tableName}`" : "`{$schemaName}`.`{$tableName}`";
-		$colCase = $this->getDbConnection()->getColumnCase();
-		if($colCase != TDbColumnCaseMode::Preserved)
+		list($schemaName, $tableName)=$this->getSchemaTableName($table);
+		$find=$schemaName===null ? "`{$tableName}`" : "`{$schemaName}`.`{$tableName}`";
+		$colCase=$this->getDbConnection()->getColumnCase();
+		if($colCase!=TDbColumnCaseMode::Preserved)
 			$this->getDbConnection()->setColumnCase('Preserved');
 		$this->getDbConnection()->setActive(true);
-		$sql = "SHOW FULL FIELDS FROM {$find}";
-		$command = $this->getDbConnection()->createCommand($sql);
-		$tableInfo = $this->createNewTableInfo($table);
+		$sql="SHOW FULL FIELDS FROM {$find}";
+		$command=$this->getDbConnection()->createCommand($sql);
+		$tableInfo=$this->createNewTableInfo($table);
 		$index=0;
 		foreach($command->query() as $col)
 		{
-			$col['index'] = $index++;
-			$this->processColumn($tableInfo,$col);
+			$col['index']=$index++;
+			$this->processColumn($tableInfo, $col);
 		}
 		if($index===0)
 			throw new TDbException('dbmetadata_invalid_table_view', $table);
-		if($colCase != TDbColumnCaseMode::Preserved)
+		if($colCase!=TDbColumnCaseMode::Preserved)
 			$this->getDbConnection()->setColumnCase($colCase);
 		return $tableInfo;
 	}
@@ -103,7 +103,7 @@ 
 	{
 		if(!$this->_serverVersion)
 		{
-			$version = $this->getDbConnection()->getAttribute(PDO::ATTR_SERVER_VERSION);
+			$version=$this->getDbConnection()->getAttribute(PDO::ATTR_SERVER_VERSION);
 			$digits=array();
 			preg_match('/(\d+)\.(\d+)\.(\d+)/', $version, $digits);
 			$this->_serverVersion=floatval($digits[1].'.'.$digits[2].$digits[3]);
@@ -117,50 +117,50 @@ 
 	 */
 	protected function processColumn($tableInfo, $col)
 	{
-		$columnId = $col['Field'];
+		$columnId=$col['Field'];
 
-		$info['ColumnName'] = "`$columnId`"; //quote the column names!
-		$info['ColumnId'] = $columnId;
-		$info['ColumnIndex'] = $col['index'];
+		$info['ColumnName']="`$columnId`"; //quote the column names!
+		$info['ColumnId']=$columnId;
+		$info['ColumnIndex']=$col['index'];
 		if($col['Null']==='YES')
-			$info['AllowNull'] = true;
+			$info['AllowNull']=true;
 		if(is_int(strpos(strtolower($col['Extra']), 'auto_increment')))
 			$info['AutoIncrement']=true;
 		if($col['Default']!=="")
-			$info['DefaultValue'] = $col['Default'];
+			$info['DefaultValue']=$col['Default'];
 
 		if($col['Key']==='PRI' || in_array($columnId, $tableInfo->getPrimaryKeys()))
-			$info['IsPrimaryKey'] = true;
+			$info['IsPrimaryKey']=true;
 		if($this->isForeignKeyColumn($columnId, $tableInfo))
-			$info['IsForeignKey'] = true;
+			$info['IsForeignKey']=true;
 
-		$info['DbType'] = $col['Type'];
+		$info['DbType']=$col['Type'];
 		$match=array();
 		//find SET/ENUM values, column size, precision, and scale
 		if(preg_match('/\((.*)\)/', $col['Type'], $match))
 		{
-			$info['DbType']= preg_replace('/\(.*\)/', '', $col['Type']);
+			$info['DbType']=preg_replace('/\(.*\)/', '', $col['Type']);
 
 			//find SET/ENUM values
 			if($this->isEnumSetType($info['DbType']))
-				$info['DbTypeValues'] = preg_split("/[',]/S", $match[1], -1, PREG_SPLIT_NO_EMPTY);
+				$info['DbTypeValues']=preg_split("/[',]/S", $match[1], -1, PREG_SPLIT_NO_EMPTY);
 
 			//find column size, precision and scale
-			$pscale = array();
+			$pscale=array();
 			if(preg_match('/(\d+)(?:,(\d+))?+/', $match[1], $pscale))
 			{
 				if($this->isPrecisionType($info['DbType']))
 				{
-					$info['NumericPrecision'] = intval($pscale[1]);
+					$info['NumericPrecision']=intval($pscale[1]);
 					if(count($pscale) > 2)
-						$info['NumericScale'] = intval($pscale[2]);
+						$info['NumericScale']=intval($pscale[2]);
 				}
 				else
-					$info['ColumnSize'] = intval($pscale[1]);
+					$info['ColumnSize']=intval($pscale[1]);
 			}
 		}
 
-		$tableInfo->Columns[$columnId] = new TMysqlTableColumn($info);
+		$tableInfo->Columns[$columnId]=new TMysqlTableColumn($info);
 	}
 
 	/**
@@ -168,7 +168,7 @@ 
 	 */
 	protected function isPrecisionType($type)
 	{
-		$type = strtolower(trim($type));
+		$type=strtolower(trim($type));
 		return $type==='decimal' || $type==='dec'
 				|| $type==='float' || $type==='double'
 				|| $type==='double precision' || $type==='real';
@@ -179,7 +179,7 @@ 
 	 */
 	protected function isEnumSetType($type)
 	{
-		$type = strtolower(trim($type));
+		$type=strtolower(trim($type));
 		return $type==='set' || $type==='enum';
 	}
 
@@ -191,12 +191,12 @@ 
 	protected function getSchemaTableName($table)
 	{
 		//remove the back ticks and separate out the "database.table"
-		$result = explode('.', str_replace('`', '', $table));
+		$result=explode('.', str_replace('`', '', $table));
 		foreach($result as $name)
 		{
 			if(!$this->isValidIdentifier($name))
 			{
-				$ref = 'http://dev.mysql.com/doc/refman/5.0/en/identifiers.html';
+				$ref='http://dev.mysql.com/doc/refman/5.0/en/identifiers.html';
 				throw new TDbException('dbcommon_invalid_identifier_name', $table, $ref);
 			}
 		}
@@ -220,14 +220,14 @@ 
 	 */
 	protected function createNewTableInfo($table)
 	{
-		list($schemaName,$tableName) = $this->getSchemaTableName($table);
-		$info['SchemaName'] = $schemaName;
-		$info['TableName'] = $tableName;
-		if($this->getIsView($schemaName,$tableName))
-			$info['IsView'] = true;
-		list($primary, $foreign) = $this->getConstraintKeys($schemaName, $tableName);
-		$class = $this->getTableInfoClass();
-		return new $class($info,$primary,$foreign);
+		list($schemaName, $tableName)=$this->getSchemaTableName($table);
+		$info['SchemaName']=$schemaName;
+		$info['TableName']=$tableName;
+		if($this->getIsView($schemaName, $tableName))
+			$info['IsView']=true;
+		list($primary, $foreign)=$this->getConstraintKeys($schemaName, $tableName);
+		$class=$this->getTableInfoClass();
+		return new $class($info, $primary, $foreign);
 	}
 
 	/**
@@ -240,25 +240,25 @@ 
 	 * @return boolean true if is view, false otherwise.
 	 * @throws TDbException if table or view does not exist.
 	 */
-	protected function getIsView($schemaName,$tableName)
+	protected function getIsView($schemaName, $tableName)
 	{
-		if($this->getServerVersion()<5.01)
+		if($this->getServerVersion() < 5.01)
 			return false;
 		if($schemaName!==null)
-			$sql = "SHOW FULL TABLES FROM `{$schemaName}` LIKE :table";
+			$sql="SHOW FULL TABLES FROM `{$schemaName}` LIKE :table";
 		else
-			$sql = "SHOW FULL TABLES LIKE :table";
+			$sql="SHOW FULL TABLES LIKE :table";
 
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $tableName);
 		try
 		{
-			return count($result = $command->queryRow()) > 0 && $result['Table_type']==='VIEW';
+			return count($result=$command->queryRow()) > 0 && $result['Table_type']==='VIEW';
 		}
 		catch(TDbException $e)
 		{
-			$table = $schemaName===null?$tableName:$schemaName.'.'.$tableName;
-			throw new TDbException('dbcommon_invalid_table_name',$table,$e->getMessage());
+			$table=$schemaName===null ? $tableName : $schemaName.'.'.$tableName;
+			throw new TDbException('dbcommon_invalid_table_name', $table, $e->getMessage());
 		}
 	}
 
@@ -270,22 +270,22 @@ 
 	 */
 	protected function getConstraintKeys($schemaName, $tableName)
 	{
-		$table = $schemaName===null ? "`{$tableName}`" : "`{$schemaName}`.`{$tableName}`";
-		$sql = "SHOW INDEX FROM {$table}";
-		$command = $this->getDbConnection()->createCommand($sql);
-		$primary = array();
+		$table=$schemaName===null ? "`{$tableName}`" : "`{$schemaName}`.`{$tableName}`";
+		$sql="SHOW INDEX FROM {$table}";
+		$command=$this->getDbConnection()->createCommand($sql);
+		$primary=array();
 		foreach($command->query() as $row)
 		{
 			if($row['Key_name']==='PRIMARY')
-				$primary[] = $row['Column_name'];
+				$primary[]=$row['Column_name'];
 		}
 				// MySQL version was increased to >=5.1.21 instead of 5.x
 				// due to a MySQL bug (http://bugs.mysql.com/bug.php?id=19588)
 		if($this->getServerVersion() >= 5.121)
-			$foreign = $this->getForeignConstraints($schemaName,$tableName);
+			$foreign=$this->getForeignConstraints($schemaName, $tableName);
 		else
-			$foreign = $this->findForeignConstraints($schemaName,$tableName);
-		return array($primary,$foreign);
+			$foreign=$this->findForeignConstraints($schemaName, $tableName);
+		return array($primary, $foreign);
 	}
 
 	/**
@@ -296,8 +296,8 @@ 
 	 */
 	protected function getForeignConstraints($schemaName, $tableName)
 	{
-		$andSchema = $schemaName !== null ? 'AND TABLE_SCHEMA LIKE :schema' : 'AND TABLE_SCHEMA LIKE DATABASE()';
-		$sql = <<<EOD
+		$andSchema=$schemaName!==null ? 'AND TABLE_SCHEMA LIKE :schema' : 'AND TABLE_SCHEMA LIKE DATABASE()';
+		$sql=<<<EOD
 			SELECT
 				CONSTRAINT_NAME as con,
 				COLUMN_NAME as col,
@@ -311,15 +311,15 @@ 
 				AND TABLE_NAME LIKE :table
 				$andSchema
 EOD;
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $tableName);
 		if($schemaName!==null)
 			$command->bindValue(':schema', $schemaName);
 		$fkeys=array();
 		foreach($command->query() as $col)
 		{
-			$fkeys[$col['con']]['keys'][$col['col']] = $col['fkcol'];
-			$fkeys[$col['con']]['table'] = $col['fktable'];
+			$fkeys[$col['con']]['keys'][$col['col']]=$col['fkcol'];
+			$fkeys[$col['con']]['table']=$col['fktable'];
 		}
 		return count($fkeys) > 0 ? array_values($fkeys) : $fkeys;
 	}
@@ -332,17 +332,17 @@ 
 	 */
 	protected function getShowCreateTable($schemaName, $tableName)
 	{
-		if(version_compare(PHP_VERSION,'5.1.3','<'))
+		if(version_compare(PHP_VERSION, '5.1.3', '<'))
 			throw new TDbException('dbmetadata_requires_php_version', 'Mysql 4.1.x', '5.1.3');
 
 		//See http://netevil.org/node.php?nid=795&SC=1
 		$this->getDbConnection()->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
 		if($schemaName!==null)
-			$sql = "SHOW CREATE TABLE `{$schemaName}`.`{$tableName}`";
+			$sql="SHOW CREATE TABLE `{$schemaName}`.`{$tableName}`";
 		else
-			$sql = "SHOW CREATE TABLE `{$tableName}`";
-		$command = $this->getDbConnection()->createCommand($sql);
-		$result = $command->queryRow();
+			$sql="SHOW CREATE TABLE `{$tableName}`";
+		$command=$this->getDbConnection()->createCommand($sql);
+		$result=$command->queryRow();
 		return isset($result['Create Table']) ? $result['Create Table'] : (isset($result['Create View']) ? $result['Create View'] : '');
 	}
 
@@ -354,19 +354,19 @@ 
 	 */
 	protected function findForeignConstraints($schemaName, $tableName)
 	{
-		$sql = $this->getShowCreateTable($schemaName, $tableName);
-		$matches =array();
-		$regexp = '/FOREIGN KEY\s+\(([^\)]+)\)\s+REFERENCES\s+`?([^`]+)`?\s\(([^\)]+)\)/mi';
-		preg_match_all($regexp,$sql,$matches,PREG_SET_ORDER);
-		$foreign = array();
+		$sql=$this->getShowCreateTable($schemaName, $tableName);
+		$matches=array();
+		$regexp='/FOREIGN KEY\s+\(([^\)]+)\)\s+REFERENCES\s+`?([^`]+)`?\s\(([^\)]+)\)/mi';
+		preg_match_all($regexp, $sql, $matches, PREG_SET_ORDER);
+		$foreign=array();
 		foreach($matches as $match)
 		{
-			$fields = array_map('trim',explode(',',str_replace('`','',$match[1])));
-			$fk_fields = array_map('trim',explode(',',str_replace('`','',$match[3])));
+			$fields=array_map('trim', explode(',', str_replace('`', '', $match[1])));
+			$fk_fields=array_map('trim', explode(',', str_replace('`', '', $match[3])));
 			$keys=array();
 			foreach($fields as $k=>$v)
-				$keys[$v] = $fk_fields[$k];
-			$foreign[] = array('keys' => $keys, 'table' => trim($match[2]));
+				$keys[$v]=$fk_fields[$k];
+			$foreign[]=array('keys' => $keys, 'table' => trim($match[2]));
 		}
 		return $foreign;
 	}

Braces +2 added lines, -4 removed lines

@@ -154,8 +154,7 @@ 
 					$info['NumericPrecision'] = intval($pscale[1]);
 					if(count($pscale) > 2)
 						$info['NumericScale'] = intval($pscale[2]);
-				}
-				else
+				} else
 					$info['ColumnSize'] = intval($pscale[1]);
 			}
 		}
@@ -254,8 +253,7 @@ 
 		try
 		{
 			return count($result = $command->queryRow()) > 0 && $result['Table_type']==='VIEW';
-		}
-		catch(TDbException $e)
+		} catch(TDbException $e)
 		{
 			$table = $schemaName===null?$tableName:$schemaName.'.'.$tableName;
 			throw new TDbException('dbcommon_invalid_table_name',$table,$e->getMessage());

framework/Data/Common/Oracle/TOracleMetaData.php

Doc Comments +3 added lines, -1 removed lines

@@ -145,7 +145,7 @@ 
 	/**
 	 * @param string table schema name
 	 * @param string table name.
-	 * @return boolean true if the table is a view.
+	 * @return integer true if the table is a view.
 	 */
 	protected function getIsView($schemaName,$tableName)
 	{
@@ -167,6 +167,7 @@ 
 	/**
 	 * @param TOracleTableInfo table information.
 	 * @param array column information.
+	 * @param TOracleTableInfo $tableInfo
 	 */
 	protected function processColumn($tableInfo, $col)
 	{
@@ -322,6 +323,7 @@ 
 	/**
 	 * @param string column name.
 	 * @param TOracleTableInfo table information.
+	 * @param string $columnId
 	 * @return boolean true if column is a foreign key.
 	 */
 	protected function isForeignKeyColumn($columnId, $tableInfo)

Indentation +6 added lines, -6 removed lines

@@ -417,12 +417,12 @@
 		return false;
 	}
 
-        /**
-	 * Returns all table names in the database.
-	 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
-	 * If not empty, the returned table names will be prefixed with the schema name.
-	 * @return array all table names in the database.
-	 */
+		/**
+		 * Returns all table names in the database.
+		 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
+		 * If not empty, the returned table names will be prefixed with the schema name.
+		 * @return array all table names in the database.
+		 */
 	public function findTableNames($schema='public')
 	{
 		if($schema==='')

Spacing +60 added lines, -60 removed lines

@@ -25,7 +25,7 @@ 
  */
 class TOracleMetaData extends TDbMetaData
 {
-	private $_defaultSchema = 'system';
+	private $_defaultSchema='system';
 
 
 	/**
@@ -58,10 +58,10 @@ 
 	 */
 	protected function getSchemaTableName($table)
 	{
-		if(count($parts= explode('.', str_replace('"','',$table))) > 1)
+		if(count($parts=explode('.', str_replace('"', '', $table))) > 1)
 			return array($parts[0], $parts[1]);
 		else
-			return array($this->getDefaultSchema(),$parts[0]);
+			return array($this->getDefaultSchema(), $parts[0]);
 	}
 
 	/**
@@ -71,12 +71,12 @@ 
 	 */
 	protected function createTableInfo($table)
 	{
-		list($schemaName,$tableName) = $this->getSchemaTableName($table);
+		list($schemaName, $tableName)=$this->getSchemaTableName($table);
 
 		// This query is made much more complex by the addition of the 'attisserial' field.
 		// The subquery to get that field checks to see if there is an internally dependent
 		// sequence on the field.
-		$sql =
+		$sql=
 <<<EOD
 		SELECT
 			a.COLUMN_ID,
@@ -96,14 +96,14 @@ 
 EOD;
 		$this->getDbConnection()->setActive(true);
 		$this->getDbConnection()->setAttribute(PDO::ATTR_CASE, PDO::CASE_LOWER);
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		//$command->bindValue(':table', $tableName);
 		//$command->bindValue(':schema', $schemaName);
-		$tableInfo = $this->createNewTableInfo($schemaName, $tableName);
+		$tableInfo=$this->createNewTableInfo($schemaName, $tableName);
 		$index=0;
 		foreach($command->query() as $col)
 		{
-			$col['index'] = $index++;
+			$col['index']=$index++;
 			$this->processColumn($tableInfo, $col);
 		}
 		if($index===0)
@@ -116,15 +116,15 @@ 
 	 * @param string table name.
 	 * @return TOracleTableInfo
 	 */
-	protected function createNewTableInfo($schemaName,$tableName)
+	protected function createNewTableInfo($schemaName, $tableName)
 	{
-		$info['SchemaName'] = $this->assertIdentifier($schemaName);
-		$info['TableName']	= $this->assertIdentifier($tableName);
-		$info['IsView'] 	= false;
-		if($this->getIsView($schemaName,$tableName)) $info['IsView'] = true;
-		list($primary, $foreign) = $this->getConstraintKeys($schemaName, $tableName);
-		$class = $this->getTableInfoClass();
-		return new $class($info,$primary,$foreign);
+		$info['SchemaName']=$this->assertIdentifier($schemaName);
+		$info['TableName']=$this->assertIdentifier($tableName);
+		$info['IsView']=false;
+		if($this->getIsView($schemaName, $tableName)) $info['IsView']=true;
+		list($primary, $foreign)=$this->getConstraintKeys($schemaName, $tableName);
+		$class=$this->getTableInfoClass();
+		return new $class($info, $primary, $foreign);
 	}
 
 	/**
@@ -136,7 +136,7 @@ 
 	{
 		if(strpos($name, '"')!==false)
 		{
-			$ref = 'http://www.oracle.com';
+			$ref='http://www.oracle.com';
 			throw new TDbException('dbcommon_invalid_identifier_name', $name, $ref);
 		}
 		return $name;
@@ -147,10 +147,10 @@ 
 	 * @param string table name.
 	 * @return boolean true if the table is a view.
 	 */
-	protected function getIsView($schemaName,$tableName)
+	protected function getIsView($schemaName, $tableName)
 	{
 		$this->getDbConnection()->setAttribute(PDO::ATTR_CASE, PDO::CASE_LOWER);
-		$sql =
+		$sql=
 <<<EOD
 		select	OBJECT_TYPE
 		from 	ALL_OBJECTS
@@ -158,10 +158,10 @@ 
 		and 	OWNER = '{$schemaName}'
 EOD;
 		$this->getDbConnection()->setActive(true);
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		//$command->bindValue(':schema',$schemaName);
 		//$command->bindValue(':table', $tableName);
-		return intval($command->queryScalar() === 'VIEW');
+		return intval($command->queryScalar()==='VIEW');
 	}
 
 	/**
@@ -170,17 +170,17 @@ 
 	 */
 	protected function processColumn($tableInfo, $col)
 	{
-		$columnId = strtolower($col['attname']); //use column name as column Id
+		$columnId=strtolower($col['attname']); //use column name as column Id
 
 		//$info['ColumnName'] 	= '"'.$columnId.'"'; //quote the column names!
-		$info['ColumnName'] 	= $columnId; //NOT quote the column names!
-		$info['ColumnId'] 		= $columnId;
-		$info['ColumnIndex'] 	= $col['index'];
-		if(! (bool)$col['attnotnull'] ) $info['AllowNull'] = true;
-		if(in_array($columnId, $tableInfo->getPrimaryKeys())) $info['IsPrimaryKey'] = true;
-		if($this->isForeignKeyColumn($columnId, $tableInfo)) $info['IsForeignKey'] = true;
-		if( (int)$col['atttypmod'] > 0 ) $info['ColumnSize'] =  $col['atttypmod']; // - 4;
-		if( (bool)$col['atthasdef'] ) $info['DefaultValue'] = $col['adsrc'];
+		$info['ColumnName']=$columnId; //NOT quote the column names!
+		$info['ColumnId']=$columnId;
+		$info['ColumnIndex']=$col['index'];
+		if(!(bool) $col['attnotnull']) $info['AllowNull']=true;
+		if(in_array($columnId, $tableInfo->getPrimaryKeys())) $info['IsPrimaryKey']=true;
+		if($this->isForeignKeyColumn($columnId, $tableInfo)) $info['IsForeignKey']=true;
+		if((int) $col['atttypmod'] > 0) $info['ColumnSize']=$col['atttypmod']; // - 4;
+		if((bool) $col['atthasdef']) $info['DefaultValue']=$col['adsrc'];
 		//
 		// For a while Oracle Tables has no  associated AutoIncrement Triggers
 		//
@@ -194,31 +194,31 @@ 
 			}
 		}
 		*/
-		$matches = array();
+		$matches=array();
 		if(preg_match('/\((\d+)(?:,(\d+))?+\)/', $col['type'], $matches))
 		{
-			$info['DbType'] = preg_replace('/\(\d+(?:,\d+)?\)/','',$col['type']);
+			$info['DbType']=preg_replace('/\(\d+(?:,\d+)?\)/', '', $col['type']);
 			if($this->isPrecisionType($info['DbType']))
 			{
-				$info['NumericPrecision'] = intval($matches[1]);
+				$info['NumericPrecision']=intval($matches[1]);
 				if(count($matches) > 2)
-					$info['NumericScale'] = intval($matches[2]);
+					$info['NumericScale']=intval($matches[2]);
 			}
 			else
-				$info['ColumnSize'] = intval($matches[1]);
+				$info['ColumnSize']=intval($matches[1]);
 		}
 		else
-			$info['DbType'] = $col['type'];
-		$tableInfo->Columns[$columnId] = new TOracleTableColumn($info);
+			$info['DbType']=$col['type'];
+		$tableInfo->Columns[$columnId]=new TOracleTableColumn($info);
 	}
 
 	/**
 	 * @return string serial name if found, null otherwise.
 	 */
-	protected function getSequenceName($tableInfo,$src)
+	protected function getSequenceName($tableInfo, $src)
 	{
-		$matches = array();
-		if(preg_match('/nextval\([^\']*\'([^\']+)\'[^\)]*\)/i',$src,$matches))
+		$matches=array();
+		if(preg_match('/nextval\([^\']*\'([^\']+)\'[^\)]*\)/i', $src, $matches))
 		{
 			if(is_int(strpos($matches[1], '.')))
 				return $matches[1];
@@ -232,7 +232,7 @@ 
 	 */
 	protected function isPrecisionType($type)
 	{
-		$type = strtolower(trim($type));
+		$type=strtolower(trim($type));
 		return $type==='number'; // || $type==='interval' || strpos($type, 'time')===0;
 	}
 
@@ -246,7 +246,7 @@ 
 	{
 		$this->getDbConnection()->setAttribute(PDO::ATTR_CASE, PDO::CASE_LOWER);
 //		select decode( a.CONSTRAINT_TYPE, 'P', 'PRIMARY KEY (', 'FOREIGN KEY (' )||b.COLUMN_NAME||')' as consrc,
-		$sql =
+		$sql=
 <<<EOD
 		select b.COLUMN_NAME as consrc,
 			   a.CONSTRAINT_TYPE as contype
@@ -257,24 +257,24 @@ 
 		and   a.CONSTRAINT_TYPE in ('P','R')
 EOD;
 		$this->getDbConnection()->setActive(true);
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		//$command->bindValue(':table', $tableName);
 		//$command->bindValue(':schema', $schemaName);
-		$primary = array();
-		$foreign = array();
+		$primary=array();
+		$foreign=array();
 		foreach($command->query() as $row)
 		{
-			switch( strtolower( $row['contype'] ) )
+			switch(strtolower($row['contype']))
 			{
 				case 'p':
-					$primary = array_merge( $primary, array(strtolower( $row['consrc'] )) );
+					$primary=array_merge($primary, array(strtolower($row['consrc'])));
 					/*
 					$arr = $this->getPrimaryKeys($row['consrc']);
 					$primary = array_merge( $primary, array(strtolower( $arr[0] )) );
 					*/
 					break;
 				case 'r':
-					$foreign = array_merge( $foreign, array(strtolower( $row['consrc'] )) );
+					$foreign=array_merge($foreign, array(strtolower($row['consrc'])));
 					/*
 					// if(($fkey = $this->getForeignKeys($row['consrc']))!==null)
 					$fkey = $this->getForeignKeys( $row['consrc'] );
@@ -283,7 +283,7 @@ 
 					break;
 			}
 		}
-		return array($primary,$foreign);
+		return array($primary, $foreign);
 	}
 
 	/**
@@ -293,9 +293,9 @@ 
 	 */
 	protected function getPrimaryKeys($src)
 	{
-		$matches = array();
+		$matches=array();
 		if(preg_match('/PRIMARY\s+KEY\s+\(([^\)]+)\)/i', $src, $matches))
-			return preg_split('/,\s+/',$matches[1]);
+			return preg_split('/,\s+/', $matches[1]);
 		return array();
 	}
 
@@ -306,16 +306,16 @@ 
 	 */
 	protected function getForeignKeys($src)
 	{
-		$matches = array();
-		$brackets = '\(([^\)]+)\)';
-		$find = "/FOREIGN\s+KEY\s+{$brackets}\s+REFERENCES\s+([^\(]+){$brackets}/i";
+		$matches=array();
+		$brackets='\(([^\)]+)\)';
+		$find="/FOREIGN\s+KEY\s+{$brackets}\s+REFERENCES\s+([^\(]+){$brackets}/i";
 		if(preg_match($find, $src, $matches))
 		{
-			$keys = preg_split('/,\s+/', $matches[1]);
-			$fkeys = array();
+			$keys=preg_split('/,\s+/', $matches[1]);
+			$fkeys=array();
 			foreach(preg_split('/,\s+/', $matches[3]) as $i => $fkey)
-				$fkeys[$keys[$i]] = $fkey;
-			return array('table' => str_replace('"','',$matches[2]), 'keys' => $fkeys);
+				$fkeys[$keys[$i]]=$fkey;
+			return array('table' => str_replace('"', '', $matches[2]), 'keys' => $fkeys);
 		}
 	}
 
@@ -328,7 +328,7 @@ 
 	{
 		foreach($tableInfo->getForeignKeys() as $fk)
 		{
-			if( $fk==$columnId )
+			if($fk==$columnId)
 			//if(in_array($columnId, array_keys($fk['keys'])))
 				return true;
 		}
@@ -357,7 +357,7 @@ 
 WHERE object_type = 'TABLE' AND owner=:schema
 EOD;
 			$command=$this->getDbConnection()->createCommand($sql);
-			$command->bindParam(':schema',$schema);
+			$command->bindParam(':schema', $schema);
 		}
 
 		$rows=$command->queryAll();

Braces +3 added lines, -6 removed lines

@@ -203,11 +203,9 @@ 
 				$info['NumericPrecision'] = intval($matches[1]);
 				if(count($matches) > 2)
 					$info['NumericScale'] = intval($matches[2]);
-			}
-			else
+			} else
 				$info['ColumnSize'] = intval($matches[1]);
-		}
-		else
+		} else
 			$info['DbType'] = $col['type'];
 		$tableInfo->Columns[$columnId] = new TOracleTableColumn($info);
 	}
@@ -349,8 +347,7 @@ 
 SELECT table_name, '{$schema}' as table_schema FROM user_tables
 EOD;
 			$command=$this->getDbConnection()->createCommand($sql);
-		}
-		else
+		} else
 		{
 			$sql=<<<EOD
 SELECT object_name as table_name, owner as table_schema FROM all_objects

framework/Data/Common/Oracle/TOracleTableInfo.php

Doc Comments +2 added lines

@@ -53,6 +53,8 @@
 	/**
 	 * @param string information array key name
 	 * @param mixed default value if information array value is null
+	 * @param string $name
+	 * @param boolean $default
 	 * @return mixed information array value.
 	 */
 	public function getInfo($name,$default=null)

Spacing +8 added lines, -8 removed lines

@@ -32,7 +32,7 @@ 
 	 * Sets the database table meta data information.
 	 * @param array table column information.
 	 */
-	public function __construct($tableInfo=array(),$primary=array(),$foreign=array())
+	public function __construct($tableInfo=array(), $primary=array(), $foreign=array())
 	{
 		$this->_info=$tableInfo;
 		$this->_primaryKeys=$primary;
@@ -47,7 +47,7 @@ 
 	public function createCommandBuilder($connection)
 	{
 		Prado::using('System.Data.Common.Oracle.TOracleCommandBuilder');
-		return new TOracleCommandBuilder($connection,$this);
+		return new TOracleCommandBuilder($connection, $this);
 	}
 
 	/**
@@ -55,7 +55,7 @@ 
 	 * @param mixed default value if information array value is null
 	 * @return mixed information array value.
 	 */
-	public function getInfo($name,$default=null)
+	public function getInfo($name, $default=null)
 	{
 		return isset($this->_info[$name]) ? $this->_info[$name] : $default;
 	}
@@ -64,7 +64,7 @@ 
 	 * @param string information array key name
 	 * @param mixed new information array value.
 	 */
-	protected function setInfo($name,$value)
+	protected function setInfo($name, $value)
 	{
 		$this->_info[$name]=$value;
 	}
@@ -90,7 +90,7 @@ 
 	 */
 	public function getIsView()
 	{
-		return $this->getInfo('IsView',false);
+		return $this->getInfo('IsView', false);
 	}
 
 	/**
@@ -107,7 +107,7 @@ 
 	 */
 	public function getColumn($name)
 	{
-		if(($column = $this->_columns->itemAt($name))!==null)
+		if(($column=$this->_columns->itemAt($name))!==null)
 			return $column;
 		throw new TDbException('dbtableinfo_invalid_column_name', $name, $this->getTableFullName());
 	}
@@ -119,7 +119,7 @@ 
 	public function getColumnNames()
 	{
 		foreach($this->getColumns() as $column)
-			$names[] = $column->getColumnName();
+			$names[]=$column->getColumnName();
 		return $names;
 	}
 
@@ -148,7 +148,7 @@ 
 		{
 			$this->_lowercase=array();
 			foreach($this->getColumns()->getKeys() as $key)
-				$this->_lowercase[strtolower($key)] = $key;
+				$this->_lowercase[strtolower($key)]=$key;
 		}
 		return $this->_lowercase;
 	}

framework/Data/Common/Pgsql/TPgsqlMetaData.php

Doc Comments +1 added lines

@@ -204,6 +204,7 @@
 	/**
 	 * @param TPgsqlTableInfo table information.
 	 * @param array column information.
+	 * @param TPgsqlTableInfo $tableInfo
 	 */
 	protected function processColumn($tableInfo, $col)
 	{

Indentation +6 added lines, -6 removed lines

@@ -417,12 +417,12 @@
 		return false;
 	}
 
-        /**
-	 * Returns all table names in the database.
-	 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
-	 * If not empty, the returned table names will be prefixed with the schema name.
-	 * @return array all table names in the database.
-	 */
+		/**
+		 * Returns all table names in the database.
+		 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
+		 * If not empty, the returned table names will be prefixed with the schema name.
+		 * @return array all table names in the database.
+		 */
 	public function findTableNames($schema='public')
 	{
 		if($schema==='')

Spacing +66 added lines, -66 removed lines

@@ -24,7 +24,7 @@ 
  */
 class TPgsqlMetaData extends TDbMetaData
 {
-	private $_defaultSchema = 'public';
+	private $_defaultSchema='public';
 
 	/**
 	 * @return string TDbTableInfo class name.
@@ -86,10 +86,10 @@ 
 	 */
 	protected function getSchemaTableName($table)
 	{
-		if(count($parts= explode('.', str_replace('"','',$table))) > 1)
+		if(count($parts=explode('.', str_replace('"', '', $table))) > 1)
 			return array($parts[0], $parts[1]);
 		else
-			return array($this->getDefaultSchema(),$parts[0]);
+			return array($this->getDefaultSchema(), $parts[0]);
 	}
 
 	/**
@@ -99,12 +99,12 @@ 
 	 */
 	protected function createTableInfo($table)
 	{
-		list($schemaName,$tableName) = $this->getSchemaTableName($table);
+		list($schemaName, $tableName)=$this->getSchemaTableName($table);
 
 		// This query is made much more complex by the addition of the 'attisserial' field.
 		// The subquery to get that field checks to see if there is an internally dependent
 		// sequence on the field.
-		$sql =
+		$sql=
 <<<EOD
 		SELECT
 			a.attname,
@@ -135,14 +135,14 @@ 
 		ORDER BY a.attnum
 EOD;
 		$this->getDbConnection()->setActive(true);
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $tableName);
 		$command->bindValue(':schema', $schemaName);
-		$tableInfo = $this->createNewTableInfo($schemaName, $tableName);
+		$tableInfo=$this->createNewTableInfo($schemaName, $tableName);
 		$index=0;
 		foreach($command->query() as $col)
 		{
-			$col['index'] = $index++;
+			$col['index']=$index++;
 			$this->processColumn($tableInfo, $col);
 		}
 		if($index===0)
@@ -155,15 +155,15 @@ 
 	 * @param string table name.
 	 * @return TPgsqlTableInfo
 	 */
-	protected function createNewTableInfo($schemaName,$tableName)
+	protected function createNewTableInfo($schemaName, $tableName)
 	{
-		$info['SchemaName'] = $this->assertIdentifier($schemaName);
-		$info['TableName'] = $this->assertIdentifier($tableName);
-		if($this->getIsView($schemaName,$tableName))
-			$info['IsView'] = true;
-		list($primary, $foreign) = $this->getConstraintKeys($schemaName, $tableName);
-		$class = $this->getTableInfoClass();
-		return new $class($info,$primary,$foreign);
+		$info['SchemaName']=$this->assertIdentifier($schemaName);
+		$info['TableName']=$this->assertIdentifier($tableName);
+		if($this->getIsView($schemaName, $tableName))
+			$info['IsView']=true;
+		list($primary, $foreign)=$this->getConstraintKeys($schemaName, $tableName);
+		$class=$this->getTableInfoClass();
+		return new $class($info, $primary, $foreign);
 	}
 
 	/**
@@ -175,7 +175,7 @@ 
 	{
 		if(strpos($name, '"')!==false)
 		{
-			$ref = 'http://www.postgresql.org/docs/7.4/static/sql-syntax.html#SQL-SYNTAX-IDENTIFIERS';
+			$ref='http://www.postgresql.org/docs/7.4/static/sql-syntax.html#SQL-SYNTAX-IDENTIFIERS';
 			throw new TDbException('dbcommon_invalid_identifier_name', $name, $ref);
 		}
 		return $name;
@@ -186,19 +186,19 @@ 
 	 * @param string table name.
 	 * @return boolean true if the table is a view.
 	 */
-	protected function getIsView($schemaName,$tableName)
+	protected function getIsView($schemaName, $tableName)
 	{
-		$sql =
+		$sql=
 <<<EOD
 		SELECT count(c.relname) FROM pg_catalog.pg_class c
 		LEFT JOIN pg_catalog.pg_namespace n ON (n.oid = c.relnamespace)
 		WHERE (n.nspname=:schema) AND (c.relkind = 'v'::"char") AND c.relname = :table
 EOD;
 		$this->getDbConnection()->setActive(true);
-		$command = $this->getDbConnection()->createCommand($sql);
-		$command->bindValue(':schema',$schemaName);
+		$command=$this->getDbConnection()->createCommand($sql);
+		$command->bindValue(':schema', $schemaName);
 		$command->bindValue(':table', $tableName);
-		return intval($command->queryScalar()) === 1;
+		return intval($command->queryScalar())===1;
 	}
 
 	/**
@@ -207,56 +207,56 @@ 
 	 */
 	protected function processColumn($tableInfo, $col)
 	{
-		$columnId = $col['attname']; //use column name as column Id
+		$columnId=$col['attname']; //use column name as column Id
 
-		$info['ColumnName'] = '"'.$columnId.'"'; //quote the column names!
-		$info['ColumnId'] = $columnId;
-		$info['ColumnIndex'] = $col['index'];
+		$info['ColumnName']='"'.$columnId.'"'; //quote the column names!
+		$info['ColumnId']=$columnId;
+		$info['ColumnIndex']=$col['index'];
 		if(!$col['attnotnull'])
-			$info['AllowNull'] = true;
+			$info['AllowNull']=true;
 		if(in_array($columnId, $tableInfo->getPrimaryKeys()))
-			$info['IsPrimaryKey'] = true;
+			$info['IsPrimaryKey']=true;
 		if($this->isForeignKeyColumn($columnId, $tableInfo))
-			$info['IsForeignKey'] = true;
+			$info['IsForeignKey']=true;
 
 		if($col['atttypmod'] > 0)
-			$info['ColumnSize'] =  $col['atttypmod'] - 4;
+			$info['ColumnSize']=$col['atttypmod'] - 4;
 		if($col['atthasdef'])
-			$info['DefaultValue'] = $col['adsrc'];
-		if($col['attisserial'] || substr($col['adsrc'],0,8) === 'nextval(')
+			$info['DefaultValue']=$col['adsrc'];
+		if($col['attisserial'] || substr($col['adsrc'], 0, 8)==='nextval(')
 		{
-			if(($sequence = $this->getSequenceName($tableInfo, $col['adsrc']))!==null)
+			if(($sequence=$this->getSequenceName($tableInfo, $col['adsrc']))!==null)
 			{
-				$info['SequenceName'] = $sequence;
+				$info['SequenceName']=$sequence;
 				unset($info['DefaultValue']);
 			}
 		}
-		$matches = array();
+		$matches=array();
 		if(preg_match('/\((\d+)(?:,(\d+))?+\)/', $col['type'], $matches))
 		{
-			$info['DbType'] = preg_replace('/\(\d+(?:,\d+)?\)/','',$col['type']);
+			$info['DbType']=preg_replace('/\(\d+(?:,\d+)?\)/', '', $col['type']);
 			if($this->isPrecisionType($info['DbType']))
 			{
-				$info['NumericPrecision'] = intval($matches[1]);
+				$info['NumericPrecision']=intval($matches[1]);
 				if(count($matches) > 2)
-					$info['NumericScale'] = intval($matches[2]);
+					$info['NumericScale']=intval($matches[2]);
 			}
 			else
-				$info['ColumnSize'] = intval($matches[1]);
+				$info['ColumnSize']=intval($matches[1]);
 		}
 		else
-			$info['DbType'] = $col['type'];
+			$info['DbType']=$col['type'];
 
-		$tableInfo->Columns[$columnId] = new TPgsqlTableColumn($info);
+		$tableInfo->Columns[$columnId]=new TPgsqlTableColumn($info);
 	}
 
 	/**
 	 * @return string serial name if found, null otherwise.
 	 */
-	protected function getSequenceName($tableInfo,$src)
+	protected function getSequenceName($tableInfo, $src)
 	{
-		$matches = array();
-		if(preg_match('/nextval\([^\']*\'([^\']+)\'[^\)]*\)/i',$src,$matches))
+		$matches=array();
+		if(preg_match('/nextval\([^\']*\'([^\']+)\'[^\)]*\)/i', $src, $matches))
 		{
 			if(is_int(strpos($matches[1], '.')))
 				return $matches[1];
@@ -270,7 +270,7 @@ 
 	 */
 	protected function isPrecisionType($type)
 	{
-		$type = strtolower(trim($type));
+		$type=strtolower(trim($type));
 		return $type==='numeric' || $type==='interval' || strpos($type, 'time')===0;
 	}
 
@@ -282,7 +282,7 @@ 
 	 */
 	protected function getConstraintKeys($schemaName, $tableName)
 	{
-		$sql =
+		$sql=
 <<<EOD
 	SELECT conname, consrc, contype, indkey, indisclustered FROM (
 			SELECT
@@ -330,25 +330,25 @@ 
 			1
 EOD;
 		$this->getDbConnection()->setActive(true);
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $tableName);
 		$command->bindValue(':schema', $schemaName);
-		$primary = array();
-		$foreign = array();
+		$primary=array();
+		$foreign=array();
 		foreach($command->query() as $row)
 		{
 			switch($row['contype'])
 			{
 				case 'p':
-					$primary = $this->getPrimaryKeys($tableName, $schemaName, $row['indkey']);
+					$primary=$this->getPrimaryKeys($tableName, $schemaName, $row['indkey']);
 					break;
 				case 'f':
-					if(($fkey = $this->getForeignKeys($row['consrc']))!==null)
-						$foreign[] = $fkey;
+					if(($fkey=$this->getForeignKeys($row['consrc']))!==null)
+						$foreign[]=$fkey;
 					break;
 			}
 		}
-		return array($primary,$foreign);
+		return array($primary, $foreign);
 	}
 
 	/**
@@ -358,8 +358,8 @@ 
 	 */
 	protected function getPrimaryKeys($tableName, $schemaName, $columnIndex)
 	{
-		$index = join(', ', explode(' ', $columnIndex));
-		$sql =
+		$index=join(', ', explode(' ', $columnIndex));
+		$sql=
 <<<EOD
 		SELECT attnum, attname FROM pg_catalog.pg_attribute WHERE
 		attrelid=(
@@ -369,14 +369,14 @@ 
 		)
 				AND attnum IN ({$index})
 EOD;
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $tableName);
 		$command->bindValue(':schema', $schemaName);
 //		$command->bindValue(':columnIndex', join(', ', explode(' ', $columnIndex)));
-		$primary = array();
+		$primary=array();
 		foreach($command->query() as $row)
 		{
-						$primary[] = $row['attname'];
+						$primary[]=$row['attname'];
 		}
 
 		return $primary;
@@ -389,16 +389,16 @@ 
 	 */
 	protected function getForeignKeys($src)
 	{
-		$matches = array();
-		$brackets = '\(([^\)]+)\)';
-		$find = "/FOREIGN\s+KEY\s+{$brackets}\s+REFERENCES\s+([^\(]+){$brackets}/i";
+		$matches=array();
+		$brackets='\(([^\)]+)\)';
+		$find="/FOREIGN\s+KEY\s+{$brackets}\s+REFERENCES\s+([^\(]+){$brackets}/i";
 		if(preg_match($find, $src, $matches))
 		{
-			$keys = preg_split('/,\s+/', $matches[1]);
-			$fkeys = array();
+			$keys=preg_split('/,\s+/', $matches[1]);
+			$fkeys=array();
 			foreach(preg_split('/,\s+/', $matches[3]) as $i => $fkey)
-				$fkeys[$keys[$i]] = $fkey;
-			return array('table' => str_replace('"','',$matches[2]), 'keys' => $fkeys);
+				$fkeys[$keys[$i]]=$fkey;
+			return array('table' => str_replace('"', '', $matches[2]), 'keys' => $fkeys);
 		}
 	}
 
@@ -432,7 +432,7 @@ 
 WHERE table_schema=:schema AND table_type='BASE TABLE'
 EOD;
 		$command=$this->getDbConnection()->createCommand($sql);
-		$command->bindParam(':schema',$schema);
+		$command->bindParam(':schema', $schema);
 		$rows=$command->queryAll();
 		$names=array();
 		foreach($rows as $row)

Braces +2 added lines, -4 removed lines

@@ -233,8 +233,7 @@ 
 				$newid=substr($id,$pos+1);
 				if ($control!==null)
 					$control=$control->$newid;
-			}
-			else
+			} else
 			{
 				// TCheckBoxList overrides findControl() with a fake implementation
 				// but accepts a second parameter to use the standard one
@@ -296,8 +295,7 @@ 
 		{
 			$group=$this->getValidationGroup();
 			return $this->getPage()->getValidators($group)->getCount()>0;
-		}
-		else
+		} else
 			return false;
 	}
 

framework/Data/Common/Sqlite/TSqliteMetaData.php

Doc Comments +1 added lines

@@ -159,6 +159,7 @@
 	 *
 	 *
 	 * @param string quoted table name.
+	 * @param string $table
 	 * @return array foreign key details.
 	 */
 	protected function getForeignKeys($table)

Indentation +5 added lines, -5 removed lines

@@ -189,11 +189,11 @@
 		return false;
 	}
 
-        /**
-	 * Returns all table names in the database.
-	 * @param string $schema the schema of the tables. This is not used for sqlite database.
-	 * @return array all table names in the database.
-	 */
+		/**
+		 * Returns all table names in the database.
+		 * @param string $schema the schema of the tables. This is not used for sqlite database.
+		 * @return array all table names in the database.
+		 */
 	public function findTableNames($schema='')
 	{
 		$sql="SELECT DISTINCT tbl_name FROM sqlite_master WHERE tbl_name<>'sqlite_sequence'";

Spacing +36 added lines, -36 removed lines

@@ -69,30 +69,30 @@ 
 	 */
 	protected function createTableInfo($tableName)
 	{
-		$tableName = str_replace("'",'',$tableName);
+		$tableName=str_replace("'", '', $tableName);
 		$this->getDbConnection()->setActive(true);
-		$table = $this->getDbConnection()->quoteString($tableName);
-		$sql = "PRAGMA table_info({$table})";
-		$command = $this->getDbConnection()->createCommand($sql);
-		$foreign = $this->getForeignKeys($table);
+		$table=$this->getDbConnection()->quoteString($tableName);
+		$sql="PRAGMA table_info({$table})";
+		$command=$this->getDbConnection()->createCommand($sql);
+		$foreign=$this->getForeignKeys($table);
 		$index=0;
 		$columns=array();
 		$primary=array();
 		foreach($command->query() as $col)
 		{
-			$col['index'] = $index++;
-			$column = $this->processColumn($col, $foreign);
-			$columns[$col['name']] = $column;
+			$col['index']=$index++;
+			$column=$this->processColumn($col, $foreign);
+			$columns[$col['name']]=$column;
 			if($column->getIsPrimaryKey())
-				$primary[] = $col['name'];
+				$primary[]=$col['name'];
 		}
-		$info['TableName'] = $tableName;
+		$info['TableName']=$tableName;
 		if($this->getIsView($tableName))
-			$info['IsView'] = true;
+			$info['IsView']=true;
 		if(count($columns)===0)
 			throw new TDbException('dbmetadata_invalid_table_view', $tableName);
-		$class = $this->getTableInfoClass();
-		$tableInfo = new $class($info,$primary,$foreign);
+		$class=$this->getTableInfoClass();
+		$tableInfo=new $class($info, $primary, $foreign);
 		$tableInfo->getColumns()->copyFrom($columns);
 		return $tableInfo;
 	}
@@ -103,11 +103,11 @@ 
 	 */
 	protected function getIsView($tableName)
 	{
-		$sql = 'SELECT count(*) FROM sqlite_master WHERE type="view" AND name= :table';
+		$sql='SELECT count(*) FROM sqlite_master WHERE type="view" AND name= :table';
 		$this->getDbConnection()->setActive(true);
-		$command = $this->getDbConnection()->createCommand($sql);
+		$command=$this->getDbConnection()->createCommand($sql);
 		$command->bindValue(':table', $tableName);
-		return intval($command->queryScalar()) === 1;
+		return intval($command->queryScalar())===1;
 	}
 
 	/**
@@ -117,39 +117,39 @@ 
 	 */
 	protected function processColumn($col, $foreign)
 	{
-		$columnId = $col['name']; //use column name as column Id
+		$columnId=$col['name']; //use column name as column Id
 
-		$info['ColumnName'] = '"'.$columnId.'"'; //quote the column names!
-		$info['ColumnId'] = $columnId;
-		$info['ColumnIndex'] = $col['index'];
+		$info['ColumnName']='"'.$columnId.'"'; //quote the column names!
+		$info['ColumnId']=$columnId;
+		$info['ColumnIndex']=$col['index'];
 
 		if($col['notnull']!=='99')
-			$info['AllowNull'] = true;
+			$info['AllowNull']=true;
 
 		if($col['pk']==='1')
-			$info['IsPrimaryKey'] = true;
+			$info['IsPrimaryKey']=true;
 		if($this->isForeignKeyColumn($columnId, $foreign))
-			$info['IsForeignKey'] = true;
+			$info['IsForeignKey']=true;
 
 		if($col['dflt_value']!==null)
-			$info['DefaultValue'] = $col['dflt_value'];
+			$info['DefaultValue']=$col['dflt_value'];
 
-		$type = strtolower($col['type']);
-		$info['AutoIncrement'] = $type==='integer' && $col['pk']==='1';
+		$type=strtolower($col['type']);
+		$info['AutoIncrement']=$type==='integer' && $col['pk']==='1';
 
-		$info['DbType'] = $type;
+		$info['DbType']=$type;
 		$match=array();
 		if(is_int($pos=strpos($type, '(')) && preg_match('/\((.*)\)/', $type, $match))
 		{
-			$ps = explode(',', $match[1]);
+			$ps=explode(',', $match[1]);
 			if(count($ps)===2)
 			{
-				$info['NumericPrecision'] = intval($ps[0]);
-				$info['NumericScale'] = intval($ps[1]);
+				$info['NumericPrecision']=intval($ps[0]);
+				$info['NumericScale']=intval($ps[1]);
 			}
 			else
 				$info['ColumnSize']=intval($match[1]);
-			$info['DbType'] = substr($type,0,$pos);
+			$info['DbType']=substr($type, 0, $pos);
 		}
 
 		return new TSqliteTableColumn($info);
@@ -163,13 +163,13 @@ 
 	 */
 	protected function getForeignKeys($table)
 	{
-		$sql = "PRAGMA foreign_key_list({$table})";
-		$command = $this->getDbConnection()->createCommand($sql);
-		$fkeys = array();
+		$sql="PRAGMA foreign_key_list({$table})";
+		$command=$this->getDbConnection()->createCommand($sql);
+		$fkeys=array();
 		foreach($command->query() as $col)
 		{
-			$fkeys[$col['table']]['keys'][$col['from']] = $col['to'];
-			$fkeys[$col['table']]['table'] = $col['table'];
+			$fkeys[$col['table']]['keys'][$col['from']]=$col['to'];
+			$fkeys[$col['table']]['table']=$col['table'];
 		}
 		return count($fkeys) > 0 ? array_values($fkeys) : $fkeys;
 	}

Braces +1 added lines, -2 removed lines

@@ -158,8 +158,7 @@
 				$e->setAttribute('maxOccurs','unbounded');
 				$sequence->appendChild($e);
 				$complexType->appendChild($sequence);
-			}
-			else
+			} else
 			{
 				$all = $dom->createElementNS('http://www.w3.org/2001/XMLSchema', 'xsd:all');
 				foreach($elements as $elem)

framework/Data/Common/TDbCommandBuilder.php

Doc Comments +4 added lines, -3 removed lines

@@ -67,7 +67,7 @@ 
 	/**
 	 * Iterate through all the columns and returns the last insert id of the
 	 * first column that has a sequence or serial.
-	 * @return mixed last insert id, null if none is found.
+	 * @return string|null last insert id, null if none is found.
 	 */
 	public function getLastInsertID()
 	{
@@ -187,7 +187,6 @@ 
 	 * array('col1' => 'NULL', '*')
 	 * // SELECT `col1`, `col2`, `col3`, NULL AS `col1` FROM...
 	 * </code>
-	 * @param mixed $value
 	 * @return array of generated fields - use implode(', ', $selectfieldlist) to collapse field list for usage
 	 * @since 3.1.7
 	 * @todo add support for table aliasing
@@ -395,7 +394,7 @@ 
 	/**
 	 * Returns a list of insert field name and a list of binding names.
 	 * @param object array or object to be inserted.
-	 * @return array tuple ($fields, $bindings)
+	 * @return string[] tuple ($fields, $bindings)
 	 */
 	protected function getInsertFieldBindings($values)
 	{
@@ -439,6 +438,7 @@ 
 	 * Bind the name-value pairs of $values where the array keys correspond to column names.
 	 * @param TDbCommand database command.
 	 * @param array name-value pairs.
+	 * @param TDbCommand $command
 	 */
 	public function bindColumnValues($command, $values)
 	{
@@ -455,6 +455,7 @@ 
 	/**
 	 * @param TDbCommand database command
 	 * @param array values for binding.
+	 * @param TDbCommand $command
 	 */
 	public function bindArrayValues($command, $values)
 	{

Spacing +80 added lines, -80 removed lines

@@ -88,10 +88,10 @@ 
 	 */
 	public function applyLimitOffset($sql, $limit=-1, $offset=-1)
 	{
-		$limit = $limit!==null ? (int)$limit : -1;
-		$offset = $offset!==null ? (int)$offset : -1;
-		$limitStr = $limit >= 0 ? ' LIMIT '.$limit : '';
-		$offsetStr = $offset >= 0 ? ' OFFSET '.$offset : '';
+		$limit=$limit!==null ? (int) $limit : -1;
+		$offset=$offset!==null ? (int) $offset : -1;
+		$limitStr=$limit >= 0 ? ' LIMIT '.$limit : '';
+		$offsetStr=$offset >= 0 ? ' OFFSET '.$offset : '';
 		return $sql.$limitStr.$offsetStr;
 	}
 
@@ -105,18 +105,18 @@ 
 		$orders=array();
 		foreach($ordering as $name => $direction)
 		{
-			$direction = strtolower($direction) == 'desc' ? 'DESC' : 'ASC';
-			if(false !== strpos($name, '(') && false !== strpos($name, ')')) {
+			$direction=strtolower($direction)=='desc' ? 'DESC' : 'ASC';
+			if(false!==strpos($name, '(') && false!==strpos($name, ')')) {
 				// key is a function (bad practice, but we need to handle it)
-				$key = $name;
+				$key=$name;
 			} else {
 				// key is a column
-				$key = $this->getTableInfo()->getColumn($name)->getColumnName();
+				$key=$this->getTableInfo()->getColumn($name)->getColumnName();
 			}
-			$orders[] = $key.' '.$direction;
+			$orders[]=$key.' '.$direction;
 		}
 		if(count($orders) > 0)
-			$sql .= ' ORDER BY '.implode(', ', $orders);
+			$sql.=' ORDER BY '.implode(', ', $orders);
 		return $sql;
 	}
 
@@ -130,13 +130,13 @@ 
 	 */
 	public function getSearchExpression($fields, $keywords)
 	{
-		if(strlen(trim($keywords)) == 0) return '';
-		$words = preg_split('/\s/u', $keywords);
-		$conditions = array();
+		if(strlen(trim($keywords))==0) return '';
+		$words=preg_split('/\s/u', $keywords);
+		$conditions=array();
 		foreach($fields as $field)
 		{
-			$column = $this->getTableInfo()->getColumn($field)->getColumnName();
-			$conditions[] = $this->getSearchCondition($column, $words);
+			$column=$this->getTableInfo()->getColumn($field)->getColumnName();
+			$conditions[]=$this->getSearchCondition($column, $words);
 		}
 		return '('.implode(' OR ', $conditions).')';
 	}
@@ -150,7 +150,7 @@ 
 	{
 		$conditions=array();
 		foreach($words as $word)
-			$conditions[] = $column.' LIKE '.$this->getDbConnection()->quoteString('%'.$word.'%');
+			$conditions[]=$column.' LIKE '.$this->getDbConnection()->quoteString('%'.$word.'%');
 		return '('.implode(' AND ', $conditions).')';
 	}
 
@@ -195,102 +195,102 @@ 
 	 */
 	public function getSelectFieldList($data='*') {
 		if(is_scalar($data)) {
-			$tmp = explode(',', $data);
-			$result = array();
+			$tmp=explode(',', $data);
+			$result=array();
 			foreach($tmp as $v)
-				$result[] = trim($v);
+				$result[]=trim($v);
 			return $result;
 		}
 
-		$bHasWildcard = false;
-		$result = array();
+		$bHasWildcard=false;
+		$result=array();
 		if(is_array($data) || $data instanceof Traversable) {
-			$columns = $this->getTableInfo()->getColumns();
+			$columns=$this->getTableInfo()->getColumns();
 			foreach($data as $key=>$value) {
 				if($key==='*' || $value==='*') {
-					$bHasWildcard = true;
+					$bHasWildcard=true;
 					continue;
 				}
 
 				if(strToUpper($key)==='NULL') {
-					$result[] = 'NULL';
+					$result[]='NULL';
 					continue;
 				}
 
 				if(strpos($key, '(')!==false && strpos($key, ')')!==false) {
-					$result[] = $key;
+					$result[]=$key;
 					continue;
 				}
 
 				if(stripos($key, 'AS')!==false) {
-					$result[] = $key;
+					$result[]=$key;
 					continue;
 				}
 
 				if(stripos($value, 'AS')!==false) {
-					$result[] = $value;
+					$result[]=$value;
 					continue;
 				}
 
-				$v = isset($columns[$value]);
-				$k = isset($columns[$key]);
+				$v=isset($columns[$value]);
+				$k=isset($columns[$key]);
 				if(is_integer($key) && $v) {
-					$key = $value;
-					$k = $v;
+					$key=$value;
+					$k=$v;
 				}
 
 				if(strToUpper($value)==='NULL') {
 					if($k)
-						$result[] = 'NULL AS ' . $columns[$key]->getColumnName();
+						$result[]='NULL AS '.$columns[$key]->getColumnName();
 					else
-						$result[] = 'NULL' . (is_string($key) ? (' AS ' . (string)$key) : '');
+						$result[]='NULL'.(is_string($key) ? (' AS '.(string) $key) : '');
 					continue;
 				}
 
 				if(strpos($value, '(')!==false && strpos($value, ')')!==false) {
 					if($k)
-						$result[] = $value . ' AS ' . $columns[$key]->getColumnName();
+						$result[]=$value.' AS '.$columns[$key]->getColumnName();
 					else
-						$result[] = $value . (is_string($key) ? (' AS ' . (string)$key) : '');
+						$result[]=$value.(is_string($key) ? (' AS '.(string) $key) : '');
 					continue;
 				}
 
 				if($v && $key==$value) {
-					$result[] = $columns[$value]->getColumnName();
+					$result[]=$columns[$value]->getColumnName();
 					continue;
 				}
 
 				if($k && $value==null) {
-					$result[] = $columns[$key]->getColumnName();
+					$result[]=$columns[$key]->getColumnName();
 					continue;
 				}
 
 				if(is_string($key) && $v) {
-					$result[] = $columns[$value]->getColumnName() . ' AS ' . $key;
+					$result[]=$columns[$value]->getColumnName().' AS '.$key;
 					continue;
 				}
 
 				if(is_numeric($value) && $k) {
-					$result[] = $value . ' AS ' . $columns[$key]->getColumnName();
+					$result[]=$value.' AS '.$columns[$key]->getColumnName();
 					continue;
 				}
 
 				if(is_string($value) && $k) {
-					$result[] = $this->getDbConnection()->quoteString($value) . ' AS ' . $columns[$key]->getColumnName();
+					$result[]=$this->getDbConnection()->quoteString($value).' AS '.$columns[$key]->getColumnName();
 					continue;
 				}
 
 				if(!$v && !$k && is_integer($key)) {
-					$result[] = is_numeric($value) ? $value : $this->getDbConnection()->quoteString((string)$value);
+					$result[]=is_numeric($value) ? $value : $this->getDbConnection()->quoteString((string) $value);
 					continue;
 				}
 
-				$result[] = (is_numeric($value) ? $value : $this->getDbConnection()->quoteString((string)$value)) . ' AS ' . $key;
+				$result[]=(is_numeric($value) ? $value : $this->getDbConnection()->quoteString((string) $value)).' AS '.$key;
 			}
 		}
 
-		if($data===null || count($result) == 0 || $bHasWildcard)
-			$result = $result = array_merge($this->getTableInfo()->getColumnNames(), $result);
+		if($data===null || count($result)==0 || $bHasWildcard)
+			$result=$result=array_merge($this->getTableInfo()->getColumnNames(), $result);
 
 		return $result;
 	}
@@ -304,21 +304,21 @@ 
 	 */
 	public function createFindCommand($where='1=1', $parameters=array(), $ordering=array(), $limit=-1, $offset=-1, $select='*')
 	{
-		$table = $this->getTableInfo()->getTableFullName();
-		$fields = implode(', ', $this -> getSelectFieldList($select));
-		$sql = "SELECT {$fields} FROM {$table}";
+		$table=$this->getTableInfo()->getTableFullName();
+		$fields=implode(', ', $this -> getSelectFieldList($select));
+		$sql="SELECT {$fields} FROM {$table}";
 		if(!empty($where))
-			$sql .= " WHERE {$where}";
+			$sql.=" WHERE {$where}";
 		return $this->applyCriterias($sql, $parameters, $ordering, $limit, $offset);
 	}
 
-	public function applyCriterias($sql, $parameters=array(),$ordering=array(), $limit=-1, $offset=-1)
+	public function applyCriterias($sql, $parameters=array(), $ordering=array(), $limit=-1, $offset=-1)
 	{
 		if(count($ordering) > 0)
-			$sql = $this->applyOrdering($sql, $ordering);
-		if($limit>=0 || $offset>=0)
-			$sql = $this->applyLimitOffset($sql, $limit, $offset);
-		$command = $this->createCommand($sql);
+			$sql=$this->applyOrdering($sql, $ordering);
+		if($limit >= 0 || $offset >= 0)
+			$sql=$this->applyLimitOffset($sql, $limit, $offset);
+		$command=$this->createCommand($sql);
 		$this->bindArrayValues($command, $parameters);
 		return $command;
 	}
@@ -329,7 +329,7 @@ 
 	 * @param array binding parameters.
 	 * @return TDbCommand count command.
 	 */
-	public function createCountCommand($where='1=1', $parameters=array(),$ordering=array(), $limit=-1, $offset=-1)
+	public function createCountCommand($where='1=1', $parameters=array(), $ordering=array(), $limit=-1, $offset=-1)
 	{
 		return $this->createFindCommand($where, $parameters, $ordering, $limit, $offset, 'COUNT(*)');
 	}
@@ -342,12 +342,12 @@ 
 	 * @param array delete parameters.
 	 * @return TDbCommand delete command.
 	 */
-	public function createDeleteCommand($where,$parameters=array())
+	public function createDeleteCommand($where, $parameters=array())
 	{
-		$table = $this->getTableInfo()->getTableFullName();
-		if (!empty($where))
-			$where = ' WHERE '.$where;
-		$command = $this->createCommand("DELETE FROM {$table}".$where);
+		$table=$this->getTableInfo()->getTableFullName();
+		if(!empty($where))
+			$where=' WHERE '.$where;
+		$command=$this->createCommand("DELETE FROM {$table}".$where);
 		$this->bindArrayValues($command, $parameters);
 		return $command;
 	}
@@ -362,9 +362,9 @@ 
 	 */
 	public function createInsertCommand($data)
 	{
-		$table = $this->getTableInfo()->getTableFullName();
-		list($fields, $bindings) = $this->getInsertFieldBindings($data);
-		$command = $this->createCommand("INSERT INTO {$table}({$fields}) VALUES ($bindings)");
+		$table=$this->getTableInfo()->getTableFullName();
+		list($fields, $bindings)=$this->getInsertFieldBindings($data);
+		$command=$this->createCommand("INSERT INTO {$table}({$fields}) VALUES ($bindings)");
 		$this->bindColumnValues($command, $data);
 		return $command;
 	}
@@ -379,15 +379,15 @@ 
 	 */
 	public function createUpdateCommand($data, $where, $parameters=array())
 	{
-		$table = $this->getTableInfo()->getTableFullName();
+		$table=$this->getTableInfo()->getTableFullName();
 		if($this->hasIntegerKey($parameters))
-			$fields = implode(', ', $this->getColumnBindings($data, true));
+			$fields=implode(', ', $this->getColumnBindings($data, true));
 		else
-			$fields = implode(', ', $this->getColumnBindings($data));
+			$fields=implode(', ', $this->getColumnBindings($data));
 
-		if (!empty($where))
-			$where = ' WHERE '.$where;
-		$command = $this->createCommand("UPDATE {$table} SET {$fields}".$where);
+		if(!empty($where))
+			$where=' WHERE '.$where;
+		$command=$this->createCommand("UPDATE {$table} SET {$fields}".$where);
 		$this->bindArrayValues($command, array_merge($data, $parameters));
 		return $command;
 	}
@@ -399,13 +399,13 @@ 
 	 */
 	protected function getInsertFieldBindings($values)
 	{
-		$fields = array(); $bindings=array();
+		$fields=array(); $bindings=array();
 		foreach(array_keys($values) as $name)
 		{
-			$fields[] = $this->getTableInfo()->getColumn($name)->getColumnName();
-			$bindings[] = ':'.$name;
+			$fields[]=$this->getTableInfo()->getColumn($name)->getColumnName();
+			$bindings[]=':'.$name;
 		}
-		return array(implode(', ',$fields), implode(', ', $bindings));
+		return array(implode(', ', $fields), implode(', ', $bindings));
 	}
 
 	/**
@@ -419,8 +419,8 @@ 
 		$bindings=array();
 		foreach(array_keys($values) as $name)
 		{
-			$column = $this->getTableInfo()->getColumn($name)->getColumnName();
-			$bindings[] = $position ? $column.' = ?' : $column.' = :'.$name;
+			$column=$this->getTableInfo()->getColumn($name)->getColumnName();
+			$bindings[]=$position ? $column.' = ?' : $column.' = :'.$name;
 		}
 		return $bindings;
 	}
@@ -444,8 +444,8 @@ 
 	{
 		foreach($values as $name=>$value)
 		{
-			$column = $this->getTableInfo()->getColumn($name);
-			if($value === null && $column->getAllowNull())
+			$column=$this->getTableInfo()->getColumn($name);
+			if($value===null && $column->getAllowNull())
 				$command->bindValue(':'.$name, null, PDO::PARAM_NULL);
 			else
 				$command->bindValue(':'.$name, $value, $column->getPdoType());
@@ -460,15 +460,15 @@ 
 	{
 		if($this->hasIntegerKey($values))
 		{
-			$values = array_values($values);
-			for($i = 0, $max=count($values); $i<$max; $i++)
-				$command->bindValue($i+1, $values[$i], $this->getPdoType($values[$i]));
+			$values=array_values($values);
+			for($i=0, $max=count($values); $i < $max; $i++)
+				$command->bindValue($i + 1, $values[$i], $this->getPdoType($values[$i]));
 		}
 		else
 		{
 			foreach($values as $name=>$value)
 			{
-				$prop = $name[0]===':' ? $name : ':'.$name;
+				$prop=$name[0]===':' ? $name : ':'.$name;
 				$command->bindValue($prop, $value, $this->getPdoType($value));
 			}
 		}

Braces +1 added lines, -2 removed lines

@@ -58,8 +58,7 @@
 		if ($this->sourcepath === NULL)
 		{
 			$this->sourcepath = $sourcepath;
-		}
-		else
+		} else
 		{
 			$this->sourcepath->append($sourcepath);
 		}

framework/Data/Common/TDbMetaData.php

Doc Comments -6 removed lines

@@ -127,8 +127,6 @@ 
 	/**
 	 * Quotes a table name for use in a query.
 	 * @param string $name table name
-	 * @param string $lft left delimiter
-	 * @param string $rgt right delimiter
 	 * @return string the properly quoted table name
 	 */
 	public function quoteTableName($name)
@@ -150,8 +148,6 @@ 
 	/**
 	 * Quotes a column name for use in a query.
 	 * @param string $name column name
-	 * @param string $lft left delimiter
-	 * @param string $rgt right delimiter
 	 * @return string the properly quoted column name
 	 */
 	public function quoteColumnName($name)
@@ -166,8 +162,6 @@ 
 	/**
 	 * Quotes a column alias for use in a query.
 	 * @param string $name column alias
-	 * @param string $lft left delimiter
-	 * @param string $rgt right delimiter
 	 * @return string the properly quoted column alias
 	 */
 	public function quoteColumnAlias($name)

Indentation +8 added lines, -8 removed lines

@@ -179,14 +179,14 @@
 		return $lft . str_replace(self::$delimiterIdentifier, '', $name) . $rgt;
 	}
 
-        /**
-	 * Returns all table names in the database.
-	 * This method should be overridden by child classes in order to support this feature
-	 * because the default implementation simply throws an exception.
-	 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
-	 * If not empty, the returned table names will be prefixed with the schema name.
-	 * @return array all table names in the database.
-	 */
+		/**
+		 * Returns all table names in the database.
+		 * This method should be overridden by child classes in order to support this feature
+		 * because the default implementation simply throws an exception.
+		 * @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
+		 * If not empty, the returned table names will be prefixed with the schema name.
+		 * @return array all table names in the database.
+		 */
 	abstract public function findTableNames($schema='');
 }
 

Spacing +21 added lines, -21 removed lines

@@ -27,7 +27,7 @@ 
 	/**
 	 * @var array
 	 */
-	protected static $delimiterIdentifier = array('[', ']', '"', '`', "'");
+	protected static $delimiterIdentifier=array('[', ']', '"', '`', "'");
 
 	/**
 	 * @param TDbConnection database connection.
@@ -53,7 +53,7 @@ 
 	public static function getInstance($conn)
 	{
 		$conn->setActive(true); //must be connected before retrieving driver name
-		$driver = $conn->getDriverName();
+		$driver=$conn->getDriverName();
 		switch(strtolower($driver))
 		{
 			case 'pgsql':
@@ -79,7 +79,7 @@ 
 //				Prado::using('System.Data.Common.IbmDb2.TIbmDb2MetaData');
 //				return new TIbmDb2MetaData($conn);
 			default:
-				throw new TDbException('ar_invalid_database_driver',$driver);
+				throw new TDbException('ar_invalid_database_driver', $driver);
 		}
 	}
 
@@ -90,12 +90,12 @@ 
 	 */
 	public function getTableInfo($tableName=null)
 	{
-		$key = $tableName===null?$this->getDbConnection()->getConnectionString():$tableName;
+		$key=$tableName===null ? $this->getDbConnection()->getConnectionString() : $tableName;
 		if(!isset($this->_tableInfoCache[$key]))
 		{
-			$class = $this->getTableInfoClass();
-			$tableInfo = $tableName===null ? new $class : $this->createTableInfo($tableName);
-			$this->_tableInfoCache[$key] = $tableInfo;
+			$class=$this->getTableInfoClass();
+			$tableInfo=$tableName===null ? new $class : $this->createTableInfo($tableName);
+			$this->_tableInfoCache[$key]=$tableInfo;
 		}
 		return $this->_tableInfoCache[$key];
 	}
@@ -133,17 +133,17 @@ 
 	 */
 	public function quoteTableName($name)
 	{
-		$name = str_replace(self::$delimiterIdentifier, '', $name);
+		$name=str_replace(self::$delimiterIdentifier, '', $name);
 
-		$args = func_get_args();
-		$rgt = $lft = isset($args[1]) ? $args[1] : '';
-		$rgt = isset($args[2]) ? $args[2] : $rgt;
+		$args=func_get_args();
+		$rgt=$lft=isset($args[1]) ? $args[1] : '';
+		$rgt=isset($args[2]) ? $args[2] : $rgt;
 
 		if(strpos($name, '.')===false)
-			return $lft . $name . $rgt;
+			return $lft.$name.$rgt;
 		$names=explode('.', $name);
 		foreach($names as &$n)
-			$n = $lft . $n . $rgt;
+			$n=$lft.$n.$rgt;
 		return implode('.', $names);
 	}
 
@@ -156,11 +156,11 @@ 
 	 */
 	public function quoteColumnName($name)
 	{
-		$args = func_get_args();
-		$rgt = $lft = isset($args[1]) ? $args[1] : '';
-		$rgt = isset($args[2]) ? $args[2] : $rgt;
+		$args=func_get_args();
+		$rgt=$lft=isset($args[1]) ? $args[1] : '';
+		$rgt=isset($args[2]) ? $args[2] : $rgt;
 
-		return $lft . str_replace(self::$delimiterIdentifier, '', $name) . $rgt;
+		return $lft.str_replace(self::$delimiterIdentifier, '', $name).$rgt;
 	}
 
 	/**
@@ -172,11 +172,11 @@ 
 	 */
 	public function quoteColumnAlias($name)
 	{
-		$args = func_get_args();
-		$rgt = $lft = isset($args[1]) ? $args[1] : '';
-		$rgt = isset($args[2]) ? $args[2] : $rgt;
+		$args=func_get_args();
+		$rgt=$lft=isset($args[1]) ? $args[1] : '';
+		$rgt=isset($args[2]) ? $args[2] : $rgt;
 
-		return $lft . str_replace(self::$delimiterIdentifier, '', $name) . $rgt;
+		return $lft.str_replace(self::$delimiterIdentifier, '', $name).$rgt;
 	}
 
         /**