pradosoft / prado

framework/Web/THttpResponseAdapter.php

Doc Comments +1 added lines

@@ -31,6 +31,7 @@
 	/**
 	 * Constructor. Attach a response to be adapted.
 	 * @param THttpResponse the response object the adapter is to attach to.
+	 * @param THttpResponse $response
 	 */
 	public function __construct($response)
 	{

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 	 */
 	public function createNewHtmlWriter($type, $writer)
 	{
-		return $this->_response->createNewHtmlWriter($type,$writer);
+		return $this->_response->createNewHtmlWriter($type, $writer);
 	}
 }
 

framework/Web/THttpSession.php

Doc Comments +3 added lines

@@ -265,6 +265,7 @@ 
 	 * If true, make sure the methods {@link _open}, {@link _close}, {@link _read},
 	 * {@link _write}, {@link _destroy}, and {@link _gc} are overridden in child
 	 * class, because they will be used as the callback handlers.
+	 * @param boolean $value
 	 */
 	public function setUseCustomStorage($value)
 	{
@@ -527,6 +528,7 @@ 
 	 * Returns the session variable value with the session variable name.
 	 * This method is exactly the same as {@link offsetGet}.
 	 * @param mixed the session variable name
+	 * @param string $key
 	 * @return mixed the session variable value, null if no such variable exists
 	 */
 	public function itemAt($key)
@@ -539,6 +541,7 @@ 
 	 * Note, if the specified name already exists, the old value will be removed first.
 	 * @param mixed session variable name
 	 * @param mixed session variable value
+	 * @param string $key
 	 */
 	public function add($key,$value)
 	{

Braces +4 added lines, -8 removed lines

@@ -309,13 +309,11 @@ 
       {
 				ini_set('session.use_cookies','0');
 			  ini_set('session.use_only_cookies','0');
-      }
-			else if($value===THttpSessionCookieMode::Allow)
+      } else if($value===THttpSessionCookieMode::Allow)
 			{
 				ini_set('session.use_cookies','1');
 				ini_set('session.use_only_cookies','0');
-			}
-			else
+			} else
 			{
 				ini_set('session.use_cookies','1');
 				ini_set('session.use_only_cookies','1');
@@ -368,8 +366,7 @@ 
 			{
 				ini_set('session.gc_probability',$value);
 				ini_set('session.gc_divisor','100');
-			}
-			else
+			} else
 				throw new TInvalidDataValueException('httpsession_gcprobability_invalid',$value);
 		}
 	}
@@ -557,8 +554,7 @@ 
 			$value=$_SESSION[$key];
 			unset($_SESSION[$key]);
 			return $value;
-		}
-		else
+		} else
 			return null;
 	}
 

Spacing +25 added lines, -25 removed lines

@@ -139,9 +139,9 @@ 
 		if(!$this->_started)
 		{
 			if($this->_customStorage)
-				session_set_save_handler(array($this,'_open'),array($this,'_close'),array($this,'_read'),array($this,'_write'),array($this,'_destroy'),array($this,'_gc'));
+				session_set_save_handler(array($this, '_open'), array($this, '_close'), array($this, '_read'), array($this, '_write'), array($this, '_destroy'), array($this, '_gc'));
 			if($this->_cookie!==null)
-				session_set_cookie_params($this->_cookie->getExpire(),$this->_cookie->getPath(),$this->_cookie->getDomain(),$this->_cookie->getSecure(),$this->_cookie->getHttpOnly());
+				session_set_cookie_params($this->_cookie->getExpire(), $this->_cookie->getPath(), $this->_cookie->getDomain(), $this->_cookie->getSecure(), $this->_cookie->getHttpOnly());
 			if(ini_get('session.auto_start')!=='1')
 				session_start();
 			$this->_started=true;
@@ -181,7 +181,7 @@ 
 	 */
 	public function regenerate($deleteOld=false)
 	{
-		$old = $this->getSessionID();
+		$old=$this->getSessionID();
 		session_regenerate_id($deleteOld);
 		return $old;
 	}
@@ -233,7 +233,7 @@ 
 		else if(ctype_alnum($value))
 			session_name($value);
 		else
-			throw new TInvalidDataValueException('httpsession_sessionname_invalid',$value);
+			throw new TInvalidDataValueException('httpsession_sessionname_invalid', $value);
 	}
 
 	/**
@@ -254,10 +254,10 @@ 
 			throw new TInvalidOperationException('httpsession_savepath_unchangeable');
 		elseif(is_dir($value))
 			session_save_path(realpath($value));
-		elseif(null !== ($ns = Prado::getPathOfNamespace($value)) && is_dir($ns))
+		elseif(null!==($ns=Prado::getPathOfNamespace($value)) && is_dir($ns))
 			session_save_path(realpath($ns));
 		else
-			throw new TInvalidDataValueException('httpsession_savepath_invalid',$value);
+			throw new TInvalidDataValueException('httpsession_savepath_invalid', $value);
 	}
 
 	/**
@@ -285,7 +285,7 @@ 
 	public function getCookie()
 	{
 		if($this->_cookie===null)
-			$this->_cookie=new THttpCookie($this->getSessionName(),$this->getSessionID());
+			$this->_cookie=new THttpCookie($this->getSessionName(), $this->getSessionID());
 		return $this->_cookie;
 	}
 
@@ -312,21 +312,21 @@ 
 			throw new TInvalidOperationException('httpsession_cookiemode_unchangeable');
 		else
 		{
-			$value=TPropertyValue::ensureEnum($value,'Prado\\Web\\THttpSessionCookieMode');
+			$value=TPropertyValue::ensureEnum($value, 'Prado\\Web\\THttpSessionCookieMode');
 			if($value===THttpSessionCookieMode::None) 
       {
-				ini_set('session.use_cookies','0');
-			  ini_set('session.use_only_cookies','0');
+				ini_set('session.use_cookies', '0');
+			  ini_set('session.use_only_cookies', '0');
       }
 			else if($value===THttpSessionCookieMode::Allow)
 			{
-				ini_set('session.use_cookies','1');
-				ini_set('session.use_only_cookies','0');
+				ini_set('session.use_cookies', '1');
+				ini_set('session.use_only_cookies', '0');
 			}
 			else
 			{
-				ini_set('session.use_cookies','1');
-				ini_set('session.use_only_cookies','1');
+				ini_set('session.use_cookies', '1');
+				ini_set('session.use_only_cookies', '1');
 				ini_set('session.use_trans_sid', 0);
 			}
 		}
@@ -372,13 +372,13 @@ 
 		else
 		{
 			$value=TPropertyValue::ensureInteger($value);
-			if($value>=0 && $value<=100)
+			if($value >= 0 && $value <= 100)
 			{
-				ini_set('session.gc_probability',$value);
-				ini_set('session.gc_divisor','100');
+				ini_set('session.gc_probability', $value);
+				ini_set('session.gc_divisor', '100');
 			}
 			else
-				throw new TInvalidDataValueException('httpsession_gcprobability_invalid',$value);
+				throw new TInvalidDataValueException('httpsession_gcprobability_invalid', $value);
 		}
 	}
 
@@ -400,9 +400,9 @@ 
 		else
 		{
 			$value=TPropertyValue::ensureBoolean($value);
-			if ($value && $this->getCookieMode()==THttpSessionCookieMode::Only)
+			if($value && $this->getCookieMode()==THttpSessionCookieMode::Only)
 					throw new TInvalidOperationException('httpsession_transid_cookieonly');
-			ini_set('session.use_trans_sid',$value?'1':'0');
+			ini_set('session.use_trans_sid', $value ? '1' : '0');
 		}
 	}
 
@@ -423,7 +423,7 @@ 
 		if($this->_started)
 			throw new TInvalidOperationException('httpsession_maxlifetime_unchangeable');
 		else
-			ini_set('session.gc_maxlifetime',$value);
+			ini_set('session.gc_maxlifetime', $value);
 	}
 
 	/**
@@ -433,7 +433,7 @@ 
 	 * @param string session name
 	 * @return boolean whether session is opened successfully
 	 */
-	public function _open($savePath,$sessionName)
+	public function _open($savePath, $sessionName)
 	{
 		return true;
 	}
@@ -466,7 +466,7 @@ 
 	 * @param string session data
 	 * @return boolean whether session write is successful
 	 */
-	public function _write($id,$data)
+	public function _write($id, $data)
 	{
 		return true;
 	}
@@ -548,7 +548,7 @@ 
 	 * @param mixed session variable name
 	 * @param mixed session variable value
 	 */
-	public function add($key,$value)
+	public function add($key, $value)
 	{
 		$_SESSION[$key]=$value;
 	}
@@ -621,7 +621,7 @@ 
 	 * @param integer the offset to set element
 	 * @param mixed the element value
 	 */
-	public function offsetSet($offset,$item)
+	public function offsetSet($offset, $item)
 	{
 		$_SESSION[$offset]=$item;
 	}

Indentation +2 added lines, -2 removed lines

@@ -314,10 +314,10 @@
 		{
 			$value=TPropertyValue::ensureEnum($value,'Prado\\Web\\THttpSessionCookieMode');
 			if($value===THttpSessionCookieMode::None) 
-      {
+	  {
 				ini_set('session.use_cookies','0');
 			  ini_set('session.use_only_cookies','0');
-      }
+	  }
 			else if($value===THttpSessionCookieMode::Allow)
 			{
 				ini_set('session.use_cookies','1');

framework/Web/UI/ActiveControls/TActiveControlAdapter.php

Doc Comments +1 added lines

@@ -175,6 +175,7 @@
 
 	/**
 	 * @param string state tracker class.
+	 * @param string $value
 	 */
 	public function setStateTracker($value)
 	{

Indentation +2 added lines, -2 removed lines

@@ -78,8 +78,8 @@
 	}
 
  	/**
-	 * Publish the ajax script
-	 */
+ 	 * Publish the ajax script
+ 	 */
 	public function onPreRender($param)
 	{
 		parent::onPreRender($param);

Spacing +10 added lines, -10 removed lines

@@ -73,12 +73,12 @@ 
 		if($type===null)
 		{
 			if($this->getControl() instanceof ICallbackEventHandler)
-				$this->_activeControlType = 'Prado\\Web\UI\\ActiveControls\\TBaseActiveCallbackControl';
+				$this->_activeControlType='Prado\\Web\UI\\ActiveControls\\TBaseActiveCallbackControl';
 			else
-				$this->_activeControlType = 'Prado\\Web\UI\\ActiveControls\\TBaseActiveControl';
+				$this->_activeControlType='Prado\\Web\UI\\ActiveControls\\TBaseActiveControl';
 		}
 		else
-			$this->_activeControlType = $type;
+			$this->_activeControlType=$type;
 	}
 
  	/**
@@ -118,8 +118,8 @@ 
 	{
 		if($this->_baseActiveControl===null)
 		{
-			$type = $this->_activeControlType;
-			$this->_baseActiveControl = new $type($this->getControl());
+			$type=$this->_activeControlType;
+			$this->_baseActiveControl=new $type($this->getControl());
 		}
 		return $this->_baseActiveControl;
 	}
@@ -131,10 +131,10 @@ 
 	{
 		if($this->getPage()->getIsCallback())
 		{
-			$target = $this->getPage()->getCallbackEventTarget();
+			$target=$this->getPage()->getCallbackEventTarget();
 			if($target instanceof ICallbackEventHandler)
 			{
-				$client = $target->getActiveControl()->getClientSide();
+				$client=$target->getActiveControl()->getClientSide();
 				return $client->getEnablePageStateUpdate();
 			}
 		}
@@ -148,8 +148,8 @@ 
 	{
 		if($this->getIsTrackingPageState())
 		{
-		  $stateTrackerClass = $this->_stateTrackerClass;
-			$this->_stateTracker = new $stateTrackerClass($this->getControl());
+		  $stateTrackerClass=$this->_stateTrackerClass;
+			$this->_stateTracker=new $stateTrackerClass($this->getControl());
 			$this->_stateTracker->trackChanges();
 		}
 		parent::onLoad($param);
@@ -182,6 +182,6 @@ 
 	 */
 	public function setStateTracker($value)
 	{
-		$this->_stateTrackerClass = TPropertyValue::ensureString($value);
+		$this->_stateTrackerClass=TPropertyValue::ensureString($value);
 	}
 }

Braces +1 added lines, -2 removed lines

@@ -76,8 +76,7 @@
 				$this->_activeControlType = 'Prado\\Web\UI\\ActiveControls\\TBaseActiveCallbackControl';
 			else
 				$this->_activeControlType = 'Prado\\Web\UI\\ActiveControls\\TBaseActiveControl';
-		}
-		else
+		} else
 			$this->_activeControlType = $type;
 	}
 

framework/Web/UI/ActiveControls/TActiveDropDownList.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
 	/**
 	 * No client class for this control.
 	 * This method overrides the parent implementation.
-	 * @return null no javascript class name.
+	 * @return string no javascript class name.
 	 */
 	protected function getClientClassName()
 	{

Spacing +3 added lines, -3 removed lines

@@ -82,7 +82,7 @@ 
 	 */
 	protected function createListItemCollection()
 	{
-		$collection  = new TActiveListItemCollection;
+		$collection=new TActiveListItemCollection;
 		$collection->setControl($this);
 		return $collection;
 	}
@@ -102,8 +102,8 @@ 
 	protected function addAttributesToRender($writer)
 	{
 		parent::addAttributesToRender($writer);
-		$writer->addAttribute('id',$this->getClientID());
-		if ($this->getAutoPostBack())
+		$writer->addAttribute('id', $this->getClientID());
+		if($this->getAutoPostBack())
 			$this->getActiveControl()->registerCallbackClientScript(
 				$this->getClientClassName(), $this->getPostBackOptions());
 	}

framework/Web/UI/ActiveControls/TActiveListBox.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
 	/**
 	 * Javascript client class for this control.
 	 * This method overrides the parent implementation.
-	 * @return null no javascript class name.
+	 * @return string no javascript class name.
 	 */
 	protected function getClientClassName()
 	{

Spacing +7 added lines, -7 removed lines

@@ -62,7 +62,7 @@ 
 	 */
 	protected function createListItemCollection()
 	{
-		$collection  = new TActiveListItemCollection;
+		$collection=new TActiveListItemCollection;
 		$collection->setControl($this);
 		return $collection;
 	}
@@ -85,15 +85,15 @@ 
 	 */
 	public function setSelectionMode($value)
 	{
-		if(parent::getSelectionMode() === $value)
+		if(parent::getSelectionMode()===$value)
 			return;
 
 		parent::setSelectionMode($value);
-		$multiple = $this->getIsMultiSelect();
-		$id = $this->getUniqueID(); $multi_id = $id.'[]';
+		$multiple=$this->getIsMultiSelect();
+		$id=$this->getUniqueID(); $multi_id=$id.'[]';
 		if($this->getActiveControl()->canUpdateClientSide())
 		{
-			$client = $this->getPage()->getCallbackClient();
+			$client=$this->getPage()->getCallbackClient();
 			$client->setAttribute($this, 'multiple', $multiple ? 'multiple' : false);
 			$client->setAttribute($this, 'name', $multiple ? $multi_id : $id);
 		}
@@ -146,8 +146,8 @@ 
 	protected function addAttributesToRender($writer)
 	{
 		parent::addAttributesToRender($writer);
-		$writer->addAttribute('id',$this->getClientID());
-		if ($this->getAutoPostBack())
+		$writer->addAttribute('id', $this->getClientID());
+		if($this->getAutoPostBack())
 			$this->getActiveControl()->registerCallbackClientScript(
 				$this->getClientClassName(), $this->getPostBackOptions());
 	}

framework/Web/UI/ActiveControls/TActiveRatingList.php

Doc Comments +1 added lines

@@ -99,6 +99,7 @@
 	 * Calls the client-side static method for this control class.
 	 * @param string static method name
 	 * @param mixed method parmaeter
+	 * @param string $func
 	 */
 	protected function callClientFunction($func,$value)
 	{

Spacing +12 added lines, -12 removed lines

@@ -80,12 +80,12 @@ 
 	 */
 	public function setReadOnly($value)
 	{
-		if(parent::getReadOnly() === $value)
+		if(parent::getReadOnly()===$value)
 			return;
 
 		parent::setReadOnly($value);
-		$value = $this->getReadOnly();
-		$this->callClientFunction('setReadOnly',$value);
+		$value=$this->getReadOnly();
+		$this->callClientFunction('setReadOnly', $value);
 	}
 
 	/**
@@ -93,12 +93,12 @@ 
 	 */
 	public function setRating($value)
 	{
-		if(parent::getRating() === $value)
+		if(parent::getRating()===$value)
 			return;
 
 		parent::setRating($value);
-		$value = $this->getRating();
-		$this->callClientFunction('setRating',$value);
+		$value=$this->getRating();
+		$this->callClientFunction('setRating', $value);
 	}
 
 	/**
@@ -106,13 +106,13 @@ 
 	 * @param string static method name
 	 * @param mixed method parmaeter
 	 */
-	protected function callClientFunction($func,$value)
+	protected function callClientFunction($func, $value)
 	{
 		if($this->getActiveControl()->canUpdateClientSide())
 		{
-			$client = $this->getPage()->getCallbackClient();
-			$code = 'Prado.Registry[\''.$this->ClientID.'\'].'.$func.'('.$value.')';
-			$client->evaluateScript($code,array($value));
+			$client=$this->getPage()->getCallbackClient();
+			$code='Prado.Registry[\''.$this->ClientID.'\'].'.$func.'('.$value.')';
+			$client->evaluateScript($code, array($value));
 		}
 	}
 
@@ -121,12 +121,12 @@ 
 	 */
 	public function setCaption($value)
 	{
-		if(parent::getCaption() === $value)
+		if(parent::getCaption()===$value)
 			return;
 
 		parent::setCaption($value);
 		// if it's an active control, this should not be needed.
-		$this->callClientFunction('setCaption',$value);
+		$this->callClientFunction('setCaption', $value);
 	}
 
 	/**

framework/Web/UI/ActiveControls/TInPlaceTextBox.php

Doc Comments +3 added lines

@@ -92,6 +92,8 @@ 
 	 * Calls the client-side static method for this control class.
 	 * @param string static method name
 	 * @param mixed method parmaeter
+	 * @param string $func
+	 * @param boolean $value
 	 */
 	protected function callClientFunction($func,$value)
 	{
@@ -239,6 +241,7 @@ 
 	 * Raised when editing the content is requsted to be loaded from the
 	 * server side.
 	 * @param TCallbackEventParameter event parameter to be passed to the event handlers
+	 * @param TCallbackEventParameter $param
 	 */
 	public function onLoadingText($param)
 	{

Spacing +31 added lines, -31 removed lines

@@ -74,10 +74,10 @@ 
 	 */
 	public function setDisplayTextBox($value)
 	{
-		$value = TPropertyValue::ensureBoolean($value);
-		$this->setViewState('DisplayTextBox', $value,false);
+		$value=TPropertyValue::ensureBoolean($value);
+		$this->setViewState('DisplayTextBox', $value, false);
 		if($this->getActiveControl()->canUpdateClientSide())
-			$this->callClientFunction('setDisplayTextBox',$value);
+			$this->callClientFunction('setDisplayTextBox', $value);
 	}
 
 	/**
@@ -93,11 +93,11 @@ 
 	 * @param string static method name
 	 * @param mixed method parmaeter
 	 */
-	protected function callClientFunction($func,$value)
+	protected function callClientFunction($func, $value)
 	{
-		$client = $this->getPage()->getCallbackClient();
-		$code = $this->getClientClassName().'.'.$func;
-		$client->callClientFunction($code,array($this,$value));
+		$client=$this->getPage()->getCallbackClient();
+		$code=$this->getClientClassName().'.'.$func;
+		$client->callClientFunction($code, array($this, $value));
 	}
 
 	/**
@@ -121,9 +121,9 @@ 
 	 */
 	protected function getExternalControlID()
 	{
-		$extID = $this->getEditTriggerControlID();
+		$extID=$this->getEditTriggerControlID();
 		if($extID===null) return '';
-		if(($control = $this->findControl($extID))!==null)
+		if(($control=$this->findControl($extID))!==null)
 			return $control->getClientID();
 		return $extID;
 	}
@@ -135,13 +135,13 @@ 
 	 */
 	public function setText($value)
 	{
-		if(TTextBox::getText() === $value)
+		if(TTextBox::getText()===$value)
 			return;
 
 		TTextBox::setText($value);
 		if($this->getActiveControl()->canUpdateClientSide())
 		{
-			$client = $this->getPage()->getCallbackClient();
+			$client=$this->getPage()->getCallbackClient();
 			$client->update($this->getLabelClientID(), $value);
 			$client->setValue($this, $value);
 		}
@@ -152,14 +152,14 @@ 
 	 * @param boolean value
 	 * @since 3.1.2
 	 */
-	public function setReadOnly ($value)
+	public function setReadOnly($value)
 	{
 		$value=TPropertyValue::ensureBoolean($value);
-		if(TTextBox::getReadOnly() === $value)
+		if(TTextBox::getReadOnly()===$value)
 			return;
 
 		TTextBox::setReadOnly($value);
-		if ($this->getActiveControl()->canUpdateClientSide())
+		if($this->getActiveControl()->canUpdateClientSide())
 		{
 			$this->callClientFunction('setReadOnly', $value);
 		}
@@ -202,10 +202,10 @@ 
 	 */
 	public function onCallback($param)
 	{
-		$action = $param->getCallbackParameter();
-		if(is_array($action) && $action[0] === '__InlineEditor_loadExternalText__')
+		$action=$param->getCallbackParameter();
+		if(is_array($action) && $action[0]==='__InlineEditor_loadExternalText__')
 		{
-			$parameter = new TCallbackEventParameter($this->getResponse(), $action[1]);
+			$parameter=new TCallbackEventParameter($this->getResponse(), $action[1]);
 			$this->onLoadingText($parameter);
 		}
 		$this->raiseEvent('OnCallback', $this, $param);
@@ -216,26 +216,26 @@ 
 	 */
 	protected function getPostBackOptions()
 	{
-		$options = parent::getPostBackOptions();
-		$options['ID'] = $this->getLabelClientID();
-		$options['TextBoxID'] = $this->getClientID();
-		$options['ExternalControl'] = $this->getExternalControlID();
-		$options['AutoHide'] = $this->getAutoHideTextBox() == false ? '' : true;
-		$options['AutoPostBack'] = $this->getAutoPostBack() == false ? '' : true;
-		$options['Columns'] = $this->getColumns();
+		$options=parent::getPostBackOptions();
+		$options['ID']=$this->getLabelClientID();
+		$options['TextBoxID']=$this->getClientID();
+		$options['ExternalControl']=$this->getExternalControlID();
+		$options['AutoHide']=$this->getAutoHideTextBox()==false ? '' : true;
+		$options['AutoPostBack']=$this->getAutoPostBack()==false ? '' : true;
+		$options['Columns']=$this->getColumns();
 		if($this->getTextMode()==='MultiLine')
 		{
-			$options['Rows'] = $this->getRows();
-			$options['Wrap'] = $this->getWrap()== false ? '' : true;
+			$options['Rows']=$this->getRows();
+			$options['Wrap']=$this->getWrap()==false ? '' : true;
 		}
 		else
 		{
-			$length = $this->getMaxLength();
-			$options['MaxLength'] = $length > 0 ? $length : '';
+			$length=$this->getMaxLength();
+			$options['MaxLength']=$length > 0 ? $length : '';
 		}
 
 		if($this->hasEventHandler('OnLoadingText'))
-			$options['LoadTextOnEdit'] = true;
+			$options['LoadTextOnEdit']=true;
 
 		$options['ReadOnly']=$this->getReadOnly();
 		return $options;
@@ -248,7 +248,7 @@ 
 	 */
 	public function onLoadingText($param)
 	{
-		$this->raiseEvent('OnLoadingText',$this,$param);
+		$this->raiseEvent('OnLoadingText', $this, $param);
 	}
 
 	/**
@@ -267,7 +267,7 @@ 
 	{
 		//calls the TWebControl to avoid rendering other attribute normally render for a textbox.
 		TWebControl::addAttributesToRender($writer);
-		$writer->addAttribute('id',$this->getLabelClientID());
+		$writer->addAttribute('id', $this->getLabelClientID());
 		$this->getActiveControl()->registerCallbackClientScript(
 			$this->getClientClassName(), $this->getPostBackOptions());
 	}

Braces +1 added lines, -2 removed lines

@@ -233,8 +233,7 @@
 		{
 			$options['Rows'] = $this->getRows();
 			$options['Wrap'] = $this->getWrap()== false ? '' : true;
-		}
-		else
+		} else
 		{
 			$length = $this->getMaxLength();
 			$options['MaxLength'] = $length > 0 ? $length : '';

framework/Web/UI/ActiveControls/TTriggeredCallback.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
 	}
 
 	/**
-	 * @return array list of trigger callback options.
+	 * @return string list of trigger callback options.
 	 */
 	protected function getTriggerOptions()
 	{

Spacing +4 added lines, -4 removed lines

@@ -44,7 +44,7 @@ 
 	 */
 	protected function getTargetControl()
 	{
-		$id = $this->getControlID();
+		$id=$this->getControlID();
 		if(($control=$this->findControl($id)) instanceof TControl)
 			return $control->getClientID();
 		if($id==='')
@@ -60,9 +60,9 @@ 
 	 */
 	protected function getTriggerOptions()
 	{
-		$options['ID'] = $this->getClientID();
-		$options['EventTarget'] = $this->getUniqueID();
-		$options['ControlID'] = $this->getTargetControl();
+		$options['ID']=$this->getClientID();
+		$options['EventTarget']=$this->getUniqueID();
+		$options['ControlID']=$this->getTargetControl();
 		return $options;
 	}
 }

framework/Web/UI/JuiControls/TJuiDialog.php

Doc Comments +3 added lines

@@ -158,6 +158,9 @@
 		$this->triggerClientMethod('close');
 	}
 
+	/**
+	 * @param string $method
+	 */
 	private function triggerClientMethod($method)
 	{
 		$cs = $this->getPage()->getClientScript();

Spacing +8 added lines, -8 removed lines

@@ -72,7 +72,7 @@ 
 	 */
 	public function getOptions()
 	{
-		if (($options=$this->getViewState('JuiOptions'))===null)
+		if(($options=$this->getViewState('JuiOptions'))===null)
 		{
 		  $options=new TJuiControlOptions($this);
 		  $this->setViewState('JuiOptions', $options);
@@ -103,14 +103,14 @@ 
 	 */
 	protected function getPostBackOptions()
 	{
-		$options = $this->getOptions()->toArray();
+		$options=$this->getOptions()->toArray();
 		// always make the dialog a child of the form, or its inner inputs won't be collected
 		if(!isset($options['appendTo']))
-			$options['appendTo'] = 'form:first';
+			$options['appendTo']='form:first';
 
 		foreach($this->getControls() as $control)
 			if($control instanceof TJuiDialogButton)
-				$options['buttons'][] = $control->getPostBackOptions();
+				$options['buttons'][]=$control->getPostBackOptions();
 
 		return $options;
 	}
@@ -123,7 +123,7 @@ 
 	{
 		parent::addAttributesToRender($writer);
 
-		$writer->addAttribute('id',$this->getClientID());
+		$writer->addAttribute('id', $this->getClientID());
 		$options=TJavaScript::encode($this->getPostBackOptions());
 		$cs=$this->getPage()->getClientScript();
 		$code="jQuery('#".$this->getWidgetID()."').".$this->getWidget()."(".$options.");";
@@ -144,7 +144,7 @@ 
 	 * Raises the OnCreate event
 	 * @param object $params event parameters
 	 */
-	public function onOpen ($params)
+	public function onOpen($params)
 	{
 		$this->raiseEvent('OnOpen', $this, $params);
 	}
@@ -167,8 +167,8 @@ 
 
 	private function triggerClientMethod($method)
 	{
-		$cs = $this->getPage()->getClientScript();
-		$code = "jQuery(document).ready(function() { jQuery('#".$this->getClientId()."').dialog('".$method."'); })";
+		$cs=$this->getPage()->getClientScript();
+		$code="jQuery(document).ready(function() { jQuery('#".$this->getClientId()."').dialog('".$method."'); })";
 		$cs->registerEndScript(sprintf('%08X', crc32($code)), $code);
 	}
 

Braces +1 added lines, -2 removed lines

@@ -193,8 +193,7 @@
 		{
 		  parent::renderContents($writer);
 			$this->getPage()->getCallbackClient()->replaceContent($this, $writer, false);
-		}
-		else
+		} else
 			parent::render($writer);
 	}
 }