pradosoft / prado

framework/TApplication.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -377,7 +377,7 @@
 					break;
 				}
 				$method = self::$_steps[$this->_step];
-				Prado::trace("Executing $method()", 'Prado\TApplication');
+				Prado::trace("executing $method()", 'Prado\TApplication');
 				$this->$method();
 				$this->_step++;
 			}

Spacing +1 added lines, -1 removed lines

@@ -1235,7 +1235,7 @@
 	public function onEndRequest()
 	{
 		$this->flushOutput(false); // flush all remaining content in the buffer
-		$this->saveGlobals();  // save global state
+		$this->saveGlobals(); // save global state
 		$this->raiseEvent('OnEndRequest', $this, null);
 	}
 }

Doc Comments +4 added lines, -4 removed lines

@@ -411,7 +411,7 @@ 
 	 *
 	 * A global value is one that is persistent across users sessions and requests.
 	 * @param string $key the name of the value to be returned
-	 * @param mixed $defaultValue the default value. If $key is not found, $defaultValue will be returned
+	 * @param integer $defaultValue the default value. If $key is not found, $defaultValue will be returned
 	 * @return mixed the global value corresponding to $key
 	 */
 	public function getGlobalState($key, $defaultValue = null)
@@ -669,7 +669,7 @@ 
 	}
 
 	/**
-	 * @param mixed $id
+	 * @param string $id
 	 * @return IModule the module with the specified ID, null if not found
 	 */
 	public function getModule($id)
@@ -741,7 +741,7 @@ 
 	}
 
 	/**
-	 * @param THttpRequest $response the request module
+	 * @param THttpResponse $response the request module
 	 */
 	public function setResponse(THttpResponse $response)
 	{
@@ -1096,7 +1096,7 @@ 
 	 * Raises OnError event.
 	 * This method is invoked when an exception is raised during the lifecycles
 	 * of the application.
-	 * @param mixed $param event parameter
+	 * @param \Exception $param event parameter
 	 */
 	public function onError($param)
 	{

framework/Data/SqlMap/Statements/TMappedStatement.php

Spacing +3 added lines, -6 removed lines

@@ -236,8 +236,7 @@ 
 	public function runQueryForList($connection, $parameter, $sql, $result, $delegate = null)
 	{
 		$registry = $this->getManager()->getTypeHandlers();
-		$list = $result instanceof \ArrayAccess ? $result :
-							$this->_statement->createInstanceOfListClass($registry);
+		$list = $result instanceof \ArrayAccess ? $result : $this->_statement->createInstanceOfListClass($registry);
 		$connection->setActive(true);
 		$reader = $sql->query();
 		//$reader = $this->executeSQLQueryLimit($connection, $sql, $max, $skip);
@@ -313,8 +312,7 @@ 
 			foreach ($reader as $row) {
 				$obj = $this->applyResultMap($row);
 				$key = TPropertyAccess::get($obj, $keyProperty);
-				$value = ($valueProperty === null) ? $obj :
-							TPropertyAccess::get($obj, $valueProperty);
+				$value = ($valueProperty === null) ? $obj : TPropertyAccess::get($obj, $valueProperty);
 				$param = new TResultSetMapItemParameter($key, $value, $parameter, $map);
 				$this->raiseRowDelegate($delegate, $param);
 			}
@@ -323,8 +321,7 @@ 
 			foreach ($reader as $row) {
 				$obj = $this->applyResultMap($row);
 				$key = TPropertyAccess::get($obj, $keyProperty);
-				$map[$key] = ($valueProperty === null) ? $obj :
-								TPropertyAccess::get($obj, $valueProperty);
+				$map[$key] = ($valueProperty === null) ? $obj : TPropertyAccess::get($obj, $valueProperty);
 			}
 		}
 		$this->onExecuteQuery($command);

Doc Comments +3 added lines, -3 removed lines

@@ -468,7 +468,7 @@ 
 	 * Execute the select key statement, used to obtain last insert ID.
 	 * @param IDbConnection $connection database connection
 	 * @param mixed $parameter insert statement parameter
-	 * @param TSqlMapSelectKey $selectKey select key statement
+	 * @param \Prado\Data\SqlMap\Configuration\TSqlMapSelectKey $selectKey select key statement
 	 * @return string last insert ID.
 	 */
 	protected function executeSelectKey($connection, $parameter, $selectKey)
@@ -595,7 +595,7 @@ 
 	/**
 	 * Apply the result to a TList or an array.
 	 * @param array $row a result set row retrieved from the database
-	 * @param object $resultObject result object, array or list
+	 * @param \ArrayAccess $resultObject result object, array or list
 	 * @return object result filled with data.
 	 */
 	protected function fillResultArrayList($row, $resultObject)
@@ -640,7 +640,7 @@ 
 	 * Fills the result object according to result mappings.
 	 * @param string $resultMapName result map name.
 	 * @param array $row a result set row retrieved from the database
-	 * @param null|mixed $parentGroup
+	 * @param null|string $parentGroup
 	 * @param null|&object $resultObject result object to fill, will create new instances if required.
 	 * @return object result object filled with data.
 	 */

framework/Web/UI/WebControls/TFileUpload.php

Spacing +1 added lines, -1 removed lines

@@ -295,7 +295,7 @@
 	 */
 	public function getValidationPropertyValue()
 	{
-		return implode(',', array_map(function ($file) {
+		return implode(',', array_map(function($file) {
 			return $file->getFileName();
 		}, $this->_files));
 	}

framework/Collections/TList.php

Spacing +1 added lines, -1 removed lines

@@ -226,7 +226,7 @@
 	 */
 	public function clear()
 	{
-		for ($i = $this->_c - 1;$i >= 0;--$i) {
+		for ($i = $this->_c - 1; $i >= 0; --$i) {
 			$this->removeAt($i);
 		}
 	}

framework/I18N/core/Gettext/TGettext.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -127,7 +127,7 @@
 	public static function poFile2moFile($pofile, $mofile)
 	{
 		if (!is_file($pofile)) {
-			throw new Exception("File $pofile doesn't exist.");
+			throw new Exception("file $pofile doesn't exist.");
 		}
 
 		include_once __DIR__ . '/PO.php';

Doc Comments +3 added lines, -3 removed lines

@@ -122,7 +122,7 @@ 
 	 * @access  public
 	 * @param   string  $pofile path to GNU PO file
 	 * @param   string  $mofile path to GNU MO file
-	 * @return  mixed   Returns true on success or PEAR_Error on failure.
+	 * @return  boolean   Returns true on success or PEAR_Error on failure.
 	 */
 	public static function poFile2moFile($pofile, $mofile)
 	{
@@ -262,7 +262,7 @@ 
 	 * toMO
 	 *
 	 * @access  protected
-	 * @return  object  File_Gettext_MO
+	 * @return  TGettext_MO  File_Gettext_MO
 	 */
 	public function toMO()
 	{
@@ -276,7 +276,7 @@ 
 	 * toPO
 	 *
 	 * @access  protected
-	 * @return  object      File_Gettext_PO
+	 * @return  TGettext_PO      File_Gettext_PO
 	 */
 	public function toPO()
 	{

framework/Collections/TPriorityList.php

Spacing +1 added lines, -1 removed lines

@@ -481,7 +481,7 @@
 		}
 
 		foreach ($this->_d as $priority => $items) {
-			for ($index = count($items) - 1;$index >= 0;$index--) {
+			for ($index = count($items) - 1; $index >= 0; $index--) {
 				$this->removeAtIndexInPriority($index, $priority);
 			}
 			unset($this->_d[$priority]);

Doc Comments +6 added lines, -6 removed lines

@@ -84,7 +84,7 @@ 
 	 * Initializes the list with an array or an iterable object.
 	 * @param null|array|Iterator $data the intial data. Default is null, meaning no initial data.
 	 * @param bool $readOnly whether the list is read-only
-	 * @param numeric $defaultPriority the default priority of items without specified priorities.
+	 * @param integer $defaultPriority the default priority of items without specified priorities.
 	 * @param int $precision the precision of the numeric priorities
 	 * @throws TInvalidDataTypeException If data is not null and is neither an array nor an iterator.
 	 */
@@ -146,7 +146,7 @@ 
 
 	/**
 	 * This must be called internally or when instantiated.
-	 * @param numeric $value sets the default priority of inserted items without a specified priority
+	 * @param integer $value sets the default priority of inserted items without a specified priority
 	 */
 	protected function setDefaultPriority($value)
 	{
@@ -173,7 +173,7 @@ 
 	/**
 	 * Returns an iterator for traversing the items in the list.
 	 * This method is required by the interface \IteratorAggregate.
-	 * @return Iterator an iterator for traversing the items in the list.
+	 * @return \ArrayIterator an iterator for traversing the items in the list.
 	 */
 	public function getIterator()
 	{
@@ -386,7 +386,7 @@ 
 	/**
 	 * Removes an item from the priority list.
 	 * The list will search for the item.  The first matching item found will be removed from the list.
-	 * @param mixed $item item the item to be removed.
+	 * @param callable $item item the item to be removed.
 	 * @param null|bool|float $priority priority of item to remove. without this parameter it defaults to false.
 	 * A value of false means any priority. null will be filled in with the default priority.
 	 * @throws TInvalidDataValueException If the item does not exist
@@ -630,7 +630,7 @@ 
 
 	/**
 	 * Combines the map elements which have a priority below the parameter value
-	 * @param numeric $priority the cut-off priority.  All items of priority less than this are returned.
+	 * @param integer $priority the cut-off priority.  All items of priority less than this are returned.
 	 * @param bool $inclusive whether or not the input cut-off priority is inclusive.  Default: false, not inclusive.
 	 * @return array the array of priorities keys with values of arrays of items that are below a specified priority.
 	 *  The priorities are sorted so important priorities, lower numerics, are first.
@@ -650,7 +650,7 @@ 
 
 	/**
 	 * Combines the map elements which have a priority above the parameter value
-	 * @param numeric $priority the cut-off priority.  All items of priority greater than this are returned.
+	 * @param integer $priority the cut-off priority.  All items of priority greater than this are returned.
 	 * @param bool $inclusive whether or not the input cut-off priority is inclusive.  Default: true, inclusive.
 	 * @return array the array of priorities keys with values of arrays of items that are above a specified priority.
 	 *  The priorities are sorted so important priorities, lower numerics, are first.

framework/Web/UI/WebControls/assets/captcha.php

Spacing +10 added lines, -10 removed lines

@@ -62,7 +62,7 @@ 
 	$hexLength = strlen($hex);
 	$base = strlen($alphabet);
 	$result = '';
-	for ($i = 0;$i < $hexLength;$i += 6) {
+	for ($i = 0; $i < $hexLength; $i += 6) {
 		$number = hexdec(substr($hex, $i, 6));
 		while ($number) {
 			$result .= $alphabet[$number % $base];
@@ -106,7 +106,7 @@ 
 	}
 
 	$hasShadow = ($theme & THEME_SHADOWED_TEXT);
-	for ($i = 0;$i < $length;$i++) {
+	for ($i = 0; $i < $length; $i++) {
 		$color = imagecolorallocate($image, rand(150, 220), rand(150, 220), rand(150, 220));
 		$size = rand($fontWidth - 10, $fontWidth);
 		$angle = rand(-30, 30);
@@ -159,8 +159,8 @@ 
 
 function addNoise($image, $width, $height)
 {
-	for ($x = 0;$x < $width;++$x) {
-		for ($y = 0;$y < $height;++$y) {
+	for ($x = 0; $x < $width; ++$x) {
+		for ($y = 0; $y < $height; ++$y) {
 			if (rand(0, 100) < 25) {
 				$color = imagecolorallocate($image, rand(150, 220), rand(150, 220), rand(150, 220));
 				imagesetpixel($image, $x, $y, $color);
@@ -172,13 +172,13 @@ 
 
 function addGrid($image, $width, $height)
 {
-	for ($i = 0;$i < $width;$i += rand(15, 25)) {
+	for ($i = 0; $i < $width; $i += rand(15, 25)) {
 		imagesetthickness($image, rand(2, 6));
 		$color = imagecolorallocate($image, rand(100, 180), rand(100, 180), rand(100, 180));
 		imageline($image, $i + rand(-10, 20), 0, $i + rand(-10, 20), $height, $color);
 		imagecolordeallocate($image, $color);
 	}
-	for ($i = 0;$i < $height;$i += rand(15, 25)) {
+	for ($i = 0; $i < $height; $i += rand(15, 25)) {
 		imagesetthickness($image, rand(2, 6));
 		$color = imagecolorallocate($image, rand(100, 180), rand(100, 180), rand(100, 180));
 		imageline($image, 0, $i + rand(-10, 20), $width, $i + rand(-10, 20), $color);
@@ -188,10 +188,10 @@ 
 
 function addScribble($image, $width, $height)
 {
-	for ($i = 0;$i < 8;$i++) {
+	for ($i = 0; $i < 8; $i++) {
 		$color = imagecolorallocate($image, rand(100, 180), rand(100, 180), rand(100, 180));
 		$points = [];
-		for ($j = 1;$j < rand(5, 10);$j++) {
+		for ($j = 1; $j < rand(5, 10); $j++) {
 			$points[] = rand(2 * (20 * ($i + 1)), 2 * (50 * ($i + 1)));
 			$points[] = rand(30, $height + 30);
 		}
@@ -205,7 +205,7 @@ 
 {
 	$tempImage = imagecreatetruecolor($width, $height);
 	$chunk = rand(1, 5);
-	for ($x = $y = 0;$x < $width;$x += $chunk) {
+	for ($x = $y = 0; $x < $width; $x += $chunk) {
 		$chunk = rand(1, 5);
 		$y += rand(-1, 1);
 		if ($y >= $height) {
@@ -216,7 +216,7 @@ 
 		}
 		imagecopy($tempImage, $image, $x, 0, $x, $y, $chunk, $height);
 	}
-	for ($x = $y = 0;$y < $height;$y += $chunk) {
+	for ($x = $y = 0; $y < $height; $y += $chunk) {
 		$chunk = rand(1, 5);
 		$x += rand(-1, 1);
 		if ($x >= $width) {

framework/Web/UI/TClientScriptManager.php

Spacing +1 added lines, -1 removed lines

@@ -542,7 +542,7 @@
 	public function getStyleSheetUrls()
 	{
 		$stylesheets = array_values(
-			array_map(function ($e) {
+			array_map(function($e) {
 				return is_array($e) ? $e[0] : $e;
 			}, $this->_styleSheetFiles)
 		);

Doc Comments +20 added lines, -5 removed lines

@@ -221,7 +221,7 @@ 
 	}
 
 	/**
-	 * @param mixed $script
+	 * @param string $script
 	 * @return string Prado javascript library base asset url.
 	 */
 	public function getPradoScriptAssetUrl($script = 'prado')
@@ -236,7 +236,7 @@ 
 	}
 
 	/**
-	 * @param mixed $script
+	 * @param string $script
 	 * @return string Prado javascript library base asset path in local filesystem.
 	 */
 	public function getPradoScriptAssetPath($script = 'prado')
@@ -265,7 +265,7 @@ 
 
 	/**
 	 * @param string $base javascript or css package path.
-	 * @return array tuple($path,$url).
+	 * @return string[] tuple($path,$url).
 	 */
 	protected function getPackagePathUrl($base)
 	{
@@ -446,7 +446,7 @@ 
 
 	/**
 	 * Registers a Prado style library to be loaded.
-	 * @param mixed $name
+	 * @param string $name
 	 */
 	protected function registerPradoStyleInternal($name)
 	{
@@ -784,11 +784,17 @@ 
 		$writer->write(TJavaScript::renderScriptBlocks($this->_headScripts));
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	public function renderScriptFilesBegin($writer)
 	{
 		$this->renderAllPendingScriptFiles($writer);
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	public function renderScriptFilesEnd($writer)
 	{
 		$this->renderAllPendingScriptFiles($writer);
@@ -801,6 +807,9 @@ 
 		$this->_page->registerCachingAction('Page.ClientScript', 'markScriptFileAsRendered', $params);
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	protected function renderScriptFiles($writer, array $scripts)
 	{
 		foreach ($scripts as $script) {
@@ -857,11 +866,17 @@ 
 		$writer->write(TJavaScript::renderScriptBlocksCallback($this->_endScripts));
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	public function renderHiddenFieldsBegin($writer)
 	{
 		$this->renderHiddenFieldsInt($writer, true);
 	}
 
+	/**
+	 * @param THtmlWriter $writer
+	 */
 	public function renderHiddenFieldsEnd($writer)
 	{
 		$this->renderHiddenFieldsInt($writer, false);
@@ -886,7 +901,7 @@ 
 	 * Unfortunately this attribute is invalid for hidden fields, so text fields are
 	 * rendered instead (#642).
 	 * @param THtmlWriter $writer writer for the rendering purpose
-	 * @param mixed $initial
+	 * @param boolean $initial
 	 */
 
 	protected function renderHiddenFieldsInt($writer, $initial)

framework/Collections/TAttributeCollection.php

Doc Comments +3 added lines, -3 removed lines

@@ -103,7 +103,7 @@ 
 	/**
 	 * Returns the item with the specified key.
 	 * This overrides the parent implementation by converting the key to lower case first if CaseSensitive is false.
-	 * @param mixed $key the key
+	 * @param string $key the key
 	 * @return mixed the element at the offset, null if no element is found at the offset
 	 */
 	public function itemAt($key)
@@ -115,7 +115,7 @@ 
 	/**
 	 * Adds an item into the map.
 	 * This overrides the parent implementation by converting the key to lower case first if CaseSensitive is false.
-	 * @param mixed $key
+	 * @param string $key
 	 * @param mixed $value
 	 */
 	public function add($key, $value)
@@ -126,7 +126,7 @@ 
 	/**
 	 * Removes an item from the map by its key.
 	 * This overrides the parent implementation by converting the key to lower case first if CaseSensitive is false.
-	 * @param mixed $key the key of the item to be removed
+	 * @param string $key the key of the item to be removed
 	 * @return mixed the removed value, null if no such key exists.
 	 */
 	public function remove($key)