| Total Complexity | 70 |
| Total Lines | 488 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like MessageSource_XLIFF often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MessageSource_XLIFF, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 40 | class MessageSource_XLIFF extends MessageSource |
||
| 41 | { |
||
| 42 | /** |
||
| 43 | * Message data filename extension. |
||
| 44 | * @var string |
||
| 45 | */ |
||
| 46 | protected $dataExt = '.xml'; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Separator between culture name and source. |
||
| 50 | * @var string |
||
| 51 | */ |
||
| 52 | protected $dataSeparator = '.'; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * Constructor. |
||
| 56 | * @param string the directory where the messages are stored. |
||
|
|
|||
| 57 | * @see MessageSource::factory(); |
||
| 58 | */ |
||
| 59 | public function __construct($source) |
||
| 60 | { |
||
| 61 | $this->source = (string)$source; |
||
| 62 | } |
||
| 63 | |||
| 64 | /** |
||
| 65 | * Load the messages from a XLIFF file. |
||
| 66 | * @param string XLIFF file. |
||
| 67 | * @return array of messages. |
||
| 68 | */ |
||
| 69 | protected function &loadData($filename) |
||
| 70 | { |
||
| 71 | //load it. |
||
| 72 | if(false === ($XML = simplexml_load_file($filename))) { |
||
| 73 | return false; |
||
| 74 | } |
||
| 75 | |||
| 76 | $translationUnit = $XML->xpath('//trans-unit'); |
||
| 77 | |||
| 78 | $translations = []; |
||
| 79 | |||
| 80 | foreach($translationUnit as $unit) |
||
| 81 | { |
||
| 82 | $source = (string)$unit->source; |
||
| 83 | $translations[$source][] = (string)$unit->target; |
||
| 84 | $translations[$source][] = (string)$unit['id']; |
||
| 85 | $translations[$source][] = (string)$unit->note; |
||
| 86 | } |
||
| 87 | |||
| 88 | return $translations; |
||
| 89 | } |
||
| 90 | |||
| 91 | /** |
||
| 92 | * Get the last modified unix-time for this particular catalogue+variant. |
||
| 93 | * Just use the file modified time. |
||
| 94 | * @param string catalogue+variant |
||
| 95 | * @return int last modified in unix-time format. |
||
| 96 | */ |
||
| 97 | protected function getLastModified($source) |
||
| 98 | { |
||
| 99 | return is_file($source) ? filemtime($source) : 0; |
||
| 100 | } |
||
| 101 | |||
| 102 | /** |
||
| 103 | * Get the XLIFF file for a specific message catalogue and cultural |
||
| 104 | * vairant. |
||
| 105 | * @param string message catalogue |
||
| 106 | * @return string full path to the XLIFF file. |
||
| 107 | */ |
||
| 108 | protected function getSource($variant) |
||
| 109 | { |
||
| 110 | return $this->source . '/' . $variant; |
||
| 111 | } |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Determin if the XLIFF file source is valid. |
||
| 115 | * @param string XLIFF file |
||
| 116 | * @return boolean true if valid, false otherwise. |
||
| 117 | */ |
||
| 118 | protected function isValidSource($source) |
||
| 119 | { |
||
| 120 | return is_file($source); |
||
| 121 | } |
||
| 122 | |||
| 123 | /** |
||
| 124 | * Get all the variants of a particular catalogue. |
||
| 125 | * @param string catalogue name |
||
| 126 | * @return array list of all variants for this catalogue. |
||
| 127 | */ |
||
| 128 | protected function getCatalogueList($catalogue) |
||
| 129 | { |
||
| 130 | $variants = explode('_', $this->culture); |
||
| 131 | $source = $catalogue . $this->dataExt; |
||
| 132 | $catalogues = [$source]; |
||
| 133 | $variant = null; |
||
| 134 | |||
| 135 | for($i = 0, $k = count($variants); $i < $k; ++$i) |
||
| 136 | { |
||
| 137 | if(isset($variants[$i]{0})) |
||
| 138 | { |
||
| 139 | $variant .= ($variant)?'_' . $variants[$i]:$variants[$i]; |
||
| 140 | $catalogues[] = $catalogue . $this->dataSeparator . $variant . $this->dataExt; |
||
| 141 | } |
||
| 142 | } |
||
| 143 | |||
| 144 | $byDir = $this->getCatalogueByDir($catalogue); |
||
| 145 | $catalogues = array_merge($byDir, array_reverse($catalogues)); |
||
| 146 | $files = []; |
||
| 147 | |||
| 148 | foreach($catalogues as $file) |
||
| 149 | { |
||
| 150 | $files[] = $file; |
||
| 151 | $files[] = preg_replace('/\.xml$/', '.xlf', $file); |
||
| 152 | } |
||
| 153 | |||
| 154 | return $files; |
||
| 155 | } |
||
| 156 | |||
| 157 | /** |
||
| 158 | * Traverse through the directory structure to find the catalogues. |
||
| 159 | * This should only be called by getCatalogueList() |
||
| 160 | * @param string a particular catalogue. |
||
| 161 | * @return array a list of catalogues. |
||
| 162 | * @see getCatalogueList() |
||
| 163 | */ |
||
| 164 | private function getCatalogueByDir($catalogue) |
||
| 165 | { |
||
| 166 | $variants = explode('_', $this->culture); |
||
| 167 | $catalogues = []; |
||
| 168 | $variant = null; |
||
| 169 | |||
| 170 | for($i = 0, $k = count($variants); $i < $k; ++$i) |
||
| 171 | { |
||
| 172 | if(isset($variants[$i]{0})) |
||
| 173 | { |
||
| 174 | $variant .= ($variant)?'_' . $variants[$i]:$variants[$i]; |
||
| 175 | $catalogues[] = $variant . '/' . $catalogue . $this->dataExt; |
||
| 176 | } |
||
| 177 | } |
||
| 178 | |||
| 179 | return array_reverse($catalogues); |
||
| 180 | } |
||
| 181 | |||
| 182 | /** |
||
| 183 | * Returns a list of catalogue and its culture ID. |
||
| 184 | * E.g. array('messages','en_AU') |
||
| 185 | * @return array list of catalogues |
||
| 186 | * @see getCatalogues() |
||
| 187 | */ |
||
| 188 | public function catalogues() |
||
| 189 | { |
||
| 190 | return $this->getCatalogues(); |
||
| 191 | } |
||
| 192 | |||
| 193 | /** |
||
| 194 | * Returns a list of catalogue and its culture ID. This takes care |
||
| 195 | * of directory structures. |
||
| 196 | * E.g. array('messages','en_AU') |
||
| 197 | * @return array list of catalogues |
||
| 198 | */ |
||
| 199 | protected function getCatalogues($dir = null, $variant = null) |
||
| 200 | { |
||
| 201 | $dir = $dir?$dir:$this->source; |
||
| 202 | $files = scandir($dir); |
||
| 203 | $catalogue = []; |
||
| 204 | |||
| 205 | foreach($files as $file) |
||
| 206 | { |
||
| 207 | if(is_dir($dir . '/' . $file) && preg_match('/^[a-z]{2}(_[A-Z]{2,3})?$/', $file)) { |
||
| 208 | $catalogue = array_merge( |
||
| 209 | $catalogue, |
||
| 210 | $this->getCatalogues($dir . '/' . $file, $file) |
||
| 211 | ); |
||
| 212 | } |
||
| 213 | |||
| 214 | $pos = strpos($file, $this->dataExt); |
||
| 215 | if($pos > 0 && substr($file, -1 * strlen($this->dataExt)) == $this->dataExt) |
||
| 216 | { |
||
| 217 | $name = substr($file, 0, $pos); |
||
| 218 | $dot = strrpos($name, $this->dataSeparator); |
||
| 219 | $culture = $variant; |
||
| 220 | $cat = $name; |
||
| 221 | |||
| 222 | if(is_int($dot)) |
||
| 223 | { |
||
| 224 | $culture = substr($name, $dot + 1, strlen($name)); |
||
| 225 | $cat = substr($name, 0, $dot); |
||
| 226 | } |
||
| 227 | |||
| 228 | $details[0] = $cat; |
||
| 229 | $details[1] = $culture; |
||
| 230 | $catalogue[] = $details; |
||
| 231 | } |
||
| 232 | } |
||
| 233 | sort($catalogue); |
||
| 234 | return $catalogue; |
||
| 235 | } |
||
| 236 | |||
| 237 | /** |
||
| 238 | * Get the variant for a catalogue depending on the current culture. |
||
| 239 | * @param string catalogue |
||
| 240 | * @return string the variant. |
||
| 241 | * @see save() |
||
| 242 | * @see update() |
||
| 243 | * @see delete() |
||
| 244 | */ |
||
| 245 | private function getVariants($catalogue = 'messages') |
||
| 259 | } |
||
| 260 | |||
| 261 | /** |
||
| 262 | * Save the list of untranslated blocks to the translation source. |
||
| 263 | * If the translation was not found, you should add those |
||
| 264 | * strings to the translation source via the <b>append()</b> method. |
||
| 265 | * @param string the catalogue to add to |
||
| 266 | * @return boolean true if saved successfuly, false otherwise. |
||
| 267 | */ |
||
| 268 | public function save($catalogue = 'messages') |
||
| 269 | { |
||
| 270 | $messages = $this->untranslated; |
||
| 271 | if(count($messages) <= 0) { |
||
| 272 | return false; |
||
| 273 | } |
||
| 274 | |||
| 275 | $variants = $this->getVariants($catalogue); |
||
| 276 | |||
| 277 | if($variants) { |
||
| 278 | list($variant, $filename) = $variants; |
||
| 279 | } else { |
||
| 280 | list($variant, $filename) = $this->createMessageTemplate($catalogue); |
||
| 281 | } |
||
| 282 | |||
| 283 | if(is_writable($filename) == false) { |
||
| 284 | throw new TIOException("Unable to save to file {$filename}, file must be writable."); |
||
| 285 | } |
||
| 286 | |||
| 287 | //create a new dom, import the existing xml |
||
| 288 | $dom = new DOMDocument(); |
||
| 289 | $dom->load($filename); |
||
| 290 | |||
| 291 | //find the body element |
||
| 292 | $xpath = new DomXPath($dom); |
||
| 293 | $body = $xpath->query('//body')->item(0); |
||
| 294 | |||
| 295 | $lastNodes = $xpath->query('//trans-unit[last()]'); |
||
| 296 | if(($last = $lastNodes->item(0)) !== null) { |
||
| 297 | $count = (int)$last->getAttribute('id'); |
||
| 298 | } else { |
||
| 299 | $count = 0; |
||
| 300 | } |
||
| 301 | |||
| 302 | //for each message add it to the XML file using DOM |
||
| 303 | foreach($messages as $message) |
||
| 304 | { |
||
| 305 | $unit = $dom->createElement('trans-unit'); |
||
| 306 | $unit->setAttribute('id', ++$count); |
||
| 307 | |||
| 308 | $source = $dom->createElement('source'); |
||
| 309 | $source->appendChild($dom->createCDATASection($message)); |
||
| 310 | |||
| 311 | $target = $dom->createElement('target'); |
||
| 312 | $target->appendChild($dom->createCDATASection('')); |
||
| 313 | |||
| 314 | $unit->appendChild($dom->createTextNode("\n")); |
||
| 315 | $unit->appendChild($source); |
||
| 316 | $unit->appendChild($dom->createTextNode("\n")); |
||
| 317 | $unit->appendChild($target); |
||
| 318 | $unit->appendChild($dom->createTextNode("\n")); |
||
| 319 | |||
| 320 | $body->appendChild($dom->createTextNode("\n")); |
||
| 321 | $body->appendChild($unit); |
||
| 322 | $body->appendChild($dom->createTextNode("\n")); |
||
| 323 | } |
||
| 324 | |||
| 325 | |||
| 326 | $fileNode = $xpath->query('//file')->item(0); |
||
| 327 | $fileNode->setAttribute('date', @date('Y-m-d\TH:i:s\Z')); |
||
| 328 | |||
| 329 | //save it and clear the cache for this variant |
||
| 330 | $dom->save($filename); |
||
| 331 | if(!empty($this->cache)) { |
||
| 332 | $this->cache->clean($variant, $this->culture); |
||
| 333 | } |
||
| 334 | |||
| 335 | return true; |
||
| 336 | } |
||
| 337 | |||
| 338 | /** |
||
| 339 | * Update the translation. |
||
| 340 | * @param string the source string. |
||
| 341 | * @param string the new translation string. |
||
| 342 | * @param string comments |
||
| 343 | * @param string the catalogue to save to. |
||
| 344 | * @return boolean true if translation was updated, false otherwise. |
||
| 345 | */ |
||
| 346 | public function update($text, $target, $comments, $catalogue = 'messages') |
||
| 347 | { |
||
| 348 | $variants = $this->getVariants($catalogue); |
||
| 349 | |||
| 350 | if($variants) { |
||
| 351 | list($variant, $filename) = $variants; |
||
| 352 | } else { |
||
| 353 | return false; |
||
| 354 | } |
||
| 355 | |||
| 356 | if(is_writable($filename) == false) { |
||
| 357 | throw new TIOException("Unable to update file {$filename}, file must be writable."); |
||
| 358 | } |
||
| 359 | |||
| 360 | //create a new dom, import the existing xml |
||
| 361 | $dom = DOMDocument::load($filename); |
||
| 362 | |||
| 363 | //find the body element |
||
| 364 | $xpath = new DomXPath($dom); |
||
| 365 | $units = $xpath->query('//trans-unit'); |
||
| 366 | |||
| 367 | //for each of the existin units |
||
| 368 | foreach($units as $unit) |
||
| 369 | { |
||
| 370 | $found = false; |
||
| 371 | $targetted = false; |
||
| 372 | $commented = false; |
||
| 373 | |||
| 374 | //in each unit, need to find the source, target and comment nodes |
||
| 375 | //it will assume that the source is before the target. |
||
| 376 | foreach($unit->childNodes as $node) |
||
| 377 | { |
||
| 378 | //source node |
||
| 379 | if($node->nodeName == 'source' && $node->firstChild->wholeText == $text) { |
||
| 380 | $found = true; |
||
| 381 | } |
||
| 382 | |||
| 383 | //found source, get the target and notes |
||
| 384 | if($found) |
||
| 385 | { |
||
| 386 | //set the new translated string |
||
| 387 | if($node->nodeName == 'target') |
||
| 388 | { |
||
| 389 | $node->nodeValue = $target; |
||
| 390 | $targetted = true; |
||
| 391 | } |
||
| 392 | |||
| 393 | //set the notes |
||
| 394 | if(!empty($comments) && $node->nodeName == 'note') |
||
| 395 | { |
||
| 396 | $node->nodeValue = $comments; |
||
| 397 | $commented = true; |
||
| 398 | } |
||
| 399 | } |
||
| 400 | } |
||
| 401 | |||
| 402 | //append a target |
||
| 403 | if($found && !$targetted) { |
||
| 404 | $unit->appendChild($dom->createElement('target', $target)); |
||
| 405 | } |
||
| 406 | |||
| 407 | //append a note |
||
| 408 | if($found && !$commented && !empty($comments)) { |
||
| 409 | $unit->appendChild($dom->createElement('note', $comments)); |
||
| 410 | } |
||
| 411 | |||
| 412 | //finished searching |
||
| 413 | if($found) { |
||
| 414 | break; |
||
| 415 | } |
||
| 416 | } |
||
| 417 | |||
| 418 | $fileNode = $xpath->query('//file')->item(0); |
||
| 419 | $fileNode->setAttribute('date', @date('Y-m-d\TH:i:s\Z')); |
||
| 420 | |||
| 421 | if($dom->save($filename) > 0) |
||
| 422 | { |
||
| 423 | if(!empty($this->cache)) { |
||
| 424 | $this->cache->clean($variant, $this->culture); |
||
| 425 | } |
||
| 426 | |||
| 427 | return true; |
||
| 428 | } |
||
| 429 | |||
| 430 | return false; |
||
| 431 | } |
||
| 432 | |||
| 433 | /** |
||
| 434 | * Delete a particular message from the specified catalogue. |
||
| 435 | * @param string the source message to delete. |
||
| 436 | * @param string the catalogue to delete from. |
||
| 437 | * @return boolean true if deleted, false otherwise. |
||
| 438 | */ |
||
| 439 | public function delete($message, $catalogue = 'messages') |
||
| 440 | { |
||
| 441 | $variants = $this->getVariants($catalogue); |
||
| 442 | if($variants) { |
||
| 443 | list($variant, $filename) = $variants; |
||
| 444 | } else { |
||
| 445 | return false; |
||
| 446 | } |
||
| 447 | |||
| 448 | if(is_writable($filename) == false) { |
||
| 449 | throw new TIOException("Unable to modify file {$filename}, file must be writable."); |
||
| 450 | } |
||
| 451 | |||
| 452 | //create a new dom, import the existing xml |
||
| 453 | $dom = DOMDocument::load($filename); |
||
| 454 | |||
| 455 | //find the body element |
||
| 456 | $xpath = new DomXPath($dom); |
||
| 457 | $units = $xpath->query('//trans-unit'); |
||
| 458 | |||
| 459 | //for each of the existin units |
||
| 460 | foreach($units as $unit) |
||
| 461 | { |
||
| 462 | //in each unit, need to find the source, target and comment nodes |
||
| 463 | //it will assume that the source is before the target. |
||
| 464 | foreach($unit->childNodes as $node) |
||
| 465 | { |
||
| 466 | //source node |
||
| 467 | if($node->nodeName == 'source' && $node->firstChild->wholeText == $message) |
||
| 468 | { |
||
| 469 | //we found it, remove and save the xml file. |
||
| 470 | $unit->parentNode->removeChild($unit); |
||
| 471 | $fileNode = $xpath->query('//file')->item(0); |
||
| 472 | $fileNode->setAttribute('date', @date('Y-m-d\TH:i:s\Z')); |
||
| 473 | |||
| 474 | if(false !== $dom->save($filename)) { |
||
| 475 | if(!empty($this->cache)) { |
||
| 476 | $this->cache->clean($variant, $this->culture); |
||
| 477 | } |
||
| 478 | return true; |
||
| 479 | } |
||
| 480 | |||
| 481 | return false; |
||
| 482 | } |
||
| 483 | } |
||
| 484 | } |
||
| 485 | |||
| 486 | return false; |
||
| 487 | } |
||
| 488 | |||
| 489 | protected function createMessageTemplate($catalogue) |
||
| 513 | } |
||
| 514 | |||
| 515 | protected function getTemplate($catalogue) |
||
| 516 | { |
||
| 517 | $date = @date('c'); |
||
| 518 | $xml = <<<EOD |
||
| 519 | <?xml version="1.0" encoding="UTF-8"?> |
||
| 520 | <xliff version="1.0"> |
||
| 521 | <file source-language="EN" target-language="{$this->culture}" datatype="plaintext" original="$catalogue" date="$date" product-name="$catalogue"> |
||
| 522 | <body> |
||
| 530 |
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths