pradosoft / prado

framework/Web/THttpCookieCollection.php

Braces +16 added lines, -12 removed lines

@@ -57,11 +57,12 @@ 
 		if($item instanceof THttpCookie)
 		{
 			parent::insertAt($index, $item);
-			if($this->_o instanceof THttpResponse)
-				$this->_o->addCookie($item);
+			if($this->_o instanceof THttpResponse) {
+							$this->_o->addCookie($item);
+			}
+		} else {
+					throw new TInvalidDataTypeException('httpcookiecollection_httpcookie_required');
 		}
-		else
-			throw new TInvalidDataTypeException('httpcookiecollection_httpcookie_required');
 	}
 
 	/**
@@ -74,8 +75,9 @@ 
 	public function removeAt($index)
 	{
 		$item = parent::removeAt($index);
-		if($this->_o instanceof THttpResponse)
-			$this->_o->removeCookie($item);
+		if($this->_o instanceof THttpResponse) {
+					$this->_o->removeCookie($item);
+		}
 		return $item;
 	}
 
@@ -85,10 +87,11 @@ 
 	 */
 	public function itemAt($index)
 	{
-		if(is_int($index))
-			return parent::itemAt($index);
-		else
-			return $this->findCookieByName($index);
+		if(is_int($index)) {
+					return parent::itemAt($index);
+		} else {
+					return $this->findCookieByName($index);
+		}
 	}
 
 	/**
@@ -98,9 +101,10 @@ 
 	 */
 	public function findCookieByName($name)
 	{
-		foreach($this as $cookie)
-			if($cookie->getName() === $name)
+		foreach($this as $cookie) {
+					if($cookie->getName() === $name)
 				return $cookie;
+		}
 		return null;
 	}
 }
\ No newline at end of file

framework/Web/UI/TControlCollection.php

Braces +10 added lines, -8 removed lines

@@ -64,11 +64,11 @@ 
 		{
 			parent::insertAt($index, $item);
 			$this->_o->addedControl($item);
+		} elseif(is_string($item) || ($item instanceof IRenderable)) {
+					parent::insertAt($index, $item);
+		} else {
+					throw new TInvalidDataTypeException('controlcollection_control_required');
 		}
-		elseif(is_string($item) || ($item instanceof IRenderable))
-			parent::insertAt($index, $item);
-		else
-			throw new TInvalidDataTypeException('controlcollection_control_required');
 	}
 
 	/**
@@ -81,8 +81,9 @@ 
 	public function removeAt($index)
 	{
 		$item = parent::removeAt($index);
-		if($item instanceof TControl)
-			$this->_o->removedControl($item);
+		if($item instanceof TControl) {
+					$this->_o->removedControl($item);
+		}
 		return $item;
 	}
 
@@ -92,7 +93,8 @@ 
 	public function clear()
 	{
 		parent::clear();
-		if($this->_o instanceof INamingContainer)
-			$this->_o->clearNamingContainer();
+		if($this->_o instanceof INamingContainer) {
+					$this->_o->clearNamingContainer();
+		}
 	}
 }
\ No newline at end of file

framework/Web/UI/TTheme.php

Braces +50 added lines, -40 removed lines

@@ -97,28 +97,29 @@ 
 				list($skins, $cssFiles, $jsFiles, $timestamp) = $array;
 				if($this->getApplication()->getMode() !== TApplicationMode::Performance)
 				{
-					if(($dir = opendir($themePath)) === false)
-						throw new TIOException('theme_path_inexistent', $themePath);
+					if(($dir = opendir($themePath)) === false) {
+											throw new TIOException('theme_path_inexistent', $themePath);
+					}
 					$cacheValid = true;
 					while(($file = readdir($dir)) !== false)
 					{
-						if($file === '.' || $file === '..')
-							continue;
-						elseif(basename($file, '.css') !== $file)
-							$this->_cssFiles[] = $themeUrl . '/' . $file;
-						elseif(basename($file, '.js') !== $file)
-							$this->_jsFiles[] = $themeUrl . '/' . $file;
-						elseif(basename($file, self::SKIN_FILE_EXT) !== $file && filemtime($themePath . DIRECTORY_SEPARATOR . $file) > $timestamp)
+						if($file === '.' || $file === '..') {
+													continue;
+						} elseif(basename($file, '.css') !== $file) {
+													$this->_cssFiles[] = $themeUrl . '/' . $file;
+						} elseif(basename($file, '.js') !== $file) {
+													$this->_jsFiles[] = $themeUrl . '/' . $file;
+						} elseif(basename($file, self::SKIN_FILE_EXT) !== $file && filemtime($themePath . DIRECTORY_SEPARATOR . $file) > $timestamp)
 						{
 							$cacheValid = false;
 							break;
 						}
 					}
 					closedir($dir);
-					if($cacheValid)
-						$this->_skins = $skins;
-				}
-				else
+					if($cacheValid) {
+											$this->_skins = $skins;
+					}
+				} else
 				{
 					$cacheValid = true;
 					$this->_cssFiles = $cssFiles;
@@ -132,30 +133,34 @@ 
 			$this->_cssFiles = [];
 			$this->_jsFiles = [];
 			$this->_skins = [];
-			if(($dir = opendir($themePath)) === false)
-				throw new TIOException('theme_path_inexistent', $themePath);
+			if(($dir = opendir($themePath)) === false) {
+							throw new TIOException('theme_path_inexistent', $themePath);
+			}
 			while(($file = readdir($dir)) !== false)
 			{
-				if($file === '.' || $file === '..')
-					continue;
-				elseif(basename($file, '.css') !== $file)
-					$this->_cssFiles[] = $themeUrl . '/' . $file;
-				elseif(basename($file, '.js') !== $file)
-					$this->_jsFiles[] = $themeUrl . '/' . $file;
-				elseif(basename($file, self::SKIN_FILE_EXT) !== $file)
+				if($file === '.' || $file === '..') {
+									continue;
+				} elseif(basename($file, '.css') !== $file) {
+									$this->_cssFiles[] = $themeUrl . '/' . $file;
+				} elseif(basename($file, '.js') !== $file) {
+									$this->_jsFiles[] = $themeUrl . '/' . $file;
+				} elseif(basename($file, self::SKIN_FILE_EXT) !== $file)
 				{
 					$template = new TTemplate(file_get_contents($themePath . '/' . $file), $themePath, $themePath . '/' . $file);
 					foreach($template->getItems() as $skin)
 					{
-						if(!isset($skin[2]))  // a text string, ignored
+						if(!isset($skin[2])) {
+							// a text string, ignored
 							continue;
-						elseif($skin[0] !== -1)
-							throw new TConfigurationException('theme_control_nested', $skin[1], dirname($themePath));
+						} elseif($skin[0] !== -1) {
+													throw new TConfigurationException('theme_control_nested', $skin[1], dirname($themePath));
+						}
 						$type = $skin[1];
 						$id = isset($skin[2]['skinid'])?$skin[2]['skinid']:0;
 						unset($skin[2]['skinid']);
-						if(isset($this->_skins[$type][$id]))
-							throw new TConfigurationException('theme_skinid_duplicated', $type, $id, dirname($themePath));
+						if(isset($this->_skins[$type][$id])) {
+													throw new TConfigurationException('theme_skinid_duplicated', $type, $id, dirname($themePath));
+						}
 						/*
 						foreach($skin[2] as $name=>$value)
 						{
@@ -170,8 +175,9 @@ 
 			closedir($dir);
 			sort($this->_cssFiles);
 			sort($this->_jsFiles);
-			if($cache !== null)
-				$cache->set(self::THEME_CACHE_PREFIX . $themePath, [$this->_skins,$this->_cssFiles,$this->_jsFiles,time()]);
+			if($cache !== null) {
+							$cache->set(self::THEME_CACHE_PREFIX . $themePath, [$this->_skins,$this->_cssFiles,$this->_jsFiles,time()]);
+			}
 		}
 	}
 
@@ -251,8 +257,9 @@ 
 	public function applySkin($control)
 	{
 		$type = get_class($control);
-		if(($id = $control->getSkinID()) === '')
-			$id = 0;
+		if(($id = $control->getSkinID()) === '') {
+					$id = 0;
+		}
 		if(isset($this->_skins[$type][$id]))
 		{
 			foreach($this->_skins[$type][$id] as $name => $value)
@@ -287,29 +294,32 @@ 
 				}
 				if(!is_array($value))
 				{
-					if(strpos($name, '.') === false)	// is simple property or custom attribute
+					if(strpos($name, '.') === false) {
+						// is simple property or custom attribute
 					{
 						if($control->hasProperty($name))
 						{
 							if($control->canSetProperty($name))
 							{
 								$setter = 'set' . $name;
+					}
 								$control->$setter($value);
+							} else {
+															throw new TConfigurationException('theme_property_readonly', $type, $name);
 							}
-							else
-								throw new TConfigurationException('theme_property_readonly', $type, $name);
+						} else {
+													throw new TConfigurationException('theme_property_undefined', $type, $name);
 						}
-						else
-							throw new TConfigurationException('theme_property_undefined', $type, $name);
-					}
-					else	// complex property
+					} else {
+						// complex property
 						$control->setSubProperty($name, $value);
+					}
 				}
 			}
 			return true;
+		} else {
+					return false;
 		}
-		else
-			return false;
 	}
 
 	/**

framework/Web/UI/ActiveControls/TActiveTableRow.php

Braces +20 added lines, -13 removed lines

@@ -121,8 +121,9 @@ 
 		{
 			$this->raiseCallbackEvent($param);
 			return true;
+		} else {
+			return false;
 		}
-		else return false;
 	}
 
 	/**
@@ -147,8 +148,9 @@ 
 	{
 		parent::addAttributesToRender($writer);
 		$writer->addAttribute('id', $this->getClientID());
-		if ($this->hasEventHandler('OnRowSelected'))
-			$this->getActiveControl()->registerCallbackClientScript($this->getClientClassName(), $this->getPostBackOptions());
+		if ($this->hasEventHandler('OnRowSelected')) {
+					$this->getActiveControl()->registerCallbackClientScript($this->getClientClassName(), $this->getPostBackOptions());
+		}
 	}
 
 	/**
@@ -163,18 +165,19 @@ 
 		if ($this->getHasPreRendered())
 		{
 			parent::render($writer);
-			if ($this->getActiveControl()->canUpdateClientSide())
-				$this->getPage()->getCallbackClient()->replaceContent($this, $writer);
-		}
-		else
+			if ($this->getActiveControl()->canUpdateClientSide()) {
+							$this->getPage()->getCallbackClient()->replaceContent($this, $writer);
+			}
+		} else
 		{
 			$this->getPage()->getAdapter()->registerControlToRender($this, $writer);
 			// If we update a TActiveTableRow on callback, we shouldn't update all childs,
 			// because the whole content will be replaced by the parent.
 			if ($this->getHasControls())
 			{
-				foreach ($this->findControlsByType('Prado\Web\UI\ActiveControls\IActiveControl', false) as $control)
-					$control->getActiveControl()->setEnableUpdate(false);
+				foreach ($this->findControlsByType('Prado\Web\UI\ActiveControls\IActiveControl', false) as $control) {
+									$control->getActiveControl()->setEnableUpdate(false);
+				}
 			}
 		}
 	}
@@ -199,8 +202,9 @@ 
 	 */
 	public function getRowIndex()
 	{
-		foreach ($this->getTable()->getRows() as $key => $row)
-			if ($row == $this) return $key;
+		foreach ($this->getTable()->getRows() as $key => $row) {
+					if ($row == $this) return $key;
+		}
 		throw new TConfigurationException('tactivetablerow_control_notincollection', get_class($this), $this->getUniqueID());
 	}
 
@@ -218,8 +222,11 @@ 
 			{
 				$table = $table->getParent();
 			}
-			if ($table instanceof TTable) $this->_table = $table;
-			else throw new TConfigurationException('tactivetablerow_control_outoftable', get_class($this), $this->getUniqueID());
+			if ($table instanceof TTable) {
+				$this->_table = $table;
+			} else {
+				throw new TConfigurationException('tactivetablerow_control_outoftable', get_class($this), $this->getUniqueID());
+			}
 		}
 		return $this->_table;
 	}

framework/Web/UI/ActiveControls/TActiveEditCommandColumn.php

Braces +12 added lines, -11 removed lines

@@ -36,20 +36,21 @@
  */
 class TActiveEditCommandColumn extends TEditCommandColumn {
 	protected function createButton($commandName, $text, $causesValidation, $validationGroup) {
-		if($this->getButtonType() === TButtonColumnType::LinkButton)
-			$button = new TActiveLinkButton;
-		elseif($this->getButtonType() === TButtonColumnType::PushButton)
-				$button = new TActiveButton;
-			else  // image buttons
+		if($this->getButtonType() === TButtonColumnType::LinkButton) {
+					$button = new TActiveLinkButton;
+		} elseif($this->getButtonType() === TButtonColumnType::PushButton) {
+						$button = new TActiveButton;
+		} else  // image buttons
 			{
 				$button = new TActiveImageButton;
 				$button->setToolTip($text);
-				if(strcasecmp($commandName, 'Update') === 0)
-					$url = $this->getUpdateImageUrl();
-				elseif(strcasecmp($commandName, 'Cancel') === 0)
-						$url = $this->getCancelImageUrl();
-					else
-						$url = $this->getEditImageUrl();
+				if(strcasecmp($commandName, 'Update') === 0) {
+									$url = $this->getUpdateImageUrl();
+				} elseif(strcasecmp($commandName, 'Cancel') === 0) {
+										$url = $this->getCancelImageUrl();
+				} else {
+											$url = $this->getEditImageUrl();
+					}
 				$button->setImageUrl($url);
 			}
 		$button->setText($text);

framework/Web/UI/ActiveControls/TCallbackResponseAdapter.php

Braces +6 added lines, -4 removed lines

@@ -59,8 +59,9 @@ 
 	 */
 	public function flushContent()
 	{
-		foreach($this->_writers as $writer)
-			echo $writer->flush();
+		foreach($this->_writers as $writer) {
+					echo $writer->flush();
+		}
 		parent::flushContent();
 	}
 
@@ -86,8 +87,9 @@ 
 	 */
 	public function httpRedirect($url)
 	{
-		if($url[0] === '/')
-			$url = $this->getRequest()->getBaseUrl() . $url;
+		if($url[0] === '/') {
+					$url = $this->getRequest()->getBaseUrl() . $url;
+		}
 		$this->_redirectUrl = str_replace('&', '&', $url);
 	}
 

framework/Web/UI/ActiveControls/TActiveControlAdapter.php

Braces +7 added lines, -6 removed lines

@@ -72,13 +72,14 @@
 	{
 		if($type === null)
 		{
-			if($this->getControl() instanceof ICallbackEventHandler)
-				$this->_activeControlType = 'Prado\\Web\UI\\ActiveControls\\TBaseActiveCallbackControl';
-			else
-				$this->_activeControlType = 'Prado\\Web\UI\\ActiveControls\\TBaseActiveControl';
+			if($this->getControl() instanceof ICallbackEventHandler) {
+							$this->_activeControlType = 'Prado\\Web\UI\\ActiveControls\\TBaseActiveCallbackControl';
+			} else {
+							$this->_activeControlType = 'Prado\\Web\UI\\ActiveControls\\TBaseActiveControl';
+			}
+		} else {
+					$this->_activeControlType = $type;
 		}
-		else
-			$this->_activeControlType = $type;
 	}
 
 	/**

framework/Web/UI/ActiveControls/TActiveListBox.php

Braces +6 added lines, -4 removed lines

@@ -89,8 +89,9 @@ 
 	 */
 	public function setSelectionMode($value)
 	{
-		if(parent::getSelectionMode() === $value)
-			return;
+		if(parent::getSelectionMode() === $value) {
+					return;
+		}
 
 		parent::setSelectionMode($value);
 		$multiple = $this->getIsMultiSelect();
@@ -151,9 +152,10 @@ 
 	{
 		parent::addAttributesToRender($writer);
 		$writer->addAttribute('id', $this->getClientID());
-		if ($this->getAutoPostBack())
-			$this->getActiveControl()->registerCallbackClientScript(
+		if ($this->getAutoPostBack()) {
+					$this->getActiveControl()->registerCallbackClientScript(
 				$this->getClientClassName(), $this->getPostBackOptions());
+		}
 	}
 }
 

framework/Web/UI/ActiveControls/TCallbackClientSide.php

Braces +3 added lines, -2 removed lines

@@ -273,8 +273,9 @@
 	 */
 	public function setPostBackTarget($value)
 	{
-		if($value instanceof TControl)
-			$value = $value->getUniqueID();
+		if($value instanceof TControl) {
+					$value = $value->getUniqueID();
+		}
 		$this->setOption('EventTarget', $value);
 	}