pradosoft / prado

framework/Web/Services/TFeedService.php

Braces +27 added lines, -24 removed lines

@@ -77,18 +77,19 @@ 
 		{
 			if(is_array($config))
 			{
-				foreach($config as $id => $feed)
-					$this->_feeds[$id] = $feed;
+				foreach($config as $id => $feed) {
+									$this->_feeds[$id] = $feed;
+				}
 			}
-		}
-		else
+		} else
 		{
 			foreach($config->getElementsByTagName('feed') as $feed)
 			{
-				if(($id = $feed->getAttributes()->remove('id')) !== null)
-					$this->_feeds[$id] = $feed;
-				else
-					throw new TConfigurationException('feedservice_id_required');
+				if(($id = $feed->getAttributes()->remove('id')) !== null) {
+									$this->_feeds[$id] = $feed;
+				} else {
+									throw new TConfigurationException('feedservice_id_required');
+				}
 			}
 		}
 	}
@@ -118,38 +119,40 @@ 
 				if(isset($feedConfig['class']))
 				{
 					$feed = Prado::createComponent($feedConfig['class']);
-					if($service instanceof IFeedContentProvider)
-						$properties = isset($feedConfig['properties'])?$feedConfig['properties']:[];
-					else
-						throw new TConfigurationException('jsonservice_response_type_invalid', $id);
+					if($service instanceof IFeedContentProvider) {
+											$properties = isset($feedConfig['properties'])?$feedConfig['properties']:[];
+					} else {
+											throw new TConfigurationException('jsonservice_response_type_invalid', $id);
+					}
+				} else {
+									throw new TConfigurationException('jsonservice_class_required', $id);
 				}
-				else
-					throw new TConfigurationException('jsonservice_class_required', $id);
-			}
-			else
+			} else
 			{
 				$properties = $feedConfig->getAttributes();
 				if(($class = $properties->remove('class')) !== null)
 				{
 					$feed = Prado::createComponent($class);
-					if(!($feed instanceof IFeedContentProvider))
-						throw new TConfigurationException('feedservice_feedtype_invalid', $id);
+					if(!($feed instanceof IFeedContentProvider)) {
+											throw new TConfigurationException('feedservice_feedtype_invalid', $id);
+					}
+				} else {
+									throw new TConfigurationException('feedservice_class_required', $id);
 				}
-				else
-					throw new TConfigurationException('feedservice_class_required', $id);
 			}
 
 			// init feed properties
-			foreach($properties as $name => $value)
-				$feed->setSubproperty($name, $value);
+			foreach($properties as $name => $value) {
+							$feed->setSubproperty($name, $value);
+			}
 			$feed->init($feedConfig);
 
 			$content = $feed->getFeedContent();
 			//$this->getResponse()->setContentType('application/rss+xml');
 			$this->getResponse()->setContentType($feed->getContentType());
 			$this->getResponse()->write($content);
+		} else {
+					throw new THttpException(404, 'feedservice_feed_unknown', $id);
 		}
-		else
-			throw new THttpException(404, 'feedservice_feed_unknown', $id);
 	}
 }
\ No newline at end of file

framework/Web/Services/TSoapService.php

Braces +35 added lines, -28 removed lines

@@ -126,9 +126,9 @@ 
 				$dom = new TXmlDocument;
 				$dom->loadFromFile($this->_configFile);
 				$this->loadConfig($dom);
+			} else {
+							throw new TConfigurationException('soapservice_configfile_invalid', $this->_configFile);
 			}
-			else
-				throw new TConfigurationException('soapservice_configfile_invalid', $this->_configFile);
 		}
 		$this->loadConfig($config);
 
@@ -149,12 +149,13 @@ 
 		{
 			$serverID = substr($serverID, 0, $pos);
 			$this->_wsdlRequest = true;
+		} else {
+					$this->_wsdlRequest = false;
 		}
-		else
-			$this->_wsdlRequest = false;
 		$this->_serverID = $serverID;
-		if(!isset($this->_servers[$serverID]))
-			throw new THttpException(400, 'soapservice_request_invalid', $serverID);
+		if(!isset($this->_servers[$serverID])) {
+					throw new THttpException(400, 'soapservice_request_invalid', $serverID);
+		}
 	}
 
 	/**
@@ -171,21 +172,23 @@ 
 				foreach($config['soap'] as $id => $server)
 				{
 					$properties = isset($server['properties'])?$server['properties']:[];
-					if(isset($this->_servers[$id]))
-						throw new TConfigurationException('soapservice_serverid_duplicated', $id);
+					if(isset($this->_servers[$id])) {
+											throw new TConfigurationException('soapservice_serverid_duplicated', $id);
+					}
 					$this->_servers[$id] = $properties;
 				}
 			}
-		}
-		else
+		} else
 		{
 			foreach($config->getElementsByTagName('soap') as $serverXML)
 			{
 				$properties = $serverXML->getAttributes();
-				if(($id = $properties->remove('id')) === null)
-					throw new TConfigurationException('soapservice_serverid_required');
-				if(isset($this->_servers[$id]))
-					throw new TConfigurationException('soapservice_serverid_duplicated', $id);
+				if(($id = $properties->remove('id')) === null) {
+									throw new TConfigurationException('soapservice_serverid_required');
+				}
+				if(isset($this->_servers[$id])) {
+									throw new TConfigurationException('soapservice_serverid_duplicated', $id);
+				}
 				$this->_servers[$id] = $properties;
 			}
 		}
@@ -206,8 +209,9 @@ 
 	 */
 	public function setConfigFile($value)
 	{
-		if(($this->_configFile = Prado::getPathOfNamespace($value, Prado::getApplication()->getConfigurationFileExt())) === null)
-			throw new TConfigurationException('soapservice_configfile_invalid', $value);
+		if(($this->_configFile = Prado::getPathOfNamespace($value, Prado::getApplication()->getConfigurationFileExt())) === null) {
+					throw new TConfigurationException('soapservice_configfile_invalid', $value);
+		}
 	}
 
 	/**
@@ -249,20 +253,24 @@ 
 	{
 		$properties = $this->_servers[$this->_serverID];
 		$serverClass = null;
-		if($this->getApplication()->getConfigurationType() == TApplication::CONFIG_TYPE_PHP && isset($config['class']))
-			$serverClass = $config['class'];
-		elseif($this->getApplication()->getConfigurationType() == TApplication::CONFIG_TYPE_XML)
-			$serverClass = $properties->remove('class');
-		if($serverClass === null)
-			$serverClass = self::DEFAULT_SOAP_SERVER;
+		if($this->getApplication()->getConfigurationType() == TApplication::CONFIG_TYPE_PHP && isset($config['class'])) {
+					$serverClass = $config['class'];
+		} elseif($this->getApplication()->getConfigurationType() == TApplication::CONFIG_TYPE_XML) {
+					$serverClass = $properties->remove('class');
+		}
+		if($serverClass === null) {
+					$serverClass = self::DEFAULT_SOAP_SERVER;
+		}
 		Prado::using($serverClass);
 		$className = ($pos = strrpos($serverClass, '.')) !== false?substr($serverClass, $pos + 1):$serverClass;
-		if($className !== self::DEFAULT_SOAP_SERVER && !is_subclass_of($className, self::DEFAULT_SOAP_SERVER))
-			throw new TConfigurationException('soapservice_server_invalid', $serverClass);
+		if($className !== self::DEFAULT_SOAP_SERVER && !is_subclass_of($className, self::DEFAULT_SOAP_SERVER)) {
+					throw new TConfigurationException('soapservice_server_invalid', $serverClass);
+		}
 		$server = new $className;
 		$server->setID($this->_serverID);
-		foreach($properties as $name => $value)
-			$server->setSubproperty($name, $value);
+		foreach($properties as $name => $value) {
+					$server->setSubproperty($name, $value);
+		}
 		return $server;
 	}
 
@@ -284,8 +292,7 @@ 
 			Prado::trace("Generating WSDL", 'Prado\Web\Services\TSoapService');
 			$this->getResponse()->clear();
 			$this->getResponse()->write($server->getWsdl());
-		}
-		else
+		} else
 		{
 			// provide SOAP service
 			Prado::trace("Handling SOAP request", 'Prado\Web\Services\TSoapService');

framework/Web/Services/TRpcProtocol.php

Braces +9 added lines, -6 removed lines

@@ -85,14 +85,17 @@
 	 */
 	public function callApiMethod($methodName, $parameters)
 	{
-		if(!isset($this->rpcMethods[$methodName]))
-			throw new TRpcException('Method "' . $methodName . '" not found');
+		if(!isset($this->rpcMethods[$methodName])) {
+					throw new TRpcException('Method "' . $methodName . '" not found');
+		}
 
-		if($parameters === null)
-			$parameters = [];
+		if($parameters === null) {
+					$parameters = [];
+		}
 
-		if(!is_array($parameters))
-			$parameters = [$parameters];
+		if(!is_array($parameters)) {
+					$parameters = [$parameters];
+		}
 		return call_user_func_array($this->rpcMethods[$methodName]['method'], $parameters);
 	}
 }
\ No newline at end of file

framework/Web/Services/TPageConfiguration.php

Braces +73 added lines, -48 removed lines

@@ -118,10 +118,11 @@ 
 		{
 			$this->loadFromFile($path . DIRECTORY_SEPARATOR . $fileName, $configPagePath);
 			$path .= DIRECTORY_SEPARATOR . $p;
-			if($configPagePath === '')
-				$configPagePath = $p;
-			else
-				$configPagePath .= '.' . $p;
+			if($configPagePath === '') {
+							$configPagePath = $p;
+			} else {
+							$configPagePath .= '.' . $p;
+			}
 		}
 		$this->loadFromFile($path . DIRECTORY_SEPARATOR . $fileName, $configPagePath);
 		$this->_rules = new TAuthorizationRuleCollection($this->_rules);
@@ -135,21 +136,22 @@ 
 	public function loadFromFile($fname, $configPagePath)
 	{
 		Prado::trace("Loading page configuration file $fname", 'System.Web.Services.TPageService');
-		if(empty($fname) || !is_file($fname))
-			return;
+		if(empty($fname) || !is_file($fname)) {
+					return;
+		}
 
 		if(Prado::getApplication()->getConfigurationType() == TApplication::CONFIG_TYPE_PHP)
 		{
 			$fcontent = include $fname;
 			$this->loadFromPhp($fcontent, dirname($fname), $configPagePath);
-		}
-		else
+		} else
 		{
 			$dom = new TXmlDocument;
-			if($dom->loadFromFile($fname))
-				$this->loadFromXml($dom, dirname($fname), $configPagePath);
-			else
-				throw new TConfigurationException('pageserviceconf_file_invalid', $fname);
+			if($dom->loadFromFile($fname)) {
+							$this->loadFromXml($dom, dirname($fname), $configPagePath);
+			} else {
+							throw new TConfigurationException('pageserviceconf_file_invalid', $fname);
+			}
 		}
 	}
 
@@ -202,27 +204,32 @@ 
 			{
 				$patterns = isset($authorization['pages'])?$authorization['pages']:'';
 				$ruleApplies = false;
-				if(empty($patterns) || trim($patterns) === '*') // null or empty string
+				if(empty($patterns) || trim($patterns) === '*') {
+					// null or empty string
 					$ruleApplies = true;
-				else
+				} else
 				{
 					foreach(explode(',', $patterns) as $pattern)
 					{
 						if(($pattern = trim($pattern)) !== '')
 						{
 							// we know $configPagePath and $this->_pagePath
-							if($configPagePath !== '')  // prepend the pattern with ConfigPagePath
+							if($configPagePath !== '') {
+								// prepend the pattern with ConfigPagePath
 								$pattern = $configPagePath . '.' . $pattern;
+							}
 							if(strcasecmp($pattern, $this->_pagePath) === 0)
 							{
 								$ruleApplies = true;
 								break;
 							}
-							if($pattern[strlen($pattern) - 1] === '*') // try wildcard matching
+							if($pattern[strlen($pattern) - 1] === '*') {
+								// try wildcard matching
 							{
 								if(strncasecmp($this->_pagePath, $pattern, strlen($pattern) - 1) === 0)
 								{
 									$ruleApplies = true;
+							}
 									break;
 								}
 							}
@@ -259,12 +266,15 @@ 
 				}
 				$matching = false;
 				$id = ($configPagePath === '')?$id:$configPagePath . '.' . $id;
-				if(strcasecmp($id, $this->_pagePath) === 0)
-					$matching = true;
-				elseif($id[strlen($id) - 1] === '*') // try wildcard matching
+				if(strcasecmp($id, $this->_pagePath) === 0) {
+									$matching = true;
+				} elseif($id[strlen($id) - 1] === '*') {
+					// try wildcard matching
 					$matching = strncasecmp($this->_pagePath, $id, strlen($id) - 1) === 0;
-				if($matching)
-					$this->_properties = array_merge($this->_properties, $properties);
+				}
+				if($matching) {
+									$this->_properties = array_merge($this->_properties, $properties);
+				}
 			}
 		}
 
@@ -274,13 +284,15 @@ 
 			foreach($config['includes'] as $include)
 			{
 				$when = isset($include['when'])?true:false;
-				if(!isset($include['file']))
-					throw new TConfigurationException('pageserviceconf_includefile_required');
+				if(!isset($include['file'])) {
+									throw new TConfigurationException('pageserviceconf_includefile_required');
+				}
 				$filePath = $include['file'];
-				if(isset($this->_includes[$filePath]))
-					$this->_includes[$filePath] = [$configPagePath,'(' . $this->_includes[$filePath][1] . ') || (' . $when . ')'];
-				else
-					$this->_includes[$filePath] = [$configPagePath,$when];
+				if(isset($this->_includes[$filePath])) {
+									$this->_includes[$filePath] = [$configPagePath,'(' . $this->_includes[$filePath][1] . ') || (' . $when . ')'];
+				} else {
+									$this->_includes[$filePath] = [$configPagePath,$when];
+				}
 			}
 		}
 	}
@@ -301,35 +313,41 @@ 
 			{
 				$patterns = $node->getAttribute('pages');
 				$ruleApplies = false;
-				if(empty($patterns) || trim($patterns) === '*') // null or empty string
+				if(empty($patterns) || trim($patterns) === '*') {
+					// null or empty string
 					$ruleApplies = true;
-				else
+				} else
 				{
 					foreach(explode(',', $patterns) as $pattern)
 					{
 						if(($pattern = trim($pattern)) !== '')
 						{
 							// we know $configPagePath and $this->_pagePath
-							if($configPagePath !== '')  // prepend the pattern with ConfigPagePath
+							if($configPagePath !== '') {
+								// prepend the pattern with ConfigPagePath
 								$pattern = $configPagePath . '.' . $pattern;
+							}
 							if(strcasecmp($pattern, $this->_pagePath) === 0)
 							{
 								$ruleApplies = true;
 								break;
 							}
-							if($pattern[strlen($pattern) - 1] === '*') // try wildcard matching
+							if($pattern[strlen($pattern) - 1] === '*') {
+								// try wildcard matching
 							{
 								if(strncasecmp($this->_pagePath, $pattern, strlen($pattern) - 1) === 0)
 								{
 									$ruleApplies = true;
+							}
 									break;
 								}
 							}
 						}
 					}
 				}
-				if($ruleApplies)
-					$rules[] = new TAuthorizationRule($node->getTagName(), $node->getAttribute('users'), $node->getAttribute('roles'), $node->getAttribute('verb'), $node->getAttribute('ips'));
+				if($ruleApplies) {
+									$rules[] = new TAuthorizationRule($node->getTagName(), $node->getAttribute('users'), $node->getAttribute('roles'), $node->getAttribute('verb'), $node->getAttribute('ips'));
+				}
 			}
 			$this->_rules = array_merge($rules, $this->_rules);
 		}
@@ -343,30 +361,37 @@ 
 			{
 				$properties = $node->getAttributes();
 				$id = $properties->remove('id');
-				if(empty($id))
-					throw new TConfigurationException('pageserviceconf_page_invalid', $configPath);
+				if(empty($id)) {
+									throw new TConfigurationException('pageserviceconf_page_invalid', $configPath);
+				}
 				$matching = false;
 				$id = ($configPagePath === '')?$id:$configPagePath . '.' . $id;
-				if(strcasecmp($id, $this->_pagePath) === 0)
-					$matching = true;
-				elseif($id[strlen($id) - 1] === '*') // try wildcard matching
+				if(strcasecmp($id, $this->_pagePath) === 0) {
+									$matching = true;
+				} elseif($id[strlen($id) - 1] === '*') {
+					// try wildcard matching
 					$matching = strncasecmp($this->_pagePath, $id, strlen($id) - 1) === 0;
-				if($matching)
-					$this->_properties = array_merge($this->_properties, $properties->toArray());
+				}
+				if($matching) {
+									$this->_properties = array_merge($this->_properties, $properties->toArray());
+				}
 			}
 		}
 
 		// external configurations
 		foreach($dom->getElementsByTagName('include') as $node)
 		{
-			if(($when = $node->getAttribute('when')) === null)
-				$when = true;
-			if(($filePath = $node->getAttribute('file')) === null)
-				throw new TConfigurationException('pageserviceconf_includefile_required');
-			if(isset($this->_includes[$filePath]))
-				$this->_includes[$filePath] = [$configPagePath,'(' . $this->_includes[$filePath][1] . ') || (' . $when . ')'];
-			else
-				$this->_includes[$filePath] = [$configPagePath,$when];
+			if(($when = $node->getAttribute('when')) === null) {
+							$when = true;
+			}
+			if(($filePath = $node->getAttribute('file')) === null) {
+							throw new TConfigurationException('pageserviceconf_includefile_required');
+			}
+			if(isset($this->_includes[$filePath])) {
+							$this->_includes[$filePath] = [$configPagePath,'(' . $this->_includes[$filePath][1] . ') || (' . $when . ')'];
+			} else {
+							$this->_includes[$filePath] = [$configPagePath,$when];
+			}
 		}
 	}
 }
\ No newline at end of file

framework/Web/Services/TPageService.php

Braces +72 added lines, -55 removed lines

@@ -174,8 +174,9 @@ 
 	protected function initPageContext($pageConfig)
 	{
 		$application = $this->getApplication();
-		foreach($pageConfig->getApplicationConfigurations() as $appConfig)
-			$application->applyConfiguration($appConfig);
+		foreach($pageConfig->getApplicationConfigurations() as $appConfig) {
+					$application->applyConfiguration($appConfig);
+		}
 
 		$this->applyConfiguration($pageConfig);
 	}
@@ -194,12 +195,14 @@ 
 		foreach($config->getExternalConfigurations() as $filePath => $params)
 		{
 			list($configPagePath, $condition) = $params;
-			if($condition !== true)
-				$condition = $this->evaluateExpression($condition);
+			if($condition !== true) {
+							$condition = $this->evaluateExpression($condition);
+			}
 			if($condition)
 			{
-				if(($path = Prado::getPathOfNamespace($filePath, Prado::getApplication()->getConfigurationFileExt())) === null || !is_file($path))
-					throw new TConfigurationException('pageservice_includefile_invalid', $filePath);
+				if(($path = Prado::getPathOfNamespace($filePath, Prado::getApplication()->getConfigurationFileExt())) === null || !is_file($path)) {
+									throw new TConfigurationException('pageservice_includefile_invalid', $filePath);
+				}
 				$c = new TPageConfiguration($pagePath);
 				$c->loadFromFile($path, $configPagePath);
 				$this->applyConfiguration($c);
@@ -215,8 +218,9 @@ 
 	protected function determineRequestedPagePath()
 	{
 		$pagePath = $this->getRequest()->getServiceParameter();
-		if(empty($pagePath))
-			$pagePath = $this->getDefaultPage();
+		if(empty($pagePath)) {
+					$pagePath = $this->getDefaultPage();
+		}
 		return $pagePath;
 	}
 
@@ -234,14 +238,14 @@ 
 			$pageConfig = new TPageConfiguration($pagePath);
 			if($config !== null)
 			{
-				if($application->getConfigurationType() == TApplication::CONFIG_TYPE_PHP)
-					$pageConfig->loadPageConfigurationFromPhp($config, $application->getBasePath(), '');
-				else
-					$pageConfig->loadPageConfigurationFromXml($config, $application->getBasePath(), '');
+				if($application->getConfigurationType() == TApplication::CONFIG_TYPE_PHP) {
+									$pageConfig->loadPageConfigurationFromPhp($config, $application->getBasePath(), '');
+				} else {
+									$pageConfig->loadPageConfigurationFromXml($config, $application->getBasePath(), '');
+				}
 			}
 			$pageConfig->loadFromFiles($this->getBasePath());
-		}
-		else
+		} else
 		{
 			$configCached = true;
 			$currentTimestamp = [];
@@ -253,23 +257,25 @@ 
 				{
 					foreach($timestamps as $fileName => $timestamp)
 					{
-						if($fileName === 0) // application config file
+						if($fileName === 0) {
+							// application config file
 						{
 							$appConfigFile = $application->getConfigurationFile();
-							$currentTimestamp[0] = $appConfigFile === null?0:@filemtime($appConfigFile);
-							if($currentTimestamp[0] > $timestamp || ($timestamp > 0 && !$currentTimestamp[0]))
-								$configCached = false;
 						}
-						else
+							$currentTimestamp[0] = $appConfigFile === null?0:@filemtime($appConfigFile);
+							if($currentTimestamp[0] > $timestamp || ($timestamp > 0 && !$currentTimestamp[0])) {
+															$configCached = false;
+							}
+						} else
 						{
 							$currentTimestamp[$fileName] = @filemtime($fileName);
-							if($currentTimestamp[$fileName] > $timestamp || ($timestamp > 0 && !$currentTimestamp[$fileName]))
-								$configCached = false;
+							if($currentTimestamp[$fileName] > $timestamp || ($timestamp > 0 && !$currentTimestamp[$fileName])) {
+															$configCached = false;
+							}
 						}
 					}
 				}
-			}
-			else
+			} else
 			{
 				$configCached = false;
 				$paths = explode('.', $pagePath);
@@ -291,10 +297,11 @@ 
 				$pageConfig = new TPageConfiguration($pagePath);
 				if($config !== null)
 				{
-					if($application->getConfigurationType() == TApplication::CONFIG_TYPE_PHP)
-						$pageConfig->loadPageConfigurationFromPhp($config, $application->getBasePath(), '');
-					else
-						$pageConfig->loadPageConfigurationFromXml($config, $application->getBasePath(), '');
+					if($application->getConfigurationType() == TApplication::CONFIG_TYPE_PHP) {
+											$pageConfig->loadPageConfigurationFromPhp($config, $application->getBasePath(), '');
+					} else {
+											$pageConfig->loadPageConfigurationFromXml($config, $application->getBasePath(), '');
+					}
 				}
 				$pageConfig->loadFromFiles($this->getBasePath());
 				$cache->set(self::CONFIG_CACHE_PREFIX . $this->getID() . $pagePath, [$pageConfig,$currentTimestamp]);
@@ -353,8 +360,9 @@ 
 		if($this->_pagePath === null)
 		{
 			$this->_pagePath = strtr($this->determineRequestedPagePath(), '/\\', '..');
-			if(empty($this->_pagePath))
-				throw new THttpException(404, 'pageservice_page_required');
+			if(empty($this->_pagePath)) {
+							throw new THttpException(404, 'pageservice_page_required');
+			}
 		}
 		return $this->_pagePath;
 	}
@@ -381,10 +389,11 @@ 
 	 */
 	public function setDefaultPage($value)
 	{
-		if($this->_initialized)
-			throw new TInvalidOperationException('pageservice_defaultpage_unchangeable');
-		else
-			$this->_defaultPage = $value;
+		if($this->_initialized) {
+					throw new TInvalidOperationException('pageservice_defaultpage_unchangeable');
+		} else {
+					$this->_defaultPage = $value;
+		}
 	}
 
 	/**
@@ -406,8 +415,9 @@ 
 			if(($this->_basePath = realpath($basePath)) === false || !is_dir($this->_basePath))
 			{
 				$basePath = $this->getApplication()->getBasePath() . DIRECTORY_SEPARATOR . self::FALLBACK_BASEPATH;
-				if(($this->_basePath = realpath($basePath)) === false || !is_dir($this->_basePath))
-					throw new TConfigurationException('pageservice_basepath_invalid', $basePath);
+				if(($this->_basePath = realpath($basePath)) === false || !is_dir($this->_basePath)) {
+									throw new TConfigurationException('pageservice_basepath_invalid', $basePath);
+				}
 			}
 		}
 		return $this->_basePath;
@@ -419,10 +429,11 @@ 
 	 */
 	public function setBasePath($value)
 	{
-		if($this->_initialized)
-			throw new TInvalidOperationException('pageservice_basepath_unchangeable');
-		elseif(($path = Prado::getPathOfNamespace($value)) === null || !is_dir($path))
-			throw new TConfigurationException('pageservice_basepath_invalid', $value);
+		if($this->_initialized) {
+					throw new TInvalidOperationException('pageservice_basepath_unchangeable');
+		} elseif(($path = Prado::getPathOfNamespace($value)) === null || !is_dir($path)) {
+					throw new TConfigurationException('pageservice_basepath_invalid', $value);
+		}
 		$this->_basePath = realpath($path);
 	}
 
@@ -489,36 +500,41 @@ 
 		$hasTemplateFile = is_file($path . self::PAGE_FILE_EXT);
 		$hasClassFile = is_file($path . Prado::CLASS_FILE_EXT);
 
-		if(!$hasTemplateFile && !$hasClassFile)
-			throw new THttpException(404, 'pageservice_page_unknown', $pagePath);
+		if(!$hasTemplateFile && !$hasClassFile) {
+					throw new THttpException(404, 'pageservice_page_unknown', $pagePath);
+		}
 
 		if($hasClassFile)
 		{
 			$className = basename($path);
 			$namespacedClassName = static::PAGE_NAMESPACE_PREFIX . str_replace('.', '\\', $pagePath);
 
-			if(!class_exists($className, false) && !class_exists($namespacedClassName, false))
-				include_once($path . Prado::CLASS_FILE_EXT);
+			if(!class_exists($className, false) && !class_exists($namespacedClassName, false)) {
+							include_once($path . Prado::CLASS_FILE_EXT);
+			}
 
-			if(!class_exists($className, false))
-				$className = $namespacedClassName;
-		}
-		else
+			if(!class_exists($className, false)) {
+							$className = $namespacedClassName;
+			}
+		} else
 		{
 			$className = $this->getBasePageClass();
 			Prado::using($className);
-			if(($pos = strrpos($className, '.')) !== false)
-				$className = substr($className, $pos + 1);
+			if(($pos = strrpos($className, '.')) !== false) {
+							$className = substr($className, $pos + 1);
+			}
 		}
 
-		if($className !== '\Prado\Web\UI\TPage' && !is_subclass_of($className, '\Prado\Web\UI\TPage'))
-			throw new THttpException(404, 'pageservice_page_unknown', $pagePath);
+		if($className !== '\Prado\Web\UI\TPage' && !is_subclass_of($className, '\Prado\Web\UI\TPage')) {
+					throw new THttpException(404, 'pageservice_page_unknown', $pagePath);
+		}
 
 		$page = Prado::createComponent($className);
 		$page->setPagePath($pagePath);
 
-		if($hasTemplateFile)
-			$page->setTemplate($this->getTemplateManager()->getTemplateByFileName($path . self::PAGE_FILE_EXT));
+		if($hasTemplateFile) {
+					$page->setTemplate($this->getTemplateManager()->getTemplateByFileName($path . self::PAGE_FILE_EXT));
+		}
 
 		return $page;
 	}
@@ -530,8 +546,9 @@ 
 	 */
 	protected function runPage($page, $properties)
 	{
-		foreach($properties as $name => $value)
-			$page->setSubProperty($name, $value);
+		foreach($properties as $name => $value) {
+					$page->setSubProperty($name, $value);
+		}
 		$page->run($this->getResponse()->createHtmlWriter());
 	}
 

framework/Web/Services/TJsonRpcProtocol.php

Braces +26 added lines, -22 removed lines

@@ -43,23 +43,28 @@ 
 			if(isset($_request['jsonrpc']))
 			{
 				$this->_specificationVersion = $_request['jsonrpc'];
-				if($this->_specificationVersion > 2.0)
-					throw new TRpcException('Unsupported specification version', '-32600');
+				if($this->_specificationVersion > 2.0) {
+									throw new TRpcException('Unsupported specification version', '-32600');
+				}
 			}
 
-			if(isset($_request['id']))
-				$this->_id = $_request['id'];
+			if(isset($_request['id'])) {
+							$this->_id = $_request['id'];
+			}
 
-			if(!isset($_request['method']))
-					throw new TRpcException('Missing request method', '-32600');
+			if(!isset($_request['method'])) {
+								throw new TRpcException('Missing request method', '-32600');
+			}
 
-			if(!isset($_request['params']))
-				$parameters = [];
-			else
-				$parameters = $_request['params'];
+			if(!isset($_request['params'])) {
+							$parameters = [];
+			} else {
+							$parameters = $_request['params'];
+			}
 
-			if(!is_array($parameters))
-				$parameters = [$parameters];
+			if(!is_array($parameters)) {
+							$parameters = [$parameters];
+			}
 
 			// a request without an id is a notification that doesn't need a response
 			if($this->_id !== null)
@@ -79,16 +84,13 @@ 
 					]);
 				}
 			}
-		}
-		catch(TRpcException $e)
+		} catch(TRpcException $e)
 		{
 			return $this->createErrorResponse($e);
-		}
-		catch(THttpException $e)
+		} catch(THttpException $e)
 		{
 			throw $e;
-		}
-		catch(\Exception $e)
+		} catch(\Exception $e)
 		{
 			return $this->createErrorResponse(new TRpcException('An internal error occured', '-32603'));
 		}
@@ -161,8 +163,9 @@ 
 	private static function checkJsonError()
 	{
 		$errnum = json_last_error();
-		if($errnum != JSON_ERROR_NONE)
-			throw new \Exception("JSON error: $msg", $err);
+		if($errnum != JSON_ERROR_NONE) {
+					throw new \Exception("JSON error: $msg", $err);
+		}
 	}
 
 	/**
@@ -174,8 +177,9 @@ 
 	 */
 	public function callApiMethod($methodName, $parameters)
 	{
-		if(!isset($this->rpcMethods[$methodName]))
-			throw new TRpcException('Method "' . $methodName . '" not found', '-32601');
+		if(!isset($this->rpcMethods[$methodName])) {
+					throw new TRpcException('Method "' . $methodName . '" not found', '-32601');
+		}
 
 		return call_user_func_array($this->rpcMethods[$methodName]['method'], $parameters);
 	}

framework/Web/Services/TRpcService.php

Braces +36 added lines, -22 removed lines

@@ -94,29 +94,34 @@ 
 	{
 		$_properties = $this->apiProviders[$providerId];
 
-		if(($_providerClass = $_properties->remove('class')) === null)
-			throw new TConfigurationException('rpcservice_apiprovider_required');
+		if(($_providerClass = $_properties->remove('class')) === null) {
+					throw new TConfigurationException('rpcservice_apiprovider_required');
+		}
 
 		Prado::using($_providerClass);
 
 		$_providerClassName = ($_pos = strrpos($_providerClass, '.')) !== false ? substr($_providerClass, $_pos + 1) : $_providerClass;
-		if(!is_subclass_of($_providerClassName, self::BASE_API_PROVIDER))
-			throw new TConfigurationException('rpcservice_apiprovider_invalid');
+		if(!is_subclass_of($_providerClassName, self::BASE_API_PROVIDER)) {
+					throw new TConfigurationException('rpcservice_apiprovider_invalid');
+		}
 
-		if(($_rpcServerClass = $_properties->remove('server')) === null)
-			$_rpcServerClass = self::BASE_RPC_SERVER;
+		if(($_rpcServerClass = $_properties->remove('server')) === null) {
+					$_rpcServerClass = self::BASE_RPC_SERVER;
+		}
 
 		Prado::using($_rpcServerClass);
 
 		$_rpcServerClassName = ($_pos = strrpos($_rpcServerClass, '.')) !== false ? substr($_rpcServerClass, $_pos + 1) : $_rpcServerClass;
-		if($_rpcServerClassName !== self::BASE_RPC_SERVER && !is_subclass_of($_rpcServerClassName, self::BASE_RPC_SERVER))
-			throw new TConfigurationException('rpcservice_rpcserver_invalid');
+		if($_rpcServerClassName !== self::BASE_RPC_SERVER && !is_subclass_of($_rpcServerClassName, self::BASE_RPC_SERVER)) {
+					throw new TConfigurationException('rpcservice_rpcserver_invalid');
+		}
 
 		$_apiProvider = new $_providerClassName(new $_rpcServerClassName($protocolHandler));
 		$_apiProvider->setId($providerId);
 
-		foreach($_properties as $_key => $_value)
-			$_apiProvider->setSubProperty($_key, $_value);
+		foreach($_properties as $_key => $_value) {
+					$_apiProvider->setSubProperty($_key, $_value);
+		}
 
 		return $_apiProvider;
 	}
@@ -140,11 +145,13 @@ 
 		{
 			$_properties = $_apiProviderXml->getAttributes();
 
-			if(($_id = $_properties->remove('id')) === null || $_id == "")
-				throw new TConfigurationException('rpcservice_apiproviderid_required');
+			if(($_id = $_properties->remove('id')) === null || $_id == "") {
+							throw new TConfigurationException('rpcservice_apiproviderid_required');
+			}
 
-			if(isset($this->apiProviders[$_id]))
-				throw new TConfigurationException('rpcservice_apiproviderid_duplicated');
+			if(isset($this->apiProviders[$_id])) {
+							throw new TConfigurationException('rpcservice_apiproviderid_duplicated');
+			}
 
 			$this->apiProviders[$_id] = $_properties;
 		}
@@ -157,17 +164,24 @@ 
 	{
 		$_request = $this->getRequest();
 
-		if(($_providerId = $_request->getServiceParameter()) == "")
-			throw new THttpException(400, 'RPC API-Provider id required');
+		if(($_providerId = $_request->getServiceParameter()) == "") {
+					throw new THttpException(400, 'RPC API-Provider id required');
+		}
 		
-		if(($_method = $_request->getRequestType()) != 'POST')
-			throw new THttpException(405, 'Invalid request method "' . $_method . '"!'); // TODO Exception muss "Allow POST" Header setzen
+		if(($_method = $_request->getRequestType()) != 'POST') {
+					throw new THttpException(405, 'Invalid request method "' . $_method . '"!');
+		}
+		// TODO Exception muss "Allow POST" Header setzen
 
-		if(($_mimeType = $_request->getContentType()) === null)
-			throw new THttpException(406, 'Content-Type is missing!'); // TODO Exception muss gültige Content-Type werte zurück geben
+		if(($_mimeType = $_request->getContentType()) === null) {
+					throw new THttpException(406, 'Content-Type is missing!');
+		}
+		// TODO Exception muss gültige Content-Type werte zurück geben
 
-		if(!in_array($_mimeType, array_keys($this->protocolHandlers)))
-			throw new THttpException(406, 'Unsupported Content-Type!'); // TODO see previous
+		if(!in_array($_mimeType, array_keys($this->protocolHandlers))) {
+					throw new THttpException(406, 'Unsupported Content-Type!');
+		}
+		// TODO see previous
 
 		$_protocolHandlerClass = $this->protocolHandlers[$_mimeType];
 		$_protocolHandler = new $_protocolHandlerClass;

framework/Web/Services/TJsonService.php

Braces +26 added lines, -24 removed lines

@@ -84,18 +84,19 @@ 
 		{
 			if(is_array($config))
 			{
-				foreach($config['json'] as $id => $json)
-					$this->_services[$id] = $json;
+				foreach($config['json'] as $id => $json) {
+									$this->_services[$id] = $json;
+				}
 			}
-		}
-		else
+		} else
 		{
 			foreach($config->getElementsByTagName('json') as $json)
 			{
-				if(($id = $json->getAttribute('id')) !== null)
-					$this->_services[$id] = $json;
-				else
-					throw new TConfigurationException('jsonservice_id_required');
+				if(($id = $json->getAttribute('id')) !== null) {
+									$this->_services[$id] = $json;
+				} else {
+									throw new TConfigurationException('jsonservice_id_required');
+				}
 			}
 		}
 	}
@@ -119,30 +120,30 @@ 
 					{
 						$properties = isset($serviceConfig['properties'])?$serviceConfig['properties']:[];
 						$this->createJsonResponse($service, $properties, $serviceConfig);
+					} else {
+											throw new TConfigurationException('jsonservice_response_type_invalid', $id);
 					}
-					else
-						throw new TConfigurationException('jsonservice_response_type_invalid', $id);
+				} else {
+									throw new TConfigurationException('jsonservice_class_required', $id);
 				}
-				else
-					throw new TConfigurationException('jsonservice_class_required', $id);
-			}
-			else
+			} else
 			{
 				$properties = $serviceConfig->getAttributes();
 				if(($class = $properties->remove('class')) !== null)
 				{
 					$service = Prado::createComponent($class);
-					if($service instanceof TJsonResponse)
-						$this->createJsonResponse($service, $properties, $serviceConfig);
-					else
-						throw new TConfigurationException('jsonservice_response_type_invalid', $id);
+					if($service instanceof TJsonResponse) {
+											$this->createJsonResponse($service, $properties, $serviceConfig);
+					} else {
+											throw new TConfigurationException('jsonservice_response_type_invalid', $id);
+					}
+				} else {
+									throw new TConfigurationException('jsonservice_class_required', $id);
 				}
-				else
-					throw new TConfigurationException('jsonservice_class_required', $id);
 			}
+		} else {
+					throw new THttpException(404, 'jsonservice_provider_unknown', $id);
 		}
-		else
-			throw new THttpException(404, 'jsonservice_provider_unknown', $id);
 	}
 
 	/**
@@ -152,8 +153,9 @@ 
 	protected function createJsonResponse($service, $properties, $config)
 	{
 		// init service properties
-		foreach($properties as $name => $value)
-			$service->setSubproperty($name, $value);
+		foreach($properties as $name => $value) {
+					$service->setSubproperty($name, $value);
+		}
 		$service->init($config);
 
 		//send content if not null

framework/Web/Services/TSoapServer.php

Braces +56 added lines, -44 removed lines

@@ -62,8 +62,9 @@ 
 	 */
 	public function setID($id)
 	{
-		if(strrpos($this->_id, '.wsdl') === strlen($this->_id) - 5)
-			throw new TInvalidDataValueException('soapserver_id_invalid', $id);
+		if(strrpos($this->_id, '.wsdl') === strlen($this->_id) - 5) {
+					throw new TInvalidDataValueException('soapserver_id_invalid', $id);
+		}
 		$this->_id = $id;
 	}
 
@@ -79,21 +80,22 @@ 
 			$this->guessMethodCallRequested($providerClass);
 			$server = $this->createServer();
 			$server->setClass($providerClass, $this);
-			if($this->_persistent)
-				$server->setPersistence(SOAP_PERSISTENCE_SESSION);
+			if($this->_persistent) {
+							$server->setPersistence(SOAP_PERSISTENCE_SESSION);
+			}
+		} else {
+					$server = $this->createServer();
 		}
-		else
-			$server = $this->createServer();
 		try
 		{
 			$server->handle();
-		}
-		catch (\Exception $e)
+		} catch (\Exception $e)
 		{
-			if($this->getApplication()->getMode() === TApplicationMode::Debug)
-				$this->fault($e->getMessage(), $e->__toString());
-			else
-				$this->fault($e->getMessage());
+			if($this->getApplication()->getMode() === TApplicationMode::Debug) {
+							$this->fault($e->getMessage(), $e->__toString());
+			} else {
+							$this->fault($e->getMessage());
+			}
 		}
 	}
 
@@ -147,8 +149,9 @@ 
 	{
 		if($this->_server === null)
 		{
-			if($this->getApplication()->getMode() === TApplicationMode::Debug)
-				ini_set("soap.wsdl_cache_enabled", 0);
+			if($this->getApplication()->getMode() === TApplicationMode::Debug) {
+							ini_set("soap.wsdl_cache_enabled", 0);
+			}
 			$this->_server = new \SoapServer($this->getWsdlUri(), $this->getOptions());
 		}
 		return $this->_server;
@@ -160,20 +163,26 @@ 
 	protected function getOptions()
 	{
 		$options = [];
-		if($this->_version === '1.1')
-			$options['soap_version'] = SOAP_1_1;
-		elseif($this->_version === '1.2')
-			$options['soap_version'] = SOAP_1_2;
-		if(!empty($this->_actor))
-			$options['actor'] = $this->_actor;
-		if(!empty($this->_encoding))
-			$options['encoding'] = $this->_encoding;
-		if(!empty($this->_uri))
-			$options['uri'] = $this->_uri;
+		if($this->_version === '1.1') {
+					$options['soap_version'] = SOAP_1_1;
+		} elseif($this->_version === '1.2') {
+					$options['soap_version'] = SOAP_1_2;
+		}
+		if(!empty($this->_actor)) {
+					$options['actor'] = $this->_actor;
+		}
+		if(!empty($this->_encoding)) {
+					$options['encoding'] = $this->_encoding;
+		}
+		if(!empty($this->_uri)) {
+					$options['uri'] = $this->_uri;
+		}
 		if(is_string($this->_classMap))
 		{
-			foreach(preg_split('/\s*,\s*/', $this->_classMap) as $className)
-				$options['classmap'][$className] = $className; //complex type uses the class name in the wsdl
+			foreach(preg_split('/\s*,\s*/', $this->_classMap) as $className) {
+							$options['classmap'][$className] = $className;
+			}
+			//complex type uses the class name in the wsdl
 		}
 		return $options;
 	}
@@ -195,19 +204,19 @@ 
 			if($this->getApplication()->getMode() === TApplicationMode::Performance && ($cache = $this->getApplication()->getCache()) !== null)
 			{
 				$wsdl = $cache->get(self::WSDL_CACHE_PREFIX . $providerClass);
-				if(is_string($wsdl))
-					return $wsdl;
+				if(is_string($wsdl)) {
+									return $wsdl;
+				}
 				$wsdl = WsdlGenerator::generate($providerClass, $this->getUri(), $this->getEncoding());
 				$cache->set(self::WSDL_CACHE_PREFIX . $providerClass, $wsdl);
 				return $wsdl;
-			}
-			else
+			} else
 			{
 				return WsdlGenerator::generate($providerClass, $this->getUri(), $this->getEncoding());
 			}
+		} else {
+					return file_get_contents($this->_wsdlUri);
 		}
-		else
-			return file_get_contents($this->_wsdlUri);
 	}
 
 	/**
@@ -215,10 +224,11 @@ 
 	 */
 	public function getWsdlUri()
 	{
-		if($this->_wsdlUri === '')
-			return $this->getRequest()->getBaseUrl() . $this->getService()->constructUrl($this->getID() . '.wsdl', false);
-		else
-			return $this->_wsdlUri;
+		if($this->_wsdlUri === '') {
+					return $this->getRequest()->getBaseUrl() . $this->getService()->constructUrl($this->getID() . '.wsdl', false);
+		} else {
+					return $this->_wsdlUri;
+		}
 	}
 
 	/**
@@ -234,10 +244,11 @@ 
 	 */
 	public function getUri()
 	{
-		if($this->_uri === '')
-			return $this->getRequest()->getBaseUrl() . $this->getService()->constructUrl($this->getID(), false);
-		else
-			return $this->_uri;
+		if($this->_uri === '') {
+					return $this->getRequest()->getBaseUrl() . $this->getService()->constructUrl($this->getID(), false);
+		} else {
+					return $this->_uri;
+		}
 	}
 
 	/**
@@ -278,10 +289,11 @@ 
 	 */
 	public function setVersion($value)
 	{
-		if($value === '1.1' || $value === '1.2' || $value === '')
-			$this->_version = $value;
-		else
-			throw new TInvalidDataValueException('soapserver_version_invalid', $value);
+		if($value === '1.1' || $value === '1.2' || $value === '') {
+					$this->_version = $value;
+		} else {
+					throw new TInvalidDataValueException('soapserver_version_invalid', $value);
+		}
 	}
 
 	/**