Completed
Push — remove_deprecates ( 1de955...c03db3 )
by Fabio
16:32 queued 07:25
created
framework/Data/ActiveRecord/Relations/TActiveRecordRelation.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,6 +92,7 @@  discard block
 block discarded – undo
92 92
 
93 93
 	/**
94 94
 	 * Fetch results for current relationship.
95
+	 * @param TActiveRecord $obj
95 96
 	 * @return boolean always true.
96 97
 	 */
97 98
 	public function fetchResultsInto($obj)
@@ -104,7 +105,6 @@  discard block
 block discarded – undo
104 105
 	 * Returns foreign keys in $fromRecord with source column names as key
105 106
 	 * and foreign column names in the corresponding $matchesRecord as value.
106 107
 	 * The method returns the first matching foreign key between these 2 records.
107
-	 * @param TActiveRecord $fromRecord
108 108
 	 * @param TActiveRecord $matchesRecord
109 109
 	 * @return array foreign keys with source column names as key and foreign column names as value.
110 110
 	 */
@@ -212,6 +212,7 @@  discard block
 block discarded – undo
212 212
 	 * @param array source property names
213 213
 	 * @param array foreign objects
214 214
 	 * @param array foreign object field names.
215
+	 * @param TActiveRecord[] $fkObjects
215 216
 	 */
216 217
 	protected function populateResult(&$results,$properties,&$fkObjects,$fields)
217 218
 	{
Please login to merge, or discard this patch.
Braces   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -83,10 +83,10 @@  discard block
 block discarded – undo
83 83
 		if($validArray || $results instanceof \ArrayAccess || $results instanceof TActiveRecord)
84 84
 		{
85 85
 			$this->collectForeignObjects($results);
86
-			while($obj = array_pop($stack))
87
-				$obj->collectForeignObjects($results);
88
-		}
89
-		else if($results instanceof TActiveRecordRelation)
86
+			while($obj = array_pop($stack)) {
87
+							$obj->collectForeignObjects($results);
88
+			}
89
+		} else if($results instanceof TActiveRecordRelation)
90 90
 			$stack[] = $this; //call it later
91 91
 		else if($results === null || !$validArray)
92 92
 			$stack = array();
@@ -236,8 +236,7 @@  discard block
 block discarded – undo
236 236
 		{
237 237
 			for($i=0,$k=count($results);$i<$k;$i++)
238 238
 				$this->setObjectProperty($results[$i], $properties, $collections);
239
-		}
240
-		else
239
+		} else
241 240
 			$this->setObjectProperty($results, $properties, $collections);
242 241
 	}
243 242
 
Please login to merge, or discard this patch.
framework/Data/ActiveRecord/Scaffold/InputBuilder/TScaffoldInputCommon.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@
 block discarded – undo
47 47
 		return $control;
48 48
 	}
49 49
 
50
+	/**
51
+	 * @return string
52
+	 */
50 53
 	protected function getDefaultControlValue($container,$column, $record)
51 54
 	{
52 55
 		$control = $container->findControl(self::DEFAULT_ID);
Please login to merge, or discard this patch.
framework/Data/Common/Mssql/TMssqlMetaData.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -123,6 +123,7 @@
 block discarded – undo
123 123
 	/**
124 124
 	 * @param TMssqlTableInfo table information.
125 125
 	 * @param array column information.
126
+	 * @param TMssqlTableInfo $tableInfo
126 127
 	 */
127 128
 	protected function processColumn($tableInfo, $col)
128 129
 	{
Please login to merge, or discard this patch.
framework/Data/Common/Mssql/TMssqlTableColumn.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 
28 28
 	/**
29 29
 	 * Overrides parent implementation, returns PHP type from the db type.
30
-	 * @return boolean derived PHP primitive type from the column db type.
30
+	 * @return string derived PHP primitive type from the column db type.
31 31
 	 */
32 32
 	public function getPHPType()
33 33
 	{
Please login to merge, or discard this patch.
framework/Data/Common/Mysql/TMysqlMetaData.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -114,6 +114,7 @@
 block discarded – undo
114 114
 	/**
115 115
 	 * @param TMysqlTableInfo table information.
116 116
 	 * @param array column information.
117
+	 * @param TMysqlTableInfo $tableInfo
117 118
 	 */
118 119
 	protected function processColumn($tableInfo, $col)
119 120
 	{
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -154,8 +154,7 @@  discard block
 block discarded – undo
154 154
 					$info['NumericPrecision'] = intval($pscale[1]);
155 155
 					if(count($pscale) > 2)
156 156
 						$info['NumericScale'] = intval($pscale[2]);
157
-				}
158
-				else
157
+				} else
159 158
 					$info['ColumnSize'] = intval($pscale[1]);
160 159
 			}
161 160
 		}
@@ -254,8 +253,7 @@  discard block
 block discarded – undo
254 253
 		try
255 254
 		{
256 255
 			return count($result = $command->queryRow()) > 0 && $result['Table_type']==='VIEW';
257
-		}
258
-		catch(TDbException $e)
256
+		} catch(TDbException $e)
259 257
 		{
260 258
 			$table = $schemaName===null?$tableName:$schemaName.'.'.$tableName;
261 259
 			throw new TDbException('dbcommon_invalid_table_name',$table,$e->getMessage());
Please login to merge, or discard this patch.
framework/Data/Common/Oracle/TOracleMetaData.php 2 patches
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	/**
146 146
 	 * @param string table schema name
147 147
 	 * @param string table name.
148
-	 * @return boolean true if the table is a view.
148
+	 * @return integer true if the table is a view.
149 149
 	 */
150 150
 	protected function getIsView($schemaName,$tableName)
151 151
 	{
@@ -167,6 +167,7 @@  discard block
 block discarded – undo
167 167
 	/**
168 168
 	 * @param TOracleTableInfo table information.
169 169
 	 * @param array column information.
170
+	 * @param TOracleTableInfo $tableInfo
170 171
 	 */
171 172
 	protected function processColumn($tableInfo, $col)
172 173
 	{
@@ -322,6 +323,7 @@  discard block
 block discarded – undo
322 323
 	/**
323 324
 	 * @param string column name.
324 325
 	 * @param TOracleTableInfo table information.
326
+	 * @param string $columnId
325 327
 	 * @return boolean true if column is a foreign key.
326 328
 	 */
327 329
 	protected function isForeignKeyColumn($columnId, $tableInfo)
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -203,11 +203,9 @@  discard block
 block discarded – undo
203 203
 				$info['NumericPrecision'] = intval($matches[1]);
204 204
 				if(count($matches) > 2)
205 205
 					$info['NumericScale'] = intval($matches[2]);
206
-			}
207
-			else
206
+			} else
208 207
 				$info['ColumnSize'] = intval($matches[1]);
209
-		}
210
-		else
208
+		} else
211 209
 			$info['DbType'] = $col['type'];
212 210
 		$tableInfo->Columns[$columnId] = new TOracleTableColumn($info);
213 211
 	}
@@ -349,8 +347,7 @@  discard block
 block discarded – undo
349 347
 SELECT table_name, '{$schema}' as table_schema FROM user_tables
350 348
 EOD;
351 349
 			$command=$this->getDbConnection()->createCommand($sql);
352
-		}
353
-		else
350
+		} else
354 351
 		{
355 352
 			$sql=<<<EOD
356 353
 SELECT object_name as table_name, owner as table_schema FROM all_objects
Please login to merge, or discard this patch.
framework/Data/Common/Pgsql/TPgsqlMetaData.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -204,6 +204,7 @@
 block discarded – undo
204 204
 	/**
205 205
 	 * @param TPgsqlTableInfo table information.
206 206
 	 * @param array column information.
207
+	 * @param TPgsqlTableInfo $tableInfo
207 208
 	 */
208 209
 	protected function processColumn($tableInfo, $col)
209 210
 	{
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -244,11 +244,9 @@
 block discarded – undo
244 244
 				$info['NumericPrecision'] = intval($matches[1]);
245 245
 				if(count($matches) > 2)
246 246
 					$info['NumericScale'] = intval($matches[2]);
247
-			}
248
-			else
247
+			} else
249 248
 				$info['ColumnSize'] = intval($matches[1]);
250
-		}
251
-		else
249
+		} else
252 250
 			$info['DbType'] = $col['type'];
253 251
 
254 252
 		$tableInfo->Columns[$columnId] = new TPgsqlTableColumn($info);
Please login to merge, or discard this patch.
framework/Data/Common/TDbMetaData.php 1 patch
Doc Comments   -6 removed lines patch added patch discarded remove patch
@@ -127,8 +127,6 @@  discard block
 block discarded – undo
127 127
 	/**
128 128
 	 * Quotes a table name for use in a query.
129 129
 	 * @param string $name table name
130
-	 * @param string $lft left delimiter
131
-	 * @param string $rgt right delimiter
132 130
 	 * @return string the properly quoted table name
133 131
 	 */
134 132
 	public function quoteTableName($name)
@@ -150,8 +148,6 @@  discard block
 block discarded – undo
150 148
 	/**
151 149
 	 * Quotes a column name for use in a query.
152 150
 	 * @param string $name column name
153
-	 * @param string $lft left delimiter
154
-	 * @param string $rgt right delimiter
155 151
 	 * @return string the properly quoted column name
156 152
 	 */
157 153
 	public function quoteColumnName($name)
@@ -166,8 +162,6 @@  discard block
 block discarded – undo
166 162
 	/**
167 163
 	 * Quotes a column alias for use in a query.
168 164
 	 * @param string $name column alias
169
-	 * @param string $lft left delimiter
170
-	 * @param string $rgt right delimiter
171 165
 	 * @return string the properly quoted column alias
172 166
 	 */
173 167
 	public function quoteColumnAlias($name)
Please login to merge, or discard this patch.
framework/Data/Common/TDbTableColumn.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -34,6 +34,7 @@
 block discarded – undo
34 34
 	/**
35 35
 	 * @param string information array key name
36 36
 	 * @param mixed default value if information array value is null
37
+	 * @param string $name
37 38
 	 * @return mixed information array value.
38 39
 	 */
39 40
 	protected function getInfo($name,$default=null)
Please login to merge, or discard this patch.