TAuthorizationRule::_getZappableSleepProps() - Code Metrics - Inspection of "TAuthorizationRule Update & TPageConfiguration ext..." - pradosoft/prado - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#795)

unknown
created 2021-07-13 21:54 UTC
TAuthorizationRule::_getZappableSleepProps() F

↳ Parent: TAuthorizationRule
Complexity

Conditions	12
Paths	512
Size

Total Lines	30
Code Lines	19
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	156
Importance

Changes
Metric	Value
cc	12
eloc	19
c	0
b	0
f	0
nc	512
nop	1
dl	0
loc	30
rs	3.4777
ccs	0
cts	0
cp	0
crap	156
How to fix Complexity

<?php
/**
 * TAuthorizationRule, TAuthorizationRuleCollection class file
 *
 * @author Qiang Xue <[email protected]>
 * @link https://github.com/pradosoft/prado
 * @license https://github.com/pradosoft/prado/blob/master/LICENSE
 * @package Prado\Security
 */

namespace Prado\Security;

use Prado\Exceptions\TInvalidDataValueException;

/**
 * TAuthorizationRule class
 *
 * TAuthorizationRule represents a single authorization rule.
 * A rule is specified by an action (required), a list of users (optional),
 * a list of roles (optional), a verb (optional), and a list of IP rules (optional).
 * Action can be either 'allow' or 'deny'.
 * Guest (anonymous, unauthenticated) users are represented by question mark '?'.
 * All users (including guest users) are represented by asterisk '*'.
 * Authenticated users are represented by '@'.
 * Users/roles are case-insensitive.
 * Different users/roles are separated by comma ','.
 * Verb can be either 'get' or 'post'. If it is absent, it means both.
 * IP rules are separated by comma ',' and can contain wild card in the rules (e.g. '192.132.23.33, 192.122.*.*')
 *
 * @author Qiang Xue <[email protected]>
 * @package Prado\Security
 * @since 3.0
 */
class TAuthorizationRule extends \Prado\TComponent implements \Prado\Collections\IPriorityItem
{
	/**
	 * @var string action, either 'allow' or 'deny'
	 */
	private $_action = 'allow';
	/**
	 * @var array list of user IDs
	 */
	private $_users = [];
	/**
	 * @var array list of roles
	 */
	private $_roles = ['*'];
	/**
	 * @var string verb, may be empty, 'get', or 'post'.
	 */
	private $_verb = '*';
	/**
	 * @var string IP patterns
	 */
	private $_ipRules = ['*'];
	/**
	 * @var numeric priority of the rule
filter:
    dependency_paths: ["lib/*"]
	 */
	private $_priority;
	/**
	 * @var bool if this rule applies to everyone
	 */
	private $_everyone = true;
	/**
	 * @var bool if this rule applies to guest user
	 */
	private $_guest = false;
	/**
	 * @var bool if this rule applies to authenticated users
	 */
	private $_authenticated = false;

	/**
	 * Constructor.
	 * @param string $action action, either 'deny' or 'allow'
	 * @param string $users a comma separated user list
	 * @param string $roles a comma separated role list
	 * @param string $verb verb, can be empty, 'get', or 'post'
	 * @param string $ipRules IP rules (separated by comma, can contain wild card *)
	 * @param null|numeric $priority
	 */
	public function __construct($action = 'allow', $users = '', $roles = '', $verb = '', $ipRules = '', $priority = '')
	{
		$action = strtolower(trim($action));
		if ($action === 'allow' || $action === 'deny') {
			$this->_action = $action;
		} else {
			throw new TInvalidDataValueException('authorizationrule_action_invalid', $action);
		}
		
		$this->_users = [];
		$this->_everyone = false;
		$this->_guest = false;
		$this->_authenticated = false;
		if (trim($users) === '') {
			$users = '*';
		}
		foreach (explode(',', $users) as $user) {
			if (($user = trim(strtolower($user))) !== '') {
				if ($user === '*') {
					$this->_everyone = true;
					break;
				} elseif ($user === '?') {
					$this->_guest = true;
				} elseif ($user === '@') {
					$this->_authenticated = true;
				} else {
					$this->_users[] = $user;
				}
			}
		}
		
		$this->_roles = [];
		if (trim($roles) === '') {
			$roles = '*';
		}
		foreach (explode(',', $roles) as $role) {
			if (($role = trim(strtolower($role))) !== '') {
				$this->_roles[] = $role;
			}
		}
		
		if (($verb = trim(strtolower($verb))) === '') {
			$verb = '*';
		}
		if ($verb === '*' || $verb === 'get' || $verb === 'post') {
			$this->_verb = $verb;
		} else {
			throw new TInvalidDataValueException('authorizationrule_verb_invalid', $verb);
		}
		
		$this->_ipRules = [];

		if (trim($ipRules) === '') {
			$ipRules = '*';
		}
		foreach (explode(',', $ipRules) as $ipRule) {
			if (($ipRule = trim($ipRule)) !== '') {
				$this->_ipRules[] = $ipRule;
			}
		}
		
		$this->_priority = is_numeric($priority) ? $priority : null;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

		parent::__construct();
	}

	/**
	 * @return string action, either 'allow' or 'deny'
	 */
	public function getAction()
	{
		return $this->_action;
	}

	/**
	 * @return string[] list of user IDs
	 */
	public function getUsers()
	{
		return $this->_users;
	}

	/**
	 * @return string[] list of roles
	 */
	public function getRoles()
	{
		return $this->_roles;
	}

	/**
	 * @return string verb, may be '*', 'get', or 'post'.
	 */
	public function getVerb()
	{
		return $this->_verb;
	}

	/**
	 * @return array list of IP rules.
	 * @since 3.1.1
	 */
	public function getIPRules()
	{
		return $this->_ipRules;

	}

	/**
	 * @return numeric priority of the rule.
	 * @since 4.2.0
	 */
	public function getPriority()
	{
		return $this->_priority;
	}

	/**
	 * @return bool if this rule applies to everyone
	 */
	public function getGuestApplied()
	{
		return $this->_guest || $this->_everyone;
	}

	/**
	 * @return bool if this rule applies to everyone
	 */
	public function getEveryoneApplied()
	{
		return $this->_everyone;
	}

	/**
	 * @return bool if this rule applies to authenticated users
	 */
	public function getAuthenticatedApplied()
	{
		return $this->_authenticated || $this->_everyone;
	}

	/**
	 * @param IUser $user the user object
	 * @param string $verb the request verb (GET, PUT)
	 * @param string $ip the request IP address
	 * @param null|mixed $extra
	 * @return int 1 if the user is allowed, -1 if the user is denied, 0 if the rule does not apply to the user
	 */
	public function isUserAllowed(IUser $user, $verb, $ip, $extra = null)
	public function isUserAllowed(IUser $user, $verb, $ip, /** @scrutinizer ignore-unused */ $extra = null)
	{
		if ($this->isVerbMatched($verb) && $this->isIpMatched($ip) && $this->isUserMatched($user) && $this->isRoleMatched($user)) {
			return ($this->_action === 'allow') ? 1 : -1;
		} else {
			return 0;
		}
	}

	private function isIpMatched($ip)
	{
		if (empty($this->_ipRules)) {
			return 1;
		}
		foreach ($this->_ipRules as $rule) {

			if ($rule === '*' || $rule === $ip || (($pos = strpos($rule, '*')) !== false && strncmp($ip, $rule, $pos) === 0)) {
				return 1;
			}
		}
		return 0;
	}

	private function isUserMatched($user)
	{
		return ($this->_everyone || ($this->_guest && $user->getIsGuest()) || ($this->_authenticated && !$user->getIsGuest()) || in_array(strtolower($user->getName()), $this->_users));
	}

	private function isRoleMatched($user)
	{
		foreach ($this->_roles as $role) {
			if ($role === '*' || $user->isInRole($role)) {
				return true;
			}
		}
		return false;
	}

	private function isVerbMatched($verb)
	{
		return ($this->_verb === '*' || strcasecmp($verb, $this->_verb) === 0);
	}
	
	/**
	 * Returns an array with the names of all variables of this object that should NOT be serialized
	 * because their value is the default one or useless to be cached for the next load.
	 * Reimplement in derived classes to add new variables, but remember to also to call the parent
	 * implementation first.
	 * @param array $exprops by reference
	 */
	protected function _getZappableSleepProps(&$exprops)
	{
		parent::_getZappableSleepProps($exprops);
		
		if ($this->_action === 'allow') {
			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_action";
		}
		if ($this->_users === []) {
			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_users";
		}
		if (count($this->_roles) === 1 && $this->_roles[0] === '*') {
			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_roles";
		}
		if ($this->_verb === '*') {
			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_verb";
		}
		if (count($this->_ipRules) === 1 && $this->_ipRules[0] === '*') {
		if (count(/** @scrutinizer ignore-type */ $this->_ipRules) === 1 && $this->_ipRules[0] === '*') {
			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_ipRules";
		}
		if ($this->_everyone == true) {

			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_everyone";
		}
		if ($this->_guest == false) {

			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_guest";
		}
		if ($this->_authenticated == false) {

			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_authenticated";
		}
		if ($this->_priority === null) {
			$exprops[] = "\0Prado\Security\TAuthorizationRule\0_priority";
		}
	}
}

pradosoft / prado

Pull Request — master (#795)

TAuthorizationRule::_getZappableSleepProps() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like
