pradosoft / prado

tests/test_tools/simpletest/HtmlReporterWithCoverage.php

Braces +18 added lines, -14 removed lines

@@ -1,9 +1,10 @@ 
 <?php
 
-if (!defined('T_ML_COMMENT'))
+if (!defined('T_ML_COMMENT')) {
 	define('T_ML_COMMENT', T_COMMENT);
-else
+} else {
 	define('T_DOC_COMMENT', T_ML_COMMENT);
+}
 
 class HtmlReporterWithCoverage extends HtmlReporter
 {
@@ -32,8 +33,9 @@ 
 		print "<h1>$test_name</h1>\n";
 		flush();
 
-		if (extension_loaded('xdebug'))
-			xdebug_start_code_coverage(XDEBUG_CC_UNUSED);
+		if (extension_loaded('xdebug')) {
+					xdebug_start_code_coverage(XDEBUG_CC_UNUSED);
+		}
 
 	}
 
@@ -91,8 +93,9 @@ 
 	function paintCoverage()
 	{
 		$dir = dirname(__FILE__);
-		if(count($this->coverage) > 0)
-			print '<h2>Code Coverage</h2>';
+		if(count($this->coverage) > 0) {
+					print '<h2>Code Coverage</h2>';
+		}
 
 
 		ksort($this->coverage);
@@ -175,10 +178,11 @@ 
 			$line = htmlspecialchars($line);
 			$line = str_replace(' ','&nbsp;',$line);
 			$line = str_replace("\t",'&nbsp;&nbsp;&nbsp;&nbsp;',$line);
-			if(in_array($count+1, $this->lines))
-			echo "<div class=\"highlight\"><tt>$num $line</tt></div>\n";
-			else
-			echo "<tt>$num $line</tt><br />\n";
+			if(in_array($count+1, $this->lines)) {
+						echo "<div class=\"highlight\"><tt>$num $line</tt></div>\n";
+			} else {
+						echo "<tt>$num $line</tt><br />\n";
+			}
 		}
 
 		$this->paintFooter();
@@ -224,8 +228,7 @@ 
 			{
 				// simple 1-character token
 				$lines .= $token;
-			}
-			else
+			} else
 			{
 					// token array
 				list($id, $text) = $token;
@@ -256,8 +259,9 @@ 
 		$pattern = '/'.implode('|', $patterns).'/';
 		foreach($codelines as $line)
 		{
-			if(!preg_match($pattern, $line))
-				$count++;
+			if(!preg_match($pattern, $line)) {
+							$count++;
+			}
 		}
 		return $count;
 		//var_dump($codelines);

tests/test_tools/PradoGenericSelenium2Test.php

Braces +6 added lines, -4 removed lines

@@ -163,13 +163,15 @@
 		{
 			$this->keys(PHPUnit_Extensions_Selenium2TestCase_Keys::END);
 			// the number 100 is purely empiric
-			for($i=0;$i<100;$i++)
-				$this->keys(PHPUnit_Extensions_Selenium2TestCase_Keys::BACKSPACE);
+			for($i=0;$i<100;$i++) {
+							$this->keys(PHPUnit_Extensions_Selenium2TestCase_Keys::BACKSPACE);
+			}
 
 			$this->keys(PHPUnit_Extensions_Selenium2TestCase_Keys::HOME);
 			// the number 100 is purely empiric
-			for($i=0;$i<100;$i++)
-				$this->keys(PHPUnit_Extensions_Selenium2TestCase_Keys::DELETE);
+			for($i=0;$i<100;$i++) {
+							$this->keys(PHPUnit_Extensions_Selenium2TestCase_Keys::DELETE);
+			}
 		}
 
 		$element->value($txt);

tests/unit/TComponentTest.php

Braces +24 added lines, -15 removed lines

@@ -95,7 +95,9 @@ 
 		return $this->_callorder;
 	}
 	public function __dycall($method, $args) {
-		if(strncasecmp($method,'fx',2)!==0) return;
+		if(strncasecmp($method,'fx',2)!==0) {
+			return;
+		}
 		$this->_callorder[] = 'fxcall';
 	}
 	public function fxGlobalListener($sender,$param,$name) {
@@ -176,14 +178,18 @@ 
 }
 class DynamicCallComponent extends NewComponent implements IDynamicMethods {
 	public function __dycall($method, $args) {
-		if($method === 'dyPowerFunction')
-			return pow($args[0], $args[1]);
-		if($method === 'dyDivisionFunction')
-			return $args[0] / $args[1];
-		if($method === 'fxPowerFunction')
-			return 2*pow($args[0], $args[1]);
-		if($method === 'fxDivisionFunction')
-			return 2*$args[0] / $args[1];
+		if($method === 'dyPowerFunction') {
+					return pow($args[0], $args[1]);
+		}
+		if($method === 'dyDivisionFunction') {
+					return $args[0] / $args[1];
+		}
+		if($method === 'fxPowerFunction') {
+					return 2*pow($args[0], $args[1]);
+		}
+		if($method === 'fxDivisionFunction') {
+					return 2*$args[0] / $args[1];
+		}
 	}
 }
 
@@ -370,8 +376,9 @@ 
 	}
 	public function __dycall($method, $args) {
 		$this->_dyMethod = $method;
-		if($method == 'dyTestDynamicBehaviorMethod')
-			return $args[0] / $args[1];
+		if($method == 'dyTestDynamicBehaviorMethod') {
+					return $args[0] / $args[1];
+		}
 	}
 	public function dyTestIntraEvent($param1, $param2, $chain) {
 		return $chain->dyTestIntraEvent($param1*2*$param2, $param2);
@@ -391,8 +398,9 @@ 
 	public function __dycall($method, $args) {
 		$this->_dyMethod = $method;
 		$object = array_shift($args);
-		if($method == 'dyTestDynamicClassBehaviorMethod')
-			return $args[0] / $args[1];
+		if($method == 'dyTestDynamicClassBehaviorMethod') {
+					return $args[0] / $args[1];
+		}
 	}
 	public function dyTestIntraEvent($object, $param1, $param2, $chain) {
 		return $chain->dyTestIntraEvent($param1*2*$param2, $param2);
@@ -420,8 +428,9 @@ 
   public function tearDown() {
   	// PHP version 5.3.6 doesn't call the __destruct method when unsetting variables;
   	//	Thus any object that listens must be explicitly call unlisten in this version of PHP.
-  	if($this->component)
-	    $this->component->unlisten();
+  	if($this->component) {
+  		    $this->component->unlisten();
+  	}
     $this->component = null;
   }
 

tests/unit/Collections/TPriorityListTest.php

Braces +48 added lines, -72 removed lines

@@ -117,8 +117,7 @@ 
 		try {
 			$list->add(1);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 	}
 	
@@ -132,8 +131,7 @@ 
 		try {
 			$this->list->insertAt(4, $this->item3);
 			$this->fail('exception not raised when adding item at an out-of-range index');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 	}
 	
@@ -143,14 +141,12 @@ 
 		try {
 			$list->insertAt(1, 2);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 		try {
 			$list->insertAt(0, 2);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 	}
 	
@@ -159,8 +155,7 @@ 
 		try {
 			$this->list->insertBefore($this->item4, $this->item3);
 			$this->fail('exception not raised when adding item before a non-existant base item');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 		$this->assertEquals(2, $this->list->getCount());
 		$this->assertEquals(0, $this->list->insertBefore($this->item1, $this->item3));
@@ -178,14 +173,12 @@ 
 		try {
 			$list->insertBefore(5, 6);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 		try {
 			$list->insertBefore(8, 6);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 	}
 	
@@ -194,8 +187,7 @@ 
 		try {
 			$this->list->insertAfter($this->item4, $this->item3);
 			$this->fail('exception not raised when adding item after a non-existant base item');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 		$this->assertEquals(2, $this->list->getCount());
 		$this->assertEquals(2, $this->list->insertAfter($this->item2, $this->item3));
@@ -213,14 +205,12 @@ 
 		try {
 			$list->insertAfter(5, 6);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 		try {
 			$list->insertAfter(8, 6);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 	}
 	
@@ -233,8 +223,7 @@ 
 		try {
 			$this->list->remove($this->item1);
 			$this->fail('exception not raised when removing nonexisting item');
-		}
-		catch (Exception $e) {
+		} catch (Exception $e) {
 		}
 	}
 	
@@ -246,8 +235,7 @@ 
 		try {
 			$list->remove(2);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 		
 		$list = new TPriorityList(array(
@@ -256,8 +244,7 @@ 
 		try {
 			$list->remove(10);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 	}
 	
@@ -271,8 +258,7 @@ 
 		try {
 			$this->list->removeAt(2);
 			$this->fail('exception not raised when removing item with invalid index');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 	}
 	
@@ -284,8 +270,7 @@ 
 		try {
 			$list->removeAt(2);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 		
 		$list = new TPriorityList(array(
@@ -294,8 +279,7 @@ 
 		try {
 			$list->removeAt(10);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 	}
 	
@@ -314,8 +298,7 @@ 
 		), true);
 		try {
 			$list->clear();
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 			return;
 		}
 		self::fail('An expected TInvalidOperationException was not raised');
@@ -345,8 +328,7 @@ 
 		try {
 			$this->list->copyFrom($this);
 			$this->fail('exception not raised when copying from non-traversable object');
-		}
-		catch (TInvalidDataTypeException $e) {
+		} catch (TInvalidDataTypeException $e) {
 		}
 	}
 	
@@ -360,8 +342,7 @@ 
 		try {
 			$this->list->mergeWith($this);
 			$this->fail('exception not raised when copying from non-traversable object');
-		}
-		catch (TInvalidDataTypeException $e) {
+		} catch (TInvalidDataTypeException $e) {
 		}
 	}
 	
@@ -378,8 +359,7 @@ 
 		try {
 			$a = $this->list[2];
 			$this->fail('exception not raised when accessing item with out-of-range index');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 	}
 	
@@ -390,10 +370,12 @@ 
 		foreach ($this->list as $index => $item) {
 			foreach ($this->list as $a => $b); // test of iterator
 			$n++;
-			if ($index === 0 && $item === $this->item1)
-				$found++;
-			if ($index === 1 && $item === $this->item2)
-				$found++;
+			if ($index === 0 && $item === $this->item1) {
+							$found++;
+			}
+			if ($index === 1 && $item === $this->item2) {
+							$found++;
+			}
 		}
 		$this->assertTrue($n == 2 && $found == 2);
 	}
@@ -552,8 +534,7 @@ 
 		try {
 			$plist->insertAt(5, $this->pitem3);
 			$this->fail('exception not raised when adding item at an out-of-range index');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 		$this->assertEquals(100, $plist->priorityAt(4));
 	}
@@ -588,22 +569,19 @@ 
 		try {
 			$plist->remove($this->pitem5);
 			$this->fail('Exception not raised: TInvalidDataValueException: The item cannot be found in the list');
-		}
-		catch (TInvalidDataValueException $v) {
+		} catch (TInvalidDataValueException $v) {
 		}
 		
 		try {
 			$plist->remove($this->pitem3, null);
 			$this->fail('Exception not raised: TInvalidDataValueException: The item cannot be found in the list');
-		}
-		catch (TInvalidDataValueException $v) {
+		} catch (TInvalidDataValueException $v) {
 		}
 		
 		try {
 			$plist->remove($this->pitem1, 100);
 			$this->fail('Exception not raised: TInvalidDataValueException: The item cannot be found in the list');
-		}
-		catch (TInvalidDataValueException $v) {
+		} catch (TInvalidDataValueException $v) {
 		}
 		
 		$plist->insertBefore($this->pitem3, $this->pitem4);
@@ -621,8 +599,7 @@ 
 		try {
 			$plist->removeAt(3);
 			$this->fail('exception not raised when removing item with invalid index');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 	}
 	
@@ -773,8 +750,7 @@ 
 		try {
 			$list->insertAtIndexInPriority(1);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 	}
 	
@@ -785,8 +761,7 @@ 
 		try {
 			$plist->removeAtIndexInPriority(1, 100);
 			$this->fail('TInvalidDataValueException not raised when accessing item with out-of-range index');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 		$this->assertEquals($this->pitem2, $plist->removeAtIndexInPriority(1));
 		$this->assertEquals($this->pitem3, $plist->removeAtIndexInPriority(0, 100));
@@ -794,8 +769,7 @@ 
 		try {
 			$plist->removeAtIndexInPriority(0, 200);
 			$this->fail('TInvalidDataValueException not raised when accessing item with out-of-range index');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 		$this->assertEquals($this->pfirst, $plist->removeAtIndexInPriority(0, -10000000));
 		$this->assertEquals(0, $plist->getCount());
@@ -808,8 +782,7 @@ 
 		try {
 			$plist->removeAtIndexInPriority(0);
 			self::fail('An expected TInvalidOperationException was not raised');
-		}
-		catch (TInvalidOperationException $e) {
+		} catch (TInvalidOperationException $e) {
 		}
 	}
 	
@@ -1043,8 +1016,7 @@ 
 		try {
 			$a = $this->plist[4];
 			$this->fail('exception not raised when accessing item with out-of-range index');
-		}
-		catch (TInvalidDataValueException $e) {
+		} catch (TInvalidDataValueException $e) {
 		}
 	}
 	
@@ -1057,14 +1029,18 @@ 
 		
 		foreach ($this->plist as $index => $item) {
 			$n++;
-			if ($index === 0 && $item === $this->pfirst)
-				$found++;
-			if ($index === 1 && $item === $this->pitem1)
-				$found++;
-			if ($index === 2 && $item === $this->pitem2)
-				$found++;
-			if ($index === 3 && $item === $this->pitem3)
-				$found++;
+			if ($index === 0 && $item === $this->pfirst) {
+							$found++;
+			}
+			if ($index === 1 && $item === $this->pitem1) {
+							$found++;
+			}
+			if ($index === 2 && $item === $this->pitem2) {
+							$found++;
+			}
+			if ($index === 3 && $item === $this->pitem3) {
+							$found++;
+			}
 		}
 		$this->assertTrue($n == 4 && $found == 4);
 	}

tests/unit/Collections/TListTest.php

Braces +6 added lines, -4 removed lines

@@ -288,10 +288,12 @@
 		foreach($this->list as $index=>$item) {
 			foreach($this->list as $a=>$b);	// test of iterator
 				$n++;
-			if($index===0 && $item===$this->item1)
-				$found++;
-			if($index===1 && $item===$this->item2)
-				$found++;
+			if($index===0 && $item===$this->item1) {
+							$found++;
+			}
+			if($index===1 && $item===$this->item2) {
+							$found++;
+			}
 		}
 		$this->assertTrue($n==2 && $found==2);
 	}

tests/unit/Collections/TPriorityMapTest.php

Braces +9 added lines, -10 removed lines

@@ -127,8 +127,7 @@ 
 		{
 			$this->map->copyFrom($this);
 			$this->fail('no exception raised when copying a non-traversable object');
-		}
-		catch(TInvalidDataTypeException $e)
+		} catch(TInvalidDataTypeException $e)
 		{
 
 		}
@@ -145,8 +144,7 @@ 
 		{
 			$this->map->mergeWith($this);
 			$this->fail('no exception raised when copying a non-traversable object');
-		}
-		catch(TInvalidDataTypeException $e)
+		} catch(TInvalidDataTypeException $e)
 		{
 
 		}
@@ -174,8 +172,7 @@ 
 		{
 			unset($this->map['unknown key']);
 
-		}
-		catch(Exception $e)
+		} catch(Exception $e)
 		{
 			$this->fail('exception raised when unsetting element with unknown key');
 		}
@@ -188,10 +185,12 @@ 
 		foreach($this->map as $index=>$item)
 		{
 			$n++;
-			if($index==='key1' && $item===$this->item1)
-				$found++;
-			if($index==='key2' && $item===$this->item2)
-				$found++;
+			if($index==='key1' && $item===$this->item1) {
+							$found++;
+			}
+			if($index==='key2' && $item===$this->item2) {
+							$found++;
+			}
 		}
 		$this->assertTrue($n==2 && $found==2);
 	}

tests/unit/I18N/core/ChoiceFormatTest.php

Braces +9 added lines, -6 removed lines

@@ -55,8 +55,9 @@ 
 						'pliko\'w' => array(5,6,7,11,12,15,17,20,21,25,26,30));
 		foreach($wants as $want => $numbers)
 		{
-			foreach($numbers as $n)
-				$this->assertEquals($want, $choice->format($string, $n));
+			foreach($numbers as $n) {
+							$this->assertEquals($want, $choice->format($string, $n));
+			}
 		}
 	}
 
@@ -74,8 +75,9 @@ 
 			);
 		foreach($wants as $want => $numbers)
 		{
-			foreach($numbers as $n)
-				$this->assertEquals($want, $choice->format($string, $n));
+			foreach($numbers as $n) {
+							$this->assertEquals($want, $choice->format($string, $n));
+			}
 		}
 	}
 
@@ -92,8 +94,9 @@ 
 			);
 		foreach($wants as $want => $numbers)
 		{
-			foreach($numbers as $n)
-				$this->assertEquals($want, $choice->format($string, $n));
+			foreach($numbers as $n) {
+							$this->assertEquals($want, $choice->format($string, $n));
+			}
 		}
 	}
 }

tests/unit/Util/TDateTimeStampTest.php

Braces +6 added lines, -4 removed lines

@@ -107,16 +107,18 @@
 		for ($max += $i; $i < $max; $i += $offset) {
 			$ret = $s->formatDate('m,d,Y,H,i,s',$i);
 			$arr = explode(',',$ret);
-			if ($lastyear != $arr[2])
-				$lastyear = $arr[2];
+			if ($lastyear != $arr[2]) {
+							$lastyear = $arr[2];
+			}
 
 			$newi = $s->getTimestamp($arr[3],$arr[4],$arr[5],$arr[0],$arr[1],$arr[2]);
 			if ($i != $newi) {
 				// This actually can fail if $i is in the middle of a time change due to DST
 				$tz = new DateTimeZone(date_default_timezone_get());
 				$transitions = $tz->getTransitions($i-3600, $i+3600);
-				if(count($transitions) == 0)
-					$fails++;
+				if(count($transitions) == 0) {
+									$fails++;
+				}
 
 				//$j = mktime($arr[3],$arr[4],$arr[5],$arr[0],$arr[1],$arr[2]);
 				//print "Error at $i, $j, getTimestamp() returned $newi ($ret)\n";

tests/unit/Caching/TDirectoryCacheDependencyTest.php

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
 		{
 			$dependency=new TDirectoryCacheDependency(dirname(__FILE__).'/temp2');
 			$this->fail("Expected exception is not raised");
-		}
-		catch(TInvalidDataValueException $e)
+		} catch(TInvalidDataValueException $e)
 		{
 		}
 	}