TNoUnserializeClassBehaviorTrait - Code Metrics - Inspection of "TTextBox: drop the unofficial autocomplete types" - pradosoft/prado - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — php8 ( bd75dc...d8afb4 )

by Fabio

created 2023-04-17 09:14 UTC

TNoUnserializeClassBehaviorTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	4
c	1
b	0
f	0
dl	0
loc	14
rs	10
wmc	2

1 Method

Rating	Name	Duplication	Size	Complexity
A	dyWakeUp()	0	6	2

<?php

/**
 * TNoUnserializeClassBehaviorTrait class file.
 *
 * @author Brad Anderson <[email protected]>
 * @link https://github.com/pradosoft/prado
 * @license https://github.com/pradosoft/prado/blob/master/LICENSE
 */

namespace Prado\Util\Behaviors;

use Prado\Util\TCallChain;

/**
 * TNoUnserializeClassBehaviorTrait class.
 *
 * When this trait is used by an IClassBehavior, upon the owner being unserialized
 * (via magic method __wakeup and dyWakeUp) this trait removes itself from its owner.
 *
 * This trait is used to deprecate serialized objects' IClassBehavior. By re-serializing
 * the object can be saved without the deprecated behavior.
 *
 * @author Brad Anderson <[email protected]>
 * @since 4.2.3
 */
trait TNoUnserializeClassBehaviorTrait
{
	/**
	 * This is raised when an owner is completed its unserialize() method call to
	 * __wakeup.  This method removes its behavior from the owner.
	 * @param object $owner The owner of he behavior raising the dynamic event.
	 * @param TCallChain $chain The chain of dynamic event method handlers.
	 */
	public function dyWakeUp(object $owner, TCallChain $chain)
	{
		if ($index = array_search($this, $owner->getBehaviors())) {
			$owner->detachBehavior($index);
		}
		return $chain->dyWakeUp();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
	}
}


1			<?php
2
3			/**
4			* TNoUnserializeClassBehaviorTrait class file.
5			*
6			* @author Brad Anderson <[email protected]>
7			* @link https://github.com/pradosoft/prado
8			* @license https://github.com/pradosoft/prado/blob/master/LICENSE
9			*/
10
11			namespace Prado\Util\Behaviors;
12
13			use Prado\Util\TCallChain;
14
15			/**
16			* TNoUnserializeClassBehaviorTrait class.
17			*
18			* When this trait is used by an IClassBehavior, upon the owner being unserialized
19			* (via magic method __wakeup and dyWakeUp) this trait removes itself from its owner.
20			*
21			* This trait is used to deprecate serialized objects' IClassBehavior. By re-serializing
22			* the object can be saved without the deprecated behavior.
23			*
24			* @author Brad Anderson <[email protected]>
25			* @since 4.2.3
26			*/
27			trait TNoUnserializeClassBehaviorTrait
28			{
29			/**
30			* This is raised when an owner is completed its unserialize() method call to
31			* __wakeup. This method removes its behavior from the owner.
32			* @param object $owner The owner of he behavior raising the dynamic event.
33			* @param TCallChain $chain The chain of dynamic event method handlers.
34			*/
35			public function dyWakeUp(object $owner, TCallChain $chain)
36			{
37			if ($index = array_search($this, $owner->getBehaviors())) {
38			$owner->detachBehavior($index);
39			}
40			return $chain->dyWakeUp();
			0 ignored issues – show Bug introduced 2023-04-14 04:35 UTC by Report Bug Copy Issue Report Are you sure the usage of `$chain->dyWakeUp()` targeting `Prado\TComponent::dyWakeUp()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
41			}
42			}
43

pradosoft / prado

Push — php8 ( bd75dc...d8afb4 )

TNoUnserializeClassBehaviorTrait A

Complexity

Size/Duplication

Importance

1 Method

Duplication Side-by-Side

Filter issues like