pradosoft / prado

framework/Collections/TPagedList.php

Spacing +2 added lines, -2 removed lines

@@ -324,7 +324,7 @@ 
 	public function indexOf($item)
 	{
 		$c = $this->getCount();
-		for ($i = 0;$i < $c;++$i) {
+		for ($i = 0; $i < $c; ++$i) {
 			if ($this->itemAt($i) === $item) {
 				return $i;
 			}
@@ -362,7 +362,7 @@ 
 	{
 		$c = $this->getCount();
 		$array = [];
-		for ($i = 0;$i < $c;++$i) {
+		for ($i = 0; $i < $c; ++$i) {
 			$array[$i] = $this->itemAt($i);
 		}
 		return $array;

Doc Comments +1 added lines, -1 removed lines

@@ -289,7 +289,7 @@
 	}
 
 	/**
-	 * @return Iterator iterator
+	 * @return \ArrayIterator iterator
 	 */
 	public function getIterator()
 	{

framework/Web/UI/WebControls/TDataList.php

Spacing +2 added lines, -2 removed lines

@@ -1340,7 +1340,7 @@ 
 		if (($separatorStyle = $this->getViewState('SeparatorStyle', null)) !== null && $this->getHasSeparators()) {
 			$controls = $this->getControls();
 			$count = $controls->getCount();
-			for ($i = $this->_header ? 2 : 1;$i < $count;$i += 2) {
+			for ($i = $this->_header ? 2 : 1; $i < $count; $i += 2) {
 				if (($separator = $controls->itemAt($i)) instanceof IStyleable) {
 					$separator->getStyle()->mergeWith($separatorStyle);
 				}
@@ -1398,7 +1398,7 @@ 
 			$editIndex = $this->getEditItemIndex();
 			$hasSeparator = $this->_separatorTemplate !== null || $this->getSeparatorRenderer() !== '';
 			$this->_header = $this->createItemInternal(-1, TListItemType::Header);
-			for ($i = 0;$i < $itemCount;++$i) {
+			for ($i = 0; $i < $itemCount; ++$i) {
 				if ($hasSeparator && $i > 0) {
 					$this->createItemInternal($i - 1, TListItemType::Separator);
 				}

Doc Comments +6 added lines, -3 removed lines

@@ -1131,7 +1131,7 @@ 
 	 * This method invokes {@link createItem} to create a new datalist item.
 	 * @param int $itemIndex zero-based item index.
 	 * @param TListItemType $itemType item type
-	 * @return TControl the created item, null if item is not created
+	 * @return \Prado\TComponent|null the created item, null if item is not created
 	 */
 	private function createItemInternal($itemIndex, $itemType)
 	{
@@ -1151,7 +1151,7 @@ 
 	 * @param int $itemIndex zero-based item index.
 	 * @param TListItemType $itemType item type
 	 * @param mixed $dataItem data to be associated with the item
-	 * @return TControl the created item, null if item is not created
+	 * @return \Prado\TComponent|null the created item, null if item is not created
 	 */
 	private function createItemWithDataInternal($itemIndex, $itemType, $dataItem)
 	{
@@ -1192,6 +1192,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $itemIndex
+	 */
 	private function getEditItemDisplay($itemIndex)
 	{
 		if (($classPath = $this->getEditItemRenderer()) === '' && $this->_editItemTemplate === null) {
@@ -1205,7 +1208,7 @@ 
 	 * Creates a datalist item instance based on the item type and index.
 	 * @param int $itemIndex zero-based item index
 	 * @param TListItemType $itemType item type
-	 * @return TControl created datalist item
+	 * @return null|\Prado\TComponent created datalist item
 	 */
 	protected function createItem($itemIndex, $itemType)
 	{

framework/Web/UI/WebControls/TDataGrid.php

Spacing +3 added lines, -3 removed lines

@@ -943,7 +943,7 @@ 
 			}
 			$selectedIndex = $this->getSelectedItemIndex();
 			$editIndex = $this->getEditItemIndex();
-			for ($index = 0;$index < $itemCount;++$index) {
+			for ($index = 0; $index < $itemCount; ++$index) {
 				if ($index === 0) {
 					if ($allowPaging) {
 						$this->_topPager = $this->createPager();
@@ -1310,7 +1310,7 @@ 
 			$controls->add("\n");
 		}
 
-		for ($i = $startPageIndex;$i <= $endPageIndex;++$i) {
+		for ($i = $startPageIndex; $i <= $endPageIndex; ++$i) {
 			if ($i === $pageIndex) {
 				$label = $this->createPagerButton($pager, $buttonType, false, "$i", '', '');
 				$controls->add($label);
@@ -1493,7 +1493,7 @@ 
 			if ($this->_columns && $itemType !== TListItemType::Pager) {
 				$n = $this->_columns->getCount();
 				$cells = $item->getCells();
-				for ($i = 0;$i < $n;++$i) {
+				for ($i = 0; $i < $n; ++$i) {
 					$cell = $cells->itemAt($i);
 					$column = $this->_columns->itemAt($i);
 					if (!$column->getVisible()) {

Doc Comments +6 added lines, -1 removed lines

@@ -1119,6 +1119,11 @@ 
 		return new TDataGridItem($itemIndex, $dataSourceIndex, $itemType);
 	}
 
+	/**
+	 * @param integer $itemIndex
+	 * @param boolean $dataBind
+	 * @param TList $columns
+	 */
 	private function createItemInternal($itemIndex, $dataSourceIndex, $itemType, $dataBind, $dataItem, $columns)
 	{
 		$item = $this->createItem($itemIndex, $dataSourceIndex, $itemType);
@@ -1192,7 +1197,7 @@ 
 	 * Depending on the button type, a TLinkButton or a TButton may be created.
 	 * If it is enabled (clickable), its command name and parameter will also be set.
 	 * Derived classes may override this method to create additional types of buttons, such as TImageButton.
-	 * @param mixed $pager the container pager instance of TActiveDatagridPager
+	 * @param TDataGridPager $pager the container pager instance of TActiveDatagridPager
 	 * @param string $buttonType button type, either LinkButton or PushButton
 	 * @param bool $enabled whether the button should be enabled
 	 * @param string $text caption of the button

framework/Web/UI/WebControls/TRepeatInfo.php

Spacing +9 added lines, -9 removed lines

@@ -188,7 +188,7 @@ 
 		// render items
 		$hasSeparators = $user->getHasSeparators();
 		$itemCount = $user->getItemCount();
-		for ($i = 0;$i < $itemCount;++$i) {
+		for ($i = 0; $i < $itemCount; ++$i) {
 			$user->renderItem($writer, $this, 'Item', $i);
 			if ($hasSeparators && $i != $itemCount - 1) {
 				$user->renderItem($writer, $this, 'Separator', $i);
@@ -221,7 +221,7 @@ 
 		if ($tableLayout) {
 			$writer->renderBeginTag('tbody');
 			$column = 0;
-			for ($i = 0;$i < $itemCount;++$i) {
+			for ($i = 0; $i < $itemCount; ++$i) {
 				if ($column == 0) {
 					$writer->renderBeginTag('tr');
 				}
@@ -247,7 +247,7 @@ 
 					if ($hasSeparators) {
 						$restColumns = $restColumns ? $restColumns + $restColumns + 1 : 1;
 					}
-					for ($j = 0;$j < $restColumns;++$j) {
+					for ($j = 0; $j < $restColumns; ++$j) {
 						$writer->write("<td></td>\n");
 					}
 				}
@@ -260,7 +260,7 @@ 
 			$writer->renderEndTag();
 		} else {
 			$column = 0;
-			for ($i = 0;$i < $itemCount;++$i) {
+			for ($i = 0; $i < $itemCount; ++$i) {
 				$user->renderItem($writer, $this, 'Item', $i);
 				if ($hasSeparators && $i != $itemCount - 1) {
 					$user->renderItem($writer, $this, 'Separator', $i);
@@ -314,10 +314,10 @@ 
 		if ($tableLayout) {
 			$writer->renderBeginTag('tbody');
 			$renderedItems = 0;
-			for ($row = 0;$row < $rows;++$row) {
+			for ($row = 0; $row < $rows; ++$row) {
 				$index = $row;
 				$writer->renderBeginTag('tr');
-				for ($col = 0;$col < $columns;++$col) {
+				for ($col = 0; $col < $columns; ++$col) {
 					if ($renderedItems >= $itemCount) {
 						break;
 					}
@@ -362,7 +362,7 @@ 
 					if ($hasSeparators) {
 						$restColumns += $restColumns;
 					}
-					for ($col = 0;$col < $restColumns;++$col) {
+					for ($col = 0; $col < $restColumns; ++$col) {
 						$writer->write("<td></td>\n");
 					}
 				}
@@ -372,9 +372,9 @@ 
 			$writer->renderEndTag();
 		} else {
 			$renderedItems = 0;
-			for ($row = 0;$row < $rows;++$row) {
+			for ($row = 0; $row < $rows; ++$row) {
 				$index = $row;
-				for ($col = 0;$col < $columns;++$col) {
+				for ($col = 0; $col < $columns; ++$col) {
 					if ($renderedItems >= $itemCount) {
 						break;
 					}

framework/Web/UI/WebControls/TPager.php

Spacing +1 added lines, -1 removed lines

@@ -591,7 +591,7 @@
 			$controls->add("\n");
 		}
 
-		for ($i = $startPageIndex;$i <= $endPageIndex;++$i) {
+		for ($i = $startPageIndex; $i <= $endPageIndex; ++$i) {
 			if ($i === $pageIndex) {
 				$label = $this->createPagerButton($buttonType, false, "$i", self::CMD_PAGE, '');
 				$controls->add($label);

framework/Web/UI/WebControls/TDatePicker.php

Spacing +3 added lines, -3 removed lines

@@ -718,7 +718,7 @@ 
 		$formatter = new TSimpleDateFormatter($this->getDateFormat());
 		$days = [];
 		$requiresPadding = $formatter->getDayPattern() === 'dd';
-		for ($i = 1;$i <= 31;$i++) {
+		for ($i = 1; $i <= 31; $i++) {
 			$days[$i] = $requiresPadding ? str_pad($i, 2, '0', STR_PAD_LEFT) : $i;
 		}
 		return $days;
@@ -761,12 +761,12 @@ 
 			case 'MMM': return $info->getAbbreviatedMonthNames();
 			case 'MM':
 				$array = [];
-				for ($i = 1;$i <= 12;$i++) {
+				for ($i = 1; $i <= 12; $i++) {
 					$array[$i - 1] = $i < 10 ? '0' . $i : $i;
 				}
 				return $array;
 			case 'M':
-				$array = []; for ($i = 1;$i <= 12;$i++) {
+				$array = []; for ($i = 1; $i <= 12; $i++) {
 					$array[$i - 1] = $i;
 				}
 				return $array;

Doc Comments +4 added lines, -4 removed lines

@@ -483,7 +483,7 @@ 
 	 * Loads date from drop down list data.
 	 * @param string $key the key that can be used to retrieve data from the input data collection
 	 * @param array $values the input data collection
-	 * @return array the date selected
+	 * @return string the date selected
 	 */
 	protected function getDateFromPostData($key, $values)
 	{
@@ -595,7 +595,7 @@ 
 	}
 
 	/**
-	 * @return DateTimeFormatInfo date time format information for the current culture.
+	 * @return \Prado\I18N\core\DateTimeFormatInfo date time format information for the current culture.
 	 */
 	protected function getLocalizedCalendarInfo()
 	{
@@ -647,7 +647,7 @@ 
 	/**
 	 * Renders the calendar drop down list depending on the DateFormat pattern.
 	 * @param THtmlWriter $writer the Html writer to render the drop down lists.
-	 * @param array $date the current selected date
+	 * @param \DateTime $date the current selected date
 	 */
 	protected function renderCalendarSelections($writer, $date)
 	{
@@ -755,7 +755,7 @@ 
 	 * Returns the localized month names that depends on the month format pattern.
 	 * "MMMM" will return the month names, "MM" or "MMM" return abbr. month names
 	 * and "M" return month digits.
-	 * @param DateTimeFormatInfo $info localized date format information.
+	 * @param \Prado\I18N\core\DateTimeFormatInfo $info localized date format information.
 	 * @return array localized month names.
 	 */
 	protected function getLocalizedMonthNames($info)

framework/Web/UI/WebControls/TTabPanel.php

Spacing +1 added lines, -1 removed lines

@@ -388,7 +388,7 @@
 	public function onPreRender($param)
 	{
 		parent::onPreRender($param);
-		$this->getActiveView();  // determine the active view
+		$this->getActiveView(); // determine the active view
 		$this->registerStyleSheet();
 
 		$page = $this->getPage();

framework/Web/UI/WebControls/TListControl.php

Spacing +2 added lines, -2 removed lines

@@ -460,7 +460,7 @@ 
 	{
 		if ($this->_items) {
 			$n = $this->_items->getCount();
-			for ($i = 0;$i < $n;++$i) {
+			for ($i = 0; $i < $n; ++$i) {
 				if ($this->_items->itemAt($i)->getSelected()) {
 					return $i;
 				}
@@ -497,7 +497,7 @@ 
 		$selections = [];
 		if ($this->_items) {
 			$n = $this->_items->getCount();
-			for ($i = 0;$i < $n;++$i) {
+			for ($i = 0; $i < $n; ++$i) {
 				if ($this->_items->itemAt($i)->getSelected()) {
 					$selections[] = $i;
 				}

Doc Comments +2 added lines, -2 removed lines

@@ -262,7 +262,7 @@ 
 	/**
 	 * Creates a collection object to hold list items.
 	 * This method may be overriden to create a customized collection.
-	 * @return TListItemCollection the collection object
+	 * @return \Prado\Collections\TListItemCollection the collection object
 	 */
 	protected function createListItemCollection()
 	{
@@ -738,7 +738,7 @@ 
 	 * Raises OnSelectedIndexChanged event when selection is changed.
 	 * This method is invoked when the list control has its selection changed
 	 * by end-users.
-	 * @param TEventParameter $param event parameter
+	 * @param null|integer $param event parameter
 	 */
 	public function onSelectedIndexChanged($param)
 	{

framework/Web/UI/WebControls/TCaptcha.php

Spacing +2 added lines, -2 removed lines

@@ -386,7 +386,7 @@ 
 	 */
 	protected function getTokenImageOptions()
 	{
-		$privateKey = $this->getPrivateKey();  // call this method to ensure private key is generated
+		$privateKey = $this->getPrivateKey(); // call this method to ensure private key is generated
 		$token = $this->getToken();
 		$options = [];
 		$options['publicKey'] = $this->getPublicKey();
@@ -473,7 +473,7 @@ 
 		$hexLength = strlen($hex);
 		$base = strlen($alphabet);
 		$result = '';
-		for ($i = 0;$i < $hexLength;$i += 6) {
+		for ($i = 0; $i < $hexLength; $i += 6) {
 			$number = hexdec(substr($hex, $i, 6));
 			while ($number) {
 				$result .= $alphabet[$number % $base];

Doc Comments +1 added lines, -1 removed lines

@@ -449,7 +449,7 @@
 	 * Generates the token.
 	 * @param string $publicKey public key
 	 * @param string $privateKey private key
-	 * @param mixed $alphabet
+	 * @param string $alphabet
 	 * @param int $tokenLength the length of the token
 	 * @param bool $caseSensitive whether the token is case sensitive
 	 * @return string the token generated.