Prado\Util\TSimpleDateFormatter::parse()

Complexity

Conditions	36
Paths	3008

Size

Total Lines	135
Code Lines	90

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	67
CRAP Score	53.6042

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function parse($value, $defaultToCurrentTime = true)
	{
		if (is_int($value) || is_float($value)) {
			return $value;
		}
		if (!is_string($value)) {

The condition is_string($value) is always true.

			throw new TInvalidDataValueException('date_to_parse_must_be_string', Prado::varDump($value));
		}

		if (empty($this->pattern)) {
			return time();
		}

		if ($this->length(trim($value)) < 1) {
			return $defaultToCurrentTime ? time() : null;
		}

		$pattern = $this->pattern;

		$i_val = 0;
		$i_format = 0;
		$pattern_length = $this->length($pattern);
		$token = '';

The assignment to $token is dead and can be removed.

		$x = null;
		$y = null;

		$year = null;
		$month = null;
		$day = null;

		while ($i_format < $pattern_length) {
			$c = $this->charAt($pattern, $i_format);
			$token = '';
			while ($this->charEqual($pattern, $i_format, $c)
						&& ($i_format < $pattern_length)) {
				$token .= $this->charAt($pattern, $i_format++);
			}

			switch ($token) {
				case 'yyyy':
				case 'yy':
				case 'y':
					{
						if ($token == 'yyyy') {
							$x = 4;
							$y = 4;
						}
						if ($token == 'yy') {
							$x = 2;
							$y = 2;
						}
						if ($token == 'y') {
							$x = 2;
							$y = 4;
						}
						$year = $this->getInteger($value, $i_val, $x, $y);
						if ($year === null) {
							return null;
						}
						$i_val += strlen($year);
						if (strlen($year) == 2) {
							$iYear = (int) $year;
							if ($iYear > 70) {
								$year = $iYear + 1900;
							} else {
								$year = $iYear + 2000;
							}
						}
						$year = (int) $year;
						break;
					}
				case 'MM':
				case 'M':
					{
						$month = $this->getInteger(
							$value,
							$i_val,
							$this->length($token),
							2
						);
						$iMonth = (int) $month;
						if ($month === null || $iMonth < 1 || $iMonth > 12) {
							return null;
						}
						$i_val += strlen($month);
						$month = $iMonth;
						break;
					}
				case 'dd':
				case 'd':
					{
						$day = $this->getInteger(
							$value,
							$i_val,
							$this->length($token),
							2
						);
						$iDay = (int) $day;
						if ($day === null || $iDay < 1 || $iDay > 31) {
							return null;
						}
						$i_val += strlen($day);
						$day = $iDay;
						break;
					}
				default:
					{
						if ($this->substring($value, $i_val, $this->length($token)) != $token) {
							return null;
						}
						$i_val += $this->length($token);
						break;
					}
			}
		}

		if ($i_val != $this->length($value)) {
			return null;
		}

		if ($year === null) {
			// always default to current year if empty
			$year = date('Y');
		}
		if ($month === null) {
			$month = $defaultToCurrentTime ? date('m') : 1;
		}
		if ($day === null) {
			$day = $defaultToCurrentTime ? date('d') : 1;
		}

		$s = new \DateTime();
		$s->setDate($year, $month, $day);

It seems like $month can also be of type string; however, parameter $month of DateTime::setDate() does only seem to accept integer, maybe add an additional type check?

It seems like $day can also be of type string; however, parameter $day of DateTime::setDate() does only seem to accept integer, maybe add an additional type check?

It seems like $year can also be of type string; however, parameter $year of DateTime::setDate() does only seem to accept integer, maybe add an additional type check?

		$s->setTime(0, 0, 0);
		return $s->getTimeStamp();
	}