ppshobi / psonic

src/SonicResponse.php

<?php

namespace Psonic;

use Psonic\Contracts\Response as ResponseInterface;
use Psonic\Exceptions\CommandFailedException;

class SonicResponse implements ResponseInterface 
{
    private $message;
    private $pieces;
    private $results;

    /**
     * SonicResponse constructor.
     * @param $message
     */
    public function __construct($message)
    {
        $this->message = (string) $message;
        $this->parse();
    }

    /**
     * parses the read buffer into a readable object
     * @throws CommandFailedException
     */
    private function parse()
    {
        $this->pieces = explode(" ", $this->message);

        if(preg_match_all("/buffer\((\d+)\)/", $this->message, $matches)) {
            $this->pieces['bufferSize'] = $matches[1][0];
        }

        $this->pieces['status'] = $this->pieces[0];
        unset($this->pieces[0]);

        if($this->pieces['status'] === 'ERR') {
            throw new CommandFailedException($this->message);
        }

        if($this->pieces['status'] === 'RESULT') {
            $this->pieces['count'] = (int) $this->pieces[1];
            unset($this->pieces[1]);
        }

        if($this->pieces['status'] === 'EVENT') {
            $this->pieces['query_key'] = $this->pieces[2];
            $this->results = array_slice($this->pieces, 2, count($this->pieces)-4);
        }
    }

    /**
     * @return mixed
     */
    public function getResults()
    {
        return $this->results;
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return implode(" ", $this->pieces);
    }

    /**
     * @param $key
     * @return mixed
     */
    public function get($key)
    {
        if(isset($this->pieces[$key])){
            return $this->pieces[$key];
        }
    }

    /**
     * @return mixed
     */
    public function getStatus(): string
    {
        return $this->get('status');

The expression return $this->get('status') could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    /**
     * @return int
     */
    public function getCount():int
    {
        return $this->get('count') ?? 0;
    }
}