ppshobi / psonic

src/Commands/Search/QueryCommand.php

<?php

namespace Psonic\Commands\Search;

use Psonic\Commands\Command;

final class QueryCommand extends Command
{
    private $command    = 'QUERY';
    private $parameters = [];

    /**
     * QueryCommand constructor.
     * @param string $collection
     * @param string $bucket
     * @param string $terms
     * @param null $limit

Are you sure the doc-type for parameter $limit is correct as it would always require null to be passed?

     * @param null $offset

Are you sure the doc-type for parameter $offset is correct as it would always require null to be passed?

     * @param null $locale

Are you sure the doc-type for parameter $locale is correct as it would always require null to be passed?

     */
    public function __construct(string $collection, string $bucket, string $terms, $limit = null, $offset = null, $locale = null)
    {
        $this->parameters = [
            'collection' => $collection,
            'bucket'     => $bucket,
            'terms'      => self::wrapInQuotes($terms),

The method Psonic\Commands\Command::wrapInQuotes() is not static, but was called statically.

            'limit'      => $limit ? "LIMIT($limit)": null,

$limit is of type null, thus it always evaluated to false.

            'offset'     => $offset ? "OFFSET($offset)": null,

$offset is of type null, thus it always evaluated to false.

            'locale'     => $locale ? "LANG($locale)": null,

$locale is of type null, thus it always evaluated to false.

        ];

        parent::__construct($this->command, $this->parameters);
    }
}