Current::get() - Code Metrics - ppshobi/openweathermap - Measure and Improve Code Quality continuously with Scrutinizer

Current::get() A
last analyzed 2020-01-16 20:05 UTC

↳ Parent: Current

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	5
c	2
b	0
f	0
nc	1
nop	1
dl	0
loc	9
rs	10

<?php

namespace Shobi\Weatherapp\Endpoints;

use Shobi\Weatherapp\Http\Client;
use Shobi\Weatherapp\Weather\Weather;
use Shobi\Weatherapp\Contracts\Endpoint;

class Current implements Endpoint
{
    const ENDPOINT = 'weather';

    private $client;

    /**
     * Current constructor.
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * @param string $location
     * @return Shobi\Weatherapp\Weather\Weather

     *
     * @throws GuzzleHttp\Exception\ClientException\ClientException
     * fetches the current weather data from the api
     */
    public function get($location = "london") : Weather
    {
        $reponse  = json_decode($this->client->get(self::ENDPOINT, ['q' => $location]), true);
                
        $description = $reponse['weather'][0]['description'];
        $temparature = $reponse['main']['temp'];
        $location    = $reponse['name'];

        return new Weather($description, $temparature, $location);

    }
}

1			<?php
2
3			namespace Shobi\Weatherapp\Endpoints;
4
5			use Shobi\Weatherapp\Http\Client;
6			use Shobi\Weatherapp\Weather\Weather;
7			use Shobi\Weatherapp\Contracts\Endpoint;
8
9			class Current implements Endpoint
10			{
11			const ENDPOINT = 'weather';
12
13			private $client;
14
15			/**
16			* Current constructor.
17			* @param Client $client
18			*/
19			public function __construct(Client $client)
20			{
21			$this->client = $client;
22			}
23
24			/**
25			* @param string $location
26			* @return Shobi\Weatherapp\Weather\Weather
			0 ignored issues – show Bug introduced 2018-12-25 08:23 UTC by Report Bug Copy Issue Report The type `Shobi\Weatherapp\Endpoin...therapp\Weather\Weather` was not found. Did you mean `Shobi\Weatherapp\Weather\Weather`? If so, make sure to prefix the type with `\`. Loading history...
27			*
28			* @throws GuzzleHttp\Exception\ClientException\ClientException
29			* fetches the current weather data from the api
30			*/
31			public function get($location = "london") : Weather
32			{
33			$reponse = json_decode($this->client->get(self::ENDPOINT, ['q' => $location]), true);
34
35			$description = $reponse['weather'][0]['description'];
36			$temparature = $reponse['main']['temp'];
37			$location = $reponse['name'];
38
39			return new Weather($description, $temparature, $location);
			0 ignored issues – show Bug Best Practice introduced 2018-12-25 08:23 UTC by Report Bug Copy Issue Report The expression `return new Shobi\Weather...temparature, $location)` returns the type `Shobi\Weatherapp\Weather\Weather` which is incompatible with the documented return type `Shobi\Weatherapp\Endpoin...therapp\Weather\Weather`. Loading history...
40			}
41			}

ppshobi / openweathermap

Current::get() A last analyzed 2020-01-16 20:05 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Current::get() A
last analyzed 2020-01-16 20:05 UTC