ppi / framework

src/Router/Loader/LaravelRoutesLoader.php

Unused Use Statements -7 removed lines

@@ -9,13 +9,6 @@
 
 namespace PPI\Framework\Router\Loader;
 
-use Illuminate\Http\Request;
-use Illuminate\Routing\Route;
-use Illuminate\Routing\Router;
-use Illuminate\Events\Dispatcher;
-use Illuminate\Container\Container;
-use Symfony\Component\HttpFoundation\Response;
-
 use Illuminate\Routing\Router as LaravelRouter;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
     public function load($path)
     {
 
-        if(!is_readable($path)) {
+        if (!is_readable($path)) {
             throw new \InvalidArgumentException('Invalid laravel routes path found: ' . $path);
         }
 
@@ -54,7 +54,7 @@ 
         // The included file must return the laravel router
         include $path;
 
-        if(!($router instanceof LaravelRouter)) {
+        if (!($router instanceof LaravelRouter)) {
             throw new \Exception('Invalid return value from '
                 . pathinfo($path, PATHINFO_FILENAME)
                 . ' expected instance of LaravelRouter'

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
- * @license    http://opensource.org/licenses/mit-license.php MIT
- * @link       http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
+     * @license    http://opensource.org/licenses/mit-license.php MIT
+     * @link       http://www.ppi.io
+     */
 
 namespace PPI\Framework\Router\Wrapper;
 

src/ServiceManager/Config/TemplatingConfig.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 use PPI\Framework\View\TemplateLocator;
 use PPI\Framework\View\TemplateNameParser;
 // Mustache
-use Symfony\Bundle\FrameworkBundle\Templating\Loader\FilesystemLoader;
 use Symfony\Component\Templating\Helper\AssetsHelper;
 // Twig
 

Indentation +8 added lines, -8 removed lines

@@ -1,12 +1,12 @@ 
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
- * @license     http://opensource.org/licenses/mit-license.php MIT
- *
- * @link        http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
+     * @license     http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link        http://www.ppi.io
+     */
 
 namespace PPI\Framework\ServiceManager\Config;
 
@@ -124,7 +124,7 @@ 
                     $serviceManager->get('templating.helper.assets'),
                     new RouterHelper($serviceManager->get('router')),
                     new SessionHelper($serviceManager->get('session')),
-                 )
+                    )
             );
 
             $engine->addGlobal('app', $serviceManager->get('templating.globals'));

Spacing +10 added lines, -10 removed lines

@@ -75,7 +75,7 @@ 
         /*
          * Templating Locator.
          */
-        $serviceManager->setFactory('templating.locator', function ($serviceManager) use ($appCacheDir) {
+        $serviceManager->setFactory('templating.locator', function($serviceManager) use ($appCacheDir) {
             return new TemplateLocator(
                 $serviceManager->get('file_locator'),
                 $appCacheDir
@@ -85,28 +85,28 @@ 
         /*
          * Templating Name Parser.
          */
-        $serviceManager->setFactory('templating.name_parser', function ($serviceManager) {
+        $serviceManager->setFactory('templating.name_parser', function($serviceManager) {
             return new TemplateNameParser($serviceManager->get('modulemanager'));
         });
 
         /*
          * Filesystem Loader.
          */
-        $serviceManager->setFactory('templating.loader.filesystem', function ($serviceManager) {
+        $serviceManager->setFactory('templating.loader.filesystem', function($serviceManager) {
             return new FileSystemLoader($serviceManager->get('templating.locator'));
         });
 
         /*
          * Templating assets helper.
          */
-        $serviceManager->setFactory('templating.helper.assets', function ($serviceManager) {
+        $serviceManager->setFactory('templating.helper.assets', function($serviceManager) {
             return new AssetsHelper($serviceManager->get('request')->getBasePath());
         });
 
         /*
          * Templating globals.
          */
-        $serviceManager->setFactory('templating.globals', function ($serviceManager) {
+        $serviceManager->setFactory('templating.globals', function($serviceManager) {
             return new GlobalVariables($serviceManager->get('servicemanager'));
         });
 
@@ -115,7 +115,7 @@ 
          *
          * TODO: Migrate to Symfony\Bundle\FrameworkBundle\Templating\PhpEngine
          */
-        $serviceManager->setFactory('templating.engine.php', function ($serviceManager) use ($appCharset) {
+        $serviceManager->setFactory('templating.engine.php', function($serviceManager) use ($appCharset) {
             $engine = new PhpEngine(
                 $serviceManager->get('templating.name_parser'),
                 $serviceManager->get('templating.loader'),
@@ -136,7 +136,7 @@ 
         /*
          * Twig Engine
          */
-        $serviceManager->setFactory('templating.engine.twig', function ($serviceManager) {
+        $serviceManager->setFactory('templating.engine.twig', function($serviceManager) {
 
             if (!class_exists('Twig_Environment')) {
                 throw new \Exception('PPI\Framework\TwigModule not found. Composer require: ppi/twig-module');
@@ -159,7 +159,7 @@ 
         /*
          * Smarty Engine.
          */
-        $serviceManager->setFactory('templating.engine.smarty', function ($serviceManager) use ($appCacheDir) {
+        $serviceManager->setFactory('templating.engine.smarty', function($serviceManager) use ($appCacheDir) {
 
             if (!class_exists('NoiseLabs\Bundle\SmartyBundle\SmartyEngine')) {
                 throw new \Exception('PPI\Framework\SmartyModule not found. Composer require: ppi/smarty-module');
@@ -188,7 +188,7 @@ 
         });
 
         // Mustache Engine
-        $serviceManager->setFactory('templating.engine.mustache', function ($serviceManager, $appCacheDir) {
+        $serviceManager->setFactory('templating.engine.mustache', function($serviceManager, $appCacheDir) {
 
             if (!class_exists('Mustache_Engine')) {
                 throw new \Exception('PPI\Framework\MustacheModule not found. Composer require: ppi/mustache-module');
@@ -206,7 +206,7 @@ 
         /*
          * Delegating Engine.
          */
-        $serviceManager->setFactory('templating.engine.delegating', function ($serviceManager) use ($engineIds) {
+        $serviceManager->setFactory('templating.engine.delegating', function($serviceManager) use ($engineIds) {
             $delegatingEngine = new DelegatingEngine();
             // @todo - lazy load this
             foreach ($engineIds as $id) {

src/ServiceManager/Factory/RouterFactory.php

Unused Use Statements -3 removed lines

@@ -14,16 +14,13 @@
 use PPI\Framework\Router\ChainRouter;
 use Zend\ServiceManager\FactoryInterface;
 use Zend\ServiceManager\ServiceLocatorInterface;
-
 use PPI\Framework\Router\Router as SymfonyRouter;
 use PPI\Framework\Router\Wrapper\SymfonyRouterWrapper;
 use Symfony\Component\Routing\RouteCollection as SymfonyRouteCollection;
-
 use Illuminate\Http\Request as LaravelRequest;
 use Illuminate\Routing\Router as LaravelRouter;
 use Illuminate\Routing\UrlGenerator as LaravelUrlGenerator;
 use PPI\LaravelRouting\Wrapper\LaravelRouterWrapper;
-
 use Aura\Router\Router as AuraRouter;
 use PPI\Framework\Router\Wrapper\AuraRouterWrapper;
 

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
         // For each module, add a matching instance type to the chain router
         foreach ($allModuleRoutes as $moduleName => $moduleRoutingResponse) {
 
-            switch(true) {
+            switch (true) {
                 // @todo - move this to a separate method()
                 case $moduleRoutingResponse instanceof SymfonyRouteCollection:
                     $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright   Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
- * @license     http://opensource.org/licenses/mit-license.php MIT
- *
- * @link        http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright   Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
+     * @license     http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link        http://www.ppi.io
+     */
 
 namespace PPI\Framework\ServiceManager;
 

Switch Indentation +28 added lines, -28 removed lines

@@ -60,37 +60,37 @@
 
             switch(true) {
                 // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof SymfonyRouteCollection:
-                    $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
-                    $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
-                    $chainRouter->add($sfRouterWrapper);
-                    break;
-
-                // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof AuraRouter:
-                    $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
-                    $chainRouter->add($auraRouterWrapper);
-                    break;
-
-                // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof LaravelRouter:
-                    $laravelRequest = new LaravelRequest();
-                    $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
-                    $laravelRouterWrapper = new LaravelRouterWrapper(
-                        $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
-                    );
-                    // @todo - solve this problem
+            case $moduleRoutingResponse instanceof SymfonyRouteCollection:
+                $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
+                $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
+                $chainRouter->add($sfRouterWrapper);
+                break;
+
+            // @todo - move this to a separate method()
+            case $moduleRoutingResponse instanceof AuraRouter:
+                $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
+                $chainRouter->add($auraRouterWrapper);
+                break;
+
+            // @todo - move this to a separate method()
+            case $moduleRoutingResponse instanceof LaravelRouter:
+                $laravelRequest = new LaravelRequest();
+                $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
+                $laravelRouterWrapper = new LaravelRouterWrapper(
+                    $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
+                );
+                // @todo - solve this problem
 //                    $laravelRouterWrapper->setModuleName($this->getName());
-                    $chainRouter->add($laravelRouterWrapper);
-                    break;
+                $chainRouter->add($laravelRouterWrapper);
+                break;
 
-                case $moduleRoutingResponse instanceof FastRouteWrapper:
-                    $chainRouter->add($moduleRoutingResponse);
-                    break;
+            case $moduleRoutingResponse instanceof FastRouteWrapper:
+                $chainRouter->add($moduleRoutingResponse);
+                break;
 
-                default:
-                    throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
-                        '. found value of type: ' . gettype($moduleRoutingResponse));
+            default:
+                throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
+                    '. found value of type: ' . gettype($moduleRoutingResponse));
             }
         }
 

src/ServiceManager/Factory/RouterListenerFactory.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 namespace PPI\Framework\ServiceManager\Factory;
 
 use PPI\Framework\Router\RouterListener;
-use Symfony\Component\Routing\RequestContext;
 use Zend\ServiceManager\FactoryInterface;
 use Zend\ServiceManager\ServiceLocatorInterface;
 

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
- * @license     http://opensource.org/licenses/mit-license.php MIT
- *
- * @link        http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
+     * @license     http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link        http://www.ppi.io
+     */
 
 namespace PPI\Framework\ServiceManager;
 

src/ServiceManager/Factory/RouterRequestContextFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      *
      * @param ServiceLocatorInterface $serviceLocator
      *
-     * @return \PPI\Framework\Router\RouterListener
+     * @return RequestContext
      */
     public function createService(ServiceLocatorInterface $serviceLocator)
     {

Spacing +1 added lines, -2 removed lines

@@ -61,7 +61,6 @@
         $defaults = $defaults['framework']['router'];
 
         return isset($config['framework']['router']) ?
-            $this->mergeConfiguration($defaults, $config['framework']['router']) :
-            $defaults;
+            $this->mergeConfiguration($defaults, $config['framework']['router']) : $defaults;
     }
 }

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
- * @license     http://opensource.org/licenses/mit-license.php MIT
- *
- * @link        http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
+     * @license     http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link        http://www.ppi.io
+     */
 
 namespace PPI\Framework\ServiceManager;
 

src/View/Twig/TwigEngine.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     /**
      * Renders a template.
      *
-     * @param mixed $name       A template name
+     * @param string $name       A template name
      * @param array $parameters An array of parameters to pass to the template
      *
      * @throws \InvalidArgumentException if the template does not exist

src/Console/Application.php

Spacing +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
             $moduleCreateCommand->setTargetModuleDir($config['module_listener_options']['module_paths'][0]);
 
             // Enabled templating engines
-            if(isset($config['framework']['templating']['engines'])) {
+            if (isset($config['framework']['templating']['engines'])) {
                 $moduleCreateCommand->setEnabledTemplatingEngines($config['framework']['templating']['engines']);
             }
 

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright  Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
- * @license    http://opensource.org/licenses/mit-license.php MIT
- *
- * @link       http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright  Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
+     * @license    http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link       http://www.ppi.io
+     */
 
 namespace PPI\Framework\View;
 

src/Console/Command/ServiceManagerDebugCommand.php

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
             $output->write(sprintf('<info>%s</info> ', str_pad($id, $pad['id'])));
             $output->write(sprintf('%s ', str_pad($line['type'], $pad['type'])));
             if ('Alias' == $line['type']) {
-                $output->write(sprintf('<comment>alias for</comment> <info>%s </info>', str_pad($line['class'], $pad['class']-10)));
+                $output->write(sprintf('<comment>alias for</comment> <info>%s </info>', str_pad($line['class'], $pad['class'] - 10)));
             } else {
                 $output->write(sprintf('%s ', str_pad($line['class'], $pad['class'])));
             }

src/Router/ChainRouter.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
             $parameters = parent::matchRequest($request);
             $this->matchedRouteRequest = $request;
             return $parameters;
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
             throw $e;
         }
     }