ppi / framework

src/ServiceManager/Factory/RouterFactory.php

Unused Use Statements -3 removed lines

@@ -14,16 +14,13 @@
 use PPI\Framework\Router\ChainRouter;
 use Zend\ServiceManager\FactoryInterface;
 use Zend\ServiceManager\ServiceLocatorInterface;
-
 use PPI\Framework\Router\Router as SymfonyRouter;
 use PPI\Framework\Router\Wrapper\SymfonyRouterWrapper;
 use Symfony\Component\Routing\RouteCollection as SymfonyRouteCollection;
-
 use Illuminate\Http\Request as LaravelRequest;
 use Illuminate\Routing\Router as LaravelRouter;
 use Illuminate\Routing\UrlGenerator as LaravelUrlGenerator;
 use PPI\LaravelRouting\Wrapper\LaravelRouterWrapper;
-
 use Aura\Router\Router as AuraRouter;
 use PPI\Framework\Router\Wrapper\AuraRouterWrapper;
 

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
         // For each module, add a matching instance type to the chain router
         foreach ($allModuleRoutes as $moduleName => $moduleRoutingResponse) {
 
-            switch(true) {
+            switch (true) {
                 // @todo - move this to a separate method()
                 case $moduleRoutingResponse instanceof SymfonyRouteCollection:
                     $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright   Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
- * @license     http://opensource.org/licenses/mit-license.php MIT
- *
- * @link        http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright   Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
+     * @license     http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link        http://www.ppi.io
+     */
 
 namespace PPI\Framework\ServiceManager;
 

Switch Indentation +28 added lines, -28 removed lines

@@ -60,37 +60,37 @@
 
             switch(true) {
                 // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof SymfonyRouteCollection:
-                    $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
-                    $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
-                    $chainRouter->add($sfRouterWrapper);
-                    break;
-
-                // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof AuraRouter:
-                    $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
-                    $chainRouter->add($auraRouterWrapper);
-                    break;
-
-                // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof LaravelRouter:
-                    $laravelRequest = new LaravelRequest();
-                    $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
-                    $laravelRouterWrapper = new LaravelRouterWrapper(
-                        $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
-                    );
-                    // @todo - solve this problem
+            case $moduleRoutingResponse instanceof SymfonyRouteCollection:
+                $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
+                $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
+                $chainRouter->add($sfRouterWrapper);
+                break;
+
+            // @todo - move this to a separate method()
+            case $moduleRoutingResponse instanceof AuraRouter:
+                $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
+                $chainRouter->add($auraRouterWrapper);
+                break;
+
+            // @todo - move this to a separate method()
+            case $moduleRoutingResponse instanceof LaravelRouter:
+                $laravelRequest = new LaravelRequest();
+                $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
+                $laravelRouterWrapper = new LaravelRouterWrapper(
+                    $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
+                );
+                // @todo - solve this problem
 //                    $laravelRouterWrapper->setModuleName($this->getName());
-                    $chainRouter->add($laravelRouterWrapper);
-                    break;
+                $chainRouter->add($laravelRouterWrapper);
+                break;
 
-                case $moduleRoutingResponse instanceof FastRouteWrapper:
-                    $chainRouter->add($moduleRoutingResponse);
-                    break;
+            case $moduleRoutingResponse instanceof FastRouteWrapper:
+                $chainRouter->add($moduleRoutingResponse);
+                break;
 
-                default:
-                    throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
-                        '. found value of type: ' . gettype($moduleRoutingResponse));
+            default:
+                throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
+                    '. found value of type: ' . gettype($moduleRoutingResponse));
             }
         }
 

src/ServiceManager/Factory/RouterListenerFactory.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 namespace PPI\Framework\ServiceManager\Factory;
 
 use PPI\Framework\Router\RouterListener;
-use Symfony\Component\Routing\RequestContext;
 use Zend\ServiceManager\FactoryInterface;
 use Zend\ServiceManager\ServiceLocatorInterface;
 

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
- * @license     http://opensource.org/licenses/mit-license.php MIT
- *
- * @link        http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
+     * @license     http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link        http://www.ppi.io
+     */
 
 namespace PPI\Framework\ServiceManager;
 

src/ServiceManager/Factory/RouterRequestContextFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      *
      * @param ServiceLocatorInterface $serviceLocator
      *
-     * @return \PPI\Framework\Router\RouterListener
+     * @return RequestContext
      */
     public function createService(ServiceLocatorInterface $serviceLocator)
     {

Spacing +1 added lines, -2 removed lines

@@ -61,7 +61,6 @@
         $defaults = $defaults['framework']['router'];
 
         return isset($config['framework']['router']) ?
-            $this->mergeConfiguration($defaults, $config['framework']['router']) :
-            $defaults;
+            $this->mergeConfiguration($defaults, $config['framework']['router']) : $defaults;
     }
 }

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
- * @license     http://opensource.org/licenses/mit-license.php MIT
- *
- * @link        http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright   Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
+     * @license     http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link        http://www.ppi.io
+     */
 
 namespace PPI\Framework\ServiceManager;
 

src/View/Twig/TwigEngine.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     /**
      * Renders a template.
      *
-     * @param mixed $name       A template name
+     * @param string $name       A template name
      * @param array $parameters An array of parameters to pass to the template
      *
      * @throws \InvalidArgumentException if the template does not exist

src/Console/Application.php

Spacing +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
             $moduleCreateCommand->setTargetModuleDir($config['module_listener_options']['module_paths'][0]);
 
             // Enabled templating engines
-            if(isset($config['framework']['templating']['engines'])) {
+            if (isset($config['framework']['templating']['engines'])) {
                 $moduleCreateCommand->setEnabledTemplatingEngines($config['framework']['templating']['engines']);
             }
 

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright  Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
- * @license    http://opensource.org/licenses/mit-license.php MIT
- *
- * @link       http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright  Copyright (c) 2011-2013 Paul Dragoonis <paul@ppi.io>
+     * @license    http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link       http://www.ppi.io
+     */
 
 namespace PPI\Framework\View;
 

src/Console/Command/ServiceManagerDebugCommand.php

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
             $output->write(sprintf('<info>%s</info> ', str_pad($id, $pad['id'])));
             $output->write(sprintf('%s ', str_pad($line['type'], $pad['type'])));
             if ('Alias' == $line['type']) {
-                $output->write(sprintf('<comment>alias for</comment> <info>%s </info>', str_pad($line['class'], $pad['class']-10)));
+                $output->write(sprintf('<comment>alias for</comment> <info>%s </info>', str_pad($line['class'], $pad['class'] - 10)));
             } else {
                 $output->write(sprintf('%s ', str_pad($line['class'], $pad['class'])));
             }

src/Router/ChainRouter.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
             $parameters = parent::matchRequest($request);
             $this->matchedRouteRequest = $request;
             return $parameters;
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
             throw $e;
         }
     }

src/Router/RoutingHelper.php

Indentation +7 added lines, -7 removed lines

@@ -1,12 +1,12 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
- * @license    http://opensource.org/licenses/mit-license.php MIT
- *
- * @link       http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
+     * @license    http://opensource.org/licenses/mit-license.php MIT
+     *
+     * @link       http://www.ppi.io
+     */
 
 namespace PPI\Framework\Router;
 

src/Router/Wrapper/AuraRouterWrapper.php

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * This file is part of the PPI Framework.
- *
- * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
- * @license    http://opensource.org/licenses/mit-license.php MIT
- * @link       http://www.ppi.io
- */
+     * This file is part of the PPI Framework.
+     *
+     * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <paul@ppi.io>
+     * @license    http://opensource.org/licenses/mit-license.php MIT
+     * @link       http://www.ppi.io
+     */
 
 namespace PPI\Framework\Router\Wrapper;
 

Spacing +6 added lines, -6 removed lines

@@ -85,7 +85,7 @@ 
     public function generate($name, $parameters = array(), $referenceType = self::ABSOLUTE_PATH)
     {
         $ret = $this->router->generate($name, $parameters);
-        if($ret === false) {
+        if ($ret === false) {
             throw new RouteNotFoundException('Unable to generate route for: ' . $name);
         }
         return $ret;
@@ -127,16 +127,16 @@ 
         $routeParams = $matchedRoute->params;
 
         // The 'action' key always exists and defaults to the Route Name, so we check accordingly
-        if(!isset($routeParams['controller']) && $routeParams['action'] === $matchedRoute->name) {
+        if (!isset($routeParams['controller']) && $routeParams['action'] === $matchedRoute->name) {
             throw new \Exception('Matched the route: ' . $matchedRoute->name . ' but unable to locate
             any controller/action params to dispatch');
         }
 
         // We need _controller, to that symfony ControllerResolver can pick this up
-        if(!isset($routeParams['_controller'])) {
-            if(isset($routeParams['controller'])) {
+        if (!isset($routeParams['_controller'])) {
+            if (isset($routeParams['controller'])) {
                 $routeParams['_controller'] = $routeParams['controller'];
-            } elseif(isset($routeParams['action'])) {
+            } elseif (isset($routeParams['action'])) {
                 $routeParams['_controller'] = $routeParams['action'];
             } else {
                 throw new \Exception('Unable to determine the controller from route: ' . $matchedRoute->name);
@@ -146,7 +146,7 @@ 
         $routeParams['_route'] = $matchedRoute->name;
 
         // If the controller is an Object, and 'action' is defaulted to the route name - we default to __invoke
-        if($routeParams['action'] === $matchedRoute->name) {
+        if ($routeParams['action'] === $matchedRoute->name) {
             $routeParams['action'] = '__invoke';
         }