Completed
Push — master ( 5a1fd0...f7ff15 )
by Vítor
03:52
created
src/App.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
     /**
404 404
      * @note Added for compatibility with Symfony's HttpKernel\Kernel.
405 405
      *
406
-     * @return null|ServiceManager\ServiceManager
406
+     * @return ServiceManager\ServiceManager
407 407
      */
408 408
     public function getContainer()
409 409
     {
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
     /**
602 602
      * Creates and initializes a ServiceManager instance.
603 603
      *
604
-     * @return ServiceManager The compiled service manager
604
+     * @return ServiceManagerBuilder The compiled service manager
605 605
      */
606 606
     protected function buildServiceManager()
607 607
     {
@@ -651,7 +651,7 @@  discard block
 block discarded – undo
651 651
     /**
652 652
      * Logs with an arbitrary level.
653 653
      *
654
-     * @param mixed  $level
654
+     * @param string  $level
655 655
      * @param string $message
656 656
      * @param array  $context
657 657
      */
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework;
12 12
 
Please login to merge, or discard this patch.
src/Router/Loader/LaravelRoutesLoader.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 
11 11
 namespace PPI\Framework\Router\Loader;
12 12
 
13
-use Illuminate\Routing\Router;
14 13
 use Illuminate\Routing\Router as LaravelRouter;
15 14
 
16 15
 /**
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework;
12 12
 
Please login to merge, or discard this patch.
src/Module/ModuleManager.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@
 block discarded – undo
122 122
     protected function getResourcesPath($module)
123 123
     {
124 124
         if (is_callable(array($module, 'getResourcesPath'))) {
125
-            $resourcesPath  = $module->getResourcesPath();
125
+            $resourcesPath = $module->getResourcesPath();
126 126
         } else {
127 127
             $resourcesPath = $module->getPath();
128 128
         }
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework;
12 12
 
Please login to merge, or discard this patch.
src/Module/AbstractModule.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@
 block discarded – undo
144 144
         }
145 145
 
146 146
         // The included file must return the laravel router
147
-        $getRouteCollector = function () use ($routeCollector, $path) {
147
+        $getRouteCollector = function() use ($routeCollector, $path) {
148 148
             $r = $routeCollector;
149 149
             include $path;
150 150
 
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework;
12 12
 
Please login to merge, or discard this patch.
src/ServiceManager/Factory/RouterFactory.php 2 patches
Switch Indentation   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -58,37 +58,37 @@
 block discarded – undo
58 58
         foreach ($allModuleRoutes as $moduleName => $moduleRoutingResponse) {
59 59
             switch (true) {
60 60
                 // @todo - move this to a separate method()
61
-                case $moduleRoutingResponse instanceof SymfonyRouteCollection:
62
-                    $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
63
-                    $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
64
-                    $chainRouter->add($sfRouterWrapper);
65
-                    break;
61
+            case $moduleRoutingResponse instanceof SymfonyRouteCollection:
62
+                $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
63
+                $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
64
+                $chainRouter->add($sfRouterWrapper);
65
+                break;
66 66
 
67
-                // @todo - move this to a separate method()
68
-                case $moduleRoutingResponse instanceof AuraRouter:
69
-                    $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
70
-                    $chainRouter->add($auraRouterWrapper);
71
-                    break;
67
+            // @todo - move this to a separate method()
68
+            case $moduleRoutingResponse instanceof AuraRouter:
69
+                $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
70
+                $chainRouter->add($auraRouterWrapper);
71
+                break;
72 72
 
73
-                // @todo - move this to a separate method()
74
-                case $moduleRoutingResponse instanceof LaravelRouter:
75
-                    $laravelRequest = new LaravelRequest();
76
-                    $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
77
-                    $laravelRouterWrapper = new LaravelRouterWrapper(
78
-                        $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
79
-                    );
80
-                    // @todo - solve this problem
73
+            // @todo - move this to a separate method()
74
+            case $moduleRoutingResponse instanceof LaravelRouter:
75
+                $laravelRequest = new LaravelRequest();
76
+                $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
77
+                $laravelRouterWrapper = new LaravelRouterWrapper(
78
+                    $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
79
+                );
80
+                // @todo - solve this problem
81 81
 //                    $laravelRouterWrapper->setModuleName($this->getName());
82
-                    $chainRouter->add($laravelRouterWrapper);
83
-                    break;
82
+                $chainRouter->add($laravelRouterWrapper);
83
+                break;
84 84
 
85
-                case $moduleRoutingResponse instanceof FastRouteWrapper:
86
-                    $chainRouter->add($moduleRoutingResponse);
87
-                    break;
85
+            case $moduleRoutingResponse instanceof FastRouteWrapper:
86
+                $chainRouter->add($moduleRoutingResponse);
87
+                break;
88 88
 
89
-                default:
90
-                    throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
91
-                        '. found value of type: ' . gettype($moduleRoutingResponse));
89
+            default:
90
+                throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
91
+                    '. found value of type: ' . gettype($moduleRoutingResponse));
92 92
             }
93 93
         }
94 94
 
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license     http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link        http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license     http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link        http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\Module\Controller;
12 12
 
Please login to merge, or discard this patch.
src/Console/Command/ModuleCreateCommand.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\Console\Command;
12 12
 
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
             rename(
235 235
                 $moduleDir . DIRECTORY_SEPARATOR . $routingFiles[0],
236 236
                 str_replace('IndexInvoke', 'Index', $moduleDir . DIRECTORY_SEPARATOR . $routingFiles[0]
237
-           ));
237
+            ));
238 238
         }
239 239
 
240 240
         // Success
Please login to merge, or discard this patch.
src/Module/Controller/ControllerResolver.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license     http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link        http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license     http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link        http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\Module\Controller;
12 12
 
Please login to merge, or discard this patch.
src/ServiceManager/Config/AbstractConfig.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license     http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link        http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license     http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link        http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\Module\Controller;
12 12
 
Please login to merge, or discard this patch.
src/ServiceManager/ServiceManager.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
- * @license     http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link        http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6
+     * @license     http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link        http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\Module\Controller;
12 12
 
Please login to merge, or discard this patch.