ppi / framework

src/ServiceManager/Factory/ConfigFactory.php

Spacing +1 added lines, -2 removed lines

@@ -48,8 +48,7 @@
         $parametersBag = $serviceLocator->get('ApplicationParameters');
 
         $config['parameters'] = isset($config['parameters']) ?
-            ArrayUtils::merge($parametersBag->all(), $config['parameters']) :
-            $config['parameters'] = $parametersBag->all();
+            ArrayUtils::merge($parametersBag->all(), $config['parameters']) : $config['parameters'] = $parametersBag->all();
 
         return $parametersBag->resolveArray($config);
     }

src/View/Mustache/MustacheEngine.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     /**
      * Renders a template.
      *
-     * @param mixed $name       A template name
+     * @param string $name       A template name
      * @param array $parameters An array of parameters to pass to the template
      *
      * @throws \InvalidArgumentException if the template does not exist

src/Config/ConfigManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
      *
      * @param string       $cachePath
      * @param boolean      $cacheEnabled
-     * @param string|array $paths        A path or an array of paths where to look for resources
+     * @param string $paths        A path or an array of paths where to look for resources
      */
     public function __construct($cachePath, $cacheEnabled, $paths = array())
     {

Spacing +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 
             if ($this->cacheEnabled) {
                 $mode       = 0666 & ~umask();
-                $content    = "<?php\nreturn " . var_export($this->mergedConfig, 1) . ';';
+                $content    = "<?php\nreturn ".var_export($this->mergedConfig, 1).';';
                 $filesystem = new Filesystem();
                 $filesystem->dumpFile($this->cachePath, $content, $mode);
             }

src/View/Smarty/Extension/RouterExtension.php

Indentation +8 added lines, -8 removed lines

@@ -12,11 +12,11 @@
 
 use NoiseLabs\Bundle\SmartyBundle\Extension\RoutingExtension as BaseRoutingExtension;
 
- /**
-  * Provides integration of the Routing component with Smarty[Bundle].
-  *
-  * @author     Vítor Brandão <vitor@ppi.io>
-  */
- class RouterExtension extends BaseRoutingExtension
- {
- }
+    /**
+     * Provides integration of the Routing component with Smarty[Bundle].
+     *
+     * @author     Vítor Brandão <vitor@ppi.io>
+     */
+    class RouterExtension extends BaseRoutingExtension
+    {
+    }

src/Router/Loader/LaravelRoutesLoader.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 namespace PPI\Framework\Router\Loader;
 
-use Illuminate\Routing\Router;
 use Illuminate\Routing\Router as LaravelRouter;
 
 /**

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     public function load($path)
     {
         if (!is_readable($path)) {
-            throw new \InvalidArgumentException('Invalid laravel routes path found: ' . $path);
+            throw new \InvalidArgumentException('Invalid laravel routes path found: '.$path);
         }
 
         // localising the object so the $path file can reference $router;

src/ServiceManager/Factory/RouterFactory.php

Switch Indentation +26 added lines, -26 removed lines

@@ -58,37 +58,37 @@
         foreach ($allModuleRoutes as $moduleName => $moduleRoutingResponse) {
             switch (true) {
                 // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof SymfonyRouteCollection:
-                    $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
-                    $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
-                    $chainRouter->add($sfRouterWrapper);
-                    break;
+            case $moduleRoutingResponse instanceof SymfonyRouteCollection:
+                $sfRouter = new SymfonyRouter($requestContext, $moduleRoutingResponse, $routerOptions, $logger);
+                $sfRouterWrapper = new SymfonyRouterWrapper($sfRouter);
+                $chainRouter->add($sfRouterWrapper);
+                break;
 
-                // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof AuraRouter:
-                    $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
-                    $chainRouter->add($auraRouterWrapper);
-                    break;
+            // @todo - move this to a separate method()
+            case $moduleRoutingResponse instanceof AuraRouter:
+                $auraRouterWrapper = new AuraRouterWrapper($moduleRoutingResponse);
+                $chainRouter->add($auraRouterWrapper);
+                break;
 
-                // @todo - move this to a separate method()
-                case $moduleRoutingResponse instanceof LaravelRouter:
-                    $laravelRequest = new LaravelRequest();
-                    $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
-                    $laravelRouterWrapper = new LaravelRouterWrapper(
-                        $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
-                    );
-                    // @todo - solve this problem
+            // @todo - move this to a separate method()
+            case $moduleRoutingResponse instanceof LaravelRouter:
+                $laravelRequest = new LaravelRequest();
+                $laravelUrlGenerator = new LaravelUrlGenerator($moduleRoutingResponse->getRoutes(), $laravelRequest);
+                $laravelRouterWrapper = new LaravelRouterWrapper(
+                    $moduleRoutingResponse, $laravelRequest, $laravelUrlGenerator
+                );
+                // @todo - solve this problem
 //                    $laravelRouterWrapper->setModuleName($this->getName());
-                    $chainRouter->add($laravelRouterWrapper);
-                    break;
+                $chainRouter->add($laravelRouterWrapper);
+                break;
 
-                case $moduleRoutingResponse instanceof FastRouteWrapper:
-                    $chainRouter->add($moduleRoutingResponse);
-                    break;
+            case $moduleRoutingResponse instanceof FastRouteWrapper:
+                $chainRouter->add($moduleRoutingResponse);
+                break;
 
-                default:
-                    throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
-                        '. found value of type: ' . gettype($moduleRoutingResponse));
+            default:
+                throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
+                    '. found value of type: ' . gettype($moduleRoutingResponse));
             }
         }
 

Spacing +2 added lines, -2 removed lines

@@ -87,8 +87,8 @@
                     break;
 
                 default:
-                    throw new \Exception('Unexpected routes value return from module: ' . $moduleName .
-                        '. found value of type: ' . gettype($moduleRoutingResponse));
+                    throw new \Exception('Unexpected routes value return from module: '.$moduleName.
+                        '. found value of type: '.gettype($moduleRoutingResponse));
             }
         }
 

src/App.php

Doc Comments +2 added lines, -2 removed lines

@@ -402,7 +402,7 @@ 
     /**
      * @note Added for compatibility with Symfony's HttpKernel\Kernel.
      *
-     * @return null|ServiceManager
+     * @return ServiceManager
      */
     public function getContainer()
     {
@@ -650,7 +650,7 @@ 
     /**
      * Logs with an arbitrary level.
      *
-     * @param mixed  $level
+     * @param string  $level
      * @param string $message
      * @param array  $context
      */

Spacing +5 added lines, -5 removed lines

@@ -343,7 +343,7 @@ 
     public function getRootDir()
     {
         if (null === $this->rootDir) {
-            $this->rootDir = realpath(getcwd() . '/app');
+            $this->rootDir = realpath(getcwd().'/app');
         }
 
         return $this->rootDir;
@@ -432,7 +432,7 @@ 
      */
     public function getCacheDir()
     {
-        return $this->rootDir . '/cache/' . $this->environment;
+        return $this->rootDir.'/cache/'.$this->environment;
     }
 
     /**
@@ -444,7 +444,7 @@ 
      */
     public function getLogDir()
     {
-        return $this->rootDir . '/logs';
+        return $this->rootDir.'/logs';
     }
 
     /**
@@ -467,8 +467,8 @@ 
     public function getConfigManager()
     {
         if (null === $this->configManager) {
-            $cachePath = $this->getCacheDir() . '/application-config-cache.' . $this->getName() . '.php';
-            $this->configManager = new ConfigManager($cachePath, !$this->debug, $this->rootDir . '/config');
+            $cachePath = $this->getCacheDir().'/application-config-cache.'.$this->getName().'.php';
+            $this->configManager = new ConfigManager($cachePath, !$this->debug, $this->rootDir.'/config');
         }
 
         return $this->configManager;

src/Console/Command/ModuleCreateCommand.php

Doc Comments +4 added lines

@@ -421,6 +421,10 @@
         return $questionHelper->ask($input, $output, $question);
     }
 
+    /**
+     * @param InputInterface $input
+     * @param OutputInterface $output
+     */
     private function chooseTemplatingEngine($input, $output)
     {
         $tplQuestion = new ChoiceQuestion('Choose your templating engine [php]',

Switch Indentation +6 added lines, -6 removed lines

@@ -561,13 +561,13 @@
         $tokenMap = [];
 
         switch($routingEngine) {
-            case self::ROUTING_ENGINE_SYMFONY:
-                $tokenMap['[ROUTING_TRAIT]'] = 'use \PPI\Framework\Module\Routing\SymfonyTrait;';
-                break;
+        case self::ROUTING_ENGINE_SYMFONY:
+            $tokenMap['[ROUTING_TRAIT]'] = 'use \PPI\Framework\Module\Routing\SymfonyTrait;';
+            break;
 
-            default:
-                throw new \Exception('Unimplemented routing engine: ' . $routingEngine);
-                break;
+        default:
+            throw new \Exception('Unimplemented routing engine: ' . $routingEngine);
+            break;
         }
 
         return $tokenMap;

Spacing +24 added lines, -24 removed lines

@@ -187,7 +187,7 @@ 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $this->moduleName = $input->getArgument('name');
-        $this->moduleDir = $this->modulesDir . DIRECTORY_SEPARATOR . $this->moduleName;
+        $this->moduleDir = $this->modulesDir.DIRECTORY_SEPARATOR.$this->moduleName;
 
         // Acquire Module Information
         $this->askQuestions($input, $output);
@@ -204,12 +204,12 @@ 
 
         $tokens['[MODULE_NAME]'] = $this->moduleName;
 
-        if(null !== $this->tplEngine && $this->isValidTemplatingEngine($this->tplEngine)) {
+        if (null !== $this->tplEngine && $this->isValidTemplatingEngine($this->tplEngine)) {
             $this->processTemplatingFiles();
             $output->writeln(sprintf("Templating: <info>%s</info>", $this->tplEngine));
         }
 
-        if($this->isValidRoutingEngine($this->routingEngine)) {
+        if ($this->isValidRoutingEngine($this->routingEngine)) {
             $this->processRoutingFiles($tokenizedFiles, $tokens);
             $output->writeln(sprintf("Router: <info>%s</info>", $this->routingEngine));
         } else {
@@ -255,7 +255,7 @@ 
     protected function replaceTokensInFiles($moduleDir, $files, $tokens)
     {
         foreach ($files as $file) {
-            $file = $moduleDir . DIRECTORY_SEPARATOR . $file;
+            $file = $moduleDir.DIRECTORY_SEPARATOR.$file;
             if (!is_writeable($file)) {
                 throw new \InvalidArgumentException(sprintf('File %s is not writeable', $file));
             }
@@ -273,8 +273,8 @@ 
     protected function copyFiles($skeletonDir, $moduleDir, $files)
     {
         foreach ($files as $file) {
-            $srcFile = $skeletonDir . DIRECTORY_SEPARATOR . $file;
-            $dstFile = $moduleDir . DIRECTORY_SEPARATOR . $file;
+            $srcFile = $skeletonDir.DIRECTORY_SEPARATOR.$file;
+            $dstFile = $moduleDir.DIRECTORY_SEPARATOR.$file;
             if (!file_exists($srcFile)) {
                 throw new \InvalidArgumentException(sprintf('File does not exist: %s', $srcFile));
             }
@@ -301,7 +301,7 @@ 
 
         // Create base structure
         foreach ($this->coreDirs as $coreDir) {
-            $tmpDir = $moduleDir . DIRECTORY_SEPARATOR . $coreDir;
+            $tmpDir = $moduleDir.DIRECTORY_SEPARATOR.$coreDir;
             @mkdir($tmpDir);
         }
     }
@@ -321,12 +321,12 @@ 
             $this->modulesDir = $questionHelper->ask($input, $output, $modulesDirQuestion);
         }
 
-        if($this->askForTemplating($input, $output)) {
+        if ($this->askForTemplating($input, $output)) {
             $this->chooseTemplatingEngine($input, $output);
         }
 
-        if($this->askForContoller($input, $output)) {
-            if($this->askForRouting($input, $output)) {
+        if ($this->askForContoller($input, $output)) {
+            if ($this->askForRouting($input, $output)) {
                 return $this->chooseRouter($input, $output);
             }
         }
@@ -441,7 +441,7 @@ 
             ]
         );
         $tplQuestion->setErrorMessage('Templating engine %s is invalid.');
-        if(99 !== ($tplEngine = $this->getHelper('question')->ask($input, $output, $tplQuestion))) {
+        if (99 !== ($tplEngine = $this->getHelper('question')->ask($input, $output, $tplQuestion))) {
             $this->tplEngine = $tplEngine;
         }
     }
@@ -467,7 +467,7 @@ 
         // @todo - test question when you don't choose any option, or an invalid one (like -1)
         $routingQuestion->setErrorMessage('Routing engine %s is invalid.');
         $chosenRouter = $this->getHelper('question')->ask($input, $output, $routingQuestion);
-        if(99 == $chosenRouter) {
+        if (99 == $chosenRouter) {
             $chosenRouter = 'NullRouter';
         }
         $this->routingEngine = $chosenRouter;
@@ -480,8 +480,8 @@ 
      */
     private function getTemplatingFilesFromEngine($tplEngine)
     {
-        if(!isset($this->tplEngineFilesMap[$tplEngine])) {
-            throw new \InvalidArgumentException('Invalid templating engine specified for map files: ' . $tplEngine);
+        if (!isset($this->tplEngineFilesMap[$tplEngine])) {
+            throw new \InvalidArgumentException('Invalid templating engine specified for map files: '.$tplEngine);
         }
     }
 
@@ -493,7 +493,7 @@ 
         $tplFiles = $this->getTemplatingFilesFromEngine($this->tplEngine);
 
         // Copy core templating files over
-        foreach($this->tplEngineCoreFiles as $coreFile) {
+        foreach ($this->tplEngineCoreFiles as $coreFile) {
             $tplFiles[] = $coreFile;
         }
 
@@ -522,18 +522,18 @@ 
     private function processRoutingFiles($tokenizedFiles, $tokens)
     {
 
-        if(!isset($this->routingEngineFilesMap[$this->routingEngine])) {
-            throw new \Exception('Routing engine not found in routing files map: ' . $this->routingEngine);
+        if (!isset($this->routingEngineFilesMap[$this->routingEngine])) {
+            throw new \Exception('Routing engine not found in routing files map: '.$this->routingEngine);
         }
 
         // Copy routing files over
         $routingFiles = $this->routingEngineFilesMap[$this->routingEngine];
 
         // If a valid routing engine and that's not null router
-        if($this->routingEngine !== 99) {
+        if ($this->routingEngine !== 99) {
             // Create core routing directories
-            foreach($this->routingEngineCoreFiles as $coreFile) {
-                @mkdir($this->moduleDir . DIRECTORY_SEPARATOR . $coreFile);
+            foreach ($this->routingEngineCoreFiles as $coreFile) {
+                @mkdir($this->moduleDir.DIRECTORY_SEPARATOR.$coreFile);
             }
         }
 
@@ -560,8 +560,8 @@ 
         // Prepare the fastroute route file
         if ($this->routingEngine === self::ROUTING_ENGINE_FASTROUTE) {
             rename(
-                $moduleDir . DIRECTORY_SEPARATOR . $routingFiles[0],
-                str_replace('IndexInvoke', 'Index', $moduleDir . DIRECTORY_SEPARATOR . $routingFiles[0]
+                $moduleDir.DIRECTORY_SEPARATOR.$routingFiles[0],
+                str_replace('IndexInvoke', 'Index', $moduleDir.DIRECTORY_SEPARATOR.$routingFiles[0]
                 ));
         }
     }
@@ -591,13 +591,13 @@ 
 
         $tokenMap = [];
 
-        switch($routingEngine) {
+        switch ($routingEngine) {
             case self::ROUTING_ENGINE_SYMFONY:
                 $tokenMap['[ROUTING_TRAIT]'] = 'use \PPI\Framework\Module\Routing\SymfonyTrait;';
                 break;
 
             default:
-                throw new \Exception('Unimplemented routing engine: ' . $routingEngine);
+                throw new \Exception('Unimplemented routing engine: '.$routingEngine);
                 break;
         }
 

src/Module/Controller/ControllerNameParser.php

Spacing +2 added lines, -2 removed lines

@@ -53,9 +53,9 @@
             // this throws an exception if there is no such module
             $msg = sprintf('Unable to find controller "%s:%s" - module alias "%s" does not exist.', $moduleName, $controller, $moduleAlias);
         } else {
-            $class = $module->getNamespace() . '\\Controller\\' . $controller;
+            $class = $module->getNamespace().'\\Controller\\'.$controller;
             if (class_exists($class)) {
-                return $class . '::' . $action . 'Action';
+                return $class.'::'.$action.'Action';
             }
 
             $msg = sprintf('Unable to find controller "%s:%s" - class "%s" does not exist.', $moduleName, $controller, $class);