SymfonyTrait - Code Metrics - Inspection of "Merge branch 'support/2.1'" - ppi/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ce54b6...5ea837 )

by Vítor

created 2016-02-28 23:27 UTC

SymfonyTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
lcom	0
cbo	0
dl	0
loc	18
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getRoutes()	0	4	1
A	getRoutingFilePath()	0	4	1

<?php
namespace PPI\Framework\Module\Routing;

use Symfony\Component\Routing\RouteCollection;

trait SymfonyTrait {

    /**
     * Get the routes for this module
     *
     * @return RouteCollection
     */
    public function getRoutes()
    {
        return $this->loadSymfonyRoutes($this->getRoutingFilePath());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    protected function getRoutingFilePath()
    {
        return $this->getPath() . '/resources/routes/symfony.yml';
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

}

1			<?php
2			namespace PPI\Framework\Module\Routing;
3
4			use Symfony\Component\Routing\RouteCollection;
5
6			trait SymfonyTrait {
7
8			/**
9			* Get the routes for this module
10			*
11			* @return RouteCollection
12			*/
13			public function getRoutes()
14			{
15			return $this->loadSymfonyRoutes($this->getRoutingFilePath());
			0 ignored issues – show Bug introduced 2016-02-28 23:31 UTC by Report Bug Copy Issue Report It seems like `loadSymfonyRoutes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			}
17
18			protected function getRoutingFilePath()
19			{
20			return $this->getPath() . '/resources/routes/symfony.yml';
			0 ignored issues – show Bug introduced 2016-02-28 23:31 UTC by Report Bug Copy Issue Report It seems like `getPath()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21			}
22
23			}

ppi / framework

Push — master ( ce54b6...5ea837 )

SymfonyTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like