Completed
Pull Request — master (#149)
by Paul
03:16 queued 14s
created
src/Config/Loader/ArrayLoader.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2012 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2012 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\View\Twig\Loader;
12 12
 
Please login to merge, or discard this patch.
src/Http/Request.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\Router;
12 12
 
Please login to merge, or discard this patch.
src/Module/ModuleInterface.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2012 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2012 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\View\Twig\Loader;
12 12
 
Please login to merge, or discard this patch.
src/App.php 4 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * This file is part of the PPI Framework.
4
- *
5
- * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <[email protected]>
6
- * @license    http://opensource.org/licenses/mit-license.php MIT
7
- *
8
- * @link       http://www.ppi.io
9
- */
3
+     * This file is part of the PPI Framework.
4
+     *
5
+     * @copyright  Copyright (c) 2011-2015 Paul Dragoonis <[email protected]>
6
+     * @license    http://opensource.org/licenses/mit-license.php MIT
7
+     *
8
+     * @link       http://www.ppi.io
9
+     */
10 10
 
11 11
 namespace PPI\Framework\Router;
12 12
 
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -126,10 +126,10 @@  discard block
 block discarded – undo
126 126
     public function __construct(array $options = array())
127 127
     {
128 128
         // Default options
129
-        $this->environment = isset($options['environment']) && $options['environment'] ? (string)$options['environment'] : 'prod';
130
-        $this->debug = isset($options['debug']) && null !== $options['debug'] ? (boolean)$options['debug'] : false;
131
-        $this->rootDir = isset($options['rootDir']) && $options['rootDir'] ? (string)$options['rootDir'] : $this->getRootDir();
132
-        $this->name = isset($options['name']) && $options['name'] ? (string)$options['name'] : $this->getName();
129
+        $this->environment = isset($options['environment']) && $options['environment'] ? (string) $options['environment'] : 'prod';
130
+        $this->debug = isset($options['debug']) && null !== $options['debug'] ? (boolean) $options['debug'] : false;
131
+        $this->rootDir = isset($options['rootDir']) && $options['rootDir'] ? (string) $options['rootDir'] : $this->getRootDir();
132
+        $this->name = isset($options['name']) && $options['name'] ? (string) $options['name'] : $this->getName();
133 133
 
134 134
         if ($this->debug) {
135 135
             $this->startTime = microtime(true);
@@ -289,9 +289,9 @@  discard block
 block discarded – undo
289 289
             $controllerArguments
290 290
         );
291 291
 
292
-        if($result === null) {
292
+        if ($result === null) {
293 293
             throw new \Exception('Your action returned null. It must always return something');
294
-        } else if(is_string($result)) {
294
+        } else if (is_string($result)) {
295 295
             $response->setContent($result);
296 296
         } else if ($result instanceof ResponseInterface || $result instanceof SymfonyResponse) {
297 297
             $response = $result;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
      * Run the application and send the response.
238 238
      *
239 239
      * @param HttpRequest|null $request
240
-     * @param HttpRequest|null $response
240
+     * @param null|Response $response
241 241
      * @return Response
242 242
      * @throws \Exception
243 243
      */
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
     /**
401 401
      * @note Added for compatibility with Symfony's HttpKernel\Kernel.
402 402
      *
403
-     * @return null|ServiceManager\ServiceManager
403
+     * @return ServiceManager\ServiceManager
404 404
      */
405 405
     public function getContainer()
406 406
     {
@@ -598,7 +598,7 @@  discard block
 block discarded – undo
598 598
     /**
599 599
      * Creates and initializes a ServiceManager instance.
600 600
      *
601
-     * @return ServiceManager The compiled service manager
601
+     * @return ServiceManagerBuilder The compiled service manager
602 602
      */
603 603
     protected function buildServiceManager()
604 604
     {
@@ -649,7 +649,7 @@  discard block
 block discarded – undo
649 649
     /**
650 650
      * Logs with an arbitrary level.
651 651
      *
652
-     * @param mixed $level
652
+     * @param string $level
653 653
      * @param string $message
654 654
      * @param array $context
655 655
      */
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,15 +12,13 @@
 block discarded – undo
12 12
 
13 13
 use PPI\Framework\Config\ConfigManager;
14 14
 use PPI\Framework\Debug\ExceptionHandler;
15
-use PPI\Framework\Http\Response;
15
+use PPI\Framework\Http\Response as HttpResponse;
16 16
 use PPI\Framework\ServiceManager\ServiceManagerBuilder;
17
-use Psr\Http\Message\ResponseInterface;
18 17
 use Symfony\Component\ClassLoader\DebugClassLoader;
19 18
 use Symfony\Component\Debug\ErrorHandler;
20 19
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
21 20
 use Symfony\Component\Routing\Exception\ResourceNotFoundException;
22 21
 use PPI\Framework\Http\Request as HttpRequest;
23
-use PPI\Framework\Http\Response as HttpResponse;
24 22
 use Symfony\Component\HttpFoundation\Response as SymfonyResponse;
25 23
 
26 24
 /**
Please login to merge, or discard this patch.