RouterRequestContextFactory::processConfiguration() - Code Metrics - Inspection of "Working on Router Caching" - ppi/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#165)

by Paul

created 2016-05-12 12:09 UTC

processConfiguration() A

↳ Parent: RouterRequestContextFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	9
rs	9.6666
cc	2
eloc	6
nc	2
nop	2

<?php
/**
 * This file is part of the PPI Framework.
 *
 * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
 * @license     http://opensource.org/licenses/mit-license.php MIT
 *
 * @link        http://www.ppi.io
 */

namespace PPI\Framework\ServiceManager\Factory;

use Symfony\Component\Routing\RequestContext;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * RouterRequestContext Factory.
 *
 * @author     Vítor Brandão <[email protected]>
 */
class RouterRequestContextFactory extends AbstractFactory
{
    /**
     * Create and return the router.
     *
     * @param ServiceLocatorInterface $serviceLocator
     *
     * @return \PPI\Framework\Router\RouterListener
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        $context = new RequestContext();
        $context->fromRequest($serviceLocator->get('Request'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $context;
    }

    /**
     * {@inheritDoc}
     */
    public function getConfigurationDefaults()
    {
        return array('framework' => array(
            'router' => array(
                // request_context
                'host'          => 'localhost',
                'scheme'        => 'http',
                // request_listener
                'http_port'     => '80',
                'https_port'    => '443',
            ),
        ));
    }

    /**
     * {@inheritDoc}
     */
    protected function processConfiguration(array $config, ServiceLocatorInterface $serviceLocator = null)
    {
        $defaults = $this->getConfigurationDefaults();
        $defaults = $defaults['framework']['router'];

        return isset($config['framework']['router']) ?
            $this->mergeConfiguration($defaults, $config['framework']['router']) :
            $defaults;
    }
}


1			<?php
2			/**
3			* This file is part of the PPI Framework.
4			*
5			* @copyright Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6			* @license http://opensource.org/licenses/mit-license.php MIT
7			*
8			* @link http://www.ppi.io
9			*/
10
11			namespace PPI\Framework\ServiceManager\Factory;
12
13			use Symfony\Component\Routing\RequestContext;
14			use Zend\ServiceManager\ServiceLocatorInterface;
15
16			/**
17			* RouterRequestContext Factory.
18			*
19			* @author Vítor Brandão <[email protected]>
20			*/
21			class RouterRequestContextFactory extends AbstractFactory
22			{
23			/**
24			* Create and return the router.
25			*
26			* @param ServiceLocatorInterface $serviceLocator
27			*
28			* @return \PPI\Framework\Router\RouterListener
29			*/
30			public function createService(ServiceLocatorInterface $serviceLocator)
31			{
32			$context = new RequestContext();
33			$context->fromRequest($serviceLocator->get('Request'));
			0 ignored issues – show Documentation introduced 2015-11-27 17:52 UTC by Report Bug Copy Issue Report `$serviceLocator->get('Request')` is of type `object\|array`, but the function expects a `object<Symfony\Component\HttpFoundation\Request>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34
35			return $context;
36			}
37
38			/**
39			* {@inheritDoc}
40			*/
41			public function getConfigurationDefaults()
42			{
43			return array('framework' => array(
44			'router' => array(
45			// request_context
46			'host' => 'localhost',
47			'scheme' => 'http',
48			// request_listener
49			'http_port' => '80',
50			'https_port' => '443',
51			),
52			));
53			}
54
55			/**
56			* {@inheritDoc}
57			*/
58			protected function processConfiguration(array $config, ServiceLocatorInterface $serviceLocator = null)
59			{
60			$defaults = $this->getConfigurationDefaults();
61			$defaults = $defaults['framework']['router'];
62
63			return isset($config['framework']['router']) ?
64			$this->mergeConfiguration($defaults, $config['framework']['router']) :
65			$defaults;
66			}
67			}
68

ppi / framework

Pull Request — master (#165)

processConfiguration() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like