FileLocatorFactory::createService() - Code Metrics - Inspection of "Working on Router Caching" - ppi/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#165)

by Paul

created 2016-05-12 12:09 UTC

FileLocatorFactory::createService() A

↳ Parent: FileLocatorFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	7
rs	9.4285
cc	1
eloc	4
nc	1
nop	1

<?php
/**
 * This file is part of the PPI Framework.
 *
 * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
 * @license     http://opensource.org/licenses/mit-license.php MIT
 *
 * @link        http://www.ppi.io
 */

namespace PPI\Framework\ServiceManager\Factory;

use PPI\Framework\Config\AppFileLocator as FileLocator;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * FileLocator Factory.
 *
 * @author     Vítor Brandão <[email protected]>
 */
class FileLocatorFactory implements FactoryInterface
{
    /**
     * Create and return the datasource service.
     *
     * @param ServiceLocatorInterface $serviceLocator
     *
     * @return \PPI\Framework\DataSource\DataSource;

     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        $config     = $serviceLocator->get('Config');
        $appRootDir = $config['parameters']['app.root_dir'];

        return new FileLocator($serviceLocator->get('ModuleManager'), $appRootDir);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2			/**
3			* This file is part of the PPI Framework.
4			*
5			* @copyright Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6			* @license http://opensource.org/licenses/mit-license.php MIT
7			*
8			* @link http://www.ppi.io
9			*/
10
11			namespace PPI\Framework\ServiceManager\Factory;
12
13			use PPI\Framework\Config\AppFileLocator as FileLocator;
14			use Zend\ServiceManager\FactoryInterface;
15			use Zend\ServiceManager\ServiceLocatorInterface;
16
17			/**
18			* FileLocator Factory.
19			*
20			* @author Vítor Brandão <[email protected]>
21			*/
22			class FileLocatorFactory implements FactoryInterface
23			{
24			/**
25			* Create and return the datasource service.
26			*
27			* @param ServiceLocatorInterface $serviceLocator
28			*
29			* @return \PPI\Framework\DataSource\DataSource;
			0 ignored issues – show Documentation introduced 2015-11-27 17:52 UTC by Report Bug Copy Issue Report The doc-type `\PPI\Framework\DataSource\DataSource;` could not be parsed: Expected "\|" or "end of type", but got ";" at position 36. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
30			*/
31			public function createService(ServiceLocatorInterface $serviceLocator)
32			{
33			$config = $serviceLocator->get('Config');
34			$appRootDir = $config['parameters']['app.root_dir'];
35
36			return new FileLocator($serviceLocator->get('ModuleManager'), $appRootDir);
			0 ignored issues – show Documentation introduced 2015-11-27 17:52 UTC by Report Bug Copy Issue Report `$serviceLocator->get('ModuleManager')` is of type `object\|array`, but the function expects a `object<PPI\Framework\Module\ModuleManager>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37			}
38			}
39

ppi / framework

Pull Request — master (#165)

FileLocatorFactory::createService() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like