DataSourceFactory::createService() - Code Metrics - Inspection of "Working on Router Caching" - ppi/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#165)

by Paul

created 2016-05-12 12:09 UTC

DataSourceFactory::createService() A

↳ Parent: DataSourceFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	17
rs	9.4285
cc	3
eloc	9
nc	3
nop	1

<?php
/**
 * This file is part of the PPI Framework.
 *
 * @copyright   Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
 * @license     http://opensource.org/licenses/mit-license.php MIT
 *
 * @link        http://www.ppi.io
 */

namespace PPI\Framework\ServiceManager\Factory;

use PPI\Framework\DataSource\ConnectionManager;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * DataSource Factory.
 *
 * @author     Vítor Brandão <[email protected]>
 * @author     Paul Dragoonis <[email protected]>
 */
class DataSourceFactory implements FactoryInterface
{
    protected $connectionClassMap = array(
        'laravel'          => 'PPI\Framework\DataSource\Connection\Laravel',
        'doctrine_dbal'    => 'PPI\Framework\DataSource\Connection\DoctrineDBAL',
        'doctrine_mongdb'  => 'PPI\Framework\DataSource\Connection\DoctrineMongoDB',
        'fuelphp'          => 'PPI\Framework\DataSource\Connection\FuelPHP',
        'monga'            => 'PPI\Framework\DataSource\Connection\Monga',
        'zend_db'          => 'PPI\Framework\DataSource\Connection\ZendDb',
    );

    /**
     * Create and return the datasource service.
     *
     * @param ServiceLocatorInterface $serviceLocator
     *
     * @return \PPI\Framework\DataSource\DataSource;

     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        $config         = $serviceLocator->get('ApplicationConfig');
        $allConnections = $libraryToConnMap = $configMap = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // Early return
        if (!isset($config['datasource']['connections'])) {
            return new ConnectionManager($allConnections, $this->connectionClassMap);
        }

        foreach ($config['datasource']['connections'] as $name => $config) {
            $allConnections[$name]                = $config;
            $configMap[$config['library']][$name] = $config;
        }

        return new ConnectionManager($allConnections, $this->connectionClassMap);
    }
}


1			<?php
2			/**
3			* This file is part of the PPI Framework.
4			*
5			* @copyright Copyright (c) 2011-2016 Paul Dragoonis <[email protected]>
6			* @license http://opensource.org/licenses/mit-license.php MIT
7			*
8			* @link http://www.ppi.io
9			*/
10
11			namespace PPI\Framework\ServiceManager\Factory;
12
13			use PPI\Framework\DataSource\ConnectionManager;
14			use Zend\ServiceManager\FactoryInterface;
15			use Zend\ServiceManager\ServiceLocatorInterface;
16
17			/**
18			* DataSource Factory.
19			*
20			* @author Vítor Brandão <[email protected]>
21			* @author Paul Dragoonis <[email protected]>
22			*/
23			class DataSourceFactory implements FactoryInterface
24			{
25			protected $connectionClassMap = array(
26			'laravel' => 'PPI\Framework\DataSource\Connection\Laravel',
27			'doctrine_dbal' => 'PPI\Framework\DataSource\Connection\DoctrineDBAL',
28			'doctrine_mongdb' => 'PPI\Framework\DataSource\Connection\DoctrineMongoDB',
29			'fuelphp' => 'PPI\Framework\DataSource\Connection\FuelPHP',
30			'monga' => 'PPI\Framework\DataSource\Connection\Monga',
31			'zend_db' => 'PPI\Framework\DataSource\Connection\ZendDb',
32			);
33
34			/**
35			* Create and return the datasource service.
36			*
37			* @param ServiceLocatorInterface $serviceLocator
38			*
39			* @return \PPI\Framework\DataSource\DataSource;
			0 ignored issues – show Documentation introduced 2015-11-27 17:52 UTC by Report Bug Copy Issue Report The doc-type `\PPI\Framework\DataSource\DataSource;` could not be parsed: Expected "\|" or "end of type", but got ";" at position 36. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
40			*/
41			public function createService(ServiceLocatorInterface $serviceLocator)
42			{
43			$config = $serviceLocator->get('ApplicationConfig');
44			$allConnections = $libraryToConnMap = $configMap = array();
			0 ignored issues – show Unused Code introduced 2015-11-27 17:52 UTC by Report Bug Copy Issue Report `$libraryToConnMap` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
45
46			// Early return
47			if (!isset($config['datasource']['connections'])) {
48			return new ConnectionManager($allConnections, $this->connectionClassMap);
49			}
50
51			foreach ($config['datasource']['connections'] as $name => $config) {
52			$allConnections[$name] = $config;
53			$configMap[$config['library']][$name] = $config;
54			}
55
56			return new ConnectionManager($allConnections, $this->connectionClassMap);
57			}
58			}
59

ppi / framework

Pull Request — master (#165)

DataSourceFactory::createService() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like