Recording::getId() - Code Metrics - powered-by-moe/MusicBrainz - Measure and Improve Code Quality continuously with Scrutinizer

Recording::getId() A
last analyzed 2016-10-21 09:13 UTC

↳ Parent: Recording

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace MusicBrainz;

/**
 * Represents a MusicBrainz Recording object
 * @package MusicBrainz
 */
class Recording
{
    /**
     * @var string
     */
    public $id;
    /**
     * @var string
     */
    public $title;
    /**
     * @var int
     */
    public $score;
    /**
     * @var Release[]
     */
    public $releases = array();
    /**
     * @var array
     */
    private $data;

    /**
     * @param array       $recording
     * @param MusicBrainz $brainz
     */
    public function __construct(array $recording, MusicBrainz $brainz)
    {
        $this->data   = $recording;
        $this->brainz = $brainz;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->id       = (string)$recording['id'];
        $this->title    = (string)$recording['title'];
        $this->length   = (isset($recording['length'])) ? (int)$recording['length'] : 0;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->score    = (isset($recording['score'])) ? (int)$recording['score'] : 0;
        $this->artistID = $recording['artist-credit'][0]['artist']['id'];
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if (isset($recording['releases'])) {
            $this->setReleases($recording['releases']);
        }
    }

    /**
     * @param array $releases
     *
     * @return $this
     */
    public function setReleases(array $releases)
    {
        foreach ($releases as $release) {
            array_push($this->releases, new Release($release, $this->brainz));
        }

        return $this;
    }

    /**
     * @return int
     */
    public function getScore()
    {
        return $this->score;
    }

    /**
     * @throws Exception
     * @return array
     */
    public function getReleaseDates()
    {

        if (empty($this->releases)) {
            throw new Exception('Could not find any releases in the recording');
        }

        $releaseDates = array();

        foreach ($this->releases as $release) {
            /** @var Release $release */
            array_push($releaseDates, $release->getReleaseDate());
        }

        asort($releaseDates);

        return $releaseDates;
    }

    /**
     * @return string
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return Artist
     */
    public function getArtist()
    {
        $includes = array(
            'releases',
            'recordings',
            'release-groups',
            'user-ratings'
        );

        $artist = $this->brainz->lookup('artist', $this->artistID, $includes);

        return new Artist($artist, $this->brainz);
    }

    /**
     * @param string $format
     *
     * @return int|string
     */
    public function getLength($format = 'int')
    {
        switch ($format) {
            case 'short':
                return str_replace('.', ':', number_format(($this->length / 1000 / 60), 2));
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'long':
                return str_replace('.', 'm ', number_format(($this->length / 1000 / 60), 2)) . 's';
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'int':
            default:
                return $this->length;
        }
    }
}


1			<?php
2
3			namespace MusicBrainz;
4
5			/**
6			* Represents a MusicBrainz Recording object
7			* @package MusicBrainz
8			*/
9			class Recording
10			{
11			/**
12			* @var string
13			*/
14			public $id;
15			/**
16			* @var string
17			*/
18			public $title;
19			/**
20			* @var int
21			*/
22			public $score;
23			/**
24			* @var Release[]
25			*/
26			public $releases = array();
27			/**
28			* @var array
29			*/
30			private $data;
31
32			/**
33			* @param array $recording
34			* @param MusicBrainz $brainz
35			*/
36			public function __construct(array $recording, MusicBrainz $brainz)
37			{
38			$this->data = $recording;
39			$this->brainz = $brainz;
			0 ignored issues – show Bug introduced 2016-04-14 18:35 UTC by Report Bug Copy Issue Report The property `brainz` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40
41			$this->id = (string)$recording['id'];
42			$this->title = (string)$recording['title'];
43			$this->length = (isset($recording['length'])) ? (int)$recording['length'] : 0;
			0 ignored issues – show Bug introduced 2016-04-14 18:35 UTC by Report Bug Copy Issue Report The property `length` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			$this->score = (isset($recording['score'])) ? (int)$recording['score'] : 0;
45			$this->artistID = $recording['artist-credit'][0]['artist']['id'];
			0 ignored issues – show Bug introduced 2016-04-14 18:35 UTC by Report Bug Copy Issue Report The property `artistID` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46
47			if (isset($recording['releases'])) {
48			$this->setReleases($recording['releases']);
49			}
50			}
51
52			/**
53			* @param array $releases
54			*
55			* @return $this
56			*/
57			public function setReleases(array $releases)
58			{
59			foreach ($releases as $release) {
60			array_push($this->releases, new Release($release, $this->brainz));
61			}
62
63			return $this;
64			}
65
66			/**
67			* @return int
68			*/
69			public function getScore()
70			{
71			return $this->score;
72			}
73
74			/**
75			* @throws Exception
76			* @return array
77			*/
78			public function getReleaseDates()
79			{
80
81			if (empty($this->releases)) {
82			throw new Exception('Could not find any releases in the recording');
83			}
84
85			$releaseDates = array();
86
87			foreach ($this->releases as $release) {
88			/** @var Release $release */
89			array_push($releaseDates, $release->getReleaseDate());
90			}
91
92			asort($releaseDates);
93
94			return $releaseDates;
95			}
96
97			/**
98			* @return string
99			*/
100			public function getId()
101			{
102			return $this->id;
103			}
104
105			/**
106			* @return Artist
107			*/
108			public function getArtist()
109			{
110			$includes = array(
111			'releases',
112			'recordings',
113			'release-groups',
114			'user-ratings'
115			);
116
117			$artist = $this->brainz->lookup('artist', $this->artistID, $includes);
118
119			return new Artist($artist, $this->brainz);
120			}
121
122			/**
123			* @param string $format
124			*
125			* @return int\|string
126			*/
127			public function getLength($format = 'int')
128			{
129			switch ($format) {
130			case 'short':
131			return str_replace('.', ':', number_format(($this->length / 1000 / 60), 2));
132			break;
			0 ignored issues – show Unused Code introduced 2016-04-14 18:35 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
133			case 'long':
134			return str_replace('.', 'm ', number_format(($this->length / 1000 / 60), 2)) . 's';
135			break;
			0 ignored issues – show Unused Code introduced 2016-04-14 18:35 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
136			case 'int':
137			default:
138			return $this->length;
139			}
140			}
141			}
142

powered-by-moe / MusicBrainz

Recording::getId() A last analyzed 2016-10-21 09:13 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Recording::getId() A
last analyzed 2016-10-21 09:13 UTC