Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class ReleaseGroup |
||
10 | { |
||
11 | /** |
||
12 | * @var string |
||
13 | */ |
||
14 | public $id; |
||
15 | /** |
||
16 | * @var array |
||
17 | */ |
||
18 | private $data; |
||
19 | /** |
||
20 | * @var MusicBrainz |
||
21 | */ |
||
22 | private $brainz; |
||
23 | /** |
||
24 | * @var Release[] |
||
25 | */ |
||
26 | private $releases = array(); |
||
27 | |||
28 | /** |
||
29 | * @param array $releaseGroup |
||
30 | * @param MusicBrainz $brainz |
||
31 | */ |
||
32 | View Code Duplication | public function __construct(array $releaseGroup, MusicBrainz $brainz) |
|
39 | |||
40 | /** |
||
41 | * @return string |
||
42 | */ |
||
43 | public function getId() |
||
47 | |||
48 | /** |
||
49 | * @return string |
||
50 | */ |
||
51 | public function getTitle() |
||
55 | |||
56 | /** |
||
57 | * @return mixed |
||
58 | */ |
||
59 | public function getScore() |
||
63 | |||
64 | /** |
||
65 | * @return Release[] |
||
66 | */ |
||
67 | public function getReleases() |
||
79 | } |
||
80 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.